From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56D15C02181 for ; Mon, 20 Jan 2025 19:34:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E53226B008C; Mon, 20 Jan 2025 14:34:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DDB796B0092; Mon, 20 Jan 2025 14:34:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C07C8280001; Mon, 20 Jan 2025 14:34:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9B0326B008C for ; Mon, 20 Jan 2025 14:34:08 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 587F91A02EA for ; Mon, 20 Jan 2025 19:34:08 +0000 (UTC) X-FDA: 83028830976.07.F627A75 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2056.outbound.protection.outlook.com [40.107.94.56]) by imf13.hostedemail.com (Postfix) with ESMTP id 7B07C20013 for ; Mon, 20 Jan 2025 19:34:05 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=dhVZCckS; spf=pass (imf13.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.94.56 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737401645; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8U0qAI+A9sjW2PsaUvPbzqTeoaFNUJ/u8IU0/a+ScB0=; b=g7chxi1EYlZzQ2t5mDyCt0KF2e1Og/i2U3zjXX0gvQ6tby9D89Io+cRPEJhurcMEgR1Sf4 peQi48OyeRCQNBx8yJnDCfXjMMaAVkcqbyaMLAUZZs8RoaNmaCONgXCs48lELNWzBQk0DU 9/jxdbsHabKLTR5RYmEtXHy3hrvorkk= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1737401645; a=rsa-sha256; cv=pass; b=YGs+8KmJLMfHvj0lZZIvBnCs2O+AjGx577Hsn5KhUGSIYv/IeU0UQ1X/4IqtXuIfE5tybL XwGpONWq6wUC5Vl3IgMc1kQYRgpOlryZsiaQf7PUtKoyfZPTX/mf5iFN7Dhi4jKBrcKs92 jCg9CvFNdAjixhb4APanR42/4mkmRNg= ARC-Authentication-Results: i=2; imf13.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=dhVZCckS; spf=pass (imf13.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.94.56 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=o0ZpO+tH3n45OLvrWxyEAAdqE4DQQODJuBN/J1kW4l7FlQfins54ktPsutFguhoiKMewX7o61pJ1oVyRcIG6D7Ah8NktcfkyEnGNU+PP1UEleaYUl9SMLtXs/81mm7pc+NCZGVS46W2o/NhqbG2HScWxJ9kqyxYVBjPiXlAJtZ1EnLBdvY+zUHFPCsP9Kdec8suhnHjm5UGIJNH0BnSCBX4bKGXYA3tTGN6vyZMdC+vOqyUTmiO3BbzyZNH/yqNr7gYdjTExUXpHk+JjTinG65KS/9q4FBB1fbNKoMFQo4KeBVY+4zSByTC3Oe2LtBmWpHjoEIxkTPJzjrIIAZRZFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8U0qAI+A9sjW2PsaUvPbzqTeoaFNUJ/u8IU0/a+ScB0=; b=DQCHVm3V1/j1ImVNbaCyLUlNDryojAIPWu0MJC6CmrIvx2wnz6lreORnRbneX8Q34MF69jVoZDZDLGm8ODvEybeBlpIQTN6taFdlaym+5KVPn9N9xqEbvPVqiw2S+ZwpLj7JOxvcqPIJdwtgX8+JOrVNE2OHTyCIv/8vH6Mg1sSMMZTo79LMCWIq3SK3sMAxwqdrQN08LgoRy78OuVosxTQA4USir54CMzAgbZrVZFpkzKlfvL/Je0feN8IAqcWlFsmVh3tXAOdFeoEBOMJbc00Sh0WWIfB+dynO/5S1/xU+7ublMtq83JvCt8O38SZ78waPtw1xZz90Yfof+fk7Iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8U0qAI+A9sjW2PsaUvPbzqTeoaFNUJ/u8IU0/a+ScB0=; b=dhVZCckScD3x20dwb0fDpvZ/qLp9PxkXZtOwnlHIFTJoHQuaYbRYxDj3/VkveJF58lEvXl8gyG9U5cirBx9ON5eMvyF8mvYVwn0VLz01dLZ1Opr5BkzAEVvyqAai0kHBy32qHCWJYtBQR5YiZOf2OAjNXMhx86UaRHyPKKO3Y++qikzLRee247ZQ31SzcB3pNVRhVTU54PoDtqGnjrCDVpUbEbpVG4YKmdSsB5+1jNkvAQc88OYyFkl1N3bLzMoWbTR7TrgOUtus6dinJHUe7BKi19uSC+i/lAc+2s1Y+pf7gZ/d6shpFgWYdpYLBV+JvqXWlHn+0QCsswT03yQ4Wg== Received: from LV2PR12MB5968.namprd12.prod.outlook.com (2603:10b6:408:14f::7) by SJ2PR12MB9212.namprd12.prod.outlook.com (2603:10b6:a03:563::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.20; Mon, 20 Jan 2025 19:34:02 +0000 Received: from LV2PR12MB5968.namprd12.prod.outlook.com ([fe80::e6dd:1206:6677:f9c4]) by LV2PR12MB5968.namprd12.prod.outlook.com ([fe80::e6dd:1206:6677:f9c4%7]) with mapi id 15.20.8356.017; Mon, 20 Jan 2025 19:34:02 +0000 Message-ID: <625d91cc-59f3-4757-81df-220d32861493@nvidia.com> Date: Mon, 20 Jan 2025 11:34:00 -0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: gup: fix infinite loop within __get_longterm_locked To: "zhaoyang.huang" , Andrew Morton , Alistair Popple , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zhaoyang Huang , steve.kang@unisoc.com References: <20250120092604.3590285-1-zhaoyang.huang@unisoc.com> Content-Language: en-US From: John Hubbard In-Reply-To: <20250120092604.3590285-1-zhaoyang.huang@unisoc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BYAPR05CA0009.namprd05.prod.outlook.com (2603:10b6:a03:c0::22) To LV2PR12MB5968.namprd12.prod.outlook.com (2603:10b6:408:14f::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV2PR12MB5968:EE_|SJ2PR12MB9212:EE_ X-MS-Office365-Filtering-Correlation-Id: 78b43cea-d2e0-4a46-6427-08dd398964d1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|10070799003|376014|366016|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?THFkcHVWMW5VZWJEbU55Wml2K0d0eHQwY0V0S040ZmVURXkyR0ExSHJpNzVK?= =?utf-8?B?cUZQTWZiQ1JYbVhGeXFkT2NZZmk5YU43bG5tWFhFendNdjBVeXY5M0lkNGIw?= =?utf-8?B?ZVdpRTZaOHV5WWVZTHJzQW42cFN4RmdLQmxjVVZDcGpYSlJGV2xrQzc0UlM4?= =?utf-8?B?Z3BOeHA1dUFCeVRPVW9LUnUreUtIM3h1alE3SjYvRWoxNllCblFwYkZYck0y?= =?utf-8?B?YmUrQ3dZZmJMbkNIcXFUVHBvdldtM1M0UFpLRjUra2wxamluQUpZZUNWazFF?= =?utf-8?B?QThZMzZ5ZHIvbGZsUDJiaHE0Mm1DUy9XME9sRmhJOExNeE14aWowdjIrVVlw?= =?utf-8?B?bkRYeW52dGcvZmdOUjZHS0dKZ2o3aUVJZ1FTbW1CL05TVEdKK2VXRW1HZ2U3?= =?utf-8?B?WHdwbmpxcncrVEtPeWxkS3JJMEVqeXJMZ1RLaGRhNnp1SWQrbUJpM2l6YmJi?= =?utf-8?B?VUVOYXcwRSs3RXMxOW1IdExDQlJRdURuTDNIUG1mdzE5Y0FFQ1VCWDFFRExi?= =?utf-8?B?RHNUckRVc01HaFYrS1JDb0JvUC91VFhtcGUxL2M3bi9aRE0wRTVlbDlTTmNw?= =?utf-8?B?eFhPdEtCU2JCeG43bWNaNy9obDBwcnVsRmxUWkhLdjdyRWlQQTN0UnYrOFFU?= =?utf-8?B?YVVaNDgwV3NUZm9weUk3c2QvS1U0OG1tdFFFaWJ1QUtsbWUzRkxGbE55VHEr?= =?utf-8?B?SW9MVDgrUzUzaXlHeDBYdGt3U05XMVNnUjhIS2NDQ1o0NVVNTG52ZjlqMXNn?= =?utf-8?B?M0NYNzVqV1pDUXJvVkdGeHFVb01PRHBXdWV2R1FIZHZ1SDZRN3FJTG1qTmwx?= =?utf-8?B?TXZIS1M3dkVlOTV5bWJkNS94KzNzdTVWWUxyZUhNSXM1R1RCM3NCaWpKRlJI?= =?utf-8?B?QzFnQjFzZWE4dWZ5dmFEQUZyT0FqTnZaaUdtV0RyVUZ5RkRHTzRwbFBtNXRP?= =?utf-8?B?aFlDKytTc1RYNk9DYy91eUdYKysvWExPVUNFdmttczIxTW8zcDdlYm52RG1l?= =?utf-8?B?bHFZczNpYi92elAxSUs4M00xaXVkc1Jhc1N3aDhuM1BFVDVwWnZCOW14Wmp6?= =?utf-8?B?WDZxa2ZHQ1JFalZPUlFwSVZvMUw3ZDZJejMvaDVrUGNzZHNhT3dIM2puU0Ro?= =?utf-8?B?VjdWb3BPSlRrS0RjbmV0QktVaDFTQkJMdEVkMk1pekxZNGhpcDQ2ajNteDZm?= =?utf-8?B?L0xCL3Y0ekRhY2J0WnRxdTBZb1pvMHpoYlNxNVhnZG4zSEtEaVFkK0ZrQU5H?= =?utf-8?B?RWk1aHlMWW9ZUWFzZVFvRmlNd0phTkt2a3g2dmE4NUNScFpwczcyZzZscm5B?= =?utf-8?B?WTlJQ0RXcjltVnp2WDcvTkc5QVhkMEZNRzEvb0dZdlRPRlJqWUNZK2NjQUZI?= =?utf-8?B?eC90S1B5cmRSWlNmazFJTTFyWFJYZ1ZubitpQ2pidi9uc1NTUjV6VGY3NWN2?= =?utf-8?B?aURNVjNsNWhULzVvZ29pYVNaZTdXRnY5NStBZlFkZk81azl4eGh1bnZqVGZh?= =?utf-8?B?OEFVQVQ5dEJSSFZkTjV5VmJtU1gweG1VMEZ2Q3p1S3dmN1gyKzVNVkRWdVA5?= =?utf-8?B?a1M1TnZ6bm1BQTRRRUN1R3AxeVRsZVR2dVVxdHNMR09LZGRlQm5XNHV3WHQ5?= =?utf-8?B?emdCS1ptSVZPZVJScEVMQWlXem5WeHhUVDhJQmcxTkk5ekwwbTlRR214bFRS?= =?utf-8?B?TnRQRTJHOWk3TFFrN05kS2dMYmxZZlZMNmhSeEZLL1JDZkhhbzU0MEZFSmtF?= =?utf-8?B?V05HUGRTL0MzTHFONUsvKzYwbHNSWGx4MnlUUjBhV1RKT2tVRDdBT1BZVFhD?= =?utf-8?B?N2Z2Q2doc3htM1BaeWUrNTlxNnJCYVYrbVVmWWphb1NqRjQ2TFRaKzJpbDJt?= =?utf-8?Q?84bF35mjRE6KA?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV2PR12MB5968.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(10070799003)(376014)(366016)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cGFqbXNLRVlPZ3BwdlFrMHhRUVZoemRIb2xIaERsN3hVMWRSOVppVitmSXJZ?= =?utf-8?B?S3JTazJzTFNSQ2plOWxIbDhYUXkzdnpqTkgzZlgxQkV0aTZFVlp3RjVVaExI?= =?utf-8?B?RTZwM3VIV2xRVUk4WHpZeXZQek1RRDhwcUpXZUxVL1Arb0NXd0pXM0psWExa?= =?utf-8?B?bkxPcnp4VTQzVWVhMnpvSFowUnVxVklZYWNRNWZ4WDFaVGorM0lnY2lmMTh4?= =?utf-8?B?SHpBS0kzSnhPV3pTVVF2Vm9mNWladndEOG84dVArYlF5TDZYTVN2SFlzcEtM?= =?utf-8?B?QldnazROSVovK3ZsNlNmOTAxU3V3TkIrVi9iZ3ZIaDhwRVBHMGVXd1JYUGRo?= =?utf-8?B?eWNHcXNuTy9WVXBOSFZqRWp5UE5RM0IwQ2JqM3RrRENpejR5Q2xJd3VNdFpi?= =?utf-8?B?VFlLMDJGOEh4R29UVXdIN1JFZEQ0TEM3Szd6QXhERExFQ3JIT1ZHc2Vxb2dh?= =?utf-8?B?RGJkN0d0eitHUjlkWU1nSnFqLzR2NkVTQ3FNSzU1VUh2ZFpnYVNZTWhLQ2V3?= =?utf-8?B?WjF2K3hXUTFsNWIzTDlSMWNtdmg1THhZVWJ1aEdtbitQVjEyMDFWbHNyampy?= =?utf-8?B?Ulh2cXNkR01IVHhkQTdaeXFvVzY4SFdyU3EvZGVWRE42NXZLZEp3d1ZMMXRl?= =?utf-8?B?d3pTaTQzR3c2cG9rMi92ekE5Yms4cCt4V3F5TWFjUmZzMXVQaFlNY2dmWlZa?= =?utf-8?B?L21pZ0hSaTcxbXFocnRnYWxBTG1SNzA2SnkrSTludjBGK1NFZEkvcGpOUlhK?= =?utf-8?B?d3pOdWliWGVKUmw2Sldzd0lsMEYvTWJHM0F4RWFDY3ZqYUhOUlVZdXhxaUE4?= =?utf-8?B?VXdHb0NFOVltMENYZmFKWU9pMmJ3OHZES0ovdUg2Smc5UUxLaElFS1diRHgw?= =?utf-8?B?blNpZXE0MHN5QUl2QmFqem84bUt1QzFLajZsOFV2SDYzb2pOQUpKV2FvUk1o?= =?utf-8?B?SFNERnB0dTJPZzMveXNPSHlpT1gxSmI0ZCtIQWFmUnJNR0cySEdzbmxVS0hY?= =?utf-8?B?Z1ZKVWl1T0hkL3BXMWE0TUJlT3R6QlNZMHZuZlcyRTZmTjEvSmhSOGVCcWEz?= =?utf-8?B?bmVOMTJDS0JSaEdQU0diMW51aTdVaFlpWGlLSWZUMkVUSXRSNUFHQU5nMnRG?= =?utf-8?B?QngzRGFFa243VWtlY2JGYmViL3RlYkluZk5lZ3RoQmJQRWY5d3hBMWQyME5p?= =?utf-8?B?OVhWck5qa1QzSnJsZFFsQzM5R1lCclUyVUtSTzJkR0lFd1JrVkFSaTFjdDMy?= =?utf-8?B?NUkwZW4xU3NTdDVLUnJvaEFCbUpQNmFwR0NFQjhmUTVGc2lXMmtGak1DaU04?= =?utf-8?B?THZnb2E3RE96ZjlTeXB6V0NzeU1sbnZHSitjOG9xeVhLUzZHVzhKMGYwNnBW?= =?utf-8?B?SkpaSmdCNlhGSlRCcC8xWXBVMzkzYURtNElmeWdxQWRRUGxsd1hycEUxRThY?= =?utf-8?B?ZW1lZ0w4cy9uTy9Wd3NBR2Uyb3BjbGxVM3prdGxyQVVxZkZiVXR0anRzK3NH?= =?utf-8?B?ZENpR05qOTJCcXF2TTZmZlAyRHI0M3ZrcmFqNTRReFI3dE8vWkcvemM4aldx?= =?utf-8?B?M0xlOHlBUlVjWkNoamp2QnhQSzRhQTFpbldDYURIR0xjaVNmejliVXJQbjMx?= =?utf-8?B?U0dudHU3RWx4MDNWYWNKMEdmNVdUOUlqU3k0VE5reTZISHplQnV1R3dhTTFE?= =?utf-8?B?dUFJYWlLMFRENHpPT3hKTHFVdE1qQjFaS1I4eW1xSVdKeXJHR3NLZmdPNE9s?= =?utf-8?B?NktRRW1kTUhudnRYU2UyVkIzMFZSU0NibFFSNkJXZ0pQR3lubUkvVU10UU1W?= =?utf-8?B?RWdQQTRoUUZRTkVLUGs1akJpRUxvaEtqYm4rck1zdm02anQvNWI3ZGs4bGMx?= =?utf-8?B?a1h2ZWpQSDhDREU4ZWFFQ3g2M3ZGOUpBWGtPZHNxNUJaSmRGanV0SktwMVF5?= =?utf-8?B?K01lbVYrd1VSZDFKbGp2OGdINzhwdGl4Mkg3TStqZTNtS25TdnN2bWJtK0Fv?= =?utf-8?B?VkRyeVcrWWxaWXpyK0JUMis5S1d5bUoreW5lUUh2N3JaVjlPc2R4NTcwWmZR?= =?utf-8?B?dVdtQk5oTVYzSmNoaThGT2hZMDM0NTVuVzBkZjBGMGV2RG5nVVdEbVVzbGRG?= =?utf-8?B?alRNdWQ2SHJMWjZNNjR4K0NHTGtlZXcrczVQcFhLTk5aQ3IrRDhCSDFQcE1M?= =?utf-8?B?dEE9PQ==?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 78b43cea-d2e0-4a46-6427-08dd398964d1 X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5968.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jan 2025 19:34:02.2671 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vMjDDRp4B9jyHptooaM9BFkplnQ8Nb2IU5ZbwWVkostfMX20Q0eWaHb4EoXasNqnFyfy8RZ0DE8L/iVhtMs56g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB9212 X-Stat-Signature: ziwh3emgz91e6cjc3kcz1cqryrqn4p9c X-Rspam-User: X-Rspamd-Queue-Id: 7B07C20013 X-Rspamd-Server: rspam03 X-HE-Tag: 1737401645-475250 X-HE-Meta: U2FsdGVkX18BcxKxIuXSxVo0UjHmrfz9OoZnmsbTG62PXgvh8w6INz7xqz59qfOzBRmpkWDvMGnV4jpH2n2RzafNGvZW2RoR5BjbHs1nvZ4+tBDIzvtErHb7P2LnCRR1euU78I+EPcodovwf8iWgb9WAZ9bNLw8Jxi1G/3TM6mAxZQvTHIoXg8B1gVJbyPm33KTDsqlVGY/j2SScOVqd01xw6zcCT91shW1VkzJOCIkefY+MqO+jFHSiELJP7wjQ3E/6W4a5EBEnWn5h+jCqe6z/w+ys5K3lLluN0D11X0rMI3vsXnTK4Y4k88cFL2XzP5dDmvOPnPo8iTvaJn80KbkTvqXRwvlUTXoRDSmWjbSok0TGzrvusCj0iGXQaGpZy1LrIJwGppVUYlPC8nYnMzX/rFqnmc3zmlMg3u5cIaPUZsBQyzbnLpRT4+V0ziCgVP6Lb5L0Y88xLt+Qc6U11c4/pKSrNXuc4ar9cIh00rLKyjOdNIlLzey4gGTBTkFs6QK7rdELJ4aTseRC5usRTkfvEiuazaS5Niwk8QuMylF90qPyg31DOxGZVy1wxZ7vZrFFagpIChhfL62b4NGNet0MEaHd3T439fo9oE3ovEeAbNv5Mhnx3EfbbxBssHXjO3N/0gDF8joqEKetB5lAnk0Z+PKFjo9s7LWqOfNsWUBTIou/ga1ZA+YXUWTbOph9mOYeuW5j/ZM3WmANyGYnvjESCoVeTScRdcnZ8MF8Abgcr3n+jtaewdCLXPftWOQE5F1WLe43hgpikS/+jZ+ibqg3z0VskfWhzq3FCsDdx+zU/423+w6gxJCjwlnVKnAydaZ60vMZp9JT1/lbNqPPedp3ZnRacaUG2lDxVjhd4KRWAgT3EMJU4+qxccSV4jwFjZaK8v2kOw97MikKrRBVEZibc1FgJvPLmDdY8QOmVMBmI97dpBeo+mgBek40UtX63uxl10keektWDh9hYA/ aErPVLFi 7LS4YY+1ucfvhqq3FCaf65fpAwNyWGKl43rIqGk3bP9Kta2WQRcHXj6cIy2fmWq5Ld4xAfLsWDEjueI8QyH7gHm4juGQrL0vx5uKXfl8KzX5lRW9IY1WU6xKfITW1g+SU5Ey5TtPhNU1DIS0f/cm1PY2k8aP60xjJekXp9jCfy/fUuEcQUNA670yr0HX7NoNklbr8TU10ffCjFOc7yTzuUS+vcIpejkdmzfaDgAgSOdk15VDZFYTUl5ByY62Ci6eOJaSIty/y0v4bPzS7HwZ34ZJCebF2RxTBIBT+TTjKIREzVuhz88XF5vWkflFSyZx+b+DoakJncsoUfH2w4DFriWyKJGUv4FaMS4JzvzXe0X7ZK4N2JmlprAgdzlslaKP/U3qazW1gYJ6CoGsUbIzP9tLCCL0bjuqoM/krMviEQ86fr8nzCayj4AjdSiFV4Xs7tuhUyqOG5fAyk3m5mN79L6VIQRqXpncy7C9RyLhQlr8Z3oHzMOFwMZ7AfCjxLE5+oTHvJdJ9I3XDbVn6W7UomQuS/3Bq5IHg/eOt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/20/25 1:26 AM, zhaoyang.huang wrote: > From: Zhaoyang Huang > > Infinite loop within __get_longterm_locked detected in an unique usage > of pin_user_pages where the VA's pages are all unpinnable(vm_ops->fault > function allocate pages via cma_alloc for hardware purpose and leave them > out of LRU). Fixing this by have 'collected' reflect the actual number > of pages in movable_folio_list. The above is rather terse, although perhaps by kernel standards it's OK. Isn't this missing a Fixes tag? Fixes: 67e139b02d994 ("mm/gup.c: refactor check_and_migrate_movable_pages()") > > Signed-off-by: Zhaoyang Huang > --- > mm/gup.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/gup.c b/mm/gup.c > index 3b75e631f369..2231ce7221f9 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -2341,8 +2341,6 @@ static unsigned long collect_longterm_unpinnable_folios( > if (folio_is_longterm_pinnable(folio)) > continue; > > - collected++; > - > if (folio_is_device_coherent(folio)) > continue; > > @@ -2359,6 +2357,8 @@ static unsigned long collect_longterm_unpinnable_folios( > if (!folio_isolate_lru(folio)) > continue; > > + collected++; > + Well, this seems correct to me. Somehow I talked myself into believing that it was OK to do collected++ early, even though later on we skip actually collecting the folio, thus miscounting things. But now I believe it was just incorrect all along. Reviewed-by: John Hubbard thanks, -- John Hubbard