From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F84EC369B1 for ; Wed, 16 Apr 2025 09:32:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 038EF6B0031; Wed, 16 Apr 2025 05:32:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F202F6B0032; Wed, 16 Apr 2025 05:32:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC0FD6B007B; Wed, 16 Apr 2025 05:32:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BF8E36B0031 for ; Wed, 16 Apr 2025 05:32:11 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0B2E21403EE for ; Wed, 16 Apr 2025 09:32:13 +0000 (UTC) X-FDA: 83339390946.24.17BD648 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id F0EABA000C for ; Wed, 16 Apr 2025 09:32:08 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=S1pxBa9S; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744795930; a=rsa-sha256; cv=none; b=wkEk5jMHCAk2ww13OzAQITD21Z+bsSPBX4zaG6RD79wNBo1X3YOnEZcBQlTyU2uZOgAH5d FI9m/iJeCp1hs1KaRSvqERPc4jyfMOS3DtmEOv2kdMIGwFi9Xx/M0jm0hvpBWv/aJs34aU buRS2e0AOKDGFd7DGx+DzMkYW0f12XY= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=S1pxBa9S; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744795930; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CPTzXXBPP9uKDT7uGvj8TNRGD1DYrkwdDHvL5CA6lgc=; b=il6GkQXbHqPcDT0Fy20YwPBsDPC8KNPUGdmAChz+myxGUwAKTbG9xMt0QfPbAs07bRefD3 JXUGvdumYadLhjIiBRd7jArwyze92nzqB2C7/7maLGm0P8mbUpRoWnZfdiLfNtwCfRxOZc qwM7ncv5Qi4PbkwUvW+FyLTrzySeybg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744795928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=CPTzXXBPP9uKDT7uGvj8TNRGD1DYrkwdDHvL5CA6lgc=; b=S1pxBa9ShLDFG+2vgyQUqorR9poZVR+WuqEsU6JCnn+A6j9ekau16Thm/iF2N0H9FnF/d+ z826m9LlBrlPb4wLadckogbJ6v+IxREBIYYhYZn71hk4kJsg9cSyhgrnBr5OzA+izx8Ttu 7zOERbB284DpT2yQEmjD1OwVfd/BJs8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-136-UFlr04iWOU-e9eGw8rHEnw-1; Wed, 16 Apr 2025 05:32:05 -0400 X-MC-Unique: UFlr04iWOU-e9eGw8rHEnw-1 X-Mimecast-MFC-AGG-ID: UFlr04iWOU-e9eGw8rHEnw_1744795924 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43d5ca7c86aso38886485e9.0 for ; Wed, 16 Apr 2025 02:32:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744795924; x=1745400724; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=CPTzXXBPP9uKDT7uGvj8TNRGD1DYrkwdDHvL5CA6lgc=; b=srMW/hFhvO4OIIZKcc/SyRCNV/wzAvJmxMQfGMZy2syHKLjpj6L4s0jrjpvZ/D4Kgf uusxFGHz2OeaGZEdxPSlxYd4hOrJhkarqqN7bvU7FHIDPJq8xSv0fIWCGyRRkwkxtke5 ZlvegdNdij4nNryseb7AtiK0PbroVqRSzG7iOPuR6yjNKrgXRlcAIkMdhbItLb9Kuv6e pMs7UyAb1QJo4zPkNqDGrh8HWQId2BWGDQXMk5WuNqxwJXQzkLzF3C5vejAL2mruxkEv 7ovjJro+1gW7ZlSYqyOCd7Fcij60k9dtQMaKfBb8n0EAxfmriwrDftFNloxOn3vg6kB4 xiew== X-Forwarded-Encrypted: i=1; AJvYcCW6RSPvuqEXRo05ogtIElwsPfMoGEyCRzv2I6cPhFuIPQj1zbj/jy3sIlXagImaoyqvtmIM1/sYMg==@kvack.org X-Gm-Message-State: AOJu0YyAjMJd4ONYB6jgcqIJTcaotJGofAXpw+8wQ5UUkvmVYlwHT1jo FdV9Oq9r/6i4K++XBkGmJM+B9XETiMOMK3khZ5eXx16sk5XrA2qkzfbTUPmWWvtAuuYIakiQgAn ibuKYU/BSUWKAbZ4Zc2HF11O5Ygz7r1M5nNwVQIoefebWLjiE X-Gm-Gg: ASbGncuqxEXzi+0/pKypS/TK72lS9YT+5Nsj3ahkuw1PmtFKjgpryUrVwJS5AFXp38o mau5MuJSV9s/qsOpf4mPneASEBNfbY5SBiKhptm6atdBMC0otqYaI201ydXvKxh7PyGYOsKqPtz AbsPB3aKf2rk8zTt0TaZIP+EXrIdqx+e7Eqw5ifW6cUeLEvVuZssDVigq/txCWV9PJN2G/ZTaPv 8P0lFRQ9RV2E08s2UNExQ94ZGAd2Ge269jwZWf6b3TcqGLxyvZZ3U6rShtfuHLVL8H/YBPFjLvt v2VpnOYhWbxnwrnphyQj73O0GhEZki45DV13+3W1NX0dpkRg0Z7Z7Su7jIHzudkbGkGkzDxstCO gSM3n3X3Da941zuHZMQ7n1BP8q/acJXTL6uvJOw== X-Received: by 2002:a05:600c:35d4:b0:43c:e9d0:9ee5 with SMTP id 5b1f17b1804b1-4405d636d49mr11377005e9.18.1744795923757; Wed, 16 Apr 2025 02:32:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFUcFKBpZ2GcpYLEoopqzQY2ZlwtvpFT+TIpkeag7SvXrZNWUWk6KDLfB+wE/68ObAEbcP/tQ== X-Received: by 2002:a05:600c:35d4:b0:43c:e9d0:9ee5 with SMTP id 5b1f17b1804b1-4405d636d49mr11376745e9.18.1744795923340; Wed, 16 Apr 2025 02:32:03 -0700 (PDT) Received: from ?IPV6:2003:d8:2f02:2900:f54f:bad7:c5f4:9404? (p200300d82f022900f54fbad7c5f49404.dip0.t-ipconnect.de. [2003:d8:2f02:2900:f54f:bad7:c5f4:9404]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4403605892fsm24685425e9.2.2025.04.16.02.32.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Apr 2025 02:32:02 -0700 (PDT) Message-ID: <6259cc1d-93a8-4293-9009-a6119166f023@redhat.com> Date: Wed, 16 Apr 2025 11:32:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] mm: don't promote exclusive file folios of dying processes To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Barry Song , Baolin Wang , Johannes Weiner , Matthew Wilcox , Oscar Salvador , Ryan Roberts , Zi Yan References: <20250412085852.48524-1-21cnbao@gmail.com> <34c54df6-9a7c-475d-9b91-0f8acb118231@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: AMNvf1DJJLlFkWdIjdrR-ebmBwIg2HOJ6Ghr7a2heIY_1744795924 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: F0EABA000C X-Rspamd-Server: rspam04 X-Stat-Signature: kak46mz76xtseatdnu13g4oc6iujfx6z X-HE-Tag: 1744795928-926071 X-HE-Meta: U2FsdGVkX18EOvPGVyfjeYNLQ9xODO5kJqCYMLmuLrL97vDl84wQ0qtfC03WuXDNSmJIQntiOkVx0kJQtOPZQswaJqjmjbmf5rbxmoG93pII04Lh1ynaXRtek2awYSwvL7hBZ1oi46VGtZY+A0QvFyujYkXCzs7MrVooXS4yrgSqJhTSBkXSjyFrYC9bxUdSO5sYPg32aq0Oa9gQBoOCn2ZM63WL5KooGMNaIck3eRPkV2T0RXz4KpT5SZvR+ovRahExT6m2hjgxIcEv6Fg6EAk6f6QlWUadkdKB2L2EFPhyY5BzQJAWA7jvedOoldaPBmKSSDjU4i3rJBnntr32a1zi9QlIeXxJ3cNDYcZUI2lFhyx8UWi+/jxcxgtV4reCDn5NW27HbRPzAeKFWZir7zLNvCHInmJdWATTQNi9hBv3JClpOcyKEqFrCcpUL2jUXq5+l1Y+bOZBZ9RW8bdLvpxpShBAkf+WP+kuQK7oq0wQfUANAJIFaeHolJhRtRy6VnSPtfcDtr31B9KpBhLaNyyps0rcjJFTNvffHeTcckWQRu/9+xg7+uigtqgqpwzrMIJ/fdYmfePwYh9PrcRjNbJx8iSHT/YvGVt9lw3NTM0L0R1fg19Z9UtYeIks/cA/rKBMTpdipnDunm1q7v6d1k/kR4qEoGK88z7EcN5P5x/iugfDItKbcvSZxhu8rozlsAF7EH49eZbaqqvl27WCXX5YqPV6PHZgTqnIUvHrVFKe7hwRyjsE7yIz/8V2YCnln6JHIdXq+HKgsZJDbbXH/vsWY+CaqrRiikkXvp8wjFmA9xZH1x/mpjRMgTOMZ9upj2RQQb7h/wSN90rDcLYPLpojR6yQ+RAGT11juk9I/EowxmpL4C2bxvXgOaqRMQhWLEnYiz/Iv1upLAGOFxtOP1+o+fZSWlqPv/fKFxp3MAfz4gfO+Rc9Gxz8O2BfNDf7HoqK7v9wmjH/WaUx9o+ /iEU54zQ ZJ3lJp7cSAkzZJf/fKEBxgQJhNnn+27eMARw/EA0CigvJalubGtL6TsnQjJlr+GrYLHS3HABTyqPiznVZ1MgWSyjmLo4Oy+svVCu8Va6suUh4izXPbI7o/hVzFtT6TOm4JlArQUpfTvQOoqFKcLZ43dQAignbQ3OMPtypuspApSZezBmpSkvPUI8g0WtLfetvtqZM5H56DSehBSxEJJtojtiVdWXwbLQ8RAEeD9E4XlNZMU/0A1M65xP34FszNb0zAcztcyZveSxtWJyy94LCPSlScw7Dc+21j0ABPxrJ1oWedmy1/zQKm4mklhyxWUP+reAOpCt2/dyaCYZHP9WDcQ3RBtCpPPqKIrht/OGo1wWe152QTLwpVeRmYMCvtAjr3IkCF1iNLtg4zz4QWIYGkh4PMeSyGp8lm1h4XduWJkXvmyHqDIpTM/ZqsJYylhGCJSbztXZ20JhS0WLdRVsGvKA6l8s693eathxg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.04.25 11:24, Barry Song wrote: > On Wed, Apr 16, 2025 at 4:32 PM David Hildenbrand wrote: >> >> On 12.04.25 10:58, Barry Song wrote: >>> From: Barry Song >>> >>> Promoting exclusive file folios of a dying process is unnecessary and >>> harmful. For example, while Firefox is killed and LibreOffice is >>> launched, activating Firefox's young file-backed folios makes it >>> harder to reclaim memory that LibreOffice doesn't use at all. >> >> Do we know when it is reasonable to promote any folios of a dying process? >> > > I don't know. It seems not reasonable at all. if one service crashes due to > SW bug, systemd will restart it immediately. this might be the case promoting > folios might be good. but it is really a bug of the service, not a normal case. > >> Assume you restart Firefox, would it really matter to promote them when >> unmapping? New Firefox would fault-in / touch the ones it really needs >> immediately afterwards? > > Usually users kill firefox to start other applications (users intend > to free memory > for new applications). For Android, an app might be killed because it has been > staying in the background inactively for a while. > On the other hand, even if users restart firefox immediately, their folios are > probably still in LRU to hit. Right, that's what I'm thinking. So I wonder if we could just say "the whole process is going down; even if we had some recency information, that could only affect some other process, where we would have to guess if it really matters". If the data is important, one would assume that another process would soon access it either way, and as you say, likely it will still be on the LRU to hit. -- Cheers, David / dhildenb