From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94F0AC28B28 for ; Mon, 10 Mar 2025 00:33:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C5FD5280002; Sun, 9 Mar 2025 20:33:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C0FDF280001; Sun, 9 Mar 2025 20:33:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AD782280002; Sun, 9 Mar 2025 20:33:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 90113280001 for ; Sun, 9 Mar 2025 20:33:19 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1558953E06 for ; Mon, 10 Mar 2025 00:33:20 +0000 (UTC) X-FDA: 83203767360.04.2CF11B1 Received: from out30-97.freemail.mail.aliyun.com (out30-97.freemail.mail.aliyun.com [115.124.30.97]) by imf08.hostedemail.com (Postfix) with ESMTP id 2296B16000C for ; Mon, 10 Mar 2025 00:33:16 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=JsylPHRO; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf08.hostedemail.com: domain of hsiangkao@linux.alibaba.com designates 115.124.30.97 as permitted sender) smtp.mailfrom=hsiangkao@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741566798; a=rsa-sha256; cv=none; b=nX+zHFNtjKmHPKiE5J8r7c66Siv46rDZ7iQ4wR/I4919hFYKq1bis7IH9I1FAzaeuRjfZn Tq05gj/ueqz4Lx1Y4F5KVjEZ0A+CmqBRjz+qX1fMY8ydCicee2K7SHhJjxfUTcwaW8LjbS sgCrf1qLC7/vak8k37L9zLsSVsMH9lg= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=JsylPHRO; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf08.hostedemail.com: domain of hsiangkao@linux.alibaba.com designates 115.124.30.97 as permitted sender) smtp.mailfrom=hsiangkao@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741566798; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i9xoUJAz+Ulc3f5EECn+evsDiO91i2wyeFM4yQAvw+Q=; b=TrWBRabWQyJyY9I1fm8BwvHd002poqvsd3jXQhcXnIc5+xFM6bGJjybVXTIPuH9vRIFXvx DFgAVH+MoGgKLouQRU2+TmtYuZ07lQ/IhyPItImqY8DSgDOiGBsBZOtjvR/e1KuIPEKx7z ughsorb+axiBtV4OMAJZDm/vlYM8K6s= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1741566793; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=i9xoUJAz+Ulc3f5EECn+evsDiO91i2wyeFM4yQAvw+Q=; b=JsylPHROsJHCKjcST9WJI0WaqkRnq1eGgxb+J6flBAjv02V7LdwuTziyVn+1W5tqCRieb0fInKOAsxZm+M9JSwkjSQbqku5N1vusGrLMPFzql7yTg2kYpLD0IVlWUfR7YZPbrikiJYqowUy7oriLa2gOjFYOXc6+p7Ckv5WFS+M= Received: from 30.134.66.95(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0WQy811n_1741566764 cluster:ay36) by smtp.aliyun-inc.com; Mon, 10 Mar 2025 08:33:11 +0800 Message-ID: <625983f8-7e52-4f6c-97bb-629596341181@linux.alibaba.com> Date: Mon, 10 Mar 2025 08:32:42 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: alloc_pages_bulk: remove assumption of populating only NULL elements To: Yunsheng Lin , Dave Chinner , Yunsheng Lin Cc: Yishai Hadas , Jason Gunthorpe , Shameer Kolothum , Kevin Tian , Alex Williamson , Chris Mason , Josef Bacik , David Sterba , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Carlos Maiolino , "Darrick J. Wong" , Andrew Morton , Jesper Dangaard Brouer , Ilias Apalodimas , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , Neil Brown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Luiz Capitulino , Mel Gorman , kvm@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-nfs@vger.kernel.org References: <20250228094424.757465-1-linyunsheng@huawei.com> <91fcdfca-3e7b-417c-ab26-7d5e37853431@huawei.com> From: Gao Xiang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 2296B16000C X-Rspamd-Server: rspam11 X-Stat-Signature: hiisymjte1dyxqqg4rezrceik3b95t17 X-Rspam-User: X-HE-Tag: 1741566796-143930 X-HE-Meta: U2FsdGVkX19l5kLJWtiSUleL5gUoZTpBU52r4o/Nw/uMHnyQ/mqBwC5AT0h6kYO7V7j4r9AevWrmZouH76ZNlsbzSU69Xl3fJreiabiq3vZIENoXH27bZimeoK0a3+wP929tyCD5JkLLphk54g3J4WGZi7+WaO51osz+P6d/LFZrxNbES5eeqSq9aDoorOVb8pOGm1zRxNrPl61bmJ53CyVTsdFOM7d7O0P++ilaoq3ZQAvKPREDIq1SJJB38Y0OgeCeu4l76U1UvPM5zkB9rRo41QKchPeSCQgL+n97bvpAjZlN/KVirE/C/X8Gq1DE4UFX18h7DZUdj0hhs0uRaxPsS+IW85iXppSI+90K3iDtRXsbWNVgsN/t18Dv0CWlSkavUNd11fUQqcEXTt1MpJ1alGTVPL3bkFdscMpDGnPSoZMlspUN7ilu/7DnyjWWTeB6xtyckzBpbRrKyPdFhynz3USjp7mGfR50nit7rN/+vkcueHFG1WBCRYSG6czdi0asnQOXtXkr7/uutnj5FPmWs9oYRe5mbjoLNNAG9CQZj2TTIQaEJuLL/6UTj+GMlpFAdpCYF6qX6v4y0wdiTO36q0qe/TXMph6k0D8JpC0M2XjRPNjfqRSpam4Zh5QggAsxF/Ivn0hekkA+v1S2kiP90CDDRAIT1YFG4o2wPbphihsnYBBK39LV0rqQrRg4lTxP6svnIXx7UH+ZgRxS70xozPw1sSCPwZjrmXS1+HQ11tVbBZ+XDRSQfI19MsUUFLE365Hbz4mC5vwb6BzngfRjKrco1vWosfZxGzMMi8wDVCgTAKhHxdKBxduIfILLvTivgupIALvMn2DIt55humXFdNQqDzLBv62Ow3VKjmg/iUJojQn/BbBxZl2NFc96nLb262uOUqm2Znehzt2ZdQsGLQ0w3RNmEIWzkT8Xku0HswrzjwncBrD8ZmUfJQ8OaokDSpxILxgpxEcZsaY umLBMrU/ oG6vlzh9uWfYAN2CiBPQWLV90MLgb2s/HMSpyjDiTUbAsuXfl5XiX1qktRttaBG6W09Pk68nnkkO/ToB/vtWKyG3WCrC+CCPP0eavRfvpWXOVstyrnpw1cT7/8CWUDXYlWzDHNvMpNMsszAhdhgHcsVkfuvaDXJXmwOTtNKzGn9bIxoz9HqcyWvc0/5EuVcuduuqWj/oElWfKULBfZXBeiZnlNNqFGMS4gyAsQKOjOm+yzHvssPEHjZTOvUTCTWb6MAg9mEWUnKTULQAIhJFxUu0dXGupeuFmVHXrxTj8YtHwOxuJdg5wi3HINUomX6xU6Zg444WnQYsb0XCV8JxL6wJSrA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/3/9 21:40, Yunsheng Lin wrote: > On 3/8/2025 2:43 PM, Dave Chinner wrote: > > ... > >>> I tested XFS using the below cmd and testcase, testing seems >>> to be working fine, or am I missing something obvious here >>> as I am not realy familiar with fs subsystem yet: >> >> That's hardly what I'd call a test. It barely touches the filesystem >> at all, and it is not exercising memory allocation failure paths at >> all. >> >> Go look up fstests and use that to test the filesystem changes you >> are making. You can use that to test btrfs and NFS, too. > > Thanks for the suggestion. > I used the below xfstests to do the testing in a VM, the smoke testing > seems fine for now, will do a full testing too: > https://github.com/tytso/xfstests-bld > > Also, it seems the fstests doesn't support erofs yet? erofs is an read-only filesystem, and almost all xfstests cases is unsuitable for erofs since erofs needs to preset dataset in advance for runtime testing and only read-related interfaces are cared: You could check erofs-specfic test cases here: https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs-utils.git/log/?h=experimental-tests Also the stress test: https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs-utils.git/commit/?id=6fa861e282408f8df9ab1654b77b563444b17ea1 BTW, I don't like your new interface either, I don't know why you must insist on this work now that others are already nak this. Why do you insist on it so much? Thanks, Gao Xiang > >> >> -Dave. >>