From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDC3EC433DF for ; Wed, 1 Jul 2020 15:35:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8607820760 for ; Wed, 1 Jul 2020 15:35:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OWPYZp/f" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8607820760 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E856A8D004C; Wed, 1 Jul 2020 11:35:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E369A8D0047; Wed, 1 Jul 2020 11:35:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D25518D004C; Wed, 1 Jul 2020 11:35:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0247.hostedemail.com [216.40.44.247]) by kanga.kvack.org (Postfix) with ESMTP id B98068D0047 for ; Wed, 1 Jul 2020 11:35:00 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 81A24824805A for ; Wed, 1 Jul 2020 15:35:00 +0000 (UTC) X-FDA: 76989905160.24.rest15_3516feb26e81 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id 504061A4A0 for ; Wed, 1 Jul 2020 15:35:00 +0000 (UTC) X-HE-Tag: rest15_3516feb26e81 X-Filterd-Recvd-Size: 5337 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Wed, 1 Jul 2020 15:34:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593617699; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K2LSOwV4F9LWO2errkulu26wSaC7ntPEQWe1qhPb/To=; b=OWPYZp/fiB1C6Y9u4V7+SnrGtDx1IGRJbKe19WvqydXHZcSHZZwWUNMTN9tcDmRnqOs2Bn 23IGMRX5j8AA/bJUFLQ/udpuLxBXMRf3EUCtP5KT9TGFIJtamMsXwkmSgY1peLDOPTuVEJ CknOjPpSFJU1SMk5HPoJK4XIFtlXcLg= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-407-uAD3kWaTOM-BjV1ZSP23Qg-1; Wed, 01 Jul 2020 11:34:57 -0400 X-MC-Unique: uAD3kWaTOM-BjV1ZSP23Qg-1 Received: by mail-wm1-f71.google.com with SMTP id b13so22016658wme.9 for ; Wed, 01 Jul 2020 08:34:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=DVvafyNDOv03AqOZTolGY7IYO4hSglqR6MUFuKdIAyA=; b=jgL8SPZTKtZ1UBavUkHdrw6qEJjOZ2iP+YGRsoFNZjFTwZn/GY2s4VXQqwpoUgwxiY PgUV/JyBlb3G4UVujgAHllQDGbtSB3OVqikjMQRaYDzxwuIoA1Muc33cSuzniDthLjPv gyE7o0kN6Ofb1GN8fW/I8taAJ/bBK46iJURdbfAIUhhAVwS5m52pv0l+IlXil3RvraaD +Z0ZpqJLZ2pAnBxK7nPEPneblNoFqZJeGOP0Uf2xS0yx3lSBBpTaCnx3ohYwz4baX9Qu 6K7SD0tEUfCJ+hPE9HivEF8tb/77kcpzJqbI4U7JH3xl2MvBOqznWUpV+fj3dznc2i5r sx7g== X-Gm-Message-State: AOAM532+G/tb8y3OMnoyWvuppdgP2733cWav2DzKeK/2jB0lm0WqgMIu ROPdMFxsnWpuAdtinvCeGkWN5ABVfqKyrvoj8XiNIFGP6h59pgDGuga7OODiKSrMhYVCb5LDezq OCgsus79YuD0= X-Received: by 2002:a05:600c:2295:: with SMTP id 21mr26499044wmf.29.1593617696636; Wed, 01 Jul 2020 08:34:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzSLRSauLQmUCOlKoZ6zhkxk/B9lCi8GzNaLObBIoBm96avDayWOtaDoizvp758LMBLXPYlzg== X-Received: by 2002:a05:600c:2295:: with SMTP id 21mr26499020wmf.29.1593617696421; Wed, 01 Jul 2020 08:34:56 -0700 (PDT) Received: from ?IPv6:2a01:598:b90d:c98:b442:aed2:92f6:a574? ([2a01:598:b90d:c98:b442:aed2:92f6:a574]) by smtp.gmail.com with ESMTPSA id z1sm7776010wru.30.2020.07.01.08.34.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2020 08:34:55 -0700 (PDT) From: David Hildenbrand Mime-Version: 1.0 (1.0) Subject: Re: [PATCH v2 1/2] mm/memblock: expose only miminal interface to add/walk physmem Date: Wed, 1 Jul 2020 17:34:54 +0200 Message-Id: <62588A3E-81FA-4C79-B215-D1D33887597C@redhat.com> References: <20200701150643.GA2999146@linux.ibm.com> Cc: David Hildenbrand , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-mm@kvack.org, Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Andrew Morton In-Reply-To: <20200701150643.GA2999146@linux.ibm.com> To: Mike Rapoport X-Mailer: iPhone Mail (17F80) Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 504061A4A0 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Am 01.07.2020 um 17:07 schrieb Mike Rapoport : >=20 > =EF=BB=BFHi David, >=20 >> On Wed, Jul 01, 2020 at 04:18:29PM +0200, David Hildenbrand wrote: >> "physmem" in the memblock allocator is somewhat weird: it's not actually >> used for allocation, it's simply information collected during boot, whic= h >> describes the unmodified physical memory map at boot time, without any >> standby/hotplugged memory. It's only used on s390x and is currently the >> only reason s390x keeps using CONFIG_ARCH_KEEP_MEMBLOCK. >>=20 >> Physmem isn't numa aware and current users don't specify any flags. Let'= s >> hide it from the user, exposing only for_each_physmem(), and simplify. T= he >> interface for physmem is now really minimalistic: >> - memblock_physmem_add() to add ranges >> - for_each_physmem() / __next_physmem_range() to walk physmem ranges >>=20 >> Don't place it into an __init section and don't discard it without >> CONFIG_ARCH_KEEP_MEMBLOCK. As we're reusing __next_mem_range(), remove >> the __meminit notifier to avoid section mismatch warnings once >> CONFIG_ARCH_KEEP_MEMBLOCK is no longer used with >> CONFIG_HAVE_MEMBLOCK_PHYS_MAP. >>=20 >> While fixing up the documentation, sneak in some related cleanups. We ca= n >> stop setting CONFIG_HAVE_MEMBLOCK_PHYS_MAP for s390x next. >=20 > As you noted in the previous version it should have been > CONFIG_ARCH_KEEP_MEMBLOCK ;-) Grml :) maybe maintainers can fix that up when applying in case there are n= o other comments. Thanks Mike for the fast review!