From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E51DC433EF for ; Sat, 9 Apr 2022 08:31:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF48A6B0071; Sat, 9 Apr 2022 04:31:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D7D5B6B0073; Sat, 9 Apr 2022 04:31:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF6976B0074; Sat, 9 Apr 2022 04:31:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id A930C6B0071 for ; Sat, 9 Apr 2022 04:31:19 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 674B125210 for ; Sat, 9 Apr 2022 08:31:19 +0000 (UTC) X-FDA: 79336671078.19.81AD97D Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) by imf01.hostedemail.com (Postfix) with ESMTP id 06DBC40007 for ; Sat, 9 Apr 2022 08:31:18 +0000 (UTC) Received: by mail-qt1-f174.google.com with SMTP id j21so12540946qta.0 for ; Sat, 09 Apr 2022 01:31:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:from:to:cc:subject:references:mime-version :content-disposition:in-reply-to; bh=ltAY4NbF/ZSQmQzIhU/4Ym22AhhgYTgYnlUh+8O5iJA=; b=cIJfldWO0aaKZ/s2g7WrzTjdvvmjd4AqSw4a7vCyoXHk9atITLN3cYXJZzBrxGWzS3 2IAzSleIVK14v/0qzAT0xa7Ym+LPV4nMqqOA8jUcX5r3wKaMve1WbBiGNCAc830xTSGY Jkh8UkYcogL/RwuGGOdsFDAbTgnZLCKT/Y2XwHO/LQb+FFIVzG8zvyhxjQsQ4yp7LLYU Gr116iV2EuFE4Te/zywR072GzV9kYiSf5rRTZpvcxpJRqvLE/IiJZ/Bakjv75Q/90RpT rbtYmAfdKtdXLYdSrtYuNPUwNEYs2R9V+8omraLsLbqFILV5IU3gicQwCzn+qtxEZq/h I8Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:from:to:cc:subject:references :mime-version:content-disposition:in-reply-to; bh=ltAY4NbF/ZSQmQzIhU/4Ym22AhhgYTgYnlUh+8O5iJA=; b=fq+V3+/qBJwwKoStdeu4K9IU7kA0UmLiQWJ5+PQqWtJCWPyc/OPGg7agtkO19t9m8r rscFKlz6Z53L46h1duK0vYiUUFj0Vyef9q9inpQHVA9hJcII8VLjv9FF9lr+zeuo+6Y5 QyeapZt98H9u0JJXl7a9/V3RIFg7xso45zI9OQ46/VAhqUXTw+X15bduU+GZ2syXR7na H/cmOeslpSzEHHMLoUlViTB+X0Upo7h/r4b6YIWgSpBxvDIqKqmIOZK1rywtJO2e+6OP eK6GOofqVDx6QPy6TwdHamC0kYKxn0cBp7/kFsEI0+uWfEpw6mwzwzKGiz+/829ioeST BUsg== X-Gm-Message-State: AOAM530GuDGYeJHT0uZ4yPKy9yWI1KDYj3kKpDQiZAaW7cYyBdZHL175 IpOiPGnZNtHTQPLkmAd4bWM= X-Google-Smtp-Source: ABdhPJyPw38hwLF/dooO3O86uxNY+G/TWkIEvyniY/+jSbTxqEMrcWm7UJDTy/nryC2ybFBUgzzGFQ== X-Received: by 2002:ac8:124c:0:b0:2ed:e5d:d07e with SMTP id g12-20020ac8124c000000b002ed0e5dd07emr3274899qtj.231.1649493078308; Sat, 09 Apr 2022 01:31:18 -0700 (PDT) Received: from localhost ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id 14-20020a37090e000000b0069bfe98662csm260436qkj.17.2022.04.09.01.31.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Apr 2022 01:31:17 -0700 (PDT) Message-ID: <62514455.1c69fb81.5db1c.0ef7@mx.google.com> X-Google-Original-Message-ID: <20220409083114.GA2513948@cgel.zte@gmail.com> Date: Sat, 9 Apr 2022 08:31:14 +0000 From: CGEL To: Peter Zijlstra Cc: akpm@linux-foundation.org, david@redhat.com, corbet@lwn.net, bsingharora@gmail.com, mike.kravetz@oracle.com, yang.yang29@zte.com.cn, wang.yong12@zte.com.cn, ran.xiaokai@zte.com.cn, jiang.xuexin@zte.com.cn, thomas.orgis@uni-hamburg.de, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, sfr@canb.auug.org.au Subject: Re: [PATCH v2] delayacct: track delays from write-protect copy References: <20220409014342.2505532-1-yang.yang29@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=cIJfldWO; spf=pass (imf01.hostedemail.com: domain of cgel.zte@gmail.com designates 209.85.160.174 as permitted sender) smtp.mailfrom=cgel.zte@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: 9thpje671t4u7ujramgan1rxooehiz37 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 06DBC40007 X-HE-Tag: 1649493078-114603 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Apr 09, 2022 at 09:53:09AM +0200, Peter Zijlstra wrote: > On Sat, Apr 09, 2022 at 01:43:44AM +0000, cgel.zte@gmail.com wrote: > > From: Yang Yang > > > > Delay accounting does not track the delay of write-protect copy. When > > tasks trigger many write-protect copys(include COW and unsharing of > > anonymous pages[1]), it may spend a amount of time waiting for them. > > To get the delay of tasks in write-protect copy, could help users to > > evaluate the impact of using KSM or fork() or GUP. > > > > Also update tools/accounting/getdelays.c: > > > > / # ./getdelays -dl -p 231 > > print delayacct stats ON > > listen forever > > PID 231 > > > > CPU count real total virtual total delay total delay average > > 6247 1859000000 2154070021 1674255063 0.268ms > > IO count delay total delay average > > 0 0 0ms > > SWAP count delay total delay average > > 0 0 0ms > > RECLAIM count delay total delay average > > 0 0 0ms > > THRASHING count delay total delay average > > 0 0 0ms > > COMPACT count delay total delay average > > 3 72758 0ms > > WPCOPY count delay total delay average > > 3635 271567604 0ms > > > > [1] commit 31cc5bc4af70("mm: support GUP-triggered unsharing of anonymous pages") > > > > Signed-off-by: Yang Yang > > Reviewed-by: David Hildenbrand > > Reviewed-by: Jiang Xuexin > > Reviewed-by: Ran Xiaokai > > Reviewed-by: wangyong > > As per always; I refuse to take patches from cgel.zte@gmail.com. Because > yet again From and Sender don't match. > > If you want me to consider your email, please send from the email > address you've listed in your SoB. Very sorry to have this problem, because our company's mail system (xx.zte.com.cn)has a little format problem, so we use gmail instead. We do want to do a little work for the community, so sent patches before it fixed. I will try to connect our mail system administrator to solve it next time. For this patch, it had been modified for several times, special thanks to David Hildenbrand, so we hope to merge it(if no other problem). Thanks!