From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2683DC2BD09 for ; Tue, 9 Jul 2024 17:21:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F5316B0092; Tue, 9 Jul 2024 13:21:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A49F6B0096; Tue, 9 Jul 2024 13:21:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 293146B0098; Tue, 9 Jul 2024 13:21:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0B6CB6B0092 for ; Tue, 9 Jul 2024 13:21:43 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 54291121928 for ; Tue, 9 Jul 2024 17:21:42 +0000 (UTC) X-FDA: 82320881244.13.EC96D5B Received: from gentwo.org (gentwo.org [62.72.0.81]) by imf24.hostedemail.com (Postfix) with ESMTP id 87C8C18002E for ; Tue, 9 Jul 2024 17:21:39 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gentwo.org header.s=default header.b=Mo1fe+He; dmarc=pass (policy=reject) header.from=gentwo.org; spf=pass (imf24.hostedemail.com: domain of cl@gentwo.org designates 62.72.0.81 as permitted sender) smtp.mailfrom=cl@gentwo.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720545676; a=rsa-sha256; cv=none; b=qb47x01AyznLDNIRqcdGesNVjk2yNsuzJMH0nUa8bC4wAgXLJuJ8l82tiCoaupUQA4kleE KW8pAwpM1s8jdDqLCT7wDKEZulB9AaCCaaZayi8/KpNRcPp4o9bxhS7eHNY90On3S+Jnyj HrJcoRIqWHdWMJgR1GhF2rbTtFrEbpQ= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gentwo.org header.s=default header.b=Mo1fe+He; dmarc=pass (policy=reject) header.from=gentwo.org; spf=pass (imf24.hostedemail.com: domain of cl@gentwo.org designates 62.72.0.81 as permitted sender) smtp.mailfrom=cl@gentwo.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720545676; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xL3youk/+gk/eTOrgHFmGgZ7lsuGaWO/a5zQ6F9W6B4=; b=GT1YxZQuTMo/gZiFNzl7Rkls4vbD2UiU6k53m6Ut3Ce6hwwRAZjilVA/sA8TW+CCoVQJ6B iToH4ie8PLE6abdyNm9PZaoHiMwswULt1Iu9Fw49Bq2InuNRbjGXo366G8vr2f1+MLKZJy p1chGGzoY8y8Lohb9jUUZcJ2JknilsY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gentwo.org; s=default; t=1720545137; bh=neVbqVHqD44Be4Hjw84TlKXXGrfcezzQiHJeDIk1kC8=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Mo1fe+HeYdILs9sCDjzp2hiljekgy5WEXQqMt6QGfY3JBQodWPVIzFyp30dmGpiWL Bol4y93xlhP4OHNe0QnaUp1frSxUcGxWWGwbBBW2DvYaL4fhUKM28Y3PIRHYNtnhSS FxQ57uBa9JBMFywP8JFdhfim48Bj5gCk5XVqvGGQ= Received: by gentwo.org (Postfix, from userid 1003) id F0C5740364; Tue, 9 Jul 2024 10:12:17 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id EFD4440253; Tue, 9 Jul 2024 10:12:17 -0700 (PDT) Date: Tue, 9 Jul 2024 10:12:17 -0700 (PDT) From: "Christoph Lameter (Ampere)" To: "Matthew Wilcox (Oracle)" cc: Andrew Morton , linux-mm@kvack.org, Johannes Weiner , Vlastimil Babka , Hyeonggon Yoo <42.hyeyoo@gmail.com> Subject: Re: [PATCH v2 2/6] slub: Use alloc_pages_node() in alloc_slab_page() In-Reply-To: <20231228085748.1083901-3-willy@infradead.org> Message-ID: <624cc2ee-9335-31e5-4177-97fe676b6e76@gentwo.org> References: <20231228085748.1083901-1-willy@infradead.org> <20231228085748.1083901-3-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Rspamd-Queue-Id: 87C8C18002E X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: seeecnsup6ugcg1yunwsxfark9ckpx43 X-HE-Tag: 1720545699-757834 X-HE-Meta: U2FsdGVkX19/lV4GEBIi8W6H59E15OVG8cAWaKAsy8ubmmceYgTnF7t2ZgLUsViNCxEXK43CyggkJPISGeBlIEWUIwFm0ea9nQHEzqTcDHRQAgyXyjkkLoSpKF6lzzG+Qq4Um4S6oUTVZCOE2TJVr1eVCxvgJAwFyN7Npam6vByRX6ZGOQ6wWEqvmkAg30E5SBcF1+LI97vFp0NOYfFpW0SBG3a74RYOeL4ewe/YRSlI04R4H/sEic8to5kpfbs9a5EDAhKANDle/57cPXV/Ea2LxradtRKtJ3nV6shMPNPXKKk9Si4uNlAAc21U//Sd1n4pLuyeoE3fVyVV3BXZWuMkru8nsJVxOT1VnU2MrrtX8NiUgH5Q8wgbxG45bFrx0rSambRxs9tJe2F3cm7Sd4Pc9123qC3OoUfJdTA239rbCZBTcLcApGQJb5bsvgTmzMklwsjEwnJfmP6yJnhzJZLgXXq01GdI1UvkqWZOkulY4jbOMW69V7Z+Xmw4mzpG8jLmyMUlZm4aWuR+587JleGJnv66/5Xj4BQcsobWtDu/wge2rNFjReW5n37KD8AtDtoTN5wgsLS04kCGHCW0S6fYZA/8WlKafw5s5REp5KMr9jf9nEzXZKf2bU3RE4BXyZe/3cdxTZdPB9vfC6vnUZvhbPG5yjK5LRU6REwM8XFZmmxtpZZMQc1BJWlbkBtpv0v9tGOrslV+TTJDS8dscYuF37EIOkcAk1rt93caLKcVB8zeMBLKoSB8sw54gK9MRMfk/DTS4yEGWMPnc9p/6QmLMVMcOhMMb5AQ9pFb6xZEnJK5qU/cIIfeV3oXYhy139wBMSROSLbwatWgr38N+g/VfVIH6ZmYfPzhde6sD6rAtsrdD/xLsLrxoU76NHLFlnMK+VI0K+dDF3LP0idvfSZVDD1YmwBPKWjD6x5hljK94W6vPYZaO4iLQzH2fY1F5YisB5TkcTo/pzNpgxt cA99i0Sx vxKKXnj/VTxGXxmaMuCe+AXBu5ZXbEHOcslWr04dAgvqiNI6yNN/Vb465ERm6pTvSgXXjy22o1t+baQjVWirQOrjZaelmGS3fUuf5PFewm+p4xlrF54GMnYkJ2AauWTjUiQpz6s+tc2xj8CUwFf3LYxPNdgRWdfHiJRmMbj9edMgyKNcfZwNhZZedm70bPJRXutymKDU4cOim+XVFUQVq3/uHlB5o6jlyWxKvw8jYTni8Iv+s+cUbGCRr3SazlAQaWRHa7zLxYpsCBl3mVqdwvFkyMdxFRfGR6WEo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 28 Dec 2023, Matthew Wilcox (Oracle) wrote: > For no apparent reason, we were open-coding alloc_pages_node() in > this function. The reason is that alloc_pages() follow memory policies, cgroup restrictions etc etc and alloc_pages_node does not. With this patch cgroup restrictions memory policies etc etc no longer work in the slab allocator. Please revert this patch. > diff --git a/mm/slub.c b/mm/slub.c > index 35aa706dc318..342545775df6 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -2187,11 +2187,7 @@ static inline struct slab *alloc_slab_page(gfp_t flags, int node, > struct slab *slab; > unsigned int order = oo_order(oo); > > - if (node == NUMA_NO_NODE) > - folio = (struct folio *)alloc_pages(flags, order); > - else > - folio = (struct folio *)__alloc_pages_node(node, flags, order); > - > + folio = (struct folio *)alloc_pages_node(node, flags, order); > if (!folio) > return NULL; > > -- > 2.43.0 > >