From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE51CC433ED for ; Fri, 9 Apr 2021 08:45:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 58D3261185 for ; Fri, 9 Apr 2021 08:45:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 58D3261185 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D4F3B6B006E; Fri, 9 Apr 2021 04:45:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D265C6B0070; Fri, 9 Apr 2021 04:45:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC6B46B0071; Fri, 9 Apr 2021 04:45:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0110.hostedemail.com [216.40.44.110]) by kanga.kvack.org (Postfix) with ESMTP id 9FD396B006E for ; Fri, 9 Apr 2021 04:45:33 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 63E698248047 for ; Fri, 9 Apr 2021 08:45:33 +0000 (UTC) X-FDA: 78012194946.26.8F79D39 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by imf26.hostedemail.com (Postfix) with ESMTP id 65CB340002C0 for ; Fri, 9 Apr 2021 08:45:29 +0000 (UTC) IronPort-SDR: KMT6IG4UF5Uqy46CE8HIHHbzZZX7MBLDwDziQk12ffmXR6aXYYUWxITN4GWgfGPbwRzhAWgboC IAafhKKsiJ+g== X-IronPort-AV: E=McAfee;i="6000,8403,9948"; a="191569548" X-IronPort-AV: E=Sophos;i="5.82,209,1613462400"; d="scan'208";a="191569548" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2021 01:45:19 -0700 IronPort-SDR: 06iTqg+iOZC09Uez8Mh4BaFQY8i7mwJkA0OhhbY6gSLjTEeQ8tPaGiIaTfDQkbVK0SZonbaH0X Y7xzZA4KqXQg== X-IronPort-AV: E=Sophos;i="5.82,209,1613462400"; d="scan'208";a="422643273" Received: from shao2-debian.sh.intel.com (HELO [10.239.13.11]) ([10.239.13.11]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2021 01:45:16 -0700 Subject: Re: [kbuild-all] Re: [PATCH] mm: gup: remove FOLL_SPLIT To: John Hubbard , kernel test robot , Yang Shi , "akpm@linux-foundation.org" Cc: "kbuild-all@lists.01.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" References: <20210329193828.179993-1-shy828301@gmail.com> <202103301403.u00aVRF6-lkp@intel.com> From: Rong Chen Message-ID: <6236d7d0-7e81-c88a-e019-12707e574274@intel.com> Date: Fri, 9 Apr 2021 16:44:21 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Stat-Signature: wekx5xzng1qpkddooxac7nudkecxqndw X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 65CB340002C0 Received-SPF: none (intel.com>: No applicable sender policy available) receiver=imf26; identity=mailfrom; envelope-from=""; helo=mga04.intel.com; client-ip=192.55.52.120 X-HE-DKIM-Result: none/none X-HE-Tag: 1617957929-419454 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi John, On 3/30/21 3:08 PM, John Hubbard wrote: > On 3/29/21 11:24 PM, kernel test robot wrote: >> Hi Yang, >> >> Thank you for the patch! Yet something to improve: >> >> [auto build test ERROR on hnaz-linux-mm/master] >> >> url:=20 >> https://github.com/0day-ci/linux/commits/Yang-Shi/mm-gup-remove-FOLL_S= PLIT/20210330-034042 >> base:=C2=A0=C2=A0 https://github.com/hnaz/linux-mm master >> config: s390-randconfig-r032-20210330 (attached as .config) >> compiler: s390-linux-gcc (GCC) 9.3.0 >> reproduce (this is a W=3D1 build): >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 wget=20 >> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cro= ss=20 >> -O ~/bin/make.cross >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 chmod +x ~/bin/make.c= ross >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #=20 >> https://github.com/0day-ci/linux/commit/c8563a636718f98af86a3965d94e25= b8f2cf2354 >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 git remote add linux-= review https://github.com/0day-ci/linux >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 git fetch --no-tags l= inux-review=20 >> Yang-Shi/mm-gup-remove-FOLL_SPLIT/20210330-034042 >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 git checkout c8563a63= 6718f98af86a3965d94e25b8f2cf2354 >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 # save the attached .= config to linux build tree >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 COMPILER_INSTALL_PATH= =3D$HOME/0day COMPILER=3Dgcc-9.3.0=20 >> make.cross ARCH=3Ds390 >> >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kernel test robot >> >> All errors (new ones prefixed by >>): >> >> =C2=A0=C2=A0=C2=A0 arch/s390/mm/gmap.c: In function 'thp_split_mm': >>>> arch/s390/mm/gmap.c:2498:27: error: 'FOLL_SPLIT' undeclared (first=20 >>>> use in this function); did you mean 'FOLL_PIN'? >> =C2=A0=C2=A0=C2=A0=C2=A0 2498 |=C2=A0=C2=A0=C2=A0 follow_page(vma, add= r, FOLL_SPLIT); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^~~~~~= ~~~~ >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 FOLL_P= IN >> =C2=A0=C2=A0=C2=A0 arch/s390/mm/gmap.c:2498:27: note: each undeclared = identifier is=20 >> reported only once for each function it appears in >> >> >> vim +2498 arch/s390/mm/gmap.c > > There appears to be an imperfection in this 0day testing system,=20 > because (just as the patch > says), commit ba925fa35057a062ac98c3e8138b013ce4ce351c ("s390/gmap:=20 > improve THP splitting"), > July 29, 2020, removes the above use of FOLL_SPLIT. > > And "git grep", just to be sure, shows it is not there in today's=20 > linux.git. So I guess the > https://github.com/0day-ci/linux repo needs a better way to stay in syn= c? Sorry for the delay, indeed, it's a issue from 0day-CI, we'll update=20 linux-mm in the system. Best Regards, Rong Chen