From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B759DCA0FED for ; Fri, 30 Aug 2024 12:59:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 392686B013E; Fri, 30 Aug 2024 08:59:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 342BB6B013F; Fri, 30 Aug 2024 08:59:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20AD06B0140; Fri, 30 Aug 2024 08:59:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 01F5F6B013E for ; Fri, 30 Aug 2024 08:59:48 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9589C14194A for ; Fri, 30 Aug 2024 12:59:48 +0000 (UTC) X-FDA: 82508918856.07.0663FC0 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf02.hostedemail.com (Postfix) with ESMTP id 66CE780015 for ; Fri, 30 Aug 2024 12:59:46 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=thiwJNo+; spf=pass (imf02.hostedemail.com: domain of broonie@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725022697; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uFTaIQmao++WMsK76RUhgx7ncRMszlOrVoJG7KLW/pE=; b=nLxqKlf82dsSmbt9/AhwLE1ldrD1tNgTtWUy1Djl7wP4yhagJs4iEEmfglFnmuDy6W/eje 5BzXPn94C0k4u2t5asjm1BFDSROv3h6jcJ5HyeU2DrBj2cJE3UT4d5p76v3nCnu0JIzTge Y11q830+X9u23JN0j5Dnw5r4vb+AzS0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725022697; a=rsa-sha256; cv=none; b=VG4UP9qZ6LPpMaXDHnP/20+Mw4S9XWNXJtoFCcHEat4vuP52Ns7AdjagMyzw+0X0aryZln tGp3DtSaQYNBnbnHOHWOga2PMMtJp8knSjpK5bPjyOyGGw+JjnlfN8IFkwG49Yq9+bjnow K2N+NfuNcw0KJfvuyQLZFDxBIL003uM= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=thiwJNo+; spf=pass (imf02.hostedemail.com: domain of broonie@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id DD33BCE1DF8; Fri, 30 Aug 2024 12:59:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 057ADC4CEC2; Fri, 30 Aug 2024 12:59:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725022782; bh=uFTaIQmao++WMsK76RUhgx7ncRMszlOrVoJG7KLW/pE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=thiwJNo+yK7GHsNtmTM1yn1DKXlkqlRYnEFUnY2oA+mxB3+F2KV6UlI2GBjOk/wQD ndyDoP0kq1Mye0jZ7NRldzLTa4Cbl9lRM//bRBpwJksL2lU7td4jTCIUJ3IRrU8q0B Msh5oRfaw0Qn784WulZkjUkZDnQCNwnhsKO1jHVgw/BYpOq0xOIq9WYN84MEMdGn+A 57D5N5sg1/PVnkg83RoL1CenvcUIeMuRkdnDyOf5odKifWWScviOPT6kjLF0fHsDNF gHYJQ94qu59DoG4tW6hD6YqnYwk7EYX/R6EGiWzHTs73v/fMisuw6XVDVCB4Spk9Uu Bj8t24Vk0FlMA== Date: Fri, 30 Aug 2024 13:59:37 +0100 From: Mark Brown To: Lorenzo Stoakes Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Liam R . Howlett" , Vlastimil Babka , Ryan Roberts , Aishwarya TCV , dev.jain@arm.com Subject: Re: [PATCH v2 06/10] mm: avoid using vma_merge() for new VMAs Message-ID: <622b3769-fb5c-4a3e-82b7-1301623faf43@sirena.org.uk> References: <57f55a1473586a88211e04b44c6b128332d4272c.1724441678.git.lorenzo.stoakes@oracle.com> <51452bab-65ef-4924-8ca8-61536d2bc168@sirena.org.uk> <9dcddc2c-482b-4e12-a409-eee8d902ba26@lucifer.local> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="+HwhJGFuaIQgoGSS" Content-Disposition: inline In-Reply-To: <9dcddc2c-482b-4e12-a409-eee8d902ba26@lucifer.local> X-Cookie: for ARTIFICIAL FLAVORING!! X-Rspamd-Queue-Id: 66CE780015 X-Stat-Signature: or9ecscnt78hgb45qjmw4rgmfcskzcuh X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1725022786-530491 X-HE-Meta: U2FsdGVkX18hWc0gF2SoSKmF2iqASNGcy6sLXfATIBxulVYpfiE9S6WzEEGm4KkITdPkaW6qwlp3dL2Z8XfZgSDYcpwUD4aNZDFN9+m0CT0ReaGa5Of652G5Gvljd68Av0W8+S6hGTa4HA3Zby5bvG2EyN/xjCOL/hnm61AaE8yvcuue33Trta6uhfn1ptWGOxtyMNSheigiuyae5hO1iRkofmMTywsEQpZjeDSbRmsIpZiIba+pgRlGCchWHdip1XxjtifhsAf4YnmK2flxy50Csby7bCmGINCWFcNNtcaOX6Rj9WXpDAgpxJca7eAq/ldrV3xuVwJqlkr+ypFVl2tIyLiS6TIO70GdwD9evUqZzoxFEwSp1K0tuJgiPZE4J2H+gW1wy3KSdNjR9SdDIZ4xrgWOoVBQFgKDyF9/2xfZZMR8P/m213S2N+K1/+IkMLq8a6fivx5MenXJyG+wKdCDXI4LN4x/qFp0rbee8e4kJQjYWKR84OtmjYD2H0J2oKLuLCWgcvR0H5BY9RI9zxKzYCX49qGv37qb/2Khih4iwCyczBS9CppCWQnQXrmnSVRgRj8fSjIXjsvULK5GJXzI8sZkmozC8GPCZkEtqvonYXbwXpfs094FVErtJN3n/HjfopDIpRhDvKMjwbkH6E0eCihyZ+bu7u/aaeXId7k9TYhD+JnKj4gdTDOQGuVlEz/nclihCepxSz+6+O9jHdd5Umuep+T0+5BakBDMeuvCsq6X3Snq8xDuo62nG6inZlTCe4nDMTla1mqbNarG+6C9pmTJ6kMD+M6aLCWdbn05gmMxQewzTxSmGNjWbnMP7Lwfhger4OJAZCKFfZlJlsaa42JCiOlAcjwFFlSKs20ke6ZcqKxyEmpfbnl0UxHkMEgChO+ZLCaorD7eH3ck6/wJOJUU916NUdvw5vLbLT2ajiS8bpVza4tXMXNAUSuxtYbTYY0yXQNrjzQUySm v2JtRLNZ LleMcEz5H523b2suiKtvOK/2zbRkPF0YDnWkpPJgrg0bWMZhHFENaYrly4Wql51hIAhqDJ6++y1/xz9E3YbcQWGl1oRcCXFxr6jxQEBd4lEeEZyH011Juocv6nb+qBhdX6W/rKDZMnnPq+UMqAorvfXaGzrR4Rj9aTJib4RHNxVpohW/Kvsm9aGgM381sMSHlYq14ztlzgdGAfxzZg81ITyKOm6JlUoRgpDHfAFYmN+xX25vRJ6C3RU5NWOvQ2N7jg/RBHuc6bbYe7rWs/mv5ZJ97MhqF/qHOA2FXENuleNr6YBuTMAQ7tolwY+gn3+anAn/tyI9nCpAMCkmhNgc+IlcC8mHELTl3j6b1gx/get/GZnZ2UP66QrlW2muoNiR2W0h332dEkmiZHjTfBxtRTlGd5qAS5uP2BZTL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --+HwhJGFuaIQgoGSS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 29, 2024 at 10:22:53PM +0100, Lorenzo Stoakes wrote: > Thanks, I figured out the problem, it's not arm-specific, I was running > self-tests but eyeballing-failure resulted in me missing this. >=20 > This is a product of vma_merge_extend() invoking vma_merge_new_range() wi= thout > having determined the next VMA correctly, after moving from vma_merge() (= which > looked this up for us) to vma_merge_new_range() (which does not). >=20 > This is after having adjusted the assumptions between v1 and v2 of the se= ries in > each merge function, and I simply missed this mremap()-specific case. >=20 > Andrew - I enclose a fix-patch to get a fix out for this asap, but I am d= ue a > respin relatively soon and will also include that in this. >=20 > ----8<---- > From 3678f8a53f98de52f11946d4d32e6fb239d11c2f Mon Sep 17 00:00:00 2001 > From: Lorenzo Stoakes > Date: Thu, 29 Aug 2024 22:18:02 +0100 > Subject: [PATCH] mm: correctly determine vmg.next in vma_merge_extend() >=20 > vma_merge_next_range() requires that the caller specify prev AND next. This fixes the problem for me. Tested-by: Mark Brown --+HwhJGFuaIQgoGSS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmbRwjgACgkQJNaLcl1U h9AXbAf9FkWBHDchz8lVBIYqoq4in52zRMMQobF6cNp8/HyUUDWMa9OWZJk8byZZ 3ogVYfXYc6BPFaY/ePBCH8ByVdUHb0r5zC6vuyK9lKg10/O0lHWKPCLBdJz+Vnuz NDAygjzV3tGPTlGSr/vZK4h2lSX/fFw59dd/1fsebnDxv+0PPnbSvzx3LKEVoXj2 r5DIbk/CuIYuvDbs2MsYTZBorDJ5PBQI9rtAXZ8SdQpSWfWZyprKED2kwnsH1IJi Ht8207Q05g9e9Ck607vSElZzSIIFkgbHcWPUFTrJ+8Uydt8Kasp09SmszudU6SJg 4Xd4pXqGzH9L27f63tdt81Rs7SHmRA== =OiSW -----END PGP SIGNATURE----- --+HwhJGFuaIQgoGSS--