From: "Christoph Lameter (Ampere)" <cl@linux.com>
To: Yang Shi <shy828301@gmail.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Marc Zyngier <maz@kernel.org>, Will Deacon <will@kernel.org>,
Ryan Roberts <ryan.roberts@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Vishal Moola <vishal.moola@gmail.com>,
linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org
Subject: Re: [PATCH] ARM64: Implement arch_report_meminfo()
Date: Wed, 13 Dec 2023 21:25:10 -0800 (PST) [thread overview]
Message-ID: <62201f98-eebc-ce13-4384-99eeb19c09cc@linux.com> (raw)
In-Reply-To: <CAHbLzkpPTVHGUKfA1xeNwp100UAJxe0pmvMQdXpn_qmX3eLdag@mail.gmail.com>
On Tue, 12 Dec 2023, Yang Shi wrote:
>> +static atomic_t nr_pte;
>> +static atomic_t nr_pmd;
>> +static atomic_t nr_pud;
>> +static atomic_t nr_pte_cont;
>> +static atomic_t nr_pmd_cont;
>
> These statistics are useful for debugging. However, why not use the
> direct_pages_count[] array to save the counters like other
> architectures, for example, x86, ppc and s390?
That is because ARM64 also has the CONT features. The code significantly
differs from x86.
Using the above naming scheme ties the values directly to what is supported by
the hardware and results in easier to read source code.
Calling this "direct" something is then a presentation issue.
That is actually something I was not sure about. CONT Direct is a bit
strange. I'd prefer to see PTE/PMD/PUD there whic makes it clear to me.
But I guess others expect to see "Direct Pages" there since they are
used to it from x86.
next prev parent reply other threads:[~2023-12-14 5:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 21:11 Christoph Lameter (Ampere)
2023-12-12 18:31 ` Yang Shi
2023-12-14 5:25 ` Christoph Lameter (Ampere) [this message]
2023-12-14 13:02 ` Robin Murphy
2023-12-14 21:35 ` Christoph Lameter (Ampere)
2023-12-15 19:44 ` Robin Murphy
2023-12-18 17:49 ` Christoph Lameter (Ampere)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62201f98-eebc-ce13-4384-99eeb19c09cc@linux.com \
--to=cl@linux.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=shy828301@gmail.com \
--cc=vishal.moola@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox