From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 266C6C46CD2 for ; Sat, 30 Dec 2023 06:46:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4C2216B013A; Sat, 30 Dec 2023 01:46:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 472FC6B013B; Sat, 30 Dec 2023 01:46:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33A266B013C; Sat, 30 Dec 2023 01:46:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2426D6B013A for ; Sat, 30 Dec 2023 01:46:11 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CBA3516025C for ; Sat, 30 Dec 2023 06:46:10 +0000 (UTC) X-FDA: 81622550100.15.C459793 Received: from mout.web.de (mout.web.de [212.227.17.12]) by imf04.hostedemail.com (Postfix) with ESMTP id A3AC840014 for ; Sat, 30 Dec 2023 06:46:08 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=web.de header.s=s29768273 header.b=KMV0nsVr; spf=pass (imf04.hostedemail.com: domain of Markus.Elfring@web.de designates 212.227.17.12 as permitted sender) smtp.mailfrom=Markus.Elfring@web.de; dmarc=pass (policy=quarantine) header.from=web.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703918768; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0rpWJ0BPv9NNSgZTLUTYF6m6rtLG150kbTHmscQ29oQ=; b=f+z9EnLDNwJsJrFbqhvz4rv1d/1do6XRxK9ZnS8CE4DHLWbZEAmTcx7BTDAvhR14R/qIZR olbqjClKoLeUXUHV2pp2J3r5m3HXEROex7HIc28y/8Swrdj2o8FtTX1nUDHoVdgkkk8I0E eXx1xj6yAwYJ1c4RaQAN+CegdWe9Ibo= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=web.de header.s=s29768273 header.b=KMV0nsVr; spf=pass (imf04.hostedemail.com: domain of Markus.Elfring@web.de designates 212.227.17.12 as permitted sender) smtp.mailfrom=Markus.Elfring@web.de; dmarc=pass (policy=quarantine) header.from=web.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703918768; a=rsa-sha256; cv=none; b=Uw9w4ZKyj91o94p1QWI5JVcHvpGt8dg8Y2zRySOB58IaNnghE6e8Xr/y/dKHwO8px9gYPH VHOYakug89Mk1X7KJ7uEtnGwYJjKzIDc9Wcz9ovf7yxbIBI+Lz1sur/GWQZ5p0dxWJkj2x PGnAWfofpFp2fCa7BEnnLsmeYY6bheg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1703918766; x=1704523566; i=markus.elfring@web.de; bh=MrI+HlTPHjGiVMETAdFalpnGbyZX2n6jfxRAlWoU6no=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From: In-Reply-To; b=KMV0nsVrGxfofH8a/TpBKu3neLfMhUs+V3VGW6Cn7iLkUp/N6la6vwe/V6d8kWfX BqCnPkVRebmheAolwV9RQpOOA18ke46k1d9XRDo08BjesW4YEeHX7OCCyrhfjFQ35 9ZKwhibEeOqxZstAth4zI6FlzJVKlNsbDdq26uvCRmJQEUvBfFCjhLx+mZ0rAHpqH fSy6KXvxdVRZ2dJLcIejyGuHULC9SwZAfGTzDhbhlUSgLx6dhR5zpv/AtNjDMTl9l 69Mjr74xO+vCMy6owLxtNrcjbpYCjK9bMU5jCus+PkpJW+rYj1neO8tgTrPePmKBu 8UvNi3ZzfOH2Amu/5A== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.87.95]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MjgSv-1qprqH0saR-00kqVE; Sat, 30 Dec 2023 07:46:06 +0100 Message-ID: <621c7483-9a8c-431c-86e0-85d23b983471@web.de> Date: Sat, 30 Dec 2023 07:45:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] hugetlbfs: Improve exception handling in hugetlbfs_fill_super() To: Matthew Wilcox , linux-mm@kvack.org Cc: kernel-janitors@vger.kernel.org, Muchun Song , LKML References: <9ce3f553-24bc-4ecd-ac5e-7ba27caeff57@web.de> Content-Language: en-GB From: Markus Elfring In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:Ve8neiGe2q5ryqxM6dzaXIxfeGHBlbzo1qJcYLsQ4RG1C0BHG4Y iVXPNs6/F7b6gq1kCic2vQE8tnCUG8nDZWQ6OteFB4tPYOuO15VfGA+Q0BoFCkjfGjWdOch pgEpL5ZqaEBhHT/rwmCXMzu2ZjWuTeuxuQcCMZaf31OwzKx07UoZ7shYeIu9ZlWsIg/gOBY QLh0SUQlhJQiX/PYhWGIA== UI-OutboundReport: notjunk:1;M01:P0:M7PlL5FeIXY=;P9CA05MuiTsu8Dx9xQU42UD9CtZ LDI4EywlodTtkCBe6x9Sz2G/e0wDw+0kn53GXNqM2o0sisVkvVUAFeQPUpxhC3VKhxjtLfRPW /egtBlhmnM6s6MWd2hitASrMibEmiZGchb6CDPKyasJ+azcGFfybofZEzTzAVncYkPqaNEutB hYRGUHc8IaWo7/XdbHjOU1skOELwJQ6rgJU2WQT52/VS4TkIl9fOnyJLHjRQVN6ZGhlI81lKD oP9HAXrGbSYGb/0+1zIL+CawJ8fRMa3IWu6Fn3Qg8kf6/tQyRQwl0rUhJTyeZlDvDtl/ftFqO 1oPLgpe7o1+FebxrkOJgbi9iB3BzGAf0BlLiD/0UZLWHj1A+BeCRXH3iWyUSQDL1JeJbC9SbO dYDJJKt6heT3OXxlQgrqTI3B4+4JPjGdMbhchQ3MzdsylWZ/Z9pC+QD5QWoVtQdPnsYTiO/+c k1I80Eiqa8WfDJJoDZrQm0SN7jEdmgtlrFKn7DHjHFK21JxCMpeHC5aly7xajtYd5nr2A/RmC WJabT0ZKJou9U7sTkoUoCG/ek8usKP7FmY02aqWosl3dXWi5Ns9nm1cItEbSP3PXEqQ09TIMv x9uBABU6P/Gzs1w6H9kfJTUVfIYLjqP8jUqG2leSfM0oEJPk0awurtYRGjQXr+CeuSnwklxPW 6YfDKwy9f1OElxm0AGvWpjo5NVic/Mdc8GF313axP9ICGODsYtpTqyrZIFvStTT2waUjvyqSJ a0AXAQB9HPHmNLrkmBnVWvIiZTNMTOIGo0KsLO0ck1xO968zG5VdiZNXqFsyOLDNCAJfkf32Y cWhdQ1++FjFeLhe/kIxPgV4xRgNB2KFU3inTJBXCemktUDTsWX/SHhl3upzmH+dlpnKqRW6Wy 7ix7xwFhZvsg6UUc6vRqYgH+NUKvB3K4Q30tPs1BmB78/6UR+C3RIllUFGpUd5XllI5v0zK8S ci8axg== X-Rspamd-Queue-Id: A3AC840014 X-Rspam-User: X-Stat-Signature: 8p51cmre366epxxyf3nex5j76my3rs97 X-Rspamd-Server: rspam01 X-HE-Tag: 1703918768-1629 X-HE-Meta: U2FsdGVkX18++y81zl+j4mLOUbuxeFHZq3n8/3lv3znsUW6Zes8OMsE0ilewcRRzMhgq2fEVKipsfPjFQCgxSrvvtlLEDo0jQCcATe9EHueWKHRNl/0C5Or35toOGYQrQhNFFQ09CoLax54pnmAQ7BIv1Lw56yvWqP9s9aINpfZKYb4E0pwpEegHSfwiht2KxrQ6bnyHfMbACtH3Jbl6TbT6uXeI7DZLEHGoGxwezIyIkSpNU8gykdgcTsp9+wH6x+q373QToELY0hhLVWZxHSBitTuuLcKaYDheickhtbfm93IBLigFeR3wJX11toATVZwtTOF3Rj1YurXdAO6kqTkByAlvfen2UbFy4gNUNCkns4iwu7uUTiYcf5zVdYuDHmRgulqF5z5rdUvKB0TcImIuUFwbtYv+Jb7wXPzuRad1A80wShJFSHbZb/m9ywSgBlcSYMUs7czbQ4o1R2VWFXfEj261TusEc+x0POU6vQEwvvrYTR/1qH4J42hDmnoRZmDq3BIFCKYVvnhTIE4dEbMn1EAeDyJocg++KFFwbUz5WGV7z+jXE17A8tJ8sD9/tp4Fxgfb4EOPru6Lfv1eBzQ/HKZoFU7zCKQVOli8M02yyAkU/UbWBG4EBgQSKn7QEj+jWGHeNbRSsusVMNBYPgDpb3g4yBFRzI0EahVrTHrQcIEmFI57zg2U+10U73wyUWjD5bAydQ5ayUaCMOQ83WX7LNAqOJqyljeQzJoZG/tQ+aJhmSa5O5lcQnL+8brZWk6wK4I6GEAkap2mI7LWAXDggDMdpXce6ceYF7QTKWLF7fXcUP1sGTlKOyqTWpQG1uqHJetM52hBtHCwStvyL9k8/UpuWxzpCSyWaIAL3TaHIqWVKaBEOKh/o82nPn9Niu8TWMMyWyHiTGDLLRkjSe9vAcvrErlO+/CkZtB8fBKaiKDONazNOVu7MKlhMFWLRTikYhD9SNWr/oXtpKm Fd2Sb7zI VT8n0Tvj3xvDsGXZaQOxk3Dtl9l4pHtw9O0Vz10nsHRy1u027iyoZPDmm3cqIaL+KxW0hh0uHp38/zf1fYIuy0ac9XN4DqDxcXQF2ylijJAsT+ZFhGrW5m46C++26V0F9oOYHWlhqHK8lOyTNZVLlXeuUAwJj4zWK51qGgps1wCTKM7R5R+xV6xYaWOlvUG7qncPpsQqE36JqxGJBoMqjhwxs+jHv8b/xFyELjJc7prhfec7rRt8RqiyZefEeUbH8W2F2NqwPGYEr6kUaKbKn6pe1KL1NRjXtsyLL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >> +++ b/fs/hugetlbfs/inode.c >> @@ -1483,7 +1483,7 @@ hugetlbfs_fill_super(struct super_block *sb, stru= ct fs_context *fc) >> ctx->max_hpages, >> ctx->min_hpages); >> if (!sbinfo->spool) >> - goto out_free; >> + goto free_sbinfo; >> } >> sb->s_maxbytes =3D MAX_LFS_FILESIZE; >> sb->s_blocksize =3D huge_page_size(ctx->hstate); >> @@ -1499,10 +1499,12 @@ hugetlbfs_fill_super(struct super_block *sb, st= ruct fs_context *fc) >> sb->s_stack_depth =3D FILESYSTEM_MAX_STACK_DEPTH; >> sb->s_root =3D d_make_root(hugetlbfs_get_root(sb, ctx)); >> if (!sb->s_root) >> - goto out_free; >> + goto free_spool; >> return 0; >> -out_free: >> + >> +free_spool: >> kfree(sbinfo->spool); >> +free_sbinfo: >> kfree(sbinfo); >> return -ENOMEM; >> } > > This is more complex. NACK. I am curious how coding style preferences will evolve further. See also: https://wiki.sei.cmu.edu/confluence/display/c/MEM12-C.+Consider+using+a+go= to+chain+when+leaving+a+function+on+error+when+using+and+releasing+resourc= es Regards, Markus