From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA498C0218B for ; Fri, 24 Jan 2025 15:20:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 06832280074; Fri, 24 Jan 2025 10:20:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0186A280070; Fri, 24 Jan 2025 10:20:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DFAFA280074; Fri, 24 Jan 2025 10:20:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C0B2B280070 for ; Fri, 24 Jan 2025 10:20:00 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 47022B1720 for ; Fri, 24 Jan 2025 15:20:00 +0000 (UTC) X-FDA: 83042705760.01.50C7964 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf30.hostedemail.com (Postfix) with ESMTP id CADF88001A for ; Fri, 24 Jan 2025 15:19:57 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=25c6Dhbl; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=oJNjoNCO; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=25c6Dhbl; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=oJNjoNCO; spf=pass (imf30.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737731998; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JVptaKsKywBb/luIYsL7Zvg5gNwGNyiSLMBWcRb5mww=; b=eRZvobw74DUiCsstQi3HsuFlJ4oInFCcSUw+rjopYGmmrmyISHGwBil/qps6pgZ30vGMCi 2a8+azJ5tYEUjARgiXz/2vOzhCQ02S9koyP4gp+wB0mgjOmuAo0gLaosUQFIREkTsy5QaL MiqWkiYlTjohybyvOBMItzfP5D6AQEc= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=25c6Dhbl; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=oJNjoNCO; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=25c6Dhbl; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=oJNjoNCO; spf=pass (imf30.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737731998; a=rsa-sha256; cv=none; b=0mrBROxTu2neI2PH6Zfmo77aG6m5LN4gQg2fiBxLG6S5TJoJ2sy4d9vyV9WSmuvg6ZG232 /QPm/zhyU5i+A0JRJMAjZh9IYds93yBqQmoKU/fDiATfLqp7d9EMjgVCZEwruaU9VZWyhq Nu8iGuzvkxn2mADByTYQ06hs5dbUytU= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 30A6621160; Fri, 24 Jan 2025 15:19:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1737731996; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JVptaKsKywBb/luIYsL7Zvg5gNwGNyiSLMBWcRb5mww=; b=25c6Dhbl+uxJG5SNNsMe/Xvr8G/+WsQ6O00cy2ANkcN8yTKJDjwOc+bfI/kpa5VMcXgNFE MuF9byzvqWj8oVs/vHslbzSsFF+j2BBfNuAY/klLCdaAjNBDq/B22oRpmERk1vAwYKywmv wp6LtFGXaEXlO8HZY3SL4ycI8xb2A6Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1737731996; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JVptaKsKywBb/luIYsL7Zvg5gNwGNyiSLMBWcRb5mww=; b=oJNjoNCOWyNVbm56bC7PzSEQcfvTy8rk3sqtMitUcDb2+6iNpcchaRbg/0FkN50g64hG/A dW6LWTBwrBrdL7CA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1737731996; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JVptaKsKywBb/luIYsL7Zvg5gNwGNyiSLMBWcRb5mww=; b=25c6Dhbl+uxJG5SNNsMe/Xvr8G/+WsQ6O00cy2ANkcN8yTKJDjwOc+bfI/kpa5VMcXgNFE MuF9byzvqWj8oVs/vHslbzSsFF+j2BBfNuAY/klLCdaAjNBDq/B22oRpmERk1vAwYKywmv wp6LtFGXaEXlO8HZY3SL4ycI8xb2A6Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1737731996; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JVptaKsKywBb/luIYsL7Zvg5gNwGNyiSLMBWcRb5mww=; b=oJNjoNCOWyNVbm56bC7PzSEQcfvTy8rk3sqtMitUcDb2+6iNpcchaRbg/0FkN50g64hG/A dW6LWTBwrBrdL7CA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 063B1139CB; Fri, 24 Jan 2025 15:19:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ofgzAZyvk2e8EAAAD6G6ig (envelope-from ); Fri, 24 Jan 2025 15:19:56 +0000 Message-ID: <62044279-0c56-4185-97f7-7afac65ff449@suse.cz> Date: Fri, 24 Jan 2025 16:19:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/slab: Achieve better kmalloc caches randomization in kvmalloc Content-Language: en-US To: "Christoph Lameter (Ampere)" , GONG Ruiqi Cc: Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Kees Cook , Tamas Koczka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Xiu Jianfeng , linux-mm@kvack.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, "Uladzislau Rezki (Sony)" References: <20250122074817.991060-1-gongruiqi1@huawei.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: CADF88001A X-Stat-Signature: u3u3ddyeqtbxf5bemimfxj7yu3arjm9p X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1737731997-916252 X-HE-Meta: U2FsdGVkX19yhpwxkiTsUYLpptyjBeFX49pOAaj/B/9rFGTb9mpagAFjjMYkZIzLHq42txOxnhkPj0Lk0B7vVJl6iw8f/u9yivLY2uKBnsOQwnF836BaUErqCG1IFLbLnI185na4Aec2pRsLDVdPCqGRVzTzElP14SESTdiHVEav0UQAGXvnzO6Hr9T+/1auOMHait/S+n2w7Rq8WgzE0T3dM3ig5b0iVHq5ebMaEuA7Y+mnH0Q7Hm+7E4wr3HIHscqcuOMxLsn4tJXo6Wbnc9Cse92yeEuhxeTCDp4QKyxm2jG1qrXwxjhuZ4XnOBMiD71364JfDf3Fn+ecd4SRPg6tcthcooARczN/boy1Oz4778y5RkzmMJ3x0hGODamSX+1NN9msoyL2z9bqdlWjhYoGH2SLIaqrzOQ6+2nxg4ECYKeQKw2jlAA/4ZtlYaNlBWcUAa5Hb66Z3+wPv5UulNEmJ7Z3PTvqdcJwg02uAEsKZmr8DhgXDYYBzyhos97nNcYYm2JN+Iq9i+id3KcQ+EgSz7uZHGZ78JYN3TQ46/SdIj/9F6pDbnzpEyNyP+2SxC2xs9vhXJZtov378l7mi7ecLVGAz6puXpFezSaK+igDYfv+0uZL2Oy1HXRJYMlo5pL8qdTdklBseR5k/lxQBMb/VNP7r+o5Hf+FIV4hHHYOBWUEBGxCfvWqr/Zc/OjroMDqOEOk3i3b3MFY4gqvwHc3SFy4ORA2RIKGBUgUd4/G13oSJKnYU2RIduKCbwZqL+xMM3+0jfKLmk1kMfMySBdviGWF1X+EByxauhHivc1zHIJGwrCIf75cIaOhHj2oa9XLrp0hocG8Z2TuBihsJwRG8D5yCVqDHJ2mOSF22jw33SFBKIvEGTfOsvo2pDtRwKgmE+9ow8gebdN4O3at5Wq6Mw4iP6579dot5B38LniuUpKi+1f+97nSmCzmk9NSD7IWI2huQeUrcM2kNgW UyH+q/R2 Tez4wXAaYVW7w7gwDAh1Auk8biiZJIYD7gXUUMj/HcBoaNSLU1xZQ37EdQq2jk1dU90psHuhcA6abjh/fzY34dYthQeFfgdkcjEJcllvcCFmHSFSXBpKBokAix5ZJNKohiRawsN8phFSlkGbibzKMLSp1VaKuqIFwt1ES0ZgJCu8lelxxo5eufEB2xFxPttDAl/jyAEqLGA68HtZDDalIR7NoJr0fkjhmhqDoxkx7s+7HJLpJPT2XeSzYLZLdmk9QX456dhTNXeDoySc0tg3XCO/BW+DhKND85IDcsHjlQ7/ks6YfderY1hgJgs8TGGeTnz1ojEPHRLUn44SrEMA/xNhIUCxP0s2/gL7v7D2e1BaN3/o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/22/25 17:02, Christoph Lameter (Ampere) wrote: > On Wed, 22 Jan 2025, GONG Ruiqi wrote: > >> >> +void *__kmalloc_node_inline(size_t size, kmem_buckets *b, gfp_t flags, >> + int node, unsigned long caller); >> + > > > Huh? Is this inline? Where is the body of the function? > >> diff --git a/mm/slub.c b/mm/slub.c >> index c2151c9fee22..ec75070345c6 100644 >> --- a/mm/slub.c >> +++ b/mm/slub.c >> @@ -4319,6 +4319,13 @@ void *__kmalloc_node_track_caller_noprof(DECL_BUCKET_PARAMS(size, b), gfp_t flag >> } >> EXPORT_SYMBOL(__kmalloc_node_track_caller_noprof); >> >> +__always_inline void *__kmalloc_node_inline(size_t size, kmem_buckets *b, >> + gfp_t flags, int node, >> + unsigned long caller) >> +{ >> + return __do_kmalloc_node(size, b, flags, node, caller); >> +} >> + > > inline functions need to be defined in the header file AFAICT. Yeah, this could possibly inline only with LTO (dunno if it does). But the real difference is passing __kvmalloc_node_noprof()'s _RET_IP_ as caller. Maybe instead of this new wrapper we could just move __kvmalloc_node_noprof() to slub.c and access __do_kmalloc_node() directly. For consistency also kvfree() and whatever necessary dependencies. The placement in util.c is kinda weird anyway and IIRC we already moved krealloc() due to needing deeper involvement with slab internals. The vmalloc part of kvmalloc/kvfree is kinda a self-contained fallback that can be just called from slub.c as well as from util.c.