From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01522C36018 for ; Tue, 1 Apr 2025 08:14:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 23CF8280006; Tue, 1 Apr 2025 04:14:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C6C9280001; Tue, 1 Apr 2025 04:14:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03D47280006; Tue, 1 Apr 2025 04:14:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D72A0280001 for ; Tue, 1 Apr 2025 04:14:46 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 930C081AA1 for ; Tue, 1 Apr 2025 08:14:46 +0000 (UTC) X-FDA: 83284763772.11.6A7E955 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 4451716000E for ; Tue, 1 Apr 2025 08:14:44 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IFbugVBs; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743495284; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZMrw/hF4iYRv8xEz3Y+x6UfdccDXIACsT6AaEq2CDuE=; b=M8eofllTN9pBjyuVh5pymrQL8a66wMaKGJrS/fCAr0qIP7k9FRkrpYdrHVd3sArse5h4Mb DY9rUt2A5teh8aKDpDGyTb1QDBd5ktAAkRVFMrEy0DjE+wpU3XQo9WFqI9z5a+lp/X4tu/ Sn/Hr1irlYNnzMeWO/Nqr3gdnDd9+EQ= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IFbugVBs; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743495284; a=rsa-sha256; cv=none; b=o5TmWpecLqA3GZUMho83KombQVnMQP47hKLPIdz56VqqWbyq82QWxejsv34prX3WTBxSe3 XjlZL4x8ZtSrv2ljP0EL3ZQA9lZmMAyTxG/ifh14y43DXmOrslUqcB+Z7Q+IEci9im8Eyq hdSNybMC9pZhSbKXdXWlPq0WCZ4Ivyg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743495283; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ZMrw/hF4iYRv8xEz3Y+x6UfdccDXIACsT6AaEq2CDuE=; b=IFbugVBs8ynOgoCFQlrAveAEvU7ze8SFtWJ1GfPM8PeX8daXiY3evJSIPDhLtio7Gt2hhN 27NrSZILkXc0ajfJwgOlmkqtLfY8ieEWKdFcbWPVKU9XnA4iNERvp3U6oUbJPmsAv9gs5g Wdn96cVU6b4d3R4SsMyKJYuLscqDzxM= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-398-cX5CrB2_OaCIZGhv02AEig-1; Tue, 01 Apr 2025 04:14:42 -0400 X-MC-Unique: cX5CrB2_OaCIZGhv02AEig-1 X-Mimecast-MFC-AGG-ID: cX5CrB2_OaCIZGhv02AEig_1743495281 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-43d08915f61so31155685e9.2 for ; Tue, 01 Apr 2025 01:14:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743495281; x=1744100081; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ZMrw/hF4iYRv8xEz3Y+x6UfdccDXIACsT6AaEq2CDuE=; b=YkIwEFx8vwyZGuB3UshcQFtGoa6X5OFbhiM/4fCi/fTEoxYyx0BSzxdXg9yhmVUXcF fzJs3xM0nE9qMmwXBuEO3k1+L9OGW3OUcmb82bMZ9WWLx8OD+SXw83bA6G2t7kHgR+Ge jIokI9f8eELLtOHNj7nP+P1R+OWhLp55dahPex+9/FbYZeSFcQImODc8PKtAwmmddoRF 8dLZKIKv9vxgvFIU0ah+Jx5K1E1dOOCCJLYBLVvjqxJgaEVQcvA8U7unam5JV9XviWUD xW6Jvt8WB+nf+s54/hbLrlg+a2floUl1t4HeSoEfzkL8CRHqqw+kJu5VK7wOzkhqlSJJ fG4Q== X-Gm-Message-State: AOJu0YzWG1il0+k8y/y5Z7LtJlvQnKD+0B6f3svpZEfO4uJFKk9hJaJk SLSWBhsHfTgKIDjNrXXo60HcMKLyIjLXW9i+lA2mc35lyAqSblSwvzSIXqsPeJ4W6/ZtnGKc2Wy VBsV/NMI04hrw7h2nERP2UMcHyLLVRKN6X5ZvrJLsZp4jo6/g X-Gm-Gg: ASbGncsWm0VX0b+HRWss0Aa4zcePIcVGn5ZAukcs2KFgY6E18tcoZ1IWdULJoGOzErG okksiDOvPLtNBpsTNSMVueLMjBsdo4rbDLQK+/SaUIfAnhTnGwT9BML7CkakXR/uceeaZCZ+NEI iSZGjfRa4mvtPM7dPvDh7+p7VLhBLCnG3vV3fyClU1bQBAPd48Z79Hd6cdacnGVRxDvtUkYUg3q VHZpSUB9Xsb53Sax47X0Irg++Nv3ZCu6o1N8kJmiWfAbCr+x1B4d+/76+PE+SBD2Au5/EluHpvi Yo11MMkh3vEsDtKVoREvOEpyRpI+alEy3GJc80TK4531lkqC2wdSyQizziJ4VvuUeYYfPCABt9T LrB7u9tfxvRDKmM8iMJb8lvKUsSEPsy8tPMJg/PlP X-Received: by 2002:a7b:c85a:0:b0:43d:fa59:cc8f with SMTP id 5b1f17b1804b1-43dfa59cd30mr76161245e9.33.1743495281285; Tue, 01 Apr 2025 01:14:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEPD6Zz8lOr7UQtRkeT40hSJsdY+e1kLD46TaF45a3fZZvcvdNjyBA+fg2ymnWHHAcglU+MXQ== X-Received: by 2002:a7b:c85a:0:b0:43d:fa59:cc8f with SMTP id 5b1f17b1804b1-43dfa59cd30mr76161055e9.33.1743495280936; Tue, 01 Apr 2025 01:14:40 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:4d00:6ac5:30d:1611:918f? (p200300cbc7074d006ac5030d1611918f.dip0.t-ipconnect.de. [2003:cb:c707:4d00:6ac5:30d:1611:918f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d82dede5csm195587865e9.8.2025.04.01.01.14.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Apr 2025 01:14:40 -0700 (PDT) Message-ID: <6203a9e6-8dc1-4b36-aa2c-41c29487812c@redhat.com> Date: Tue, 1 Apr 2025 10:14:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/7] mm/gup: Fix the outdated code comments above get_user_pages_unlocked() To: Baoquan He , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, yanjun.zhu@linux.dev References: <20250331081327.256412-1-bhe@redhat.com> <20250331081327.256412-4-bhe@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250331081327.256412-4-bhe@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: PCvh8l-mvHHSBYRpwEHtAK0krS3TZ6XbWji2cRsXzYg_1743495281 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4451716000E X-Stat-Signature: wqbft6motdm1h9qqcfk5f6p1tyr6a6ft X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1743495284-719114 X-HE-Meta: U2FsdGVkX18Q5UsZQw4yTrgTszCOhN6KRmfZ1/0oo4foYGH7ckU5S3f7DQpyIGq/u40td98dzYSyFPD91ZZbzusP3c2u3TsMLyL9a5T5BJefl09P1zws3Sjqo0Cvc2yO75i+CGM7IHeQVlIIyswr0IqWYY8BRbmn6QBRPW+x2kLnTcoTTEdSxQc9FL3fe4+cbtYk/Eydg6lJAK809Xb2uR4wk19ovy+XydPR7mzZ+Ns1hV4tp01mln9vYpERn0NHCfCMXACr7TPlG/URZIqH10G4gWJU2RA7V0d0Flp3rkCZ+o2zZSKw0LfYGRGhHutVRGOCGrKbVt4vHFuuoOcetpdLOwLm5H+p0TFe8ubwgaSFOCpv+pJoHfFoSN6pfpKUxO6TGbdPfoWpL+9g9vol2Nob9zJcxBvhFVSWuBK2xglJg8CS1CkY7IZHbIIs+4sCjIDZNaXIpL3JfebHF/yHwqSlA3jDybqrDFV7GchbY6+ToILXpYdFwN+//cHg5/efwwpnH+aILHwaXajBEBeI4iXVfRi8Vbcki+dyQ1mncS3Yh6jlS62uT9Iwb8H3e5Q5r5ZjK6Q/m3vKRqazXEpKrxF/EfJVjrIvbEeurjPiCGecQ6qhnzn4U6MIWbVyvik3OUIlak+QaEPHJwpeQ02eSn6jmoIkWmwzBZfygVswfP/hmj/kbgbihL4Wjw6WKC8BtynlQLYMGX27Ysz1uJ41qKQ2x1kH1ZV1k8DVJAjpyb+FcqrHAnYJBhJTXTbrzoMe5saeZRwSILCdWZ6Z3IQyLC7t2sOYh2aJ7Ae+YaYzl7euT12uP2zpGugEZgJc5OV1rwqsX0jtG3guS1QGWJ8AjRo+eZhJaAtq8/h7qCHRDCpAgYiRua4r0OhWVBk2O//tDIu+1BgO2S9NsNnuy3AjA+M36zx6MrW1jG8hYfEpSjdfy9CGELn32VnnqucBgcoyjiTvAhsz8JJzPinMfav QDe14Q68 MoCxcSZDBCL8/3KBGB52FnHXwIwbSW6wIbGA6Z1LlP9576NZLCqNAPjI0nddPvvhW+FCkcmfIlN70WLezeEvHqsrwonItULlczwbuhPuce73p5izSZOoHxNQlJVBIlXvARGR1xXwXqPwW+qq0gxvu/xnBJrp6RQY9eJEi78JhXEBDbUV8VOE+jbX3P3rx6MSqYO63p+UmSzfmU4RGL9DhOE4oG0ob02/VjveSElP9at7f2Hylwkno1xLIEFXpntKRF4nwrZS1mJasjG3mH6j/2z80bYUfALVoqo/ge5rKc+XsK+L5pt6YXbyAVO4Zgc40NJMu+gDb2s+7Trii/VSF0UzeA8LrhjLg/sPWJYKBfOTV4L4FFVJmDR01X7kSaid1aaTogRfgcQ5u8rvvNAvx1Oo63NQ6c9WodJgdZFw9wOtjH6IVmHLjWrx6YnbsQILSYtQZlJxy1H+qGZFA6v782cjJN/TIQBAAltjw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000071, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 31.03.25 10:13, Baoquan He wrote: > Since commit f0818f472d8d ("mm: gup: add get_user_pages_locked > and get_user_pages_unlocked"), get_user_pages() doesn't need to have > mmap_lock held anymore. It calls __get_user_pages_locked() which > can acquire and drop the mmap_lock internaly. s/internaly/internally/ But your statement is wrong. get_user_pages() must be called with the mmap_lock held, because it sets "int locked = 1;" when calling __get_user_pages_locked(). -- Cheers, David / dhildenb