From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0BD2C83004 for ; Wed, 29 Apr 2020 17:01:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AB1C02083B for ; Wed, 29 Apr 2020 17:01:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB1C02083B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5B8518E000C; Wed, 29 Apr 2020 13:01:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5677F8E0001; Wed, 29 Apr 2020 13:01:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 47E248E000C; Wed, 29 Apr 2020 13:01:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0158.hostedemail.com [216.40.44.158]) by kanga.kvack.org (Postfix) with ESMTP id 314468E0001 for ; Wed, 29 Apr 2020 13:01:40 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D7F6B181AC9CB for ; Wed, 29 Apr 2020 17:01:39 +0000 (UTC) X-FDA: 76761509118.27.gun08_659978d60cc49 X-HE-Tag: gun08_659978d60cc49 X-Filterd-Recvd-Size: 2385 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Wed, 29 Apr 2020 17:01:37 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 72CB11045; Wed, 29 Apr 2020 10:01:37 -0700 (PDT) Received: from [192.168.0.14] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 05F713F73D; Wed, 29 Apr 2020 10:01:34 -0700 (PDT) Subject: Re: [PATCH v9 09/18] arm64: kexec: call kexec_image_info only once To: Pavel Tatashin References: <20200326032420.27220-1-pasha.tatashin@soleen.com> <20200326032420.27220-10-pasha.tatashin@soleen.com> From: James Morse Cc: jmorris@namei.org, sashal@kernel.org, ebiederm@xmission.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, corbet@lwn.net, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, maz@kernel.org, vladimir.murzin@arm.com, matthias.bgg@gmail.com, bhsharma@redhat.com, linux-mm@kvack.org, mark.rutland@arm.com, steve.capper@arm.com, rfontana@redhat.com, tglx@linutronix.de, selindag@gmail.com Message-ID: <61f1b270-9c88-f309-9665-0221a228b5b9@arm.com> Date: Wed, 29 Apr 2020 18:01:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200326032420.27220-10-pasha.tatashin@soleen.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000075, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Pavel, On 26/03/2020 03:24, Pavel Tatashin wrote: > Currently, kexec_image_info() is called during load time, and > right before kernel is being kexec'ed. There is no need to do both. I think the original logic was if debugging, you'd see the load-time value in dmesg, and the kexec-time values when the machine panic()d and you hadn't made a note of the previous set. But I'm not sure why you'd have these debug messages enabled unless you were debugging kexec. > So, call it only once when segments are loaded and the physical > location of page with copy of arm64_relocate_new_kernel is known. Sure, keep the earlier version that is more likely to be seen. Acked-by: James Morse Thanks, James