From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D52DC4332F for ; Tue, 12 Dec 2023 13:20:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 050316B02CB; Tue, 12 Dec 2023 08:20:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F420A6B02CF; Tue, 12 Dec 2023 08:20:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE34E6B02D2; Tue, 12 Dec 2023 08:20:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CF8E36B02CB for ; Tue, 12 Dec 2023 08:20:52 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9EE07C09A9 for ; Tue, 12 Dec 2023 13:20:52 +0000 (UTC) X-FDA: 81558226344.20.C89174D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 6B5AA80008 for ; Tue, 12 Dec 2023 13:20:50 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IFiCNdHe; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702387250; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gEp2xh0K6m3dXczx1Tbxypd18VXOHzxaxsU22bcEgQE=; b=lA8ikoSP7sL2BTQmtm9+dmx0EBuneAYiFuJyUK3kdRbfdoE90LYPoa1n9ooaayODnd9T6C m036wy2ixpA2u9yK3UJkdredoqMc3/gNx/fAIZH0BRnfFEOre99MssHLF9jiBtRpPd7YgZ nby1phaMajW/Xr93wiRHim/EtUuhrgs= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IFiCNdHe; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702387250; a=rsa-sha256; cv=none; b=QaPomLbraN5hDzfy7d2iJOKDS1Eiwxk43QB4fH3Tkwp9iJEmyG3m/uoIM+01SB35cfzN5J pDZrxjruqYsDVqZXVsrIklKmzb46DtoDQ/tL8N7UMD7V3BCKPyqGI5eMsVMF7VBZZE7OI5 OzoRgrEVsezf/mawZ1yueTxay4IZpak= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702387249; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=gEp2xh0K6m3dXczx1Tbxypd18VXOHzxaxsU22bcEgQE=; b=IFiCNdHeoODc3wJuC8upg5l0aH2Xkv44OWUyQ+XXkdphUlXEvwdjmaheLMlS5oeYeomt1V H7V2KkDfCvTect9BTXmEFt4huR4t5kPWDajnP71St7U8FthzzvgsKmW5Ga7c0/wDSrRV5M KYwywhIpFl3RWbJg05dp5EaiMZADQds= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-348-zprYRXRNPFO8Zxoy1dHEEw-1; Tue, 12 Dec 2023 08:20:48 -0500 X-MC-Unique: zprYRXRNPFO8Zxoy1dHEEw-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3333c009305so4879118f8f.1 for ; Tue, 12 Dec 2023 05:20:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702387247; x=1702992047; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gEp2xh0K6m3dXczx1Tbxypd18VXOHzxaxsU22bcEgQE=; b=sMc8JDclO248jGPjuNogyKTKTQiFLp5OS4QDn5qD0W8Ko2I3VQaoT9lzmGAVSOq8oi UIR+Ww3PYJjxsTq3+LLWe0xVd4GHdha2Y2qm3DYWAaYx6TSrWVhEYD+1Po7rKBjyj2kn p5ANVGjaKulfVtV6vYaVx5uhAdKAoQDiNlADyHzmnv/swkri1c0B9sBkvpcdgzCoqdWy Aezatqi+fLHHpEXp0u2SQtpe6gdeREGOflSzoBfmqn5rRy1yRRFf1RSsONI50fjVdW5Z FVBc6m3RCrh2j8o8Sgv01Wy8WLamQd4bz8O20MrakXKs2npXlVciSi8HoRWixcmtJWrh X0CQ== X-Gm-Message-State: AOJu0YwiC0JEykL8+gE3NE7TwmeewdTaJch7XzAK7WcdnNRhcUdm5Wrc KaLr3hVUOJspd20ATtqePGZdATq7W+5mADERCZ7b+eOYfkKzFV/Inej7YG3VBne+mxNAoCgrtPw P0j6vYycPBa0= X-Received: by 2002:a5d:6e8d:0:b0:333:5230:ad12 with SMTP id k13-20020a5d6e8d000000b003335230ad12mr3545137wrz.72.1702387247061; Tue, 12 Dec 2023 05:20:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IGdAXa6hUravv5crckLeM7LLfU/EOPlShqNVu8ayAbnZdfho7qjOHEctn2DI6h4R2ii/OJGKg== X-Received: by 2002:a5d:6e8d:0:b0:333:5230:ad12 with SMTP id k13-20020a5d6e8d000000b003335230ad12mr3545132wrz.72.1702387246659; Tue, 12 Dec 2023 05:20:46 -0800 (PST) Received: from ?IPV6:2003:cb:c74b:ca00:4ca2:ff2c:9092:f070? (p200300cbc74bca004ca2ff2c9092f070.dip0.t-ipconnect.de. [2003:cb:c74b:ca00:4ca2:ff2c:9092:f070]) by smtp.gmail.com with ESMTPSA id v14-20020a5d4a4e000000b003333541a5bdsm10845248wrs.80.2023.12.12.05.20.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Dec 2023 05:20:46 -0800 (PST) Message-ID: <61e9abb5-0c2c-4277-a6a2-4cbf8f9e0e9a@redhat.com> Date: Tue, 12 Dec 2023 14:20:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/9] mm: Remove stale example from comment To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org, Ralph Campbell References: <20231211162214.2146080-1-willy@infradead.org> <20231211162214.2146080-6-willy@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20231211162214.2146080-6-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6B5AA80008 X-Rspam-User: X-Stat-Signature: pq8a4u9oqsr8wpqaoc564hfz14oada5a X-Rspamd-Server: rspam01 X-HE-Tag: 1702387250-329375 X-HE-Meta: U2FsdGVkX18NUwWm/T3+s/bwyuJMansOVGVgDYHsaZShLeuqcAPYvfNUXS83yBaqs6dAz+1tEKGJlNbjfCmfEtU/Jul2nUiVsB+94r796qv6qxSiTXcH+lP1IkvVV3ChQF/S4gC/rfn5+wQWUuQfuHCJdRdYQ19gjDmr9Cgg2huuy9aEmb2DT3x9aZaZJ63Vm+3fijDRCbNpCK7ccLn1btmbqQLCF8D6lgDpSkbeoJvGsIAe4FfoOyo9loTu/mLKmBPtdnapocrs72ExeYiYYIX4LUBCRAcysfxAMfg7xvJTHKgEu0jXpRMUTLUqid6xOphRyPFUIAtLO0Q7BBOR+wMTpRi5h4qShg/TtrPir2+qG0zz3IROCCMyXPYPdXKrB7gElehct3aMJCZwZOhyfyI+uiKhssS1ZssUMCZCxHmS4NcFEjK1VR8x2upPA69lwFLVE5WACBs63ePUFLkaUrn2rvyR+7G/j3spUYknRto+ynUSuLsk03Y3gXqEbubkS/2+7nPS/6ohlu56gO6aTTf1uqaS3wlNIVHaqx5dVasnfpuze/GEhG18cFWlqOLLIVuPo51Cu3aONkHIU/gyD98m0IGvdUqjhGW5R80g/j6dC59mrEOeRZcAgo8yTiI97qIOrUpIMuVfJNLP3VkoZFT6/gDw55PBUfAmqQnJbrNj5H/BO6IxaI/mPA8ZqGT+5GsCNsyqsyQixPRkY9MzE9qQ0o6KvFnmYDWbXuzzb+WCkcpohq5OyN6NyI92mYLsM+71bGoXQIwp8G7Rs8e2FTAiM/BYwOu4ge1iLi+RhZcrKYd3dKFGl38LXVebOk0LM98JOXfCJ1Vo/AsrdoHB9OpVASxyJ78FgCykaH6u57DA8dMTMhTk94OSCzTnXCBnoDWQLcoo5d9EP4niEWWPjeDbvjArAA1HrQATSWBs1wyLmR+bvIJKzn7JVFpKvwuZXMGH5RZgPFwDx4c+K3P YBM33DOh Tmj9kYutHL8cU4mtEGol9iR1PFqCiNXGe5gjV8SQJl8WLAWTZg05scYlVM4hb9tuVmgpgPWw1FAHA8Goo7cJkOHwmSNrJpIfnlGmkDMnc6eg0Vu8VZmTitzjtYAX367mgrY1MBzi8QH6TIVhaCtY7/VdyBAjfS28yeA5hStWxlGL9zaqUdfgHrQCpcFhX77bM4BdVs083FcSTOX3m0yVUTY4qY4pVJKKsNpMzO2LcTX42wIdfruxLw3qK7Hp+fFGFMj5oSS13ETYiKuBAmy9a/wlBFsmygctW0Njlq+HxJfF9FXdewets9UBjeSMOZ4X0yo66wvcV2Pch5CKSNDx+EMD8+iKPQ3iricCIzcHSgHg6+9kHo1qGgchLCeDsO34D5zaMu+bmM4vhtVCc1Meisyy51bMePRakvZEBejWS0OaHQRM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.12.23 17:22, Matthew Wilcox (Oracle) wrote: > folio_add_new_anon_rmap() no longer works this way, so just remove the > entire example. > > Signed-off-by: Matthew Wilcox (Oracle) > Cc: Ralph Campbell > --- > mm/memremap.c | 18 ++++-------------- > 1 file changed, 4 insertions(+), 14 deletions(-) > > diff --git a/mm/memremap.c b/mm/memremap.c > index 9531faa92a7c..9e9fb1972fff 100644 > --- a/mm/memremap.c > +++ b/mm/memremap.c > @@ -473,21 +473,11 @@ void free_zone_device_page(struct page *page) > __ClearPageAnonExclusive(page); > > /* > - * When a device managed page is freed, the page->mapping field > + * When a device managed page is freed, the folio->mapping field > * may still contain a (stale) mapping value. For example, the > - * lower bits of page->mapping may still identify the page as an > - * anonymous page. Ultimately, this entire field is just stale > - * and wrong, and it will cause errors if not cleared. One > - * example is: > - * > - * migrate_vma_pages() > - * migrate_vma_insert_page() > - * page_add_new_anon_rmap() > - * __page_set_anon_rmap() > - * ...checks page->mapping, via PageAnon(page) call, > - * and incorrectly concludes that the page is an > - * anonymous page. Therefore, it incorrectly, > - * silently fails to set up the new anon rmap. > + * lower bits of folio->mapping may still identify the folio as an > + * anonymous folio. Ultimately, this entire field is just stale > + * and wrong, and it will cause errors if not cleared. > * > * For other types of ZONE_DEVICE pages, migration is either > * handled differently or not done at all, so there is no need Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb