From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA37ECD484F for ; Wed, 4 Sep 2024 14:51:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4BB6B6B03A2; Wed, 4 Sep 2024 10:51:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 46C0F6B03A5; Wed, 4 Sep 2024 10:51:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26E356B03A4; Wed, 4 Sep 2024 10:51:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 006306B03A2 for ; Wed, 4 Sep 2024 10:51:57 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 74FCB121691 for ; Wed, 4 Sep 2024 14:51:57 +0000 (UTC) X-FDA: 82527345474.16.5818394 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf11.hostedemail.com (Postfix) with ESMTP id DDAEF4003C for ; Wed, 4 Sep 2024 14:51:53 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=OkijkxxL; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=bBHBVP2h; dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf11.hostedemail.com: domain of steven.sistare@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=steven.sistare@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725461407; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GRIxtnkj9791v2kYv3Ka52kLJeKw5i8Rj0j5I9g1MOQ=; b=sE2zqcSWKkwJd7Qp54UJECCScoVxwNvz2i7yQ3p1lOWEtdWQkHB0HJhOM+afs/4HW72CZo BsLtXfjhSpUe6yrO+iIZd9ilpOpRDW4vxAMj6ZhqSVr6h9ZqCwbEtxaBI5TFFGxkSH8bsi cB4jgfj+DhmygsEjxsZDiBWw3OKex90= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1725461407; a=rsa-sha256; cv=pass; b=jrq6UFmjDkVX9/FOYD5wmQSPQqZB2dPtQdHgE5k1soIZcZe1uUklBcG4/h6+6kg6BifI0A BxoalpbXRJVE2Gj5vF08cGewkbZxy6G8CEFNe81MRG8ggzd8VDvzHMC4jRSBmXSxS6V8mh uZxFvMAEcXTwcTL1O8v0PNPqSyLpGDg= ARC-Authentication-Results: i=2; imf11.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=OkijkxxL; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=bBHBVP2h; dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf11.hostedemail.com: domain of steven.sistare@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=steven.sistare@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 484DXVHL028731; Wed, 4 Sep 2024 14:51:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h= message-id:date:subject:to:cc:references:from:in-reply-to :content-type:content-transfer-encoding:mime-version; s= corp-2023-11-20; bh=GRIxtnkj9791v2kYv3Ka52kLJeKw5i8Rj0j5I9g1MOQ=; b= OkijkxxLtDVbFJJR2tWK83oGzNOZ/msFN7Nzc+co+tRTSPB25iw3NdKh/kmMDawM lGhYnmiS9nGd9nWeLAXUChW9XQPshCeXi010/hrqxWcL3oDXyPIerK2sFhgb0L6f tm32+jwC/z90Yva7w5CRXLh2/suhJXlKTmLtzDAGl6LzgmnVhKhIk35S7u3kAclB Rxbv/qGRjLOh1X03kIuCNYYoOYOOw7uHoOQ5hs3CH/RqA4dsorUfotRnDumMR9PF wJVH4oDRXBq/LpCBWK11xGj5ct0FzzGq6F/69Dr2/zP/9TAZxxNd2zmsqki2HmUC DrJKoRv+Mfe0vbvrrAmrdQ== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 41dw51uq0c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 Sep 2024 14:51:45 +0000 (GMT) Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 484E207x023570; Wed, 4 Sep 2024 14:51:45 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2171.outbound.protection.outlook.com [104.47.56.171]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 41bsm9pbn7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 04 Sep 2024 14:51:45 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Rupvu/TVL8LJH7+p9wGVFXE0SwpZfMhaQ6RjVhnHw4DPxdydVr0PTtwy6+rZYBywxPbM5C0u07uJenpU8OHL4t8/xGkudj0G+EaTU1xZxv1i0BIyxj+1vdq3vzi1ZygftCo27HyDxYTUiST23I6hMpNi0ZrJ/KJonEYwR7PaSMqjhwRZmURkHeWkCUOBsyWw2pPo4YNWq4rDBPda33AdQOqWYpiRabKGvzunuIJ18YRqmXy6x4BwoLwQmzaLaSMFuudRnsf5fV47NQWg2T60bKef7PDcoUj7+44Q9y3OpGdspy6wufNif7C4YzvV2b0+1LeKTBUj5LWCTCJMdsG+Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GRIxtnkj9791v2kYv3Ka52kLJeKw5i8Rj0j5I9g1MOQ=; b=hb0R9rVJRmxg+9mUlMrTxBoaoOdYeWFjh6bxW+5AQw+1OF3P+rE23aAjE7SiaoyhqGIIJBd+HEuS9j85j6fwE6K68HeW0TlHcEsHxLDq+0E0+2EsLEoZqwdo3NNwo6eWmZqA1zh9CEE082NmE7SQoDl6iyvYh601uFi4cRSvVxkIgk0K+MzcxytXdbXtmc5BFZq1oi5qDxnfb/sd1veaGWV/0cO7FUYDafCqNX8KoLC+PES0JJdFKfc9VoJRcrNmS3FcQjkUWkJAT3MJwQBm45tEI8D1zXBMiwTZxkkBfBRkA1sErYNuTNTU3WTOGnkgeHF59b5ue/1UuuVvcgKyFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GRIxtnkj9791v2kYv3Ka52kLJeKw5i8Rj0j5I9g1MOQ=; b=bBHBVP2hExEAceuyKnANIhLRMF14fmvc1nlcgkNgc4ar+yoxd2srNmP/yOl1JsvrxcpYLcB/9PwBRoVnlcTqXvXt/e9mrJeT8sPojMWTfMF7brMkoUI3v3Vs8eP7k/V1HJDYh2qFX4izRckJU2RuCqTcODRBE8H7y1tvex98RnE= Received: from IA1PR10MB7447.namprd10.prod.outlook.com (2603:10b6:208:44c::10) by PH7PR10MB5675.namprd10.prod.outlook.com (2603:10b6:510:127::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7939.10; Wed, 4 Sep 2024 14:51:41 +0000 Received: from IA1PR10MB7447.namprd10.prod.outlook.com ([fe80::f2fe:d6c6:70c4:4572]) by IA1PR10MB7447.namprd10.prod.outlook.com ([fe80::f2fe:d6c6:70c4:4572%7]) with mapi id 15.20.7939.010; Wed, 4 Sep 2024 14:51:41 +0000 Message-ID: <61dae311-f552-412f-9888-85b6e4bae086@oracle.com> Date: Wed, 4 Sep 2024 10:51:37 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V1 4/5] mm/gup: fix memfd_pin_folios hugetlb page allocation To: "Kasireddy, Vivek" , "linux-mm@kvack.org" Cc: Muchun Song , Andrew Morton , Matthew Wilcox , Peter Xu , David Hildenbrand , Jason Gunthorpe References: <1725373521-451395-1-git-send-email-steven.sistare@oracle.com> <1725373521-451395-5-git-send-email-steven.sistare@oracle.com> Content-Language: en-US From: Steven Sistare Organization: Oracle Corporation In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MN2PR02CA0025.namprd02.prod.outlook.com (2603:10b6:208:fc::38) To IA1PR10MB7447.namprd10.prod.outlook.com (2603:10b6:208:44c::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: IA1PR10MB7447:EE_|PH7PR10MB5675:EE_ X-MS-Office365-Filtering-Correlation-Id: 6004a5b0-e19b-4ac0-229d-08dcccf1167d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dDZEZytMM1RQNkFXOHE1eHR1WVB5UlJPTGczMGVlZS9Gd0VQQk1mNExhNHVm?= =?utf-8?B?UVB2VTA3TmNpSUtMNTFad0hiSGhjQWxEWlRJMkZrRXMwNGVzSmFEQnk0c0Ni?= =?utf-8?B?WWk5dGFybk5FSE5jdE45ZUZ5VTBGRTJkMHRpcERPVVdMTFNJM3l0ZkdndGhU?= =?utf-8?B?Tkp3Q2xtSCtHRWN3c1NPTEFsN3VrWVY2emoxSG44VzR5RmVSb3F6OGlISXB6?= =?utf-8?B?ejc4ZDZNSnovSkxwdWlpcVAyZ2ZPSzQ0OXVLSlZoRUthVkVOdWw4TG1vd00r?= =?utf-8?B?bFNIMzF4WFNTWE1ZaTYvWndkcU1oLzRsZW91Z1pLZ3RmWDVWK3o3MWNuamE4?= =?utf-8?B?SVExYjdwRUhoZjFPR0toUTNwRlU0SU1leFY1UDJGM0xOTTIzNXMrdStlVnU3?= =?utf-8?B?amtyMjByU0oxUjBSMXdxNmlXalJ3SmNKQ1JBdnV0WnBxTnhvOEVRb2wxRllM?= =?utf-8?B?WUI4Ri9EWktidlR4a0dPVUg4VExFTWZpZSsxcGJNZFNPUXdEZGJ2QTBBQlJS?= =?utf-8?B?OExXUjBTVHFxOElvSE9kK3IwU0t3QzVlU2NOZjUybDcvMVptQTZ6WTB5Nnhz?= =?utf-8?B?Qmtob1JUampNMzFTdGMwVjJxVE4xQ1JKM2JlSXVzcTdjWUV6SkRlS1l3WEZx?= =?utf-8?B?SCtyc05KY1N2bGZwUElvQnN0R1pnY2pVWlQ5eUloM0c0clJ6b3NGS2IxTS9W?= =?utf-8?B?VUovOEQrY2krVTJQcThmdGxNc1ZYYXFBTEYxWXdMM1FLTFdOTGIwNCtIUndz?= =?utf-8?B?VThERU5jam5zc0o0V0l4Zk54V2RMeUMxRGlEMTVmZHgxMlkwN21nb1p4VmRC?= =?utf-8?B?SktTdlhacjlWNFd5Y3dGTFVtNU5wRktxVy9IRGpmanhNVko2WERyRXBoVTk1?= =?utf-8?B?cXpOMGpQR01sQktuY1VQc1RxakZ0YnpRZGswMUZaQmhuZU1uczR1TkREb2lS?= =?utf-8?B?Y25saWpkSzM2R2ZIMHk5dkcyd2FqMGdpQi9ZOTRQcWNmVEpqMkFMTFZYRmNZ?= =?utf-8?B?cmRVRjdCbWFhRTk1RHE0R1hTN3lxeXhhOUpJTVJlZnQwWWU4UWF4dFNsanRO?= =?utf-8?B?MWRrMnF1VG11aGZ3b2FsQnl1eUNydkRlRnMwTlI5SjlKUEJ5V0FFRldyNzlS?= =?utf-8?B?YW5WV0d4bDdadG1jYmhBL3JjcmNxR2JFRDNyYUZpR3ZFU0VpaGhIaUxVWjd0?= =?utf-8?B?WFZmd0RyOGtaUS92ODlRczZaTDgrSmN5SXMwTU1sY0lYNm10YlpHQVBkYVBo?= =?utf-8?B?emRiaG1RTVNnbG9wNUdlRjY2R0kyR1pCKzNIRjJ0ZVdNUjcyN3lWSGV1Uk9Z?= =?utf-8?B?Zlc0VHNGRHZOQTlvNmx6SFF5TnpzRXkzTDlwck5Fa1VzeW1UOTZWTnphVFhU?= =?utf-8?B?WjhydHFOTndYN2tBUUJFK1ZRNnVQYm82Q0g5bzQ3RFVRSXZNVmUxeVR4WEt4?= =?utf-8?B?Z0pPUFkrZjg1ZTl5NWl2aVlTOWtnVWZkMDk5elBGa29UcU1YRk85Uk9BcUxI?= =?utf-8?B?VStVdW95VTl3MHlCNVl4ZXFEQVJsVlplaS9rMExKUE1xTmNNRU5Tcms2NFp1?= =?utf-8?B?R3IzNUJPYXFhY2JrMjFvYk8yNmgzWlR4eHhpL1NHOTRia0x4TFMwNkQ1T3JZ?= =?utf-8?B?SittRlB0cTlvY25EdWdwVGtkTWJWN25CWGpyQmxzL3o0QkZ3NmxLUUNtQWZL?= =?utf-8?B?TENnaFFhRWV4OFQ0UE10ZVhqa2FBTUpoR29zMHdBZWd2S2oxdnRNeHZrdnNy?= =?utf-8?B?bWVIWmJRcW02UmpsVWUyYlkzeUdoRWd1TWxCQWNrTUJVNXpHMlZaVjJXaENq?= =?utf-8?B?VFErRExvdHhBVzltTjliZz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR10MB7447.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bXhYbGs0NURkV0xHT0pqVkhjbktKVUlLRE12Q1J6OVRGOE00TlFVWW9nMTlT?= =?utf-8?B?NGdCaE1ML0FVZ25lYVNPWHVXRXE5U3o0UWRjRTE5NGJLVFVmTk1RSEpVc0pj?= =?utf-8?B?b1M1cXd2WVlLbURqaGw4enRGN0JXcCs0TC91bEJ1aHQyOVVIZGh3WUtJMXp5?= =?utf-8?B?TjlMbEh5bnJGazlhKzhxUFJBNGFlSXpyMDBSclc5bmxnQlRQYlJxWXZoaXcw?= =?utf-8?B?MkhzdHF2UUpzcFFrN0lYK1NhdUpTT2xiM3B1eUtQcGNxTkEzeC9QWnNaTWdv?= =?utf-8?B?bFQ0b3VGRFlVZWVYcU1GQTd3T25iME9MR1E3bnBXU0NPUzVwOWlBY1hSTXpY?= =?utf-8?B?bUxvRFoxNHNmWVhlTmpMMlpCclZGNXZUNzFOeFdWS3pFeHh0ejRLMWlQOWw5?= =?utf-8?B?b1VJM2FrTlAxUktmRVRydENxcHBrS1NMWERVYXVkeUVFc08xeEFZVENCakVK?= =?utf-8?B?WitVNktFS2lUdGo2ZVlVY2NJdUxvN3UyYXdrYTlFR0J1a09KRXNWeVNWZFJ4?= =?utf-8?B?UWorby8zTnB3LzRkTkVaaE5UeFFZMXRBbkh1Q0F0WWZLblVTcnUrS241N1pN?= =?utf-8?B?cWxqZWRUZlUrenBsUU45UEZxOXhleEQrbHAyOGJVRUVQR0tmTnlEL1F0bi9C?= =?utf-8?B?RS9LWUdkWWlndFJRUHI3aHRtMHgxNnFrMmptWW02dHZuQm9RU2Nnb1VPYUJW?= =?utf-8?B?VEo5OElLaVdTTTRsenFURWRsS1AyZmYyU0VXSzV5d1FFSXgwNHpVV0RTVVQ5?= =?utf-8?B?aFJxYUUwRGpJUzJnbXdXOW1SRFhpcHA4K1UrMG9MaHB6RnJWOG91cm9TU05F?= =?utf-8?B?eTlFems3MnVUczhLZk9BR2htakNJZXRWSm1wTWlkOXJrbEt4dkd5K0plN3d5?= =?utf-8?B?cDBmZWlKZDJzRW1yRU83WHY1YlhSSk91S0Y1WnRYRDJMVHpGcUxCS0NHZGZh?= =?utf-8?B?OU9yWG5VNS9mZThFckl4V2FQTCtYbkd0Y0hWYitSWFdKOU9jNHl6SnlBbDlT?= =?utf-8?B?ckNpZllhT0NEOXlFaDZDd0EzczJaMVIxVXozZkhXeVFNQnVGUFhlQWI5b2FF?= =?utf-8?B?VUpIR1Q3M2M0Rml4OWtpWjBMQ3phRnE2eUNISHRPTHVaUEVHZDcwOWo5QjZS?= =?utf-8?B?MDd3ZEt0SmpFNTI4L3BDQmNtdlAxRVNZUHExdUMwazY4TGM3aXZHckhLQVF4?= =?utf-8?B?QU8xanAxOWp1cDFhY2dPdUJBZFlrS3crUmFsMWpSQ21Td1NOU1lQRmUvbFdw?= =?utf-8?B?U0UyMmhXUlJHVm1IM0ZBSWNhdTlESzBWWmN0c3pGRytnQ2NtNWNqZC9LU0dk?= =?utf-8?B?ai9CNm5sVmxCSkhjMEE1L3JrakJmbjljYjcvOCtrWlIzM2ZUalNRVHBua296?= =?utf-8?B?MERpUm5FYlNqQlVSNURqb3RvNWFpeWt1WWNLNDAwWG9KanJXNnZydVhrUm8z?= =?utf-8?B?T2MraVBJdmJYOGJoZVBDWEg4QkZBK2s0c0tGRUI0ZWRaYWV3NHBySWdIQkxK?= =?utf-8?B?QUNicmxHWEV5TVVqS2hWUXJnLzBRVzJEYktwcmNUd3BDK2ptR2RuZzUxendB?= =?utf-8?B?VEpJcVBkQTJ6MlZnc0R5ek5XV0xEWFIvUWVoWGE4SWc5bFQ0bWxUSUk3SjNv?= =?utf-8?B?bm9GcGUrRFV2dHZ5TTdlTDEydVZPYzJacXVVVVJmRWRDb0x4NUZ0eDdpWEYy?= =?utf-8?B?N21RTmJuVjFCUjJvNkdHNTdJbVNkdnJqSFJ6dXVXanRMZFZZelNUQVZZUVVI?= =?utf-8?B?TmQ4cU9EaGt5dGFMeWFwNW5aVU9KbDhzMUEzMGRCMEVrcTZHelgvelhNWFJJ?= =?utf-8?B?QnBjdUV0VzRIbWFmRUw3UXZScGhZVEpDVnJJZW1CalYvQk1vdE9WdXQydEZS?= =?utf-8?B?QldVcVFYMDh5bnRZU201WFRzc3dWOTBEK3R0SUZOYzBReUFiT1BHWXhVUWdX?= =?utf-8?B?UUtIaEw1ZTUzMnQvcllMdlZQb0VvTGIrRE9QYlBtTStBR2xwdEpwbk5YWGVm?= =?utf-8?B?RmJaNk5DNHFDeEM2d3hnMkZUN2hrVmo4MHFCTzJjNXdheFhrQmZLMjd3akI5?= =?utf-8?B?WUZpeEt1Vm1uRW9wN2RmbnBESzJiMkdDaXExeUYwOE4rTWdrTWhGeGRCandE?= =?utf-8?B?cHdpMkhOV3FIZkRHYnUwdUJWdCt0WklReDRvRHRpN2ZGR2llY21IWDZ1cGQ0?= =?utf-8?B?Q0E9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: TJHXBExO3e4EnYV5wfZzaOfsTWotNx32MS9yHv+GaLNRL9f+opDipLSFVb4FH6dWqnKoHWhOflDRfNxyj3KS5tdDPV0g1Ps22a83CbTzlqSyNjxaZfBZPdUKCGAMFK3zm3DMVQbdHn2fBE1GzcL8YB2VlGwzrKRhEMR5M/TeENOZl3I4Vu964SpDjFvHNnvZb70ZpaU9HtXL29omaiyBHWHvEkTnWPy3m3H3/jop9PRpOwhwv3xgb0cGpRz+PvRkaFPy1qqRbrHl+nyn+DpNIK5odt/A/RDzbSq2RZnyiH7uxQWXpQSu9nT7/23u1qjaLbhwlHW1atl4BJIkk4whEi8sZU53sHHKQIcvTdgCPyZ7VWv/0KS19vwLKUnNCjv7yvoOzFODJiairuTS0NoIOpwssJ315CyMdn70IdL6UPhIJ9qfWxTWIiz8dFWHdVMqjcfG6FFxMeDRmbAh+fLK7Ej9iQMs5U1R3Q+t5rW82TDOmkGu1NgGNCXVwiWeE9MsoW5wuPBLLFGR6AD2qbmmnL5t8zQldtTpy1+tjeClH+IBO8O3R7Lrp3513/CHIe/Gboysky8IxcRSU1vTLgMK64KXw8C0cpugNqykW1PHLlw= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6004a5b0-e19b-4ac0-229d-08dcccf1167d X-MS-Exchange-CrossTenant-AuthSource: IA1PR10MB7447.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Sep 2024 14:51:41.7454 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pRduZ7g7golmWOrt5JNtq2goW07yTpeHcBdxHgrcywKodmwSH+GpWHI+JqkNdfaGkO4u9fMgvy3o+UvNthGv0m0brGhvihcCW/laNLyVk24= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB5675 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-04_12,2024-09-04_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0 mlxscore=0 spamscore=0 adultscore=0 phishscore=0 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2407110000 definitions=main-2409040112 X-Proofpoint-ORIG-GUID: TqXObISf-1YsouzQIaxKNAVNnI7hrPRf X-Proofpoint-GUID: TqXObISf-1YsouzQIaxKNAVNnI7hrPRf X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: DDAEF4003C X-Stat-Signature: 6beixsedxnfrtjn7z3s1y5gq3qbniayy X-Rspam-User: X-HE-Tag: 1725461513-918845 X-HE-Meta: U2FsdGVkX189G0LrUaTE36z4+ClfvvzmRZON7oh+1G3i/9wWEsuc297P8x02VHdXdFfV7NiniQstTLNJFVyK3b5ix1T0pP1/GzEWL6hbdF7QJfmuZ6WRsqzdL53v9gRLbnAeBHLcZ1n5HL9MdbIZRCbIgf/mqJX+P+wXc+Ke4IGix122aytcuU+wQHdmdPrxUd7IZmrdsmAvgwnT0lJhYFYg+jLMdGHWU8JeHH5nZjm3jz8X2BTupnFmv3KxO5etmDQd7XCeuL7vcdRTIPzr1fk34Hrj+88YOtMLXREVtJdaqKvblrFiczIwZ6v/dwsvHg8dh+BcDFmRHRWTW5Fo+3NdBWGtGyZCc+dU/kqvStGHGXP4bNkFXSJN+zYYuMjb2xZdE9mjKSRQrOEGIER+KlchcAPlPiZVrfappRTf+3QfYh37PjjPZ9pIGxvg2Vl7sAaqq09w25utU48EHfjke1gUc/ic8z15hk53wGCIudN7yMf0Uti4TMOG/59N2XM7QpaPfro906nDy0UT5VCB85a8DsGvdltqr1D8jOn3Ytz6aEkuDjjEs71gvdvVGVvELv088UpFYeaDj7CzjLnkiY6vAbnSKcyVKdXqarDkBUiKoZLs0gnFsZaP6lVElZ1ZZZ7bKOd+3Mii7PpONTd2T4O/3DIbczzabFxZ91isv+LO1drZ47olrxsBEpajQz5tAKjEbwcMm+qKJ2lyUTadSRYXh46BiIPVsmqi4cNgbMblc372ktMwpOiiZtnTds+XsHGKgBhKHG+sAquHVSVn0a7NOGGmi2czp7neiGvrZcD3bClNYvxLWNuJ1uO8nw6r1IkcYxTHvwHmOaQCR8dK8dy3K4LMWgBxTB0YNqosigeF6tOZy8hE8ze3j4qp1ulYh/Ot+3o5krBWoBNkAQiLSRGYUntx1XfNtY++TaYLtKsqSpQIicU2aCfIToXu8er4xy67tUvh1w8CpCQJuWm 8AYNF0xf XBy2Zh9ye7VwQq+tVq91HnuZgvad8jQpPrX5uOw+PORqSi3vHSLf8Dnypr6GOHVUrYZnaENm61g90jJumxuFL5tzPVe80j9zA4lH3Rv4RtoQFsQnX5GVbNa2bDPbg3xWViK6XZAGeidgxta1tOe4MnyMId24srMoaZL5nt0BmvtzmF2btYUgpE/HxqQIa3TsOM/N5+7PR2iKHfKF6qb+yzfsQ94+Z0fKXYpIbBI39XoWM074cl8hzD8eSINxPuXA656E5LlewmIuPM7mmRRMNMHROAvTXJPEnLyaw3DSdz5xjfiBXOIVs7X36WYoFQtg1U1tWxCsQA+6SsZazqajLIY+xhbOBuJ4FWqmL/v6P8lJs+8OkIn+xybghy2lAeM78bzkafK2WKbd0HM40q7KV4RdazNREE+DsKnorlPE+S4IghmfxZcztq+g/W4VkIMk7IHgDVUeLC9FnVBiiTd7hkq/P29DoSuMMeQRI93b+Jz48//aVnRUAsUN4kef8rwQZpp+JkSrkBoLDkK/WJ1b9/9EAdGekNbyiv0IcemMhruISg2tbN4EXSwFO3nRCvTg6mnv36KypS0zJlViExMjW9+XsPqJ+M24fVN07Pyyrg2lJj7w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 9/3/2024 9:06 PM, Kasireddy, Vivek wrote: > Hi Steve, > >> Subject: [PATCH V1 4/5] mm/gup: fix memfd_pin_folios hugetlb page >> allocation >> >> When memfd_pin_folios -> memfd_alloc_folio creates a hugetlb page, the >> index is wrong. The subsequent call to filemap_get_folios_contig thus >> cannot find it, and fails, and memfd_pin_folios loops forever. >> To fix, adjust the index for the huge_page_order. >> >> memfd_alloc_folio also forgets to unlock the folio, so the next touch >> of the page calls hugetlb_fault which blocks forever trying to take >> the lock. Unlock it. > Where exactly is the lock taken from? I did a quick search but couldn't > immediately figure out in which function is the lock taken, while allocating > the folio. memfd_alloc_folio -> hugetlb_add_to_page_cache -> __folio_set_locked I forgot to add that detail to the commit message. See for example hugetlbfs_fallocate which calls hugetlb_add_to_page_cache and then calls folio_unlock before returning. - Steve >> Fixes: 89c1905d9c14 ("mm/gup: introduce memfd_pin_folios() for pinning >> memfd folios") >> >> Signed-off-by: Steve Sistare >> --- >> mm/memfd.c | 8 ++++++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/mm/memfd.c b/mm/memfd.c >> index bfe0e71..bcb131d 100644 >> --- a/mm/memfd.c >> +++ b/mm/memfd.c >> @@ -79,10 +79,13 @@ struct folio *memfd_alloc_folio(struct file *memfd, >> pgoff_t idx) >> * alloc from. Also, the folio will be pinned for an indefinite >> * amount of time, so it is not expected to be migrated away. >> */ >> - gfp_mask = htlb_alloc_mask(hstate_file(memfd)); >> + struct hstate *h = hstate_file(memfd); >> + >> + gfp_mask = htlb_alloc_mask(h); >> gfp_mask &= ~(__GFP_HIGHMEM | __GFP_MOVABLE); >> + idx >>= huge_page_order(h); >> >> - folio = alloc_hugetlb_folio_reserve(hstate_file(memfd), >> + folio = alloc_hugetlb_folio_reserve(h, >> numa_node_id(), >> NULL, >> gfp_mask); >> @@ -95,6 +98,7 @@ struct folio *memfd_alloc_folio(struct file *memfd, >> pgoff_t idx) >> free_huge_folio(folio); >> return ERR_PTR(err); >> } >> + folio_unlock(folio); > Acked-by: Vivek Kasireddy > > Thanks, > Vivek > >> return folio; >> } >> return ERR_PTR(-ENOMEM); >> -- >> 1.8.3.1 >