From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68A52C2D0D1 for ; Mon, 24 Jun 2024 15:27:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF2A96B03CC; Mon, 24 Jun 2024 11:27:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA31D6B03CD; Mon, 24 Jun 2024 11:27:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B442A6B03CE; Mon, 24 Jun 2024 11:27:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 908816B03CC for ; Mon, 24 Jun 2024 11:27:08 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 318AD1C24A5 for ; Mon, 24 Jun 2024 15:27:08 +0000 (UTC) X-FDA: 82266160536.26.CDCABB3 Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com [209.85.128.177]) by imf20.hostedemail.com (Postfix) with ESMTP id 5B29E1C0008 for ; Mon, 24 Jun 2024 15:27:06 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=aBSwYRPf; spf=pass (imf20.hostedemail.com: domain of hughd@google.com designates 209.85.128.177 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719242812; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VHhhBBRB8rhuYmKapjgWgpG4+G3I2uB8l3zW0POFr3I=; b=mDc37+J1WGegRppnx82hEpW7+1u3EonUkuJPV7Fzl6QfFL1fsXmMyO25EwOz0NKsRGpsVf e5YbyhTCg/BaPN+muZK0Gfh8sreHcQXjqgBJILSKri+mCLwzSCdFcey2vXBxYFyEEnrJjd fj2UaYEewnL06B8wORIbHG12Fj2NiQI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719242812; a=rsa-sha256; cv=none; b=PLlq5sVrrxueKktWU0R9FM9agwX2hPkLeeSmaUEh75iXPMOMsskh5kLr1ZeavTNvPN+eVG +6sPAW0KAJNX52oYyU1A0wp3yInj6qTG64j5+sw7g+/kbwX2WrM19JF/qyxm1qvpgdUqR+ 1T4Ajk3jRP6kzbUCOqQXL1O7/EYXQzk= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=aBSwYRPf; spf=pass (imf20.hostedemail.com: domain of hughd@google.com designates 209.85.128.177 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-63258caaa91so41205097b3.0 for ; Mon, 24 Jun 2024 08:27:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719242825; x=1719847625; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=VHhhBBRB8rhuYmKapjgWgpG4+G3I2uB8l3zW0POFr3I=; b=aBSwYRPf5JJ/0vWDF5VUBCbYu42KaM9eYy5/qiYoC3ZG48whX4iu76651dNiee873G QbDA7m/hJ+nntWLnXO8YdDr11Yz5BnOvPB1OQpXl5MFD9NzvM2zcyJ6MI2itODTNnxwe 9644SWrr6cMJcbHL3xYZaoeDS20sodYBJZaXOj/jZmNpndaa+dQmYeMojS8wNLlSb0yb NgQPWw+bhwoSFamEAvsMmRGSfyfuOn0Gg76Eg661qD9U5FqyU4CBCX9w3Wio1BzMSF2w VysC+Qi3zu9fbv75SruEveni03kY4FTzg0B8frv341UnqfCBMr4eAh0477gFzYWhcVT1 oTcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719242825; x=1719847625; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VHhhBBRB8rhuYmKapjgWgpG4+G3I2uB8l3zW0POFr3I=; b=D0aPm/1IYuv3mjb5AU8ON9x4vsHBMCUxZVToK6Nl7e3OqBaJ7c9LVnN4kwvdDvwNCU rjk4gWD2fO4fIlzL+WLUGbWNytk6QcMyZ4xLVt+EIroqzmge8Z5gpB0DzzylykvO6KkI da6EjCL8qvRw/PE8E8tD2/SD8lIU7V0VLD9tpkpqTAEP8b/WvI3+ovF9wjR9Rmqgil0Z GjZKKtjksdgnbojOitrqGWg8Q05YgIXg4dCi4Q+9GVJjgEejIpPTMkDnVNK+if3+4SFq zQgY+Ct9OQFn/CgBqLm8/zSRANdTRJa4F1TT9iGbh7r3sNqFyTJkpHUqUPvEcnurZd9o 5PWg== X-Forwarded-Encrypted: i=1; AJvYcCVILKE+aFmxEx52ghwikTeFiupI5QaiLLO7JHwoEBkbjqQElGBDuWyB2A3bYuFEXqRyFLpHuUUOenXUeSwl2wV/A4E= X-Gm-Message-State: AOJu0Yx8EKIvH0fZokwS6o0PJzGSXJ8FDyzbiJfjPbpZ/cZShp9JifZu 8h8akiDBCeN5sj1+sIfcLYJGU/cmAJWZbB0TxVygzby9k+bTjlm7kpIj/cwNCw== X-Google-Smtp-Source: AGHT+IH0xArOWZLb36B6dJSXuEj4YUKCkqiyL/JUHGGKJMOwiH8NjjpjjnU66Y8zzE+DIobA6DJAIQ== X-Received: by 2002:a81:b184:0:b0:630:4:5895 with SMTP id 00721157ae682-64299f71455mr40316647b3.24.1719242825030; Mon, 24 Jun 2024 08:27:05 -0700 (PDT) Received: from darker.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id 00721157ae682-64586546d17sm5790037b3.134.2024.06.24.08.27.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jun 2024 08:27:04 -0700 (PDT) Date: Mon, 24 Jun 2024 08:26:44 -0700 (PDT) From: Hugh Dickins To: Usama Arif cc: Yosry Ahmed , kernel test robot , oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , Andrew Morton , Chengming Zhou , Nhat Pham , David Hildenbrand , "Huang, Ying" , Hugh Dickins , Johannes Weiner , Matthew Wilcox , Shakeel Butt , Andi Kleen , linux-kernel@vger.kernel.org Subject: Re: [linux-next:master] [mm] 0fa2857d23: WARNING:at_mm/page_alloc.c:#__alloc_pages_noprof In-Reply-To: <12fb19d1-3e57-4880-be59-0e83cdc4b7f1@gmail.com> Message-ID: <61d19ec8-2ba7-e156-7bb7-f746dae8e120@google.com> References: <202406241651.963e3e78-oliver.sang@intel.com> <12fb19d1-3e57-4880-be59-0e83cdc4b7f1@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="-1463770367-265768386-1719242824=:2162" X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 5B29E1C0008 X-Stat-Signature: gt3yxbiertn3hhzohma8ot434n8bdtn6 X-HE-Tag: 1719242826-635697 X-HE-Meta: U2FsdGVkX1+szPyRW81GhQMI1EbB81MTZQ+SAWr6tUtFPcNuUDU+6LPVX8Iw+yhJr8ylBL6arEoYoJeqbbrxzr5BMFQyiAejwrqiJVVFocXd2xLH/0zwHXcdd9JOBUuyrZPnrAdBrpC5P1YfXEE0HOLE2TeDmauErBIeAdG0kxE34t/dD0Yoc/lOZk97YUV8hAE8SlmQ7muc2KGbrpZ1jljc2xcvdtQE5atbRAMgCKALVPauBWyroUxnVbJzmKRxeLujBdVOmIAuSgipwqGlPY74BMgoHEbalLQ0JpX5S8BvjeEr1GBHyEGC+kW3zcIY6tWesYZ+kTvN5diO9KmNRZTBYGuyZDES4Ow5Vg3AVlh9vXUMGCNj5fBhdLxBlaVpzlipHfHFXAxxVWe5W7iBUTlKihuLbMwu4eQro1zNcJEsxtyUE3KEwcYQ0LldknZ8KrPyNPe6Okh0orPGw6sI5hZEYwQ0NKx/3n1X5LvrfNbTrIinUTd2s03jYwFVZ4Em0m57v3NEVBHqEQOSBToCN0/E8bUDipGmYuZlOj6ZvT6VU1nQPCMTnkl8WzMG95dslYt9m9xttIkDc/mAIuip582qD1T0BT2sfnp0wZ3Bk/4JgR1UT++zJAzpnF3NipUTYfJPJzcTylgYCqt0QtyAwCOpVecgfzMIfQFdCc6QSRKJ+IoVB0eswaJ8/1xy/BhoWKkqthh9pdl8iwAiS4BihHqPVh3CNp2xKSk/J+47YVTTWOUvJ+DfeCIrpWIecR1NwzOqh4oEMwV4ufwYTaF+CCizXOzd81fays+/hl6Px4JUditr0op/ANoahlLtdYv9cQk1Y88L298U5osxEhW4d4+oVRfpoO+ANC/i646wGGK5nG6KunfT8y8KSWzOofhZp6138rIgWyPpk4dxGo2gckzfpySmUihG8/sKLGaWDuqqxgsY8dXUx05neUcYxGuB2XC2HBhps868cwMsF0Q UkA+7G6x w+ihRJBpeQXacvDiRxryGSDhT8wL1RXwB4b6piTUkqWx5pf8O7cFVmlBAWXUaAdzbrInnnd3wLYgdAVtJq0dpQAwqpcy9IdhxzuD7GE2CqK3dmDiq/oP8tbMMFKssdWgC5lrO8NLkAyNOLoIOVDcBbPzVCsTaHbAzjB1zqpFkNHi8xUpjnbXf0ol2np+gZbDE7UrJfo9XK+TtC+/AL+kgbiaWMo1LNnLYmE786NDqb4e4sh/f86MiYWgVUCR7uJdF4azTtHKknw4B/xCJGdSyd57ObdE7KbDzsbo9JLgpSvCs3gklQbwBgzmoI3fWCrGdo+tLQdxF3LpbxKoT1b1FQyNVDV8U4qikpJjytokdEz6J0Jhl1OYf8gMtaunV5OKb1VqPwl8pr99T3G8vMlf139oYXylzu47AdRjobuyp41Xn3wJsGDZyzWYY4s0jfbhO7SPGZyzXLUr5O9dzW9FN1pUJdAJRhqBH/VS0PtBST59H291ArWNk3C2omw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1463770367-265768386-1719242824=:2162 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE On Mon, 24 Jun 2024, Usama Arif wrote: > On 24/06/2024 15:05, Yosry Ahmed wrote: > > On Mon, Jun 24, 2024 at 1:49=E2=80=AFAM kernel test robot > > wrote: > >> > >> > >> Hello, > >> > >> kernel test robot noticed > >> "WARNING:at_mm/page_alloc.c:#__alloc_pages_noprof" on: > >> > >> commit: 0fa2857d23aa170e5e28d13c467b303b0065aad8 ("mm: store zero page= s to > >> be swapped out in a bitmap") > >> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git maste= r > > This is coming from WARN_ON_ONCE_GFP(order > MAX_PAGE_ORDER, gfp), and > > is triggered by the new bitmap_zalloc() call in the swapon path. For a > > sufficiently large swapfile, bitmap_zalloc() (which uses kmalloc() > > under the hood) cannot be used to allocate the bitmap. > > > > Usama, I think we want to use a variant of kvmalloc() here. Yes, I hit the same problem with swapon in my testing, and had been intending to send a patch. >=20 > Yes, just testing with below diff now. The patch is not in mm-stable yet,= so > will just send another revision with below diff included. Thanks! >=20 >=20 > diff --git a/mm/swapfile.c b/mm/swapfile.c > index 0b8270359bcf..2263f71baa31 100644 > --- a/mm/swapfile.c > +++ b/mm/swapfile.c > @@ -2643,7 +2643,7 @@ SYSCALL_DEFINE1(swapoff, const char __user *, > specialfile) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 free_percpu(p->cluster_next_cp= u); > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 p->cluster_next_cpu =3D NULL; > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 vfree(swap_map); > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 bitmap_free(p->zeromap); > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kvfree(p->zeromap); Yes. > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kvfree(cluster_info); > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* Destroy swap account inform= ation */ > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 swap_cgroup_swapoff(p->type); > @@ -3170,7 +3170,7 @@ SYSCALL_DEFINE2(swapon, const char __user *, > specialfile, int, swap_flags) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 goto bad_swap_unlock_inode; > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } >=20 > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 p->zeromap =3D bitmap_zalloc(maxpag= es, GFP_KERNEL); > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 p->zeromap =3D kvzalloc(DIV_ROUND_U= P(maxpages, 8), GFP_KERNEL); No, 8 is not right for 32-bit kernels. I think you want =09p->zeromap =3D kvzalloc(BITS_TO_LONGS(maxpages), GFP_KERNEL); but please check it carefully, I'm easily confused by such conversions. Hugh > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (!p->zeromap) { > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 error =3D -ENOMEM; > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 goto bad_swap_unlock_inode; ---1463770367-265768386-1719242824=:2162--