From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8575C3DA7A for ; Fri, 6 Jan 2023 17:29:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48ECF8E0003; Fri, 6 Jan 2023 12:29:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 43D4B8E0001; Fri, 6 Jan 2023 12:29:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 32CCB8E0003; Fri, 6 Jan 2023 12:29:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 22EDF8E0001 for ; Fri, 6 Jan 2023 12:29:40 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E7A6F160E44 for ; Fri, 6 Jan 2023 17:29:39 +0000 (UTC) X-FDA: 80325061278.16.3F166F6 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf05.hostedemail.com (Postfix) with ESMTP id 1B59C100011 for ; Fri, 6 Jan 2023 17:29:36 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=chf2yaWv; spf=pass (imf05.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673026178; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UfW57oUuNUcU85V0x3vYJgOlolu5FIvxm4Iw2I2zskA=; b=sVYuFtrvNps6aRc/cCX0VnWZPCf1tUUruq2AVyfDWwXTPdcbf76JHbOkAZdiM7b+Cw+BdX atQYSeh0nx6DEhl/KJkXaMvWlmZ8yw6xFXaqyRDQPVtXu4f0BAa/dSawhO8yJ1bgUMstW3 O9alRkQKNgkocN6n0sne1pXQ8hNNa7I= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=chf2yaWv; spf=pass (imf05.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673026178; a=rsa-sha256; cv=none; b=sLvtYVA7QAMprP7QTK3bAaQcFZPtsEinQP7vrpTJXpzGfTubWm+wbNJu1N2Hz0pQs4kAEa naAyzpC2rOtYW7OqOrvSeH+6p7AfGjNAVaeOZnLjceE66+eLFHWuGIQ6awDi2oU939zkET OqTwu9eVYmk1xy829nLMNHRk9nZ2JKU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673026177; x=1704562177; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Bk36Bjlg11pHfC2kVVC8AHsa8BkcjI7RwNUEFj2ZCuM=; b=chf2yaWv9FV1zHqBhYSsiN1dgHi2AGs5tCTwIl52RMsrhUNmfmJKXEDy UdKOW6dn2f7IQipcPOD0Tp7/Kcurqg9qUPvyZyfxQTXSk5NJebDemodzj KGh+x+vz3+tXpK3sjS8qXuIcUt0sHZlhkCBb2x/KSqi3/foOL5vPjllMO wlCPlpmhJwt183Xjp5EIRJ30pPHQS9HELmWyWEjZk4B2CY6dK5niod2D3 9OJk0tajiPv8aFtplqN+0XKSbBn7nPNDlBUNN1yOKFYBvTcINBT/WbqsP OldOY+itOIjVBnWxMZnW+L4hc+wPeNNvVay+bnj7ONrzM1wsi89whbh4E w==; X-IronPort-AV: E=McAfee;i="6500,9779,10582"; a="306036979" X-IronPort-AV: E=Sophos;i="5.96,305,1665471600"; d="scan'208";a="306036979" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2023 09:29:35 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10582"; a="984734060" X-IronPort-AV: E=Sophos;i="5.96,305,1665471600"; d="scan'208";a="984734060" Received: from xiangyuy-mobl.amr.corp.intel.com (HELO [10.212.251.186]) ([10.212.251.186]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2023 09:29:34 -0800 Message-ID: <61b9cc00-d514-df77-0a31-88ec35d73456@intel.com> Date: Fri, 6 Jan 2023 09:29:33 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v8 05/16] x86/virt/tdx: Implement functions to make SEAMCALL Content-Language: en-US To: Kai Huang , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: linux-mm@kvack.org, peterz@infradead.org, tglx@linutronix.de, seanjc@google.com, pbonzini@redhat.com, dan.j.williams@intel.com, rafael.j.wysocki@intel.com, kirill.shutemov@linux.intel.com, ying.huang@intel.com, reinette.chatre@intel.com, len.brown@intel.com, tony.luck@intel.com, ak@linux.intel.com, isaku.yamahata@intel.com, chao.gao@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, bagasdotme@gmail.com, sagis@google.com, imammedo@redhat.com References: From: Dave Hansen In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 1B59C100011 X-Stat-Signature: 47n679a7bxjyhcecyahfcbwbjcx9bpf7 X-Rspam-User: X-HE-Tag: 1673026176-272482 X-HE-Meta: U2FsdGVkX1/7iW4XkNshbbD1BrlZP3/vrehSJYpDZw8BoCIbO0f+eA7DHU5/D6kX5bDQww4wiFUC3NBmxaYWwWm+KH3hiVjtBpkoM3IzJ3sMZqu0WXUSDqtkZOXbzKD/9y2XO0D7TyH8RPy6EAKc3mNB6QMxyLBuWzvkn3gwC+Zfq2v1U+FVZkeXrTd7EbcmNRsitGexOBW8aIpETdx1i7F/gTpwM0hxOpWe2Bs0phCiiwd40cI4l+jonFtlFVnq1EGTED7hzJcxdsW3+m5JsOk/IIzMA++L3NMaptRhaoA6apK+vHsAFtfP0Fh+IuCB8OgPRW6mA1E5GHg7wVk2blFCYfdpMaSXvpk+NQrc66Tcyfbod91sDJ/odRajQwwODMIpg/Tm/gCIhFH/LGGgK13BYk5DjoEPaJb38AX0ZNW3GNNXI1ZuhrKzv/1Uqsl+p4f3TmSTuXRS9ho54FtcjFWmcpEwNJVt8TAJKYl1EabVQnavgtaHrGzMtJ/OWQtin77j5h+DbG5JQ+ORoRqg3w9bZTPnvgYzYAzdz/ojB9Hd1c7R3nj1ourCT3oSjgKOR9Vx1+HTdM15XWk5n/fESinvWednfFftB6tqK2MQ40TaJo6S3Ki8JruAiBdvkP0lTkAiID8NPecfJfPXECWntTIsh/0DxXwRpsAidB9cSrXrIKLKxi8l9PgrajKhceS5bowxnfSXoRsjuURSiUTwWh+isNvzBK4jx8Z+079wC4sWt1ZBNZWzaDw3xV1I1/8xMj2e6uIUZWjkhR8egAUld46dvnaRUcKpbR88e4FLpK7pc0o3PQ5pguZtYleKaPCJOARKDnuuQaWtUS7D8Os+fSJcU7w5PVOqnhZT8rTWCDs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000358, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The subject here is a bit too specific. This patch isn't just "implementing functions". There are more than just functions here. The best subject is probably: Add SEAMCALL infrastructure But that's rather generic by necessity because this patch does several _different_ logical things: * Wrap TDX_MODULE_CALL so it can be used for SEAMCALLs with host=1 * Add handling to TDX_MODULE_CALL to allow it to handle specifically host-side error conditions * Add high-level seamcall() function with actual error handling It's probably also worth noting that the code that allows "host=1" to be passed to TDX_MODULE_CALL is dead code in mainline right now. It probably shouldn't have been merged this way, but oh well. I don't know that you really _need_ to split this up, but I'm just pointing out that mashing three different logical things together makes it hard to write a coherent Subject. But, I've seen worse.