From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07217C77B7E for ; Thu, 25 May 2023 04:43:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C886900002; Thu, 25 May 2023 00:43:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 277276B0075; Thu, 25 May 2023 00:43:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 167B8900002; Thu, 25 May 2023 00:43:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 080146B0074 for ; Thu, 25 May 2023 00:43:30 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C3BA0A051B for ; Thu, 25 May 2023 04:43:29 +0000 (UTC) X-FDA: 80827533738.04.DA1C329 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf24.hostedemail.com (Postfix) with ESMTP id BF1FB18000E for ; Thu, 25 May 2023 04:43:27 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684989808; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cgNv0ADwZxIFSPVd//k9taMMtLfA5uRdjciPLFb3YIU=; b=deFqcA0y/ZTwnywtjMSfrT1SPn+m5NhweZLI1dwDN4pjiE3tV7MBkcelZIESppxKDgbf7U v/UKq9w8azIPphWgDoljsQHDRtScoNEIgYMxXlVzn6L5Wih39J+00+Iao1bxkytJPK22PY wE6iM1kt560ipSvBa5TG26WgcI1FpTo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684989808; a=rsa-sha256; cv=none; b=cxHO6J4mDKUqx9GvDQwcSVcAZnio5r0JrtFxmySYWUjKF5RjMHXK4FAJpt1LKZXPXkHyFV lu68qkFWY1YgE7YnkNpc+ykT+fQWL6KEOwzJCKF6Vm1tWuSPf2DQjIvk+BC8u2oXilNV0V YgZFbx9xknmGC51z9ludcU0vgyQkAtA= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CA3831042; Wed, 24 May 2023 21:44:11 -0700 (PDT) Received: from [10.162.43.6] (unknown [10.162.43.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 856FA3F67D; Wed, 24 May 2023 21:43:24 -0700 (PDT) Message-ID: <61ac4856-d7a9-6620-8fb2-47a77191c440@arm.com> Date: Thu, 25 May 2023 10:13:21 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 09/36] arm64: Implement the new page table range API Content-Language: en-US To: Matthew Wilcox Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Catalin Marinas , linux-arm-kernel@lists.infradead.org References: <20230315051444.3229621-1-willy@infradead.org> <20230315051444.3229621-10-willy@infradead.org> <592942c0-00dc-0317-0411-f9e17870fb11@arm.com> From: Anshuman Khandual In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: BF1FB18000E X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: qyrcqub49ja8pimfj8fau7t3bcmppfik X-HE-Tag: 1684989807-797177 X-HE-Meta: U2FsdGVkX1/YOKYS+bPm7kI6euU3PAlTOqPTLIbHe2hJCNx7GDvKw55W89Y5Xi053zkDqqGngfcrFcj236cc8GtQa2mj5Fc35edu+WNfJueRipQJSZjUoPgCqTIozvgh92ZOMFpgpu/ZFBrV2YlPPVITGAjLBmtQi9Ncb7iojemKrThVsbH/1nUhp/Z6M1QLzW+9UG+VyGsL7eqEhGb7Ob9rpTLIJHtcleKs73zL4WtmWnOBq7gcmJf/mNxRMaSKbZ5tIP6bdvv4cGHRzv8CL+UbsMje6EKz/8jIPE5+ZYUN6go0yC2T7qrd064I9hJAEYyKxNOWotrd/5ChJUo5Gycn0XdqVm7htHWHo95wYkRFhfIjlBVJQJPMphtYOKwlZ49oTwxkig7X/bPcOL/GL2D05RfB9yUSyNecNfwjJiNQccoN5DAoWwX2Nz1RjiSLBeV0JeBgsTgfuKy8RFlNUDxoxiyqTZ23JIbcC2nnWn8d1hEhcBGwEXlmCJq6pHleatgHGnOvwvBxZ7nx9a5wZr1jJxA4Nxno1efDq0xkoScnobq+AKibyWcHVIEPG/pf7zQtVBEPorUbk5zh3BpPr+0n7O2haVB2tzoP5Wxty1ZLaJtAAteVGYDOJ1nKea5nxIZUY8aBwaP4vhc6HzYUBJdavVXr61nfR31VBOvAMCilEStpdMY0EnOZQTT9BWl3sSN8zvxgASigu4Op8lOc6b15FLDPhD7qUMsxxVMNuQwn2Tmqufc1XCZ4UVeuhayUMG0ZhTH/7Ox8o01TzN9CJ5VQ9LZBmwrEn9pCupwYl1GqHRxPDbJBiAV7RwvnLrCTVwUMtQIdnrbIp4G/nMeotCnyuCSRcuOgjUVapXoTS2qn6eQ3sedCIgPQxdQ0s3yinUeZzLPrkgI1mXh3OmphIyimSyLgHVnTGiD5WvwwoAtNYISOdrEGuBCQzcYis6+/fizomwqR7PAe+gt8Qd5 tmBdQAGk f4pnubLnfTMPNOkvLa+CChs6hkXPFvSgaYTYYVuZ8y9PpH82Rw6vBU29jFhqkwlk6Ue3MRk/puHVSOcPRCx+bb4ezk6IH0ogsqPf9AR+tM3+ml5Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/25/23 09:35, Matthew Wilcox wrote: > On Thu, May 25, 2023 at 09:05:35AM +0530, Anshuman Khandual wrote: >>> @@ -127,6 +127,8 @@ extern void copy_to_user_page(struct vm_area_struct *, struct page *, >>> */ >>> #define ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE 1 >>> extern void flush_dcache_page(struct page *); >>> +void flush_dcache_folio(struct folio *); >> >> This is giving a checkpatch.pl warning >> >> WARNING: function definition argument 'struct folio *' should also have an identifier name >> #36: FILE: arch/arm64/include/asm/cacheflush.h:130: >> +void flush_dcache_folio(struct folio *); > > Yes, but checkpatch is *stupid*. Don't just follow tools blindly. > How is naming the parameter here helping anyone? Agreed, it seemed bit weird. Never mind.