From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E454CD1299 for ; Wed, 10 Apr 2024 13:01:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7FAB36B0082; Wed, 10 Apr 2024 09:01:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7AB136B0083; Wed, 10 Apr 2024 09:01:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5FD876B0085; Wed, 10 Apr 2024 09:01:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 38E266B0082 for ; Wed, 10 Apr 2024 09:01:51 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E6A8A805F8 for ; Wed, 10 Apr 2024 13:01:50 +0000 (UTC) X-FDA: 81993634380.09.C8EA9D7 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by imf22.hostedemail.com (Postfix) with ESMTP id EA381C000F for ; Wed, 10 Apr 2024 13:01:45 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=RLwyFqds; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf22.hostedemail.com: domain of przemyslaw.kitszel@intel.com designates 198.175.65.14 as permitted sender) smtp.mailfrom=przemyslaw.kitszel@intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1712754107; a=rsa-sha256; cv=fail; b=ZIgcTBbKGUld8EfBmXsEfvTWIi1rPv8WtlMSGTD/sQjnLJFyVkD3A+QmLyW3/4qJT7XV+9 i88ERcVygCeseusH3YxP1iSktAvfqVkF9jMNikCQLrXDf5rDMudZk0OHgU0+9EdqkVMnFm fWgZMtC49k1ljDzEkk2wyG57aUP10WY= ARC-Authentication-Results: i=2; imf22.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=RLwyFqds; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf22.hostedemail.com: domain of przemyslaw.kitszel@intel.com designates 198.175.65.14 as permitted sender) smtp.mailfrom=przemyslaw.kitszel@intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712754107; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n4cMIj+EqcCItM+efIRhnECUaWO7hZIbwpsxGS6pdU8=; b=IjsZ5Uq1PSuJx4VKoU8TJHDG61JTHNov3027mvKsXArPfi6DlxyHwNohK/QO4aERxMSY1m f3R0hSOeTd+0xPgGlgQXlDivZCCJNgje6GJ5IlDU3j5pJT6rsLs7n+yJesJz0jpq6YMkBv Y/43oZOiv2nynpZDrXs/KexIwNi7mEk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712754106; x=1744290106; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=qgHuLOyx7MWIf58FxJo1rF1v8NPdIl3CEsuN4Q8dsyw=; b=RLwyFqdsh4qBLBXrgh7QlLP8flCaYya3tZSHko9bdNIoDr3PsFuZif45 gTo8ZLsYCqukn9xV7l3ID90A/GWyt81U/Q/SYsmSPJjaBra4T7H5zeyQd ISJ5TURT5GtZCi2RQ6FRDxDW1BQ6kyEgjEka9BV1GeoZuIS44tr9NjYtV JCVzS6pY3URMw/wIQ5uYFHLu3LI3haEiiZCxWblRTs3+Nt8EExxxKc8gI BxSdkvly0+0m+sDwcHdSMQCH7FcUpHUgn2CB4wkpQA7V4EOQrCZeprnBr +/vsZMk8Af5phi8dMK2WlG7gko7LPXcHwMDVZsmMEyMv0Wsl/MEb1lHBx Q==; X-CSE-ConnectionGUID: M100VIUSSv6F2gw074kJlA== X-CSE-MsgGUID: rpIyP/piQ5WRb5sTeCwiOg== X-IronPort-AV: E=McAfee;i="6600,9927,11039"; a="11951000" X-IronPort-AV: E=Sophos;i="6.07,190,1708416000"; d="scan'208";a="11951000" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2024 06:01:42 -0700 X-CSE-ConnectionGUID: WGZLhib6SpqaZMpu5rlw+g== X-CSE-MsgGUID: VDnf34/SRLGaF7rsKxvbYA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,190,1708416000"; d="scan'208";a="25178630" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 10 Apr 2024 06:01:42 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 10 Apr 2024 06:01:41 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 10 Apr 2024 06:01:41 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 10 Apr 2024 06:01:41 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 10 Apr 2024 06:01:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JH5Shuv3yJcYV5EyKmeePkUaWLzB6bBXPkPTiEhAXDkxQa9F+PWGJcVYEhYc5TOUFBDeRLVUu/IClm/Szaqj2POHyCH30Fkq7sGPVzYQCFkICCC7w/KAGOABpf4CNmuw/p2ACK5Owd9+8Mfnp6BTlz8m0zrLiA35/yKJJSS+I32tDGIaNTTS4r3QdqlEinIkZv0by3476iFSU23KKGGveCD5pdUp+Q4vvxecRS9QCkC+PFK/xaqMhxTyfbn2PviGH2gEXxvLt7G+eK/9XJ2pSuqlYQn4YvevbcZyMGnXjmlI+oGAMRDWsOjEYuwP//I6EoPPFcz6IIf+Pjd6ClY7FQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n4cMIj+EqcCItM+efIRhnECUaWO7hZIbwpsxGS6pdU8=; b=c4Ia/3OLjeefKPAeNlvphgeJAENu+KcsyEPmE6Fwq0GsPBeTpcgXxULLnqrMhGBOur/uLzCKQAn6dy/Iy6awYs6WEG0+9Lx2bXQEnHPafDQrfEkFTozA2mL5QpZJAOin9pQYlBsqoPBkjMlx93+UEhkXJoTjtkKh2dHWWJMG5KCcZw3rWMKmyyEgQayJiO1ReLU6vS3xE2MwRczuuex3ETsf1x6yvsPxQJ0NDOdaL9MDSy7d8HGgbmyN6klSVSMsE/ctKIEikcabsUgseFlTNc8z4LZ7XUyBF3M6Ro62AUZ/TsGUOEHKWFpMCFcZ8bqChTq0FlU9WSff+N6jB2swnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8102.namprd11.prod.outlook.com (2603:10b6:208:46d::9) by PH8PR11MB6753.namprd11.prod.outlook.com (2603:10b6:510:1c8::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.31; Wed, 10 Apr 2024 13:01:38 +0000 Received: from MN6PR11MB8102.namprd11.prod.outlook.com ([fe80::5c8:d560:c544:d9cf]) by MN6PR11MB8102.namprd11.prod.outlook.com ([fe80::5c8:d560:c544:d9cf%5]) with mapi id 15.20.7430.045; Wed, 10 Apr 2024 13:01:38 +0000 Message-ID: <61a952aa-1b3e-43c7-9f35-ab53e492305a@intel.com> Date: Wed, 10 Apr 2024 15:01:32 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v9 7/9] libeth: add Rx buffer management Content-Language: en-US To: Alexander Lobakin CC: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexander Duyck , Yunsheng Lin , Jesper Dangaard Brouer , "Ilias Apalodimas" , Christoph Lameter , Vlastimil Babka , Andrew Morton , , , , , References: <20240404154402.3581254-1-aleksander.lobakin@intel.com> <20240404154402.3581254-8-aleksander.lobakin@intel.com> <45eb2bf1-e7b0-4045-82b3-93b9f81b7988@intel.com> <9d389192-63c4-44e8-b863-6323b45aec0f@intel.com> <36a067fa-75c0-4e7d-b704-229deea2d440@intel.com> From: Przemek Kitszel In-Reply-To: <36a067fa-75c0-4e7d-b704-229deea2d440@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB9PR02CA0018.eurprd02.prod.outlook.com (2603:10a6:10:1d9::23) To MN6PR11MB8102.namprd11.prod.outlook.com (2603:10b6:208:46d::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN6PR11MB8102:EE_|PH8PR11MB6753:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: K56s2h5XiN+caFpM69Bc+qJkuMALOYtc74NjQfMuHTC1nf2+Myky9n2Uj5zP3/vpl9Wsn5XRoHMEW58Gl3d33TU25sINqwbKBDVeXFxBfdHQspvA7aG5RdlDS96JO6kKCbTUhBxmkaaA5lG3Tbnx+vb1UoY2K7jOdgz+AGxHZP0Rot8ib5SaSJlHJdSuprfsk1UnYqEOHoYzl/7UFs5LTWu2hv5J2XDQpbLlCt8j6WNW/a+k/0MmCRs9cpWeWweuODQCPPckD6OI3ySruSWmxu+U6hMqgN55LRrJzo29UDv+I8Ad9xJtV9SZzjWyrm8qr5/qvfGoElmjSKBfOXqIcnYxzMc6idqBDQ6d0uhtmwXOFaAQtONHX3/aCdCVPYZJOZ+YS+2ZCB9V343z+J/W0iXOCjUjK+qQ2YJfu/M92LhPYNNlaDHoooXda9ojDc5ADLQcIG9p43SLCDnTsFtuiDevLWewyLuc2lgJIjPeSuWuHV9THr3Ar6jxziG6nRBIz6RgQvqAlVHHm4rtxbKEtUnVggbVQc1f1JZquHZNA6KDrg6HHwoZaP3SoMF/038R85Jgsc8K9KJw/M6Re5js6jxrMt9yYg0Xjk4eY7Nsbu/CrevG9l39ouo8AXVJE9JrUYNQ/ouT0Xe0krBtTUxMvZYFGxyhK1dNyPJjRJ6K8kk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8102.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(366007)(7416005)(1800799015);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aWpnZXFJeUhTTXJramNhWXVkN2FCSVJSaGl1VlVrWUdMa2xwY3VlSkVqRitq?= =?utf-8?B?NlZobDA4eXR3VHh6cUEyeFBSTnVlY3NCNmZpV1huWDFvNWQ4VE9pZldwYzZQ?= =?utf-8?B?bTFoNlI5aisybGo4VEpQYUxZUVFLRC9na3B3aDdjRDVQQThrK0pmQkd1UnlP?= =?utf-8?B?TDJlS0JhSHZYM3ZhZXNoNWZFTVR2TlFSM2RNMkJLWmh3Sm9jTWErckRubVYz?= =?utf-8?B?WjYyckQ2dnlFVTJnZzV6aG5YSFh5QUNPRlN3SW83U2didWhWUEQ5QVJuY08w?= =?utf-8?B?RlExKzdRazN1SHFTelkxelQxUHg3eHJ2N1J2aFlWb1lMQ2pyRXNXMmFiNVRj?= =?utf-8?B?aWpqTThuZko4elFJMnhrR2VrVVBZZjNRblVjZ3N6aVdmNndsTjM4WHVZSnBo?= =?utf-8?B?eEZWZElZcXhFTzdScTFzWmtuOTBKdzRacEdnVmd2SEJ0TTd4eG96ZEk2U2tq?= =?utf-8?B?QmhkdGdGQ1FON010bnFvZ3dBQ2NSNUtzQVRPd1VMQTFrMGR3ZWl5S2ErK2dB?= =?utf-8?B?QkFMQzBvMjRaSy85Q1ZtdkJ5U1NGS0xOOG1xMTdMS0JHQndzU3QvSU9xWXN5?= =?utf-8?B?TlozekprKzgrbmpLWVdCbEJhRWhaUVluSFVtdHp1RzhEY1RqWVErUENYQkRJ?= =?utf-8?B?OHdBYTBDaTRlUWFrTitmeTJXcFdTR2xNUkpXM3daL0NHU29wMHFMZXhlQjlt?= =?utf-8?B?aTZvWVZTcElHaklHZ2JpYmR3dnFWZ3JDdVkra05hS1hWalVsclBXby94UnNG?= =?utf-8?B?SDdpRU5UL2IzajUrOGpZYkpEdWVhR1FvQlNTRjB0MXh0Z09UbTN2SFNVd3h6?= =?utf-8?B?RGh0ZWkrUWFjcndRZnBFTnA5ckdFV3lZMlpISTlhSk9yL3dTYnM3SkRzemE3?= =?utf-8?B?NHNQcm10U1RJcUVBTEphTVhuNUkzbFlhZ2NXS0NVZkdNNlN0NzduNWtxK2hS?= =?utf-8?B?RkVIQlFrOFlDY0c2U2lzN2ZpaEFFOGcwOEJwMGlUclRoR3BTank2amdTeU1z?= =?utf-8?B?a09lOW5LVERoL0llU2xRR1pwME43ZThtNkwvRkROaExwOTE0WXpGVVRmeitt?= =?utf-8?B?NlJrY3o3L2FNbTVBSUtaRnFzQzh5bFpFVzJ6UkI0ZE5USnZyM3NDMkt6VWNo?= =?utf-8?B?ZWtsWVpBN21FQ0hZYTlXcW96VWYxcklWdU5BUXdjN0RlWGUwTlRYTG5rdzhY?= =?utf-8?B?MVEwS3JMRkZiVFg0QnduaFd3dUJFK3pkYm1ZakhnMEVjK2o0VExUVzhXM3h5?= =?utf-8?B?NW9CNUhKejBEODErS0V2V3UxY1BiYUhwU1VNVmduWWxWWVY5U2hJaU02anR0?= =?utf-8?B?VWFrQUpFcEYweklLc0ptdlNmbjVIOG04L3QyVURaazEzL29ueE9YMndvWkxw?= =?utf-8?B?ZXJMM3B1bnBybG1FQjIrb05PUjRia0VHdXpBanRCbUpFWWtsRmtwa3pVRUto?= =?utf-8?B?TDR4SGRyYWhOOUR2bmhyYS9CZjY1aVdyNEdYaG42TmM5aFNlNTNNS0xvT0gv?= =?utf-8?B?M3FTdHZGVnFiRVBNTSthdWFPMFJhMGxYUnVLdTBCNjFGVllON1hZKzMyRmRX?= =?utf-8?B?TEsyaWlGSEc0VVRicUg3ajVIRldCRWdtS2lMVkVYTHZSWEFKK0ZZUFJQM0p2?= =?utf-8?B?RUIxRkIwRmovS0lBWUdNYmFCZ2R2dlp1VnpXQ3JwellZcWtQOWc3UTBYV3dW?= =?utf-8?B?bFcxWGhRdXhCQlEwSlg1UkpuQ1ZNR2wxZ1djMkhHbDQ2NjAwa2p5YUt3RXNw?= =?utf-8?B?bTZzRHBhbFBRaTNPMytOaEg5UEoyditSMzBBTVVmVjUxT21YODVOekxhQ0lO?= =?utf-8?B?L2w5djUyYzc5L0pRVFJKRTlPVHV5UGNoYm01UkxoSUY0VVk4bnFoSy91ZmNa?= =?utf-8?B?REp6Qm5YSXVXU2JXVDNZbWRKeHdrSTdvSFlIczdKM3Z5eDlhd0llQWVKb2Nl?= =?utf-8?B?NlpUSERXWjJuRk0zZ0NEVGRjcWRtRURXcE9teE40MDRtS2I5eUowckZYbWtk?= =?utf-8?B?MjJZUXhVNlV5SnNFbmxYVUt4NkU4bFZMUzFNVEwzUDdSVTVrVTdvWTMyc2dP?= =?utf-8?B?b1JjZVR4RUhJL2NtcG9GcnZSMTN0OTRTL0gva25TamFuNHF4enRuUXRWV0RO?= =?utf-8?B?R3NMb0dpaWFLdGpxMG5VWFBNMlhORlJhc2pBa3AzNUhGZHBvcFNGOXVuQk9x?= =?utf-8?Q?OA8ZCDyB2PoAVZXhuiyRXr4=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: f6716eec-4b81-45c7-26cc-08dc595e5bd4 X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8102.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2024 13:01:38.3302 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BMY4kpeJTN2eqze3mcoMWhsVKrFyKyaQszj1ytoFZ0K5sKWpQ1Hh4JVoEsstmbBEnDlZIHONmEg4+eWSWVCQn0hkNW2Iqh9U66Im8hSPMqI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6753 X-OriginatorOrg: intel.com X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: EA381C000F X-Stat-Signature: 51sb7ioizt8dupgrtdhzo5qn6yjc7puu X-HE-Tag: 1712754105-78142 X-HE-Meta: U2FsdGVkX1/K2FWvoUbpyuTzkly1q2S4JgtWEbxkJrjm27GWtnkWE1hRGF1tfXhB9QMWw0llJMNypEWPKpbYxh+va+5xg4lr6c7CP+1dAnU5fES+mlBnpg+ndS3AY23KwCypYWVTqo0UhL6YCU6x/qjepORbdaR983jc5jI84xa9oB26OTMbCem//MKImbcevQBkyyimNf8M/YRUlDZiLGvCI8bJK0wZAOGh2SLKu+me+Qqz8uuwQsl+mhZCCqiUKa0xevg8nCpJG4P305i6EcUL1kfYRHtZYZq23eNmnpMgQfQNUteBDsyO0DImqyu8pUNC7vPaDX68WAL9MgCgnskrhjqa21Fx2zXg2b2Ng+QDPQpI/qg16U4BATZvdJ5D35Aeq8KgkbfzMS8tCSw3+ExWSwbbcDkKj0YbjCy178QMu3Ivn2TnrB3sl3EbgdY0IaHFgFP/GPCia0VNYtsuyfsz6ezR6MakMfRN6aUZjVnPnHXWlaxou4M1PGrDulicJWbC3s9C+xEAWtn0aDWJ40ikM7Sd1udUUtT5XJXoqGm8ph9RvxL9ikfjxJZgl9tUhVx7AXBL+RXtIdjLZkZH4pS4+EPhqbwxvk6PGSPb5fsfYo3+3ALd856jkRjaaq/t5sm0+IpJl3PlzRk1xs4eMhAHXTlZM/3wQCkHm9j0uY5mYcblKhOTR0cGlEgnIDGpYkoHAIy0Qc9IoUo+G99HLcrVeIFtIDwyLwxV/SC8TO0Q3MMXjBWxEhuyK4rchQ1mpLqfqjXghXvXRiiAv2/gn0XHLEdOpZtEfkxOM3Aiy4z8rBgLFaXmFTdS/QNXXC+zEgnTkqbwnPC21e+Qc9MJACdhJmODy6aG8gm/qoBs12pS1n3csgJ3CCJDRrUgk9wwCVLQLdeXhRnbAD6u9yBQF2MBlKRGh0gV7+jtZ0t029fCrBFJDbSEJ72KKZZVng7AEMqABC/VcbNA7d4yPNV MEG4sF1e s3CW58GlSjPusWP1wLjybGPLl+LwGGHOFMeMVcfVsMfikdl5agSXsw8r3MDf8zariv/N5QczLVNoJ+ivk1UuMNOX9vbP+CQ7dLCRkHnX1/7ZPueDnowP3v8DuFJZ08A0YQgBVl0oD8OuUqVtLsEsAvaN0rCRUCG1XJNm2oduIx+juM37K01J1PxCCO11YLe2Tro5a5ebZAACqr3XySQ9eeSWJi9U6u3sFh0woUzqY4L3Honwky7h7ie8o7DOf+knmaDYzoTloG2c+4IqrgaZveYR7FnxUOOKyz5X7Bn++28DtTBUJlT1qgDCYA4nflwHtWoFxYcxwlHAv3o6uRgBiaVz+Vw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/10/24 13:49, Alexander Lobakin wrote: > From: Przemek Kitszel > Date: Tue, 9 Apr 2024 12:58:33 +0200 > >> On 4/8/24 11:09, Alexander Lobakin wrote: >>> From: Przemek Kitszel >>> Date: Fri, 5 Apr 2024 12:32:55 +0200 >>> >>>> On 4/4/24 17:44, Alexander Lobakin wrote: >>>>> Add a couple intuitive helpers to hide Rx buffer implementation details >>> >>> [...] >>> >>>>> +struct libeth_fqe { >>>>> +    struct page        *page; >>>>> +    u32            offset; >>>>> +    u32            truesize; >>>>> +} __aligned_largest; >>>>> + >>>>> +/** >>>>> + * struct libeth_fq - structure representing a buffer queue >>>>> + * @fp: hotpath part of the structure >>>>> + * @pp: &page_pool for buffer management >>>>> + * @fqes: array of Rx buffers >>>>> + * @truesize: size to allocate per buffer, w/overhead >>>>> + * @count: number of descriptors/buffers the queue has >>>>> + * @buf_len: HW-writeable length per each buffer >>>>> + * @nid: ID of the closest NUMA node with memory >>>>> + */ >>>>> +struct libeth_fq { >>>>> +    struct_group_tagged(libeth_fq_fp, fp, >>>>> +        struct page_pool    *pp; >>>>> +        struct libeth_fqe    *fqes; >>>>> + >>>>> +        u32            truesize; >>>>> +        u32            count; >>>>> +    ); >>>>> + >>>>> +    /* Cold fields */ >>>>> +    u32            buf_len; >>>>> +    int            nid; >>>>> +}; >>>> >>>> [...] >>>> >>>> Could you please unpack the meaning of `fq` and `fqe` acronyms here? >>> >>> Rx: >>> >>> RQ -- receive queue, on which you get Rx DMA complete descriptors >>> FQ -- fill queue, the one you fill with free buffers >>>    FQE -- fill queue element, i.e. smth like "iavf_rx_buffer" or whatever >>> >>> Tx: >>> >>> SQ -- send queue, the one you fill with buffers to transmit >>>    SQE -- send queue element, i.e. "iavf_tx_buffer" >>> CQ -- completion queue, on which you get Tx DMA complete descriptors >>> >>> XDPSQ, XSkRQ etc. -- same as above, but for XDP / XSk >>> >>> I know that rxq, txq, bufq, complq is more common since it's been used >>> for years, but I like these "new" ones more :> >>> >> >> Thank you, that sounds right. If you happen to sent v10, a bit of code >> comment with this info would be useful ;) > > The current kdoc in front of each struct and function declaration is not > enough? :D > > Thanks, > Olek I've asked my initial question just after reading it thrice, without your reply `FQE` was as meaningful as `ABC`