From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97EDAC25B75 for ; Mon, 3 Jun 2024 09:32:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 337556B00A4; Mon, 3 Jun 2024 05:32:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E5886B00A3; Mon, 3 Jun 2024 05:32:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 15ECE6B00A4; Mon, 3 Jun 2024 05:32:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E89FF6B00A1 for ; Mon, 3 Jun 2024 05:32:43 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A88921C0D36 for ; Mon, 3 Jun 2024 09:32:43 +0000 (UTC) X-FDA: 82189062606.25.AFA9CA9 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf06.hostedemail.com (Postfix) with ESMTP id 5534318000D for ; Mon, 3 Jun 2024 09:32:41 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ENmMGnjO; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9QQy8XKn; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ENmMGnjO; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9QQy8XKn; dmarc=none; spf=pass (imf06.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717407161; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=unoPvHtEY2q8ar/jFsOGCYlFRxG2foKN8adh7yrkQyM=; b=6zerDK9hoECYZJKpFjZpXxqKnGIjLoa4sG00gks//j6ov4prS6Z0tRFIwmrxvI1xCvglWD SwDR310mqncYylwqLSppCBRQIUvROY5LTqRSdd/at4ykEPr5AeadBNBxVeyIDZCgh7HKoT UWyfJTx+TbDi8bVWC58+Or6NObo5ado= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ENmMGnjO; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9QQy8XKn; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ENmMGnjO; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9QQy8XKn; dmarc=none; spf=pass (imf06.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717407161; a=rsa-sha256; cv=none; b=J3J+OjfefEs/tPMG8mMAdyz1P3UuUMtN4oMae9cj9yE3kkI76c8XOw7bEvZDXKWaFbBcTx EWxSrERa4wZLSfPbraS6kh2EVbR0ikoX7iWW7HW1ZXqyl1CE9vwmfj2/wH7dfwXlQYcUYZ EzhMOz8BBB4+no9/r0TC4wrvifQuDxw= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id AA979220EF; Mon, 3 Jun 2024 09:32:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1717407159; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=unoPvHtEY2q8ar/jFsOGCYlFRxG2foKN8adh7yrkQyM=; b=ENmMGnjOaRwB8GQsF2OJkw8i4I2Rw9Vwss0yYCz1SLkNY3bybiMq4C2FTtqjh5rOQo/FtJ RClcmU+22aQiU680tUPr1KqF/OgjnqWGbT75BWwAuaERq7uNvR5DJeI7JlJt074qBGfo2T 0pbqVCCq4XAw2ZlOP/rBs70LC+n0v8I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1717407159; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=unoPvHtEY2q8ar/jFsOGCYlFRxG2foKN8adh7yrkQyM=; b=9QQy8XKn/fbOW0gmknAO2g/sAcpBTqaaXNLk83Xr7Vi0Z/2lYQQhz/HZHdrKWIHyuGBTWO SmBNbzIkESN8ZXDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1717407159; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=unoPvHtEY2q8ar/jFsOGCYlFRxG2foKN8adh7yrkQyM=; b=ENmMGnjOaRwB8GQsF2OJkw8i4I2Rw9Vwss0yYCz1SLkNY3bybiMq4C2FTtqjh5rOQo/FtJ RClcmU+22aQiU680tUPr1KqF/OgjnqWGbT75BWwAuaERq7uNvR5DJeI7JlJt074qBGfo2T 0pbqVCCq4XAw2ZlOP/rBs70LC+n0v8I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1717407159; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=unoPvHtEY2q8ar/jFsOGCYlFRxG2foKN8adh7yrkQyM=; b=9QQy8XKn/fbOW0gmknAO2g/sAcpBTqaaXNLk83Xr7Vi0Z/2lYQQhz/HZHdrKWIHyuGBTWO SmBNbzIkESN8ZXDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 969FA139CB; Mon, 3 Jun 2024 09:32:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id /QtbJLeNXWYhBAAAD6G6ig (envelope-from ); Mon, 03 Jun 2024 09:32:39 +0000 Message-ID: <618f3c36-9952-438b-94dc-e3cb4a8afc48@suse.cz> Date: Mon, 3 Jun 2024 11:32:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] lib/alloc_tag: do not register sysctl interface when CONFIG_SYSCTL=n Content-Language: en-US To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: kent.overstreet@linux.dev, pasha.tatashin@soleen.com, keescook@chromium.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel test robot References: <20240601233831.617124-1-surenb@google.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240601233831.617124-1-surenb@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 5534318000D X-Stat-Signature: tqux4fw4z3zbrukkhebu5nd65k7neugh X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1717407161-337293 X-HE-Meta: U2FsdGVkX1/mQQOBfBrsKcCMBwFATTcrARLRJYAo7X0VXO8X78IOIlm5+9JnOGj1M5MI7iK5/7PuDreKEUsLX29x6+UbMA22i0KSGuScZ4iP35DU4o3pT26+Mrc9cikyrKV++rP1RuYCtTJ0UcEOAH5WPGO22wGXtlhnDPvfmVbyt7pn0n14kOUaXsLZFT7XpyhybV21zybtSLRDZDQlmFVARAC7knffYB1AO41UiOFnWgggei98BU2RvNLeAmeFR7xIPgmWsR06q5xu2YmrUMsNCCC40EQnethRbfxV55CM8MzXK205qwIl760SMEI0jePbSViUlwVnXTtgkzZNnv3FfJGzbUZK0fNIkAcZQZAWdIZqSXQMiDohgli+QrPqz+/hTpqndQT1gCiuTGEZzV40IcTYycP4mLUCjKQoizuRaLQL1GirFwcbrT+cLGD88MXO2hz3XIeo0uTbkPMiB2/wYa88F+/0+0HbmFxaKZK9P6dRd0s6nF6mwmA2C89s2ASXD3zoWP0hU8qp8O96oLNtaHVW3KZod1Nx7vjoW75jl2neI7qH+Ba6FP2cVqIbSGA+a7n39ixRO7qQHHoIESn9A7Xe8TOpyYiA0nP+k8NELlDXdN7CbwUrCcO/cZjxapnRqnS/+kixbRNIF4zTxlEeAmoJZuidu2dO5zo1v2oaBADAlm2tG/R6f5+J5+y4LHYya8m/X2bmNAEVoyDo5ECqV77PBi2Fnu7wj87HYbclMeGCuS7DT/oNId7LBUTaJgFuHWcpLdAlBMyUPKst/0hWHWB9NY+pmNUofgLNx1BKMZZX3YMfFbxwq9hvN1WvsxjE3WMs54GRnvwzfeX3Z5MB94r12mAYbxRYjhabeJETbK9oyjp32y43N/Bf+xeF3CH26l3e+wAMrPQejawB1FMFnE/t2wUDmrY3epT0floqievyLFcSijfnsE4WL0lcRnn2IAKHUhRQKEDv3Xa LCh61F0A G57V5LU28yCEMGjhd2bmxIj/WUr5niJGSaI14ioYoFlLrgkwadXG6O8LHafWKNMa5c6O8t0m5ISbxAjYOezOIY44JnhjaXwEpRqHwEj9z1ZJPLrnVkoDPebs/yrBi3gl/0dZvkGhNBHTLlfz0mevbBIoK0Q8Y0fq4MhvrLiUplhtV+FUOApoQvQslSb5uS0uKLth9WWQ96Ce1yjnJT1/nlgLSgLMWH87dGRBWWbJ9iss2GuAEAYPgaIITDh3I6PyxYN+Sll59L0CgUb5inOZy23FnpXgMWAzfVoehdQPaoR25PkwPEBHaVq0/gSzuzLA9eJFyfjnHzJc3Ji+QxDqIQjcOgsQwNkt+FgM6JQbnGjV90OvQ155jzDoZaKvsMPQmuhzAuknl9utHF+KAEzJj7U6iDebnJDa+Afxd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/2/24 1:38 AM, Suren Baghdasaryan wrote: > Memory allocation profiling is trying to register sysctl interface even > when CONFIG_SYSCTL=n, resulting in proc_do_static_key() being undefined. > Prevent that by skipping sysctl registration for such configurations. > > Fixes: 22d407b164ff ("lib: add allocation tagging support for memory allocation profiling") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202405280616.wcOGWJEj-lkp@intel.com/ > Signed-off-by: Suren Baghdasaryan > Cc: Kent Overstreet Acked-by: Vlastimil Babka > --- > lib/alloc_tag.c | 16 +++++++++++++--- > 1 file changed, 13 insertions(+), 3 deletions(-) > > diff --git a/lib/alloc_tag.c b/lib/alloc_tag.c > index 11ed973ac359..c347b8b72d78 100644 > --- a/lib/alloc_tag.c > +++ b/lib/alloc_tag.c > @@ -227,6 +227,7 @@ struct page_ext_operations page_alloc_tagging_ops = { > }; > EXPORT_SYMBOL(page_alloc_tagging_ops); > > +#ifdef CONFIG_SYSCTL > static struct ctl_table memory_allocation_profiling_sysctls[] = { > { > .procname = "mem_profiling", > @@ -241,6 +242,17 @@ static struct ctl_table memory_allocation_profiling_sysctls[] = { > { } > }; > > +static void __init sysctl_init(void) > +{ > + if (!mem_profiling_support) > + memory_allocation_profiling_sysctls[0].mode = 0444; > + > + register_sysctl_init("vm", memory_allocation_profiling_sysctls); > +} > +#else /* CONFIG_SYSCTL */ > +static inline void sysctl_init(void) {} > +#endif /* CONFIG_SYSCTL */ > + > static int __init alloc_tag_init(void) > { > const struct codetag_type_desc desc = { > @@ -253,9 +265,7 @@ static int __init alloc_tag_init(void) > if (IS_ERR(alloc_tag_cttype)) > return PTR_ERR(alloc_tag_cttype); > > - if (!mem_profiling_support) > - memory_allocation_profiling_sysctls[0].mode = 0444; > - register_sysctl_init("vm", memory_allocation_profiling_sysctls); > + sysctl_init(); > procfs_init(); > > return 0; > > base-commit: 065d3634d60843b8e338d405b844cc7f2e5e1c66