From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DFE0C27C5F for ; Sat, 8 Jun 2024 16:04:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F8F06B009A; Sat, 8 Jun 2024 12:04:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A79C6B009B; Sat, 8 Jun 2024 12:04:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E89AA6B009C; Sat, 8 Jun 2024 12:04:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CC62F6B009A for ; Sat, 8 Jun 2024 12:04:03 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8C743A2357 for ; Sat, 8 Jun 2024 16:04:03 +0000 (UTC) X-FDA: 82208192766.21.8730707 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 3C8AEC0007 for ; Sat, 8 Jun 2024 16:04:01 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Yp9Beqws; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717862641; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qVkfmd0A4LSH9aeoF9S7AqEXOafs58bJBwLWsHiogQU=; b=IBDI1pzMCOnwairNzAJZ5Es0K1cUs4clIBE8uWJ7RlM9++cjXYjQ0yFqnREgySX0JllaRP xOzuoTNKzbkwJ2LsvavbmyClFS4zhJ8o61X71vvCouSxOhdbojXTM8K5eFlfe05HK8Oy7N tfpZE6T9V6sh5nFzx2gH1l1grC/l2X0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717862641; a=rsa-sha256; cv=none; b=l9O9JAc9w8cPN0e90djytMmfRAQ89LqC4u3angoV6xXK/PhC4K/s+PHTQ1IOqy7xd/3HZe rOtSYnD9uRrm/+e85tSM2Mf8qrvgWaDqD5AN8J3vd077fvypXCm9pPz7zQiFKUCVEzzOC3 mG+roIUbStBspgfLiRXPrXWEP/tsss0= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Yp9Beqws; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717862640; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=qVkfmd0A4LSH9aeoF9S7AqEXOafs58bJBwLWsHiogQU=; b=Yp9BeqwsuXxKC42RbLDAKniC5A+KrTOXFiwb3T6bQ7goskda6O9e6mEqlszofqSxKrwQeo 4Izp99G3Piyp7OdwftT+D9yS4QQCoBIUzIUI1h+Dc8bWW7L6uRnqmAepBVxCvu4qGOkWh2 WvKECf2B7QEuEZff9CMuYq+CeIN6R98= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-488-74ZpzuLaPB2M-CkYDeWufg-1; Sat, 08 Jun 2024 12:03:58 -0400 X-MC-Unique: 74ZpzuLaPB2M-CkYDeWufg-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-35f06558bc3so888933f8f.1 for ; Sat, 08 Jun 2024 09:03:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717862637; x=1718467437; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qVkfmd0A4LSH9aeoF9S7AqEXOafs58bJBwLWsHiogQU=; b=eivj7a8sg5RMm5Cifuu+i7kYoqvZm0G+2vwrYSj6AwIjS0Qjnehxr1n467Ifn1b8ZM 9xPFokHjQTmQGRg2uv9I8l7qbM025h6YoJXSdwEbxdlXTGWtipp1Mo+B4Ms7T8ehk+49 Mz0n8dNDQeYD525a+2Dg8xcoPPvH4dO6u2HbFOpkHyLRM3ifvet86EoKYvcAHgCDlxsS NoE1o0trQDO9vF+mNo8EPcGc2QAdG8dg5vA7LEsAeJfzg7cnrYiIMAiyQG3VNnErpxFG LwSCWEyMQF/IP56YJgEyXQ8BXD40yZiJU44qjG+HrlBuxg0wTVvzkpP9aEMIFf0zZFpu WJCg== X-Forwarded-Encrypted: i=1; AJvYcCXASW8gqr38bpPehWrW8zfwDdXSiT9UcjMKz7AuAsi/2m+Sp2hkd+fs7yuJV+XiJjOjSHNL1cMqVQ0ovhWM3/gy528= X-Gm-Message-State: AOJu0Yzc91eazXMup9EBaGYRFcyhcbuLdzVl4jvHgrDa+kKEdRbMrE7X PnKEVLLKxhDBtH7D68YmwjX5WMlH/BEmicWcvun2i5zgv/QcP9WuPCcMYu2wYx3LbEzHlCoGbYQ czk35Tzn7qlO3zEMYKrR896qUtVBIu8zEp7vmUzjoqF/WbsNfZgQ0NzH7 X-Received: by 2002:a5d:648c:0:b0:35e:5b3c:b11f with SMTP id ffacd0b85a97d-35efedf69a6mr4136852f8f.58.1717862637325; Sat, 08 Jun 2024 09:03:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG6t3CY8lINt/8W7LI84Kb4ZP8m+Ag7Es0XZ9YMGZx68e9mM+O7GkNFhPNxHyppXfZ4VvhQmA== X-Received: by 2002:a5d:648c:0:b0:35e:5b3c:b11f with SMTP id ffacd0b85a97d-35efedf69a6mr4136835f8f.58.1717862636892; Sat, 08 Jun 2024 09:03:56 -0700 (PDT) Received: from ?IPV6:2003:cb:c725:2c00:2436:de9:dfc8:5e67? (p200300cbc7252c0024360de9dfc85e67.dip0.t-ipconnect.de. [2003:cb:c725:2c00:2436:de9:dfc8:5e67]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35f0f996ee3sm2535873f8f.71.2024.06.08.09.03.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 08 Jun 2024 09:03:56 -0700 (PDT) Message-ID: <617f9e36-9334-4630-a6b9-473f2dd570d4@redhat.com> Date: Sat, 8 Jun 2024 18:03:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/gup: don't check page lru flag before draining it To: Matthew Wilcox , yangge1116 Cc: Baolin Wang , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, liuzixing@hygon.cn References: <0d7a4405-9a2e-4bd1-ba89-a31486155233@redhat.com> <776de760-e817-43b2-bd00-8ce96f4e37a8@redhat.com> <7063920f-963a-4b3e-a3f3-c5cc227bc877@redhat.com> <48150a28-ed48-49ff-9432-9cd30cda4da4@linux.alibaba.com> <11ef3deb-d1e3-46d5-97ed-9ba3c1fbbba9@redhat.com> <697a9bc2-a655-4035-aa5e-7d3acb23e79d@redhat.com> <3a368e38-a4cb-413e-a6d9-41c6b3dbd5ae@redhat.com> <48fb0e58-16d1-7956-cf35-74741826617a@126.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 3C8AEC0007 X-Rspam-User: X-Stat-Signature: 1onahkp6mz9bf6zgmig1a89bt6obq7gp X-HE-Tag: 1717862641-426685 X-HE-Meta: U2FsdGVkX1/MYwj39Lvo4EEpQ9zHM2E7bMYQhPgWXucD4l8PEFbxRrenpR+wyljv6jDYQOHn6aZOEiDxaSaPuzkEUBWJvOTlvlxFAMTO7qgyyrJhKx5dAZ0BnAv4aLJfInBtLnv8HwwJl2rCAMGjLzpzsYmURb1oiY6OvbKWvQdWZ7SkyxmnuwHIqGXwoOEztgAsesfdm8I69O8j2tBPVr/8CFVMdypXLCZbGyhkWtjDz7IySrQ1iZo29eCfnz96s9u6C0rllHz4oE6M1bIwV8ASc/coL3RU+e+RkzD6/gjBLKBqxCcbDTIdYlOOtBpLna5EZ99vpcWKRhsVpxOWPhGCzIbJ8LllCOlp2gsfZlXS6v6Sqtlm5VfRbTACuYH4bI0nKi8rwfrLL29q6p9A7tIh2UEkCYJtS0oFY4zTiJvyNueZkqSc7y+OYisLmJqur2vXQMVxzfqfUXWMGIRvZDCdM32V6PXKYM9GG7XGxkJDRf6GPSzWjqtFtsxFfpflROw0iRt+1TgRMp+s6MpE5cEZMU5M7HrdqhjAmiiIW1mG78i/dnjYDAbEA3QTYOedleGKkB+5u5nKYyUiSGntyy+xpOFLOQHi3lu89aDjijsUdAxmC/kpUJkhECThSi8ils1YjZ25fQZOVQLoCJm7Z61Q59emFW/dGiPuzkVXGAhOcxoSzVwaVTOguTrxeeyDaACpJK6wCovlMEt8NK2q+KKrU46vc8hXA/YIZ0n6FJ8ZgKgYU1kY92cL7aofQgdW7xzt0rurTTdsqjAnyYPkKrVTfDYD/d36L/fGXMQb0ROEUcgmQXg/Oug2VvJoYVyf6gcA9kZzkbXWnegvkOo7M9C7P2AhK4wCRHeeaVpNKiRaSt/RazHBwh4Tkh/6akTH7UXI+eQhhvA7K0nXnZWnkmP3l7KarikWHhzwuDyZhl0tzpL6z+NahjtaI/eM0+kFo/czdDpUwrfAqIif+yt mSs20a4Z u03pKmc+sVukDz+PO9qDd1v577lhBQ8eaRnKIB3vA0W2YdZ8Rm7TGeVl8ZKAM61jceuBspG1a86jEVFQNKASbfIn3+cFGyKWhv8qNcO6Tz5MzIU6dkmwB74lJ3JVej2+W1GZCtbJZOVzJ3WS63xUrPaDvr/7+YVUAnCODAYIuxG8RoWqk2JclJsGhmfBbco/8boiwM20QvMfuLzg378t/jsPL0oPuAJamLvGNlfxMubT4Zxb04ft/bv0ya8P5baiy73qU3MqYe/J9GlS1bxa8JXHLI3fXIzfwVP51mVVsBt/N7p8LZFYiyUgW0VnoM9G9BXqrU/rXlwPD9HzsFoCFbgnbYuldXhIex1Uk0RmgYbjnfvO51Y5xIYzUIQCQUtdBroAKRsG230Yv7zbIJdu+taPo+HZmWoZT+kPGzvbI68Le8UgfMdu7JduG15kbc7bFYnNdNPjD53prCJZdsX36EV9Vxq7r2/x+rpkCWfqgrAWNV6T4e1I8rU69iv1o6uRJvCgGZYsLRHimLKI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08.06.24 17:15, Matthew Wilcox wrote: > On Sat, Jun 08, 2024 at 12:38:49PM +0800, yangge1116 wrote: >> Can we add a PG_lru_batch flag to determine whether a page is in lru batch? >> If we can, seems this problem will be easier. > > Page flags are in short supply. You'd need a really good justification. > A flag would not be able to handle the "part of multiple LRU batches" that should currently possible (when to clear the flag?). Well, if we have to keep supporting that. If we only to be part in a single LRU batch, a new flag could work and we could still allow isolating a folio from LRU while in some LRU batch. If we could handle it using the existing flags, that would of course be better (wondering if we could store more information in the existing flags by using a different encoding for the different states). The temporary clearing of the LRU flag we do right now tells me that it's already not 100% reliable, so the question is how much more unreliable we can make it before it would hurt :) -- Cheers, David / dhildenb