From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75BE3C4829A for ; Tue, 13 Feb 2024 14:58:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0DDE78D0011; Tue, 13 Feb 2024 09:58:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 08D378D000E; Tue, 13 Feb 2024 09:58:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E97C58D0011; Tue, 13 Feb 2024 09:58:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D87958D000E for ; Tue, 13 Feb 2024 09:58:36 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BADF5A219C for ; Tue, 13 Feb 2024 14:58:36 +0000 (UTC) X-FDA: 81787087032.05.553DEC8 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf05.hostedemail.com (Postfix) with ESMTP id 6D33E100003 for ; Tue, 13 Feb 2024 14:58:34 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=TsmF6EuW; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=4IzAiNJu; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=TsmF6EuW; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=4IzAiNJu; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf05.hostedemail.com: domain of hare@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=hare@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707836314; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OSAPi76ZfKEBUK44Kk9m2ondarSlgg03teP4kt0h9ts=; b=mYyHvtvT1OAirtgRr94QJDhr6AABkmD9LmjhDcTiuX9XRsIp7MhvH58pfjSSrWyzEMj6Zf UH3LATyi8xm+DXN92FUTJzgh0sLHXrhOM+BJOqEofN7HRayxBhzIUFpTUUvUJd/Qeb4f8o c7nci15WXMRa18XFw79idV07aDyWXPU= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=TsmF6EuW; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=4IzAiNJu; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=TsmF6EuW; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=4IzAiNJu; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf05.hostedemail.com: domain of hare@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=hare@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707836314; a=rsa-sha256; cv=none; b=B4lh0jaDLYMNC4Y/DRFPd1MV23ebg+jtc8t4mEYAXmRceC4z2WpnWfTgYAvo75fvbO9V9O 4ZutJ8w/gspetLx5f3dCiDaa/K8HwXpYEBWUo+mtn6wnuLFtUyjceMXZFM0KmPc0B2u6aB apSeADVE/n5fW+82gj+vSWhydBuPP9Q= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AA9FE1FCDB; Tue, 13 Feb 2024 14:58:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707836312; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OSAPi76ZfKEBUK44Kk9m2ondarSlgg03teP4kt0h9ts=; b=TsmF6EuW1/ZrDEQnj5xa/n18uHulfwkLO6rU++JFQbmWcTs8JRISjd0e0DYJCt93M8Q3Lq 9xnDoEfMbslmTO8DqClxTOLoIkxUBw2BOdrCOKwqSEu3Y414rDadOzOFwAoj+Ikh4kV//E YuKVrwmP6GcFw3WmUC0+jb1CcBYwqWw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707836312; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OSAPi76ZfKEBUK44Kk9m2ondarSlgg03teP4kt0h9ts=; b=4IzAiNJu0NaYcOYhd5h+T7ewe3kM8czpxtzkUT374zxrHQPrVhKL+RoLYylPryY2l0GzID Od3wT3xopUGMH0Cw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707836312; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OSAPi76ZfKEBUK44Kk9m2ondarSlgg03teP4kt0h9ts=; b=TsmF6EuW1/ZrDEQnj5xa/n18uHulfwkLO6rU++JFQbmWcTs8JRISjd0e0DYJCt93M8Q3Lq 9xnDoEfMbslmTO8DqClxTOLoIkxUBw2BOdrCOKwqSEu3Y414rDadOzOFwAoj+Ikh4kV//E YuKVrwmP6GcFw3WmUC0+jb1CcBYwqWw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707836312; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OSAPi76ZfKEBUK44Kk9m2ondarSlgg03teP4kt0h9ts=; b=4IzAiNJu0NaYcOYhd5h+T7ewe3kM8czpxtzkUT374zxrHQPrVhKL+RoLYylPryY2l0GzID Od3wT3xopUGMH0Cw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8587C13404; Tue, 13 Feb 2024 14:58:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id le0RIJiDy2VlMwAAD6G6ig (envelope-from ); Tue, 13 Feb 2024 14:58:32 +0000 Message-ID: <617c710c-6b61-46cf-b507-4c16c9d8e9e4@suse.de> Date: Tue, 13 Feb 2024 15:58:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v2 03/14] filemap: use mapping_min_order while allocating folios Content-Language: en-US To: "Pankaj Raghav (Samsung)" , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Cc: mcgrof@kernel.org, gost.dev@samsung.com, akpm@linux-foundation.org, kbusch@kernel.org, djwong@kernel.org, chandan.babu@oracle.com, p.raghav@samsung.com, linux-kernel@vger.kernel.org, willy@infradead.org, linux-mm@kvack.org, david@fromorbit.com References: <20240213093713.1753368-1-kernel@pankajraghav.com> <20240213093713.1753368-4-kernel@pankajraghav.com> From: Hannes Reinecke In-Reply-To: <20240213093713.1753368-4-kernel@pankajraghav.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 6D33E100003 X-Stat-Signature: jpmh11ozykzb9jyp4a9j3x3jccxoxdh3 X-Rspam-User: X-HE-Tag: 1707836314-77501 X-HE-Meta: U2FsdGVkX18WHIKocDhknV3Km4HrxvQmxRnzhc/ZXHKpcVnKFtifEe6gN1WhKMS82ysmWtBmERjZhWkj4q3FHxuOF37iYUTnyvP8JOJ2v/6comwMtn+oy1dXEFAJI4CVPH8Ra4xpuhzMhNJsfe6bQ2X+yhYQUaRg4CMTX8Wi/bzvhTiyHwZnDOtzt0bVWMwqERk+HGQ1373fmtrQhdHam8BWHRe4msc6j3Ztgbj0S3K0Dh6DJLWDx8Hds7WpLw4shLaTEeVCntjnR41pgMUFcwNlP53HIrJ4OmdA/449Y4mM8IhKSy9CHRx/wblx3ZOe6Ni0jtIFtoejxraXHbt/eq3JY2H0RJZ+tgbS6McUToUf1JjK6knS+AnQsTzd67YbVPR7dzY0cb9vjv7iWKM/afy6sKaVgotAxUQJeAaIXNe5ruk8NqTkZC7nVR0akkMYofg2VxTT8/Y8w/E8zCTP7QO0NjHqWTTEBp+KxUnOEEHtSg3UCGp2uCekJEw8YNbuzA0XKbB+L51rcvo2ZGzqBgppqIVq5wkLTKE3FkhQuuzhBD6Srh6ANXl72UyVEQNFBo08VRLVCqNNuw6OfV9p3TDooEL2P2CbaOsjq+9oj5GZf53fjaszB1kcTtT7lucOuDjb3tukHDkvKBYQSvJ5cvf5JLyarMz2aGBbNoG3h2vgPOvRBXMawDEUYihklxMb1qrI8z8Z860DgZkBCv1AL5dCRbZZFjeI0EuMXNEVzrvK3+OjK+lbH+Hx+WesR2S5VkvxiE14D1O6kKUXFd3wW7k5IM7Ig5yE9x54E57EOFz8el2rj8KJq1D5Yu2rco2WO+W6SuD/v2IZedqPZgKM4VlE9GGrs9/8hBlajyspQmLs7af2ALWycUIvRiirf2/21T5DPk17tpwhblrDI1Z3PORUY3aDsIjYJ4108hb2s63VC+pEP9GCJ+Y9Cs1AksqAjIZ1DF6Ed9TcsSb7mAw wOry0VMW zH9hO3wtR6x+SRbi5mFTikSYt/HQoiY1/i9pz/Aup3NwHNPwkjE8HZfgYgfx/MqW7NgYgw2Vu5VCueN4MIpNYaqFMbsxESaHdxU+1lZj+hGKgrZSXgrfHlGemvNVESqJN5HOzKLS/LxxdPGttkmbcQmLo0Q9cmnjpH4IVAKKbuvoAOy44N+2OP5K/K/WPRCLVTnfG5XJ9R7y14/b4ko+wGaZg3nMGfvOiaHbwlBboPhloQw/2ZbemQ6mDoV1MD/gBJY1g4mN0HuDrfMdDp6ebfiebeUDiA2+On1ekpucofIgE+NEsLdgD3plBSzaUO/U52+BfxTCPgX9E2u+FrwyVjQALyFFWIoYggUuN1zS4GtFIE7+G5GAkiOWcS7pw630un3CpZShx79744a0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/13/24 10:37, Pankaj Raghav (Samsung) wrote: > From: Pankaj Raghav > > filemap_create_folio() and do_read_cache_folio() were always allocating > folio of order 0. __filemap_get_folio was trying to allocate higher > order folios when fgp_flags had higher order hint set but it will default > to order 0 folio if higher order memory allocation fails. > > As we bring the notion of mapping_min_order, make sure these functions > allocate at least folio of mapping_min_order as we need to guarantee it > in the page cache. > > Add some additional VM_BUG_ON() in page_cache_delete[batch] and > __filemap_add_folio to catch errors where we delete or add folios that > has order less than min_order. > > Signed-off-by: Pankaj Raghav > Signed-off-by: Luis Chamberlain > --- > mm/filemap.c | 25 +++++++++++++++++++++---- > 1 file changed, 21 insertions(+), 4 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes