From: "Luck, Tony" <tony.luck@intel.com>
To: Jason Baron <jbaron@redhat.com>
Cc: torvalds@osdl.org, akpm@osdl.org, linux-ia64@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: RE: [PATCH] ia64: race flushing icache in COW path
Date: Thu, 13 Jul 2006 13:37:17 -0700 [thread overview]
Message-ID: <617E1C2C70743745A92448908E030B2A38D779@scsmsx411.amr.corp.intel.com> (raw)
> lazy_mmu_prot_update() is used in a number of other places *after* the pte
> is established. An explanation as to why this case is different, would be
> interesting.
The other places do need a close look, it seems that some of
them may not be needed (e.g. the one inside "if (reuse) { }" at
the top of do_wp_page() ... at the moment I'm struggling to see
what it manages to achieve).
Most of the rest are in cases where we are adding a new virtual
page (comments like "No need to invalidate - it was non-present
before"). These may also need to have the order shuffled, but
they seem unlikely to be the cause of a bug (it is unlikely
that an application has threads that branch to new anonymous
pages as they are being attached to the process).
So you are right that there may be some more work here, but
I wanted to get the one-liner that is a clear and obvious
bugfix posted without being cluttered with some less obvious
fixes.
-Tony
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2006-07-13 20:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-13 20:37 Luck, Tony [this message]
2006-07-14 3:11 ` Peter Zijlstra
-- strict thread matches above, loose matches on Subject: below --
2006-07-14 17:11 Luck, Tony
2006-07-13 17:00 Luck, Tony, Anil Keshavamurthy
2006-07-13 19:16 ` Jason Baron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=617E1C2C70743745A92448908E030B2A38D779@scsmsx411.amr.corp.intel.com \
--to=tony.luck@intel.com \
--cc=akpm@osdl.org \
--cc=jbaron@redhat.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox