From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 056DEC0219E for ; Tue, 11 Feb 2025 07:46:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 51551280004; Tue, 11 Feb 2025 02:46:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 49D63280003; Tue, 11 Feb 2025 02:46:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33E76280004; Tue, 11 Feb 2025 02:46:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 10CF6280003 for ; Tue, 11 Feb 2025 02:46:04 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 98D40A120E for ; Tue, 11 Feb 2025 07:46:03 +0000 (UTC) X-FDA: 83106880206.14.4FF6081 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf07.hostedemail.com (Postfix) with ESMTP id A866640007 for ; Tue, 11 Feb 2025 07:46:00 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=krzjjITG; spf=pass (imf07.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739259961; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YSAKHucokt7qfKmNQyIV/wNLM0zYjyzDQ14qjRlnafk=; b=ptK1OZj0naa0SeQe3oJPyUAmZNN9wmdmIHb+kocubu5/L+kmet/RyCwrOhw2joOuQHwU8n DO2xbxsMccZWF2L0C7nRMLWH79canP0afr1gf0cxoZYTgpwImFxu7EQXEDQDjDN1kWrcGi xk+Z+9c75AHVy3kNTYcFx6RezXP7MPw= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=krzjjITG; spf=pass (imf07.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739259961; a=rsa-sha256; cv=none; b=n0p6sVm+0711an39mL8hAVZMIHKIM1MeOP8p+t3p9jCYsdpObZuj01FK4lKeW3MXkTaf7i Fc56na/xo6aQ3GOtqax6xiMc04U88pDAvol57fQI73hiSbyYXlHcdQEnB9XP6ZPy5j+Hz5 gVxeX+5kgFht4u6YmbDU1l0z6BvFZZI= Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-21f5660c2fdso69636465ad.2 for ; Mon, 10 Feb 2025 23:46:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1739259959; x=1739864759; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YSAKHucokt7qfKmNQyIV/wNLM0zYjyzDQ14qjRlnafk=; b=krzjjITGqC/52IqE6nGC+6ouxgJ7xXxIC4F1thyUglDwNjfceBjDGqGqsxyHqhdkFd 7DHYWk5AHiG64enYnZKg30QVLH3DxE/T/N7zvJPOpv1uPgNOgfxiF8OgoPVC3cxh6eyg kacnXkrbuWCxlC3FqDPO5gU8QC3zm/evgO2zv53mhMnrYep2BqQCmhFhcGMeF+e67kbY pDOFaUqYzWKdVoo63KQCq5ecgJAujYi2jRdSNXng5sHfLrFSl10Q72nwL/ddGzJ6kXnB u/8J0nHK3A37D39sMJaRm5ZWNuB4PJpiC13o7LtH8NguK4rx639aTPHVxJYm/qUrWAV7 b/qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739259959; x=1739864759; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YSAKHucokt7qfKmNQyIV/wNLM0zYjyzDQ14qjRlnafk=; b=pQwkBpeIu/hg/G4zTrhS8Qol9TtXtJjjgjhNPnukXXCNXpGeLVRvTFOO8BEBJu5+82 ugsqa47FciK7Hoi+XR75jxtZSyiZkVzFEQIxlhZIBLbcDEEDvw8jOM9gcU8TCWHsiSmF 4k0RXtTFyc6h2GH35NHs4NCBSuxYLCHTxF9rVWM7yYeJPOml2Fz0m12EP4aXxc2z53aW TZM3aEa0A1jTPJTrvwBcQy6n2dcGb+lcKz8VfE9IUEQyhPpWxqaHIC47p0D9Zc7Db94Z bjdFDh3gN9H0J5f/MesftFsZy3i1FPNW+dzZ8u3T3MAvlP2f7LiYFDbRrU9ZcZ8X1ew8 m+og== X-Gm-Message-State: AOJu0Ywf2oSmRS1GF9kq8yNwK8unXfxoQy84+L7Qp2ikYUMKa9/t1mAj vGsaKrjC1P6cs/0e4e6CrNZGqNI4VnfFifSyPnBK/jN2QAkrFymXtgWbttGZEF8= X-Gm-Gg: ASbGncsKeHk6DGhGhnkoidsvPsmK9KUsq0YLd98JQ4AGIuiFHnXhfwXmqpZ1p6X9B5L PbqSf+PaVLR4kWZxPdYW8ODrBDE/GeQs5v3OnUXrMJFLSNR77McvclDvTPIsbGFOxrUAWhhRd5b 8SUZhT+C0iW6XdEfBQFy4VBOTniolkdWtdBd13ElgDE3NWRzXfYMJ7aYc63EUWgRb8hajENk34A gEGxg/o8X3YC7+A0drWzeqiNQQUay8qxvDpDTCCh7M3mrnQ/WnwcG+nuXvkynTybcu7wl//6axG +2EED56yoBv8KJp3YMNBH+xOk/1s4LT6YSpn6cRmRw== X-Google-Smtp-Source: AGHT+IFW6xSaUDrAWCZSPou2nD+/XK4bxqsbZZDruwD3E7NNexOes8n+tG2fP46G3dcaSbDR2HAwGA== X-Received: by 2002:a17:902:ea0d:b0:21d:dae6:d956 with SMTP id d9443c01a7336-21f4e6e1eb8mr275512905ad.24.1739259959260; Mon, 10 Feb 2025 23:45:59 -0800 (PST) Received: from [10.84.150.121] ([203.208.167.150]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21f36510e58sm90654975ad.10.2025.02.10.23.45.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Feb 2025 23:45:58 -0800 (PST) Message-ID: <616b5fdd-0f15-485a-b5fd-cdd6d7fc9d45@bytedance.com> Date: Tue, 11 Feb 2025 15:45:53 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] mm/mmu_gather: remove unused __tlb_remove_page() Content-Language: en-US To: Baoquan He Cc: linux-mm@kvack.org, akpm@linux-foundation.org, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, peterz@infradead.org, linux-kernel@vger.kernel.org References: <20250211034348.39531-1-bhe@redhat.com> From: Qi Zheng In-Reply-To: <20250211034348.39531-1-bhe@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A866640007 X-Stat-Signature: gc4a3gf37nom5zai735599km1qjqctbs X-Rspam-User: X-HE-Tag: 1739259960-126506 X-HE-Meta: U2FsdGVkX18DFrlSCImub4j5vFDowFyT5qZayowVwNKnGs2XiRHA7BM0Gj/h99KbQA0X8uwXBhRFZB/N0yiewU2whMcmLbppJ/LwhRtpXu28UO3vQeOSszWzx2FesPZvipa5xpxrUh9RyzMkOPYpITp+NpSACzuL4+MWER77d82SpOyCgXr/AzwVyP9G+3Mz54+jgm8VT2cr488w701aS+iwLEpf7+OPcU1sorZReIQbNSI5wTUGjTzpmtzUkQqqmoR43G6zASU1MkLwJgDlzy0WH45PweFVx8+jUuMeUVZuaIILBPSkVri1Y9Vcs8ZjOoTtXEe7rNaulwUt9MlakzLXbU4ANmCs1gI8WZfHAV2/cJwRy8JHBjFdNM1KAx7Q7KkzuE2N8A8ZmWmXgPm05+5QA7sqt7LY5lUgzMfOjeY65j97+2mBKFsDimJo+MBp9Cdy+vmeMjEt4/7sVT05NPnSaQjuFBQaZZSlEbExw1PiJIiRAQctPCQtdc4HBl5xzgnT2ziKuizm905uiNsJo9jOkkG0Or9fHwAWqSbWVG8nVnWD5NSffcWkMPjssIoL0B+0eM/OBPyPg4flJXSOI0t3DN/+bnR2/bbvo01XnYVJmviWzgsOUaOdA7/Fpno+Aw3eu6rd8eAtu5Ph2JHm5jIuaMgj11hod1pntFF07A+zGCe5LeArIsoYxwliEWHFM4hzWmvZ9Ad3MbIEAcgBqVq2CMl2epG8L9QGQXtdoSzTTLLgvz1ldFgHz02c2htJElz/Usq9/1pFhLCMC4rvGTKDr8Zja7Q/6OI/F5lECEo3N/oN93nSHpoibNcIK0CwWlk8hrNMY1gfg6OHK/XVkRRpiMeApigCxElZ+1QectqaFIN3Wlt4iI33cI7yuqA+CReF5Ky/QVoGN4qIOk8eIyhqMIM5RcKGOoK0a1NfzNPF1pP4O/j4W+xQUUL7VIy6toi+f1iUIo7rME50GCl C2zVzCoE 8dEtYbmNPeV1zHsJxgmH2+xmCrHtjH9DR62mibaoHvCu5gh/pL56e87Ce05wYeOqGYed3QCOdpSG5G/Jn/jQyKhjP7uHRVKm1H0BkY17behsPkwE+APWblud3HquzB0gGBMVCxbpdyy9Dx7h5vI3LoWIVI+hEW2e0z90MkfTU71JEPjnX+qNWkYfMl1pSUosIHFPAHz5hOwy2//zABj/4Ay0qlHjevTk4ww0C6YV9LbKAbypAl5KMP3XcArbQlLC87UGtVXI5ce8Mdt+nPmalYeunDak9j7mVH/qqtJN7m8zX0D1d4JVIvHbMRp/fAzR7/Eg2muxSIdrCssgbnXq2dgvdSy8t8yiGWMRs7kk8XpabqQmyWtqjg3/DoeQFrI6VuVJrELfSpak/QUENRDLAUXEvJKUSs2NCvLKI0zx4hnYD/8k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/2/11 11:43, Baoquan He wrote: > Nobody is using __tlb_remove_page() now, clean it up. > > Signed-off-by: Baoquan He > --- > include/asm-generic/tlb.h | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/include/asm-generic/tlb.h b/include/asm-generic/tlb.h > index e402aef79c93..9ae4ca02f29f 100644 > --- a/include/asm-generic/tlb.h > +++ b/include/asm-generic/tlb.h > @@ -489,12 +489,6 @@ static inline void tlb_remove_page_size(struct mmu_gather *tlb, > tlb_flush_mmu(tlb); > } > > -static __always_inline bool __tlb_remove_page(struct mmu_gather *tlb, > - struct page *page, bool delay_rmap) > -{ > - return __tlb_remove_page_size(tlb, page, delay_rmap, PAGE_SIZE); > -} > - > /* tlb_remove_page > * Similar to __tlb_remove_page but will call tlb_flush_mmu() itself when ^ please update this too Otherwise: Reviewed-by: Qi Zheng > * required.