From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A3EAC3DA4A for ; Fri, 9 Aug 2024 08:58:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B55706B0092; Fri, 9 Aug 2024 04:58:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B03066B0095; Fri, 9 Aug 2024 04:58:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A3D36B0098; Fri, 9 Aug 2024 04:58:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7C1186B0092 for ; Fri, 9 Aug 2024 04:58:28 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2449440B78 for ; Fri, 9 Aug 2024 08:58:28 +0000 (UTC) X-FDA: 82432105896.05.2B64D0D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id D97E21A001B for ; Fri, 9 Aug 2024 08:58:25 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="G/qMjnyt"; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723193854; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sML3YzZIz+yskWIrnpgB+yUBCfurqFCNy3lpq/CSMx0=; b=VtKm21ikZtkZ/RfZEpC/E+7Jukf364rvh7mHc9ct3NNnarEygMSdnJL9Y5FBZldiPKOURu K2zvXQK7rt8fNEYnydx4Nt+z5Au7JWqv4Y6Z94fXAFqkRJoKniCwI/cvcA5ll+C2nuCNB1 wAkj6NHLSGylIBryyp04ujhuLFkpcpA= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="G/qMjnyt"; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723193854; a=rsa-sha256; cv=none; b=np7gfsQ5vE8Mp0xWC/wlPGoeiIfjng9QQc/hKzo+O4NdPmH7lqtASLZJyhxQw7T0tI4w3F b/U1wUUPNLnbW0jkMpvH2vc23Q8QY3EdxvYQDixKdIYiwzTHFoN9FydqlHegJ9u7rgoQh5 T9LzHdWx2+rFEe25e77IuXlst67V9yc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723193905; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=sML3YzZIz+yskWIrnpgB+yUBCfurqFCNy3lpq/CSMx0=; b=G/qMjnytu7aX6MvdoJ2f7NB6X6/z7DWH1Q05i38RuXC2fcjHtsGjUSiJLWzyezW/GO88cS F0IOpEvdHdd5RkJ0cgNpYMbBHuftUUKNM56CHRqq/ewo1BlIk55a42ACvQMXY+oF48+Bnb ye0nD0L0WXa8nFCKV4liZG1PE0nzoeA= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-488-xfmARmmaNRWxpfBpD8Wluw-1; Fri, 09 Aug 2024 04:58:22 -0400 X-MC-Unique: xfmARmmaNRWxpfBpD8Wluw-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-36875698d0dso883959f8f.3 for ; Fri, 09 Aug 2024 01:58:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723193901; x=1723798701; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=sML3YzZIz+yskWIrnpgB+yUBCfurqFCNy3lpq/CSMx0=; b=q2uR1Fvow7evlEDUFsPoM2ZqFM9CEYb2LO060gagDA9yDyq3m8yKnVb66ww1JpZbdh f0qlduVbM7uPstX/f257AYAY4iRt/5sb5G2TdBcLB5zJG5uxpY+bX++o7QUdOa31yJDx BuP9LxIcsLSVCACZ3s1cYwvV8GuinHaA3ExWieuNyZpGyIWSdu7xfvIlHIpqlhYDIVcz MRb81qpNt0dp5vP8bPj7OhUZyGINqFxJEuVPDZNhoQTxv5SQYsMaWwq/OUkAhyfK3Mpp lFsMHS7NIrJ6gU6FlsUw7x6NB2DztIQqJtZRqA452zVhDAOYt+7RD+r3Hh9M6/7J4nKg roUA== X-Forwarded-Encrypted: i=1; AJvYcCVuJY2cjqnSfECI2b5vRIgUsQgfdLG51RBKLdqFycCmnnT/TX+jQx7yaAWXjiinmXsbH9HrsEJnp7aNacdNnVlf9IE= X-Gm-Message-State: AOJu0YzPwbxMnqophzuci7LIc31PgZhjzFrS6T1qQa1oD0nrGusIqM6L Khhzj1YRdm4RLDfh+0zd3Tg3fKicYj2L71FJp1lvpgI2O/mhneMVrkHTaQK9qvQ57QunNG/7weD iCYIK70R8zcFbNadql2exYZCiG7KynjDwC0f69UZbR/r1yNqc X-Received: by 2002:a5d:6341:0:b0:368:57dd:3822 with SMTP id ffacd0b85a97d-36d5eeddcffmr721707f8f.37.1723193900700; Fri, 09 Aug 2024 01:58:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFZq+4P4t4Ib46KVqzvqIXF5ENpZsB1z0y4AYNTNT1VkfdkzrrflyF1N0gKmu92npRa3XV/pg== X-Received: by 2002:a5d:6341:0:b0:368:57dd:3822 with SMTP id ffacd0b85a97d-36d5eeddcffmr721688f8f.37.1723193900196; Fri, 09 Aug 2024 01:58:20 -0700 (PDT) Received: from ?IPV6:2003:cb:c71c:4e00:b097:7075:f6ba:300a? (p200300cbc71c4e00b0977075f6ba300a.dip0.t-ipconnect.de. [2003:cb:c71c:4e00:b097:7075:f6ba:300a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36d340acfdasm1485050f8f.13.2024.08.09.01.58.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Aug 2024 01:58:19 -0700 (PDT) Message-ID: <616401ea-289d-4ae2-acde-6704b0fa9c46@redhat.com> Date: Fri, 9 Aug 2024 10:58:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 1/2] mm: collect the number of anon large folios From: David Hildenbrand To: Ryan Roberts , Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org Cc: chrisl@kernel.org, kaleshsingh@google.com, kasong@tencent.com, linux-kernel@vger.kernel.org, ioworker0@gmail.com, baolin.wang@linux.alibaba.com, ziy@nvidia.com, hanchuanhua@oppo.com, Barry Song References: <20240808010457.228753-1-21cnbao@gmail.com> <20240808010457.228753-2-21cnbao@gmail.com> <1222cd76-e732-4238-9413-61843249c1e8@arm.com> <4465afdc-23e9-4844-a0a0-519f49b1229c@redhat.com> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <4465afdc-23e9-4844-a0a0-519f49b1229c@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: abmkeegb8pjecy73xnmjftw1scyrweqs X-Rspam-User: X-Rspamd-Queue-Id: D97E21A001B X-Rspamd-Server: rspam02 X-HE-Tag: 1723193905-669021 X-HE-Meta: U2FsdGVkX1/TJN3a/UJ+XrKljejYtZ8wd677KoBKDWGmqKmitK4CrA6OCvP/R5i+I+WSCDdriQV27fJMkRNa3H2BGB8j56zG9Px9vFwlbnJcRjZO/avuKaYizsbTLRDQt+lMnhS7d5lVhthILGQ8ccGDgXECGr4ORL1dB3BTW5FXug2SgjjppARiGaSpTZduWmzUGBaFtUNQM/FBisGNrrJ1fKtpuojTlJqPEH6j+J2LZq/0UyL0O2PKVtF+CrcAZO41JQvui4xnpDOIZSJrz6zr2okYwaMtt1Zq/HD1f6CkCsg2UF5CxGFvkuLokjw4kZk8a3md5/3URHLNmQVmy4CZedLLLy44zP7gJJiNui8R8zZbmXyBRxq5qpLmeudTyS9uTliali+uX43a1Vl3V6UaE7E8TFDKJCe/5MS+aOx6StgAPyYOxtMPYm+j953plO0HJOmGwfleatVZj6etZSirK9t3WsDj402H3NVVkDqkietsVOo8hKvLibtqX7sIOsRzT91GgEkRrV5LSnBvJzrXl3IvI+Qi9M2ekVrYYfmbPkNjjc6t30MP2g/xGTDDzBusQzKpfeLQR3X2itKgbx7qRzQxzJGUn5O8FPpg4NQtKThbIni6HD7Ml8o/vcn4cZj8K39Kf5O8S0hMkB6+S0oO/Mf20QqWbXLZAazrHemWjkihzSAZ/ZwVCDcKNvGgqDC3n77zJcndSu4mZyA5TLb5uNm95tQnvEVu7dRb3Ca/72oxhsDmqfS1sJlmrLTrNtaVJF6zebY0cgb5jlazP8zThj4mZq5cpFNweUEKdG6zK9xlFLgEQVZMSChIXkt9SjjTBS2xNSEvdhSN6cco0i9u9gT9n+isz9ozrEz2usvnw37nCJl8dxg8C6SfVGmQMWEe0Es/cF2d/jgGZmUEvvw+P9zV37EgPoPkL4tawfCm9gUrYxqdN8C+FstiB0paEGHdRWpDc3WOW5Q+W0C WEhDCdaO /Z13wp+Lh/Jc0lYSD43iTMXmnyBf4nKTOHpujuPzT2APfviLcYi2hWSeYNjzNXzFG7DS1anixJ2Nmwou56bnIPM8IoLbOaNQgcyS996zFBMVCRs0z1ejZFBMTnHBcZV4zc/qyWKVqhtLQfVTDN/92lQXlqrhm7ANAUQ0s2XGAhMkW66B3ufkivINiZRPmspQ4BTleSo4tC5r2MgXETOR5yVMJZcQHj98f1MJnAjFmRlVG5wpa9KA+fTBhr646xzrqD3pL5BMje9EuhAJ02/cM/vBbE9Fvu5g/H2x8yExKSPL8OcN8+YLOvL37ZUVe8QSnoIC131T6r8EA8jyX7DFouZDvZPSPvVf9LqIhWlrWu6dR0mHn0Pj+oPlI/K3iDvTrdKmw684lrM2zEn8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09.08.24 10:42, David Hildenbrand wrote: >>> Not sure I fully understand why David prefers to do the unaccounting at >>> free-time though? It feels unbalanced to me to increment when first mapped but >>> decrement when freed. Surely its safer to either use alloc/free or use first >>> map/last map? >>> >>> If using alloc/free isn't there a THP constructor/destructor that prepares the >>> deferred list? (My memory may be failing me). Could we use that? >> >> Additionally, if we wanted to extend (eventually) to track the number of shmem >> and file mthps in additional counters, could we also account using similar folio >> free-time hooks? If not, it might be an argument to account in rmap_unmap to be >> consistent for all? > > Again, see NR_FILE_THPS handling. No rmap over-complication please. ... not to mention that it is non-sensical to only count pageache folios that are mapped to user space ;) -- Cheers, David / dhildenb