From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B981D3E2A1 for ; Mon, 28 Oct 2024 18:29:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B51676B00A1; Mon, 28 Oct 2024 14:29:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AD9AB6B00A2; Mon, 28 Oct 2024 14:29:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 97B146B00A3; Mon, 28 Oct 2024 14:29:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 755266B00A1 for ; Mon, 28 Oct 2024 14:29:45 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2B59514090B for ; Mon, 28 Oct 2024 18:29:45 +0000 (UTC) X-FDA: 82723848228.09.6794FE0 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf19.hostedemail.com (Postfix) with ESMTP id 02A691A0005 for ; Mon, 28 Oct 2024 18:29:13 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=KKZ+EjwX; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of broonie@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730140009; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XTX4KSH892M9KCDEUXteNEyOJqf4RXIrerMOF5tPv5o=; b=z5kd35wtPkvGyWv7fW5cZIqiA7zm7Rm4Mjl2IF1MoJxlsPqF1oyW0pBDes0JdyDoR/tKup AYwiIsTHRjfp7SU3YE/27oBs1iMAG3zbUrz5YtpomtkU4rfd92xVDrux40ZAznyh4yV5KI RKPF265Glmvz49natCB6Wx9Rsr30xUc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730140009; a=rsa-sha256; cv=none; b=IAkjdz8m1YQMMCZAWtOAkTuNlqI/6DcZ3uKcEhXmIAeniOAptRvYtm0aaE7a7U/GNMwVOS 5rCdYRYTTTAU4AYzNt0CCpzvKRFznPzeacgT+wQKNegRY4eVFXpDOe8x0jq843V4RSAi6k JFhrJaYrk21O8b3TwFf8J8UkX8p/ynU= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=KKZ+EjwX; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of broonie@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=broonie@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id B5EA0A42AE0; Mon, 28 Oct 2024 18:27:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 685AFC4CEC3; Mon, 28 Oct 2024 18:29:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730140182; bh=8OmpXILBuI+6wKvs6RAK06K+NY8fg730oVtwqZY18UQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KKZ+EjwX/7ENZi02x0H84gmYRS+6nYEdTYYmv3JVRcIYUiL0g8alPTrZJb/wRgz4K wnwK+MTAQAAEh1fuI+T8wKQ8T6OI0ZoXv9HzFnUs0R0L6I62Xx7WtYMEHA8R8NH/yA wQemdJeMWet1dUmuqPEQEdScuLJw/4IHhKXR+arYs5mvUvGHHDTToPxWTyiBmQ5wVv fS9qgCgrcvFZLXz/Jm9cdhUh+eX31wEbPBLJhuuE+ku1bmxHLR4Y6ggrc17qdTSRsz Rpu0J8LrsZ5ZOgWoBbMURK+7smXajPukz1umnwtdS/3El/Jc1t3HFZXrPiFN1oWRdH XuxUslM5c2Hyg== Date: Mon, 28 Oct 2024 18:29:36 +0000 From: Mark Brown To: Lorenzo Stoakes Cc: Andrew Morton , "Liam R . Howlett" , Vlastimil Babka , Jann Horn , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Linus Torvalds , Peter Xu , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Aishwarya TCV Subject: Re: [PATCH hotfix 6.12 v2 4/8] mm: resolve faulty mmap_region() error path behaviour Message-ID: <61461dcc-e455-450d-9c01-5465003fc31c@sirena.org.uk> References: <6e8deda970b982e1e8ffd876e3cef342c292fbb5.1729715266.git.lorenzo.stoakes@oracle.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="AN/SqrqcdGLKIaZP" Content-Disposition: inline In-Reply-To: <6e8deda970b982e1e8ffd876e3cef342c292fbb5.1729715266.git.lorenzo.stoakes@oracle.com> X-Cookie: Results vary by individual. X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 02A691A0005 X-Stat-Signature: 7ihjbasun6c31mqnaizoyt1ttns7tuch X-Rspam-User: X-HE-Tag: 1730140153-126908 X-HE-Meta: U2FsdGVkX1/YrDIzRdUJQBrlXsjGARt56IUhh68Lj7e3TRIVP+InxVTZ+mK0mRY1mFfhe+VjorapW4hUpRFg40ozly0jElqA+sKS/SxpN/+LqaOLjdcTSKzZPBSkSDNsNj2D3R7Ce1JRAgBxU/CHmaeR7vjiouSncGrHd2qknTTCasbLQW70PbpmyXgAKJ+uSwxi+p0U9iFq3v9Y+9MGhTCzbB19QQFvmNy4/OPNC+E6Bisv8hBuiSO3N4SBo9g5JplWsp51o0QG8PmBgURT2+rBDypc1MQ89gUYUwITzt76MCDiZpzu9qZEtsFqF2VhoFE+7dwk6XXGBQGI7x9SPt3pfn8izsRvkEWNLyA0FevNL4qV18KbBnFPhmYZC7jKQMLBvlOUfH7CadNBQ8GMdKnysiT0YfYeUfeiY17pWF9lZfhlSEnMCJrIoHmdnjpvtxrtbsDQ7s6Oa8qD7tOtCPjJZu3jfMjCpPy9bHMJag5J3rrCAnzSW98ubXkBQnRsS1X42JMX+Xj+UC6uDRuyQmpd8zJ+su1BXiYroq4+SsCXl3NT5YPZw4gb5YLTKG2hXPg7oQw+WjmKxXSPHnw6FtZy7/HybFWhLwFqO7nlh3Azk1vWNDFQsaw+e34rviTXOp1eU7/1p2VV+hoOemJ0KBh0IQu0VdsgUkFhw1kNeGuREVUFiyNsrkFAsDvwbA1jRySaYGX3IcYmr0NHYmHMqaNfesQ9ODsDVvb43chglFfSp8bWKzKwj6kxTwueYXfQtzP5y7c1gWBOk+fj+EcXqYyvG30POJFZ2AMaVrYRN7BP0xnGfGPT5WZr3KagdG8PEIYZAB3nsLpit05DCYOTm9y7y/xqNKD0Bb2iH6nsUGIZqnHxm2XTqFNTDFIMukyjExP2IO4dXdgBPGmpslrLL6zK3wB/bmu8gsZlHW4rUCMDgftaYYdXVSyWsP6K66POcGzr8A7jcXzjcIkQL80 YLWb7YTz zUSnLTSwLHOodmv58rFFw4n0ZVaGCai4kh8krX8MZ1SjqbmraI9himTkD9vgtgf1FWgLA0215UBwJM+Qaq4PWrL1LTpb+Y7EOo4y2LSE9z2UYy2e675uDvFHPeKDbY9bgVgIILCV7Q7eZfvGtKiKv2C0FxwMIXsXfG1HqZ0NLVGu+923G0Ve2zjmQ28h1POSeBqQy1FsTxjl/gujy/zgrQdT+fbsa4h4NPFs51oGtQkemIuK8bJERbqd/RxVChtd39/U+otHEuKapxWB9olxpgrv//l5wx4z3cjwhhJQ0/tMxuPBv3fOBlYS/i1YNLTFv1LypcGePLBTJvKegcWpmNAEVcAdBg7KPCG66LL1QVJPtwxxf04eGVQwpj4gqdMukBJRK9fA+Hc0axtzAVNdfTwfpLjdYNBVqcy640kS7ga8GYX19Z84pmjL5CjzA7l8VB3uyKZ/nueJHlWZBkVPRBjWEhyf7GGRPgx8vP0/5CcQsqWrKtrgPmbAFD+MLH3P2JeDB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --AN/SqrqcdGLKIaZP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Oct 23, 2024 at 09:38:29PM +0100, Lorenzo Stoakes wrote: > The mmap_region() function is somewhat terrifying, with spaghetti-like > control flow and numerous means by which issues can arise and incomplete > state, memory leaks and other unpleasantness can occur. Today's pending-fixes is showing a fairly large set of failures in the arm64 MTE selftests on all the platforms that have MTE (currently just the software ones). Bisection points at this change which is 0967bf7fbd0e0 in -next which seems plausible but I didn't investigate in any meaingful detail. There's nothing particularly instructive in the test logs, just plain reports that the tests failed: # # FAIL: mmap allocation # # FAIL: memory allocation # not ok 17 Check initial tags with private mapping, sync error mode and mmap memory # ok 18 Check initial tags with private mapping, sync error mode and mmap/mprotect memory # # FAIL: mmap allocation # # FAIL: memory allocation # not ok 19 Check initial tags with shared mapping, sync error mode and mmap memory # ok 20 Check initial tags with shared mapping, sync error mode and mmap/mprotect memory # # Totals: pass:18 fail:2 xfail:0 xpass:0 skip:0 error:0 not ok 42 selftests: arm64: check_buffer_fill # exit=1 (and more, mainly on mmap related things). A full log for a sample run on the FVP can be seen at: https://lava.sirena.org.uk/scheduler/job/901638#L3693 and one from qemu here: https://lava.sirena.org.uk/scheduler/job/901630#L3031 Both of these logs include links to filesystem/firmware images and command lines to run the model. Bisects converge cleanly (there's some random extra good commits logged at the start as my tooling feeds test results it already has on hand between the good and bad commits into the bisect): # bad: [6560005f01c3c14aab4c2ce35d97b75796d33d81] Merge branch 'for-linux-next-fixes' of https://gitlab.freedesktop.org/drm/misc/kernel.git # good: [ea1fda89f5b23734e10c62762990120d5ae23c43] Merge tag 'x86_urgent_for_v6.12_rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip # good: [6668610b4d8ce9a3ee3ed61a9471f62fb5f05bf9] ASoC: Intel: sst: Support LPE0F28 ACPI HID # good: [2feb023110843acce790e9089e72e9a9503d9fa5] regulator: rtq2208: Fix uninitialized use of regulator_config # good: [0107f28f135231da22a9ad5756bb16bd5cada4d5] ASoC: Intel: bytcr_rt5640: Add DMI quirk for Vexia Edu Atla 10 tablet # good: [25f00a13dccf8e45441265768de46c8bf58e08f6] spi: spi-fsl-dspi: Fix crash when not using GPIO chip select # good: [032532f91a1d06d0750f16c49a9698ef5374a68f] ASoC: codecs: rt5640: Always disable IRQs from rt5640_cancel_work() # good: [d48696b915527b5bcdd207a299aec03fb037eb17] ASoC: Intel: bytcr_rt5640: Add support for non ACPI instantiated codec # good: [d0ccf760a405d243a49485be0a43bd5b66ed17e2] spi: geni-qcom: Fix boot warning related to pm_runtime and devres # good: [f2b5b8201b1545ef92e050735e9c768010d497aa] spi: mtk-snfi: fix kerneldoc for mtk_snand_is_page_ops() # good: [b5a468199b995bd8ee3c26f169a416a181210c9e] spi: stm32: fix missing device mode capability in stm32mp25 git bisect start '6560005f01c3c14aab4c2ce35d97b75796d33d81' 'ea1fda89f5b23734e10c62762990120d5ae23c43' '6668610b4d8ce9a3ee3ed61a9471f62fb5f05bf9' '2feb023110843acce790e9089e72e9a9503d9fa5' '0107f28f135231da22a9ad5756bb16bd5cada4d5' '25f00a13dccf8e45441265768de46c8bf58e08f6' '032532f91a1d06d0750f16c49a9698ef5374a68f' 'd48696b915527b5bcdd207a299aec03fb037eb17' 'd0ccf760a405d243a49485be0a43bd5b66ed17e2' 'f2b5b8201b1545ef92e050735e9c768010d497aa' 'b5a468199b995bd8ee3c26f169a416a181210c9e' # bad: [6560005f01c3c14aab4c2ce35d97b75796d33d81] Merge branch 'for-linux-next-fixes' of https://gitlab.freedesktop.org/drm/misc/kernel.git git bisect bad 6560005f01c3c14aab4c2ce35d97b75796d33d81 # bad: [4a2901b5d394f58cdc60bc25e32c381bb2b83891] Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless.git git bisect bad 4a2901b5d394f58cdc60bc25e32c381bb2b83891 # bad: [4093d34d740447b23a1ea916dabcf902aa767812] Merge branch 'fs-current' of linux-next git bisect bad 4093d34d740447b23a1ea916dabcf902aa767812 # bad: [0967bf7fbd0e03cee0525035762150a91ba1bb7c] mm: resolve faulty mmap_region() error path behaviour git bisect bad 0967bf7fbd0e03cee0525035762150a91ba1bb7c # good: [633e7df6cfdf97f8acf2a59fbfead01e31d0e492] tools: testing: add expand-only mode VMA test git bisect good 633e7df6cfdf97f8acf2a59fbfead01e31d0e492 # good: [315add1ace71306a7d8518fd417466d938041ff1] mseal: update mseal.rst git bisect good 315add1ace71306a7d8518fd417466d938041ff1 # good: [bcbb8b25ab80347994e33c358481e65f95f665fd] mm: fix PSWPIN counter for large folios swap-in git bisect good bcbb8b25ab80347994e33c358481e65f95f665fd # good: [8438cf67b86bf8c966f32612a7e12b2eb910396b] mm: unconditionally close VMAs on error git bisect good 8438cf67b86bf8c966f32612a7e12b2eb910396b # good: [a220e219d89c2d574ad9ffda627575e11334fede] mm: refactor map_deny_write_exec() git bisect good a220e219d89c2d574ad9ffda627575e11334fede # first bad commit: [0967bf7fbd0e03cee0525035762150a91ba1bb7c] mm: resolve faulty mmap_region() error path behaviour --AN/SqrqcdGLKIaZP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmcf2A8ACgkQJNaLcl1U h9Ax4Af/Vm4bnquLf/9D2o7eiOwiYvrtHWp4UiY1AuXoe5f/eJCSwNvhaFpdcUqb 5mV1GuTj7LTJ/eGz/Shd4HLB61WcWrWBiUGa4xPswMJYrUsjpmWhz8M2gW28Hftx RVT3lBUFm0ggGwW28fmQolEcxlzemFF00our0Mw+DWvic4pdWiG4K7q4Q6NtY+C9 SjOdtYEBuvthbmyrdJkfwePdOnc3k/ZbkDgSsySclvSqIPYWp9C5O3PP/oLyziz9 4IduHyuJ3AeJ6l2xxeXfrXiBxM1CputDNr1O2SqXFB4Dc+Je2LMY/n5UBY/OB2fM Roib+Pv1dBYudYiThz9RaCpktKZbrQ== =u0Vu -----END PGP SIGNATURE----- --AN/SqrqcdGLKIaZP--