From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73F0AC433E0 for ; Thu, 11 Jun 2020 11:33:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 24EB520760 for ; Thu, 11 Jun 2020 11:33:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eQPYi7fu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 24EB520760 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B97B98D0098; Thu, 11 Jun 2020 07:33:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B21258D0084; Thu, 11 Jun 2020 07:33:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A19ED8D0098; Thu, 11 Jun 2020 07:33:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0195.hostedemail.com [216.40.44.195]) by kanga.kvack.org (Postfix) with ESMTP id 8344E8D0084 for ; Thu, 11 Jun 2020 07:33:11 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 3CD9D801C5D3 for ; Thu, 11 Jun 2020 11:33:11 +0000 (UTC) X-FDA: 76916719782.15.care32_2106f7526dd3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id 0C0E71814C509 for ; Thu, 11 Jun 2020 11:33:11 +0000 (UTC) X-HE-Tag: care32_2106f7526dd3 X-Filterd-Recvd-Size: 9116 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Thu, 11 Jun 2020 11:33:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591875189; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WfJS7MFBfhpSfT92H5Xzf5630oX/SV35fbP14C0fT/M=; b=eQPYi7fuZSEy4J9ANd+g4vQiqWUNMaZaCrpnLoMmAlSI4BIORO2Kdi1U+U7Gk9WCgMBwdc HcZ9m6QuBkEhiPW3aBDVwzKWJ1GX1JKJ7q8OBZYxqB9pgo1Ch0gROOFfYifwp/1U3Xqe+6 ejktCJakH1YYoizqNukbrvZvXsFCE44= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-475-sWryF5IUMh-LSagMIHHoxg-1; Thu, 11 Jun 2020 07:33:07 -0400 X-MC-Unique: sWryF5IUMh-LSagMIHHoxg-1 Received: by mail-wm1-f71.google.com with SMTP id p24so1011981wma.4 for ; Thu, 11 Jun 2020 04:33:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=2dIQ6RqotB/k3O/m27HZrFUYODkeA8BdBJOrJFzbkOQ=; b=IBiFOAy5p3Kd/oXbZzMSR0eEJiewlk61GV9mmt1iqK3s8+Agaxh1Y3XIFouW8G+NFp N1fkbK/M/xegBOrGgMkHWuTztBAzpsHYep+EOFn0vKVrNOb/uTqbmWklAt06o1xTs7W9 tGtuKoG9Q+R5u0aIC4BarYAe8PuaYzm6hk+6X37zvwq15UcmONtPVQPedIhENXFzXgPd nqMCuswStOsfT29CCTVGg7rUZPi6v/1LTvhkW9MAhObZDG9wZdD+C4bXd40o95bqcK9z eXOvtwK4+FfLToG28LqrkO0eQBtxpmRWBmyu6Xh9H5NmCM3+eLflnVQ6tcJYh/KWp619 t2HQ== X-Gm-Message-State: AOAM530Q1KURkhuKPQsTHebo+6eMRdOotRU63PHBePIaAy/Hso51xkiC 3OeDSxPQomzC5lC80fRg7kgg/NnJ0LTfa/3cfvoC3mECr+9KOSFgw8w0tYVKWD0RqGo6IYPgjYD YQKnTc3UQJPg= X-Received: by 2002:a1c:3987:: with SMTP id g129mr7761443wma.139.1591875186242; Thu, 11 Jun 2020 04:33:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzITmqYJue/6h7gE6EEmJk49t3YKpLGBtczqqyWVB6G8GeCFtE8WXdsatoDXXqRHe8AN7iMpA== X-Received: by 2002:a1c:3987:: with SMTP id g129mr7761420wma.139.1591875185963; Thu, 11 Jun 2020 04:33:05 -0700 (PDT) Received: from ?IPv6:2a01:598:b907:8575:cdbd:bd6:4dce:9256? ([2a01:598:b907:8575:cdbd:bd6:4dce:9256]) by smtp.gmail.com with ESMTPSA id w1sm3728533wmi.13.2020.06.11.04.33.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jun 2020 04:33:05 -0700 (PDT) From: David Hildenbrand Mime-Version: 1.0 (1.0) Subject: Re: [PATCH v1] virtio-mem: add memory via add_memory_driver_managed() Date: Thu, 11 Jun 2020 13:33:04 +0200 Message-Id: <613382D2-5F4D-4A32-AC8E-E1D03240036F@redhat.com> References: <20200611071744-mutt-send-email-mst@kernel.org> Cc: David Hildenbrand , linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtio-dev@lists.oasis-open.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, Jason Wang , Pankaj Gupta , teawater In-Reply-To: <20200611071744-mutt-send-email-mst@kernel.org> To: "Michael S. Tsirkin" X-Mailer: iPhone Mail (17E262) X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary=Apple-Mail-3BDDA998-C2BD-49D8-8575-72FA81B00AAD X-Rspamd-Queue-Id: 0C0E71814C509 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --Apple-Mail-3BDDA998-C2BD-49D8-8575-72FA81B00AAD Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable > Am 11.06.2020 um 13:18 schrieb Michael S. Tsirkin : >=20 > =EF=BB=BFOn Thu, Jun 11, 2020 at 01:00:24PM +0200, David Hildenbrand wrot= e: >>>> I'd like to have this patch in 5.8, with the initial merge of virtio-m= em >>>> if possible (so the user space representation of virtio-mem added memo= ry >>>> resources won't change anymore). >>>=20 >>> So my plan is to rebase on top of -rc1 and merge this for rc2 then. >>> I don't like rebase on top of tip as the results are sometimes kind of >>> random. >>=20 >> Right, I just wanted to get this out early so we can discuss how to proc= eed. >>=20 >>> And let's add a Fixes: tag as well, this way people will remember to >>> pick this. >>> Makes sense? >>=20 >> Yes, it's somehow a fix (for kexec). So >>=20 >> Fixes: 5f1f79bbc9e26 ("virtio-mem: Paravirtualized memory hotplug") >>=20 >> I can respin after -rc1 with the commit id fixed as noted by Pankaj. >> Just let me know what you prefer. >>=20 >> Thanks! >=20 > Some once this commit is in Linus' tree, please ping me. It already is as mentioned, only the id was wrong. https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/= ?id=3D7b7b27214bba1966772f9213cd2d8e5d67f8487f >=20 >> --=20 >> Thanks, >>=20 >> David / dhildenb >=20 --Apple-Mail-3BDDA998-C2BD-49D8-8575-72FA81B00AAD Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable


Am 11.06.2020 um 13:18 schrieb Michael S= . Tsirkin <mst@redhat.com>:

=EF=BB=BFOn Thu, Jun 11, 2020 at 01:00:24= PM +0200, David Hildenbrand wrote:
I'd like to have this= patch in 5.8, with the initial merge of virtio-mem
=
if possible (so the user space represent= ation of virtio-mem added memory
resources won't change anymore).
=
So my plan is to rebase on top of -rc1 and merge = this for rc2 then.
I don't like rebase on top of tip as = the results are sometimes kind of
random.

Right, I just wanted to get this out ear= ly so we can discuss how to proceed.

And let's add a Fixes: tag as well, this way people= will remember to
pick this.
Makes se= nse?

Yes, it's somehow a f= ix (for kexec). So
<= /span>
Fixes: 5f1f79bbc9e26= ("virtio-mem: Paravirtualized memory hotplug")

I can respin after -rc1 with the commit id fixed as noted by Panka= j.
Just let me know = what you prefer.

Thanks!

Some once this commit is in Linus' tree, pl= ease ping me.

It already i= s as mentioned, only the id was wrong.



--
Thanks,

David / dhildenb

--Apple-Mail-3BDDA998-C2BD-49D8-8575-72FA81B00AAD--