From: Chengming Zhou <chengming.zhou@linux.dev>
To: SeongJae Park <sj@kernel.org>
Cc: "Liam R. Howlett" <Liam.Howlett@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Jonathan Corbet <corbet@lwn.net>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Michal Hocko <mhocko@suse.com>, Mike Rapoport <rppt@kernel.org>,
Nhat Pham <nphamcs@gmail.com>,
Suren Baghdasaryan <surenb@google.com>,
Vlastimil Babka <vbabka@suse.cz>,
Yosry Ahmed <yosry.ahmed@linux.dev>,
kernel-team@meta.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 4/4] Docs/admin-guide/mm/zswap: s/red-black tree/xarray/
Date: Thu, 9 Oct 2025 11:03:56 +0800 [thread overview]
Message-ID: <612e4576-437f-4c63-b56a-fa2ad62779b9@linux.dev> (raw)
In-Reply-To: <20251003203851.43128-5-sj@kernel.org>
On 2025/10/4 04:38, SeongJae Park wrote:
> The change from commit 796c2c23e14e ("zswap: replace RB tree with
> xarray") is not reflected on the document. Update the document.
>
> Signed-off-by: SeongJae Park <sj@kernel.org>
Reviewed-by: Chengming Zhou <chengming.zhou@linux.dev>
> ---
> Documentation/admin-guide/mm/zswap.rst | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/admin-guide/mm/zswap.rst b/Documentation/admin-guide/mm/zswap.rst
> index 283d77217c6f..2464425c783d 100644
> --- a/Documentation/admin-guide/mm/zswap.rst
> +++ b/Documentation/admin-guide/mm/zswap.rst
> @@ -59,11 +59,11 @@ returned by the allocation routine and that handle must be mapped before being
> accessed. The compressed memory pool grows on demand and shrinks as compressed
> pages are freed. The pool is not preallocated.
>
> -When a swap page is passed from swapout to zswap, zswap maintains a mapping
> -of the swap entry, a combination of the swap type and swap offset, to the
> -zsmalloc handle that references that compressed swap page. This mapping is
> -achieved with a red-black tree per swap type. The swap offset is the search
> -key for the tree nodes.
> +When a swap page is passed from swapout to zswap, zswap maintains a mapping of
> +the swap entry, a combination of the swap type and swap offset, to the zsmalloc
> +handle that references that compressed swap page. This mapping is achieved
> +with an xarray per swap type. The swap offset is the search key for the xarray
> +nodes.
>
> During a page fault on a PTE that is a swap entry, the swapin code calls the
> zswap load function to decompress the page into the page allocated by the page
prev parent reply other threads:[~2025-10-09 3:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-03 20:38 [PATCH 0/4] mm/zswap: misc cleanup of code and documentations SeongJae Park
2025-10-03 20:38 ` [PATCH 1/4] mm/zswap: remove unnecessary dlen writes for incompressible pages SeongJae Park
2025-10-07 23:40 ` Yosry Ahmed
2025-10-08 15:45 ` Nhat Pham
2025-10-09 3:02 ` Chengming Zhou
2025-10-03 20:38 ` [PATCH 2/4] mm/zswap: fix typos: s/zwap/zswap/ SeongJae Park
2025-10-07 23:40 ` Yosry Ahmed
2025-10-08 15:46 ` Nhat Pham
2025-10-09 3:02 ` Chengming Zhou
2025-10-03 20:38 ` [PATCH 3/4] mm/zswap: s/red-black tree/xarray/ SeongJae Park
2025-10-07 23:41 ` Yosry Ahmed
2025-10-08 15:46 ` Nhat Pham
2025-10-09 3:03 ` Chengming Zhou
2025-10-03 20:38 ` [PATCH 4/4] Docs/admin-guide/mm/zswap: " SeongJae Park
2025-10-07 23:42 ` Yosry Ahmed
2025-10-08 15:48 ` Nhat Pham
2025-10-09 3:03 ` Chengming Zhou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=612e4576-437f-4c63-b56a-fa2ad62779b9@linux.dev \
--to=chengming.zhou@linux.dev \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@meta.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=nphamcs@gmail.com \
--cc=rppt@kernel.org \
--cc=sj@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=yosry.ahmed@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox