From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB39DC3DA42 for ; Wed, 10 Jul 2024 18:49:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F7316B009C; Wed, 10 Jul 2024 14:49:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A6FB6B00A1; Wed, 10 Jul 2024 14:49:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26E726B00A2; Wed, 10 Jul 2024 14:49:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 08AA56B00A1 for ; Wed, 10 Jul 2024 14:49:24 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7A4A614021B for ; Wed, 10 Jul 2024 18:49:23 +0000 (UTC) X-FDA: 82324731006.23.838053E Received: from mail-oa1-f44.google.com (mail-oa1-f44.google.com [209.85.160.44]) by imf06.hostedemail.com (Postfix) with ESMTP id A8FE7180007 for ; Wed, 10 Jul 2024 18:49:21 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ckmx30le; spf=pass (imf06.hostedemail.com: domain of hughd@google.com designates 209.85.160.44 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720637329; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CDzDoDBPrI9O45fu4nDGF7EewD4QPEbaHsgpGnRS9bA=; b=BSU164n9vjOzRsFMyf3yp1+raC+VMT2y7ACFXGIYD45gbp6qAjQLl+/dDXLgOYzipUX8NY lKLi79ZKeHbkMxVvp3qVmg/44I/1ghu3p8aiir6LNTTUf9xBjNmZdp35cwxqgvorXQI4Y2 D3PFWJCZzs40lQMzdK3sKJWi3nMYATM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720637329; a=rsa-sha256; cv=none; b=407imWTXV9oR42WfJDtfnhiEopOsssy3gFxhtOKKQF3hrom6XhhNOFgozuyvD+A/dthtsc bf+hV0/wHmp3s+eMcUlQtZUHi+UgqZw1rviG8bI08m+y8a4bbEdFHWo6TenaQwrWH6Lgcc +OizNM/qx23QH1HnQALugh2TOZuaom8= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ckmx30le; spf=pass (imf06.hostedemail.com: domain of hughd@google.com designates 209.85.160.44 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-oa1-f44.google.com with SMTP id 586e51a60fabf-25e2cc76becso66785fac.3 for ; Wed, 10 Jul 2024 11:49:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1720637360; x=1721242160; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=CDzDoDBPrI9O45fu4nDGF7EewD4QPEbaHsgpGnRS9bA=; b=ckmx30le5nGgkmys5R9Y+gwPzI1xsCjCWSyiGQWnfkfwEZalHQ59FNWS8QL8OKNB40 qEMD8FcQUx/qSLppuDrsUxGEAa2w/t/lylSe5zkQ8jdl29JgeTGk9/4ZtZMfRexO+AE4 hmRZn1ENXDGogE1MnqA9lupFbFd5D5vMgaaR2U+xgtfGteKgZfAYy4h0G2NHEOGlZ/94 IjxrPWPXQ6z4gKuGOR6rdXpEOVPPBD6Z+iewK+4DITysoJ3leac4050pItBLqg+ryE1t sqHmTjC5Ilf9RVVgoNVue47hmnRl8x0sLXl1b1qG1Ur/c17oaEOXpRGJh1wVPcsTA0vY kLdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720637360; x=1721242160; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CDzDoDBPrI9O45fu4nDGF7EewD4QPEbaHsgpGnRS9bA=; b=XKSRkph20MPkFae7QgvF3+VgbRwJQEhNuNuJlbIfQNz1CtmLo7ohTl7o5B4gu0W/0p kKujxh2aFD/gmiP95JQrYwjliqnUo08CBFWga1RdxTIqRhmG27bi8NM56mps/ZJdgiA3 CGbdonspvjhrJwD3Hn9DV5ifg5+5it6/mglLorj0ftw5/HcWTxMb7CegLYxN5oRyehTh j9n9Lqj4hscLErzE/DxYF8a93lwN51PALwXnivy8/Uqq5samn795TndbI1/wbqvHFQkf lmiAQVUHBLp/znOOTs2fvdWP2woEFlq8/9ApYb987nw/o5vI8gLP/qewLjccL/foUidE FYkA== X-Forwarded-Encrypted: i=1; AJvYcCWifu1Wwhmea9jHTIYS8MyLWGETPULG01GK7BSCx6xAiv00QtoCJZkE5vZoE95lL2MszUqZR+RyOfDH2+quq1SNc5A= X-Gm-Message-State: AOJu0YzKXuLqTsI23Me4OsKtMRXHepSy+Yx0mOC/YI2qItUvMVTpBnCn OOGRJY2n7QrAnORFQFy+Ql+T3kBO4DTwFcc9/qipEWsc3jcBmxGM/BMvjQV4pQ== X-Google-Smtp-Source: AGHT+IGpNu9mEuoMmeAlVedGx8Nyw0EmBMtvokuZhBygl5S2JzWgS4Wea6kyWyOlMeLcWyY/SXZaig== X-Received: by 2002:a05:6870:71c4:b0:254:d147:f256 with SMTP id 586e51a60fabf-25eae749f6dmr5489335fac.8.1720637360470; Wed, 10 Jul 2024 11:49:20 -0700 (PDT) Received: from darker.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-25eaa078407sm1336933fac.27.2024.07.10.11.49.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jul 2024 11:49:19 -0700 (PDT) Date: Wed, 10 Jul 2024 11:49:09 -0700 (PDT) From: Hugh Dickins To: Usama Arif cc: kernel test robot , Andrew Morton , Johannes Weiner , oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , Chengming Zhou , Yosry Ahmed , Nhat Pham , David Hildenbrand , "Huang, Ying" , Hugh Dickins , Matthew Wilcox , Shakeel Butt , Andi Kleen , linux-kernel@vger.kernel.org, ltp@lists.linux.it Subject: Re: [linux-next:master] [mm] 47325a5c88: WARNING:at_mm/slub.c:#free_large_kmalloc In-Reply-To: <4bc6400e-6199-4147-9399-4a54c94613fd@gmail.com> Message-ID: <612af749-0a59-f91d-693a-43d6217ffebb@google.com> References: <202407101031.c6c3c651-lkp@intel.com> <053bd429-ae19-4beb-a733-a7a838b1e010@gmail.com> <4bc6400e-6199-4147-9399-4a54c94613fd@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A8FE7180007 X-Stat-Signature: cs9z8uodgi4mo39smeeaeokmyadkbr3b X-HE-Tag: 1720637361-956910 X-HE-Meta: U2FsdGVkX1/miz/YwhcWU/3erq5j6eui5hAVb+ZVSPIj3jOYh4xdeEXCSRPCQiuXh8BIjNy1oLwmefbmb0Q9VbbQVq2Wz7e1VFFK/+3NnL/lQ8ttuF66IlEhDRI8wmbbmJRGDPEElp/Oak+nxxqk1+zIHHPKFn6OGgiEAmqh0adENyIzqQgQPxn7kfQy+xMbwgY6hBUSS8jmbOK7R9Z0djXB33Dtu6IylXirF7YGZZiK49GUU4Hht0k67w6lXnZyxuaUg0sZbeSuoidxXZYmsk1W9wGT0P+sJc7PojePHyUlriZcMfnmcRWHq3IdTsJI/FnUPmKkQgQ15mSc/nYr7N8/W9Hn32ecjgfTs6j2bqnrn7f6MJpjqPgHoYCmESFPX+qMSbMKU4kdj5matnybYEJ/UWllaLbusUqu169T8UHpak69DdDaSlPbzIAY8ZOAIqVssZuuINUgdBwMS4TwhrwGdQGMWZ9zoQjtAy3GqA1r79HbM6m+A6tTLsxXh4nrABleVttYXs28V/Pxa5VAoh7r/LUH3yH3cSYbF+Bc2k54VkUnLnMljWmd0I2XJouMh+mSmiUIk+Ij9Crz+q/e23qKFRjHsquzaIIg2o613ngFBNPH91I6ADK3+9UTEh3YYeIuMDYjm7ezlG+Wt1S4Kms8Z1QLhPxQKm885sM7LxHdwHh3KAL+4hQQBr7ppqZ3DjuJKaZzjKsLaR6QZC39xTfJqR43tAXMg+SbZhQDgToT8kyDZ6pTxScB9FD0+B+RTSD23LEfmQc4jWnPrMSGnNASdW+4zglqVL2+muqN9QPDFP0YyvdThGGOsvh1CsDnK6NVfqL2g2nz4vIKjTTM9XZPea07DWfhrX3zmIcT56/yD798VefbZbCzfFtV0as9EqawdjSL/C85Uhs3FDLs6m0l3ieNdI2L2athdsXNcgWauTEH8njh946GK3GgqfSzc5shkYo67+YyTQSZL9I YMgTgvUC 18NBh5oSdhin4ETDNfV+3X9kl/pxjWCPGWhWMduSwGQKC1O1bpgh2lwS1lIeBnAGBYZIOQ3ZX/cqjoFPIwxGYnO9L7yGvA1GkXk2PovDeezn1qIJT2ObJ1LsM/XXEgUPg+GQuvSxMtamGH5JHJQi+Y3OQBxjfxR1Yt434IybuDq916McSXzxlOjhp7TjwblAd7YmTYC6Ez6gIj9LN6ZNYdpNv7lvHlUAKnVD8EqEC8hHeIOPJL7ZE9/8G/OJWePZ0HWPP9hqMuSCW7HHa1Ikt++wlNKEOaGb6XUoyE12ELcAwH14= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: It's a long time since I was active hereabouts, but the bot report and your flurry of updates make me think that you should step back, slow down, and look more carefully at the precedents here. IIRC, the main problem is that parts of the swap_info_struct can still be in use from before while you're wanting to set up new values. Observe how alloc_swap_info() may return a fresh or an old allocation. Observe how enable_swap_info() is called after getting swapon_mutex late in swapon(), once past all possiblities of error. I expect that your new zeromap needs to be taking the same care as is taken with swap_map and cluster_info: to be safe, follow their example in both swapon() and swapoff(). Hugh