linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Li Wang <liwang@ubuntukylin.com>
To: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Sage Weil <sage@inktank.com>,
	linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, Li Wang <liwang@ubuntukylin.com>,
	Yunchuan Wen <yunchuanwen@ubuntukylin.com>
Subject: [PATCH 5/5] VFS: Extend drop_caches sysctl handler to allow directory level cache cleaning
Date: Mon, 16 Dec 2013 07:00:09 -0800	[thread overview]
Message-ID: <612334c18d31f67fb41416638f40cdf090062140.1387205337.git.liwang@ubuntukylin.com> (raw)
In-Reply-To: <cover.1387205337.git.liwang@ubuntukylin.com>
In-Reply-To: <cover.1387205337.git.liwang@ubuntukylin.com>


Signed-off-by: Li Wang <liwang@ubuntukylin.com>
Signed-off-by: Yunchuan Wen <yunchuanwen@ubuntukylin.com>
---
 fs/drop_caches.c |   45 +++++++++++++++++++++++++++++++++++++--------
 1 file changed, 37 insertions(+), 8 deletions(-)

diff --git a/fs/drop_caches.c b/fs/drop_caches.c
index 9fd702f..ab31393 100644
--- a/fs/drop_caches.c
+++ b/fs/drop_caches.c
@@ -8,10 +8,11 @@
 #include <linux/writeback.h>
 #include <linux/sysctl.h>
 #include <linux/gfp.h>
+#include <linux/fs_struct.h>
 #include "internal.h"
 
 /* A global variable is a bit ugly, but it keeps the code simple */
-int sysctl_drop_caches;
+char sysctl_drop_caches[PATH_MAX];
 
 static void drop_pagecache_sb(struct super_block *sb, void *unused)
 {
@@ -54,15 +55,43 @@ int drop_caches_sysctl_handler(ctl_table *table, int write,
 	void __user *buffer, size_t *length, loff_t *ppos)
 {
 	int ret;
+	int command;
+	struct path path;
+	struct path root;
 
-	ret = proc_dointvec_minmax(table, write, buffer, length, ppos);
-	if (ret)
-		return ret;
-	if (write) {
-		if (sysctl_drop_caches & 1)
+	ret = proc_dostring(table, write, buffer, length, ppos);
+	if (ret || !write)
+		goto out;
+	ret = -EINVAL;
+	command = sysctl_drop_caches[0] - '0';
+	if (command < 1 || command > 3)
+		goto out;
+	if (sysctl_drop_caches[1] == '\0') {
+		if (command & 1)
 			iterate_supers(drop_pagecache_sb, NULL);
-		if (sysctl_drop_caches & 2)
+		if (command & 2)
 			drop_slab();
+		ret = 0;
+		goto out;
 	}
-	return 0;
+	if (sysctl_drop_caches[1] != ':' || sysctl_drop_caches[2] == '\0')
+		goto out;
+	if (sysctl_drop_caches[2] == '/')
+		get_fs_root(current->fs, &root);
+	else
+		get_fs_pwd(current->fs, &root);
+	ret = vfs_path_lookup(root.dentry, root.mnt,
+		&sysctl_drop_caches[2], 0, &path);
+	path_put(&root);
+	if (ret)
+		goto out;
+	if (command & 1)
+		shrink_pagecache_parent(path.dentry);
+	if (command & 2)
+		shrink_dcache_parent(path.dentry);
+	path_put(&path);
+out:
+	if (ret)
+		memset(sysctl_drop_caches, 0, PATH_MAX);
+	return ret;
 }
-- 
1.7.9.5

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2013-12-16 15:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-16 15:00 [PATCH 0/5] VFS: Directory " Li Wang
2013-12-16 15:00 ` [PATCH 1/5] VFS: Convert drop_caches to accept string Li Wang
2013-12-16 15:00 ` [PATCH 2/5] VFS: Convert sysctl_drop_caches to string Li Wang
2013-12-16 15:00 ` [PATCH 3/5] VFS: Add the declaration of shrink_pagecache_parent Li Wang
2013-12-16 15:00 ` [PATCH 4/5] VFS: Add shrink_pagecache_parent Li Wang
2013-12-16 15:00 ` Li Wang [this message]
2013-12-16 17:45 ` [PATCH 0/5] VFS: Directory level cache cleaning Cong Wang
2013-12-17  3:08   ` Li Wang
2013-12-17  3:58     ` Matthew Wilcox
2013-12-17  7:23       ` Li Wang
2013-12-17  9:12         ` Li Zefan
2013-12-17  9:31           ` Li Wang
2013-12-18  1:26             ` Li Zefan
2013-12-17 13:55           ` Michal Hocko
2013-12-17 22:05 ` Dave Chinner
2013-12-18  1:36   ` Li Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=612334c18d31f67fb41416638f40cdf090062140.1387205337.git.liwang@ubuntukylin.com \
    --to=liwang@ubuntukylin.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=sage@inktank.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=yunchuanwen@ubuntukylin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox