From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BD34C3DA42 for ; Mon, 8 Jul 2024 09:49:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B5EEB6B008A; Mon, 8 Jul 2024 05:49:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AE70D6B008C; Mon, 8 Jul 2024 05:49:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 938F66B0092; Mon, 8 Jul 2024 05:49:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 754F46B008A for ; Mon, 8 Jul 2024 05:49:19 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id EB9B712125C for ; Mon, 8 Jul 2024 09:49:18 +0000 (UTC) X-FDA: 82316112396.14.D46AA88 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id A0D5C100018 for ; Mon, 8 Jul 2024 09:49:16 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UqvS2OXC; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720432141; a=rsa-sha256; cv=none; b=dCEiyB4V2K+TsdlZxZZMtoc5GT9x9tBCe48bTlj2uFr7KeDwpoXQo1X4XN5jS1MG6cfaGa EtMH+0alQEtybAPrVnmrcM5pno7KrjpSVb73pWzjhxBkvuScza8J5DxsjFcA30RY/ULsqt rtzI07LMZCYqx7di9qnrXHly7SZipbw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UqvS2OXC; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720432141; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BcyUU407noAi0s1rCqW1FXWE4833LU41MvXrn9iTbfs=; b=CeGyX0dp9y6wRPdw6TS4qBZx4OnTmFoUmesN6wy1xBsDj4iLI5eKc97BmSWCrsyOD0ocuw vTsBfUVjyd6wHtOIMJGi51VutvQwKMSJ7jCLbe42FfPjK7gWikMTbfnvVh8L3rsZ7oZb0e DOx7dyMV8LYioWPlgQkSGWjS/zPqelk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720432155; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BcyUU407noAi0s1rCqW1FXWE4833LU41MvXrn9iTbfs=; b=UqvS2OXCCPDF7g84+8Uk0/f/z0S4LrttAtB7Jf45/mi0CgEScLp3oat795HDQtOQvXmV+k KFfQE2+/3nNBj7wz4I61fss9C2gsyWgRGwS2Jum6TMMPL4PMM6BQ2V0n1KvyWm8w0LNDML xs+XuzYIgl7L/3553TY/9AKkTGRZaPc= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-637-kZtLAL6UN0G6rbKyPPqrFg-1; Mon, 08 Jul 2024 05:49:11 -0400 X-MC-Unique: kZtLAL6UN0G6rbKyPPqrFg-1 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-a77c85826fdso253766966b.3 for ; Mon, 08 Jul 2024 02:49:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720432150; x=1721036950; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=BcyUU407noAi0s1rCqW1FXWE4833LU41MvXrn9iTbfs=; b=O+mqGiHtDlhkFeWDVFiQ+q2UVFn4cZc8N9ahMQrxKYjP0jVhrtcuChuBJ6ZfNDJKBN 7B9Abl3amTXyHF8A8lKiPC9xSqP0PmJ3ZXc0DddV2kds6B1FxbfPlsVvxWn0rNaymom0 Hd9s5VZuQcUM8G5Gii9HgY/x9WJcTVN9HotLWKisv79DcFAWHRQxQdkP1PZaoRjbmABt ZJnug7S5je3d8ymW9nqvN3t1tL0dwv/MQwk7RxcoqfBx+Doa0E8+Htj6UmvYtcuh7jI4 /jKM4ySSDDrJ4m6b5wexm5HO08GLjitBbJgvV/Gawkl7L1QAt2dvve0teE6oqvxW7ZYu 34hg== X-Forwarded-Encrypted: i=1; AJvYcCUiYcrLTP8oDITd+KRPCZkJYmdJJa+HnsSY2qHRgAus1J2BqZOyDL/fV4RRpC/sjkXN+xlgYZGfsbdqEyYyHpCdLVw= X-Gm-Message-State: AOJu0Yzee4nlnm20NG5bElDdIfNuNoqbv+u0ySNQJ4VEj5XxvdO/OGvq CmT6JFbDp+N/BMtiDU8cnaAJlJkwe9hA3BeU+bjsabmubGEaAJ/68sr4pLUcv4KvDTz39/IS23U qt42riIoY+kbLbjVofKN6vuqLE5Oa0dgjGcwyrL8HnwmEZ5SA X-Received: by 2002:a17:906:3403:b0:a77:da14:840f with SMTP id a640c23a62f3a-a77da1485f2mr528134366b.9.1720432150714; Mon, 08 Jul 2024 02:49:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE9hGQ/TjnbqBLAl65i7DLN14ClWrC5jDk0Ici1BDdpNqxLDuyzK74pdnU5rfcIrOKPkR2qgg== X-Received: by 2002:a17:906:3403:b0:a77:da14:840f with SMTP id a640c23a62f3a-a77da1485f2mr528132966b.9.1720432150278; Mon, 08 Jul 2024 02:49:10 -0700 (PDT) Received: from [100.81.188.195] (ipb218f924.dynamic.kabel-deutschland.de. [178.24.249.36]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a77db963ee4sm248523866b.154.2024.07.08.02.49.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jul 2024 02:49:09 -0700 (PDT) Message-ID: <611dd616-a626-4968-b88a-4db82dccfb90@redhat.com> Date: Mon, 8 Jul 2024 11:49:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5] mm: shrink skip folio mapped by an exiting process To: Barry Song Cc: Zhiguo Jiang , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, opensource.kernel@vivo.com References: <20240708090413.888-1-justinjiang@vivo.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: hw9mmkj61em4odxgb98h1ij5ana33jw8 X-Rspamd-Queue-Id: A0D5C100018 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1720432156-728864 X-HE-Meta: U2FsdGVkX19fT67u6I4NI5HQ6cRbBa8g6A82Y3F/C9zxh7el5Kx5BXS5cSI04upX+BL+2C3IyW3MgHJHdBT8S8SFOBXT2bdcMnCxIrUJn3fC0+pOSYORtItJeVPFEMkDtdKqR0iGgTp3OqGbkVro+E9/gnj/mmYfZhWolKWqhGGRRAuxLQTH4RsQ+cKW+9Lqo2DK1jYnPpW5EF0HxkrIvnFvP0hY5f8GW7BLFq3Xbs19dsbQqrse8z55TMOVa9dwJfcKg8XX/ICGa5ESorbEF8mMzV/+l1D98C0QHg2AjNdbbf+v1xt2cVA1aM3RpQbIWbxLVP1ZKptwcWalt3bj2zr9uA5rxz1hgY3hRcDUOjfHraNT46JWBfgppLtwlmD5wIfY20701DehDGbyC69Q1VZEEsBrZsvDJLiAvrjXg2Z2w/n8lY7x3VzGW8IlGB5KASIU1thLq8/g9I0RV4keewakv5SMwVRS4xVRAEORTkIsab3w9aEj9J85VGbEC65/+K+s8NuJdAVqGipyvAHkW0+d+sQtnRnQS2hE0g7bx65axrH8izy25ELBstPexRcP8QXejXTveb12a/CKESnejjFuerN8idrr/RUOhzS76niwchM59/W6ygo9PgtuPWPF6nBcEB9Ke0i4x1Ei+W6oYOl1mlFGR/4GWYVxHMlhJZUyYVr9krgyMtypW+yNcNNG58FfRgqfNO+b32VlzgUc4tRF83qC5fgM6xyI1pNNAJ6a7e3Y7gxn4lLyJGfXvBy5ToRDlLiDUNxNFfgGTUiIzjYKTJcC/sJlQ15QRNFS1XobapsbciSmODOK7ZpyhD5bu67LsflwpfwT5mnSN1qJp2nChxV/ceD98UCIzurbZn0cjUzo91Rsl9mkr7M4Q11EQ0TYgX/u34mHGMUjvLWyzMom3OH6iQlbyqLeLJfyciT/kpZfyspqKmsVNLn8pK5PBY1V70YDZ7uaMX3m8wR aOsUrWwK AytiwuEdSg2w+ad4asdF+4S+vyLFbX9lYrLGGt/IlEbyvupH8WK3FqXLzNy8iZFCaIBTrMYt87puVIskLcxd3AYdFHIKBBhRhNZnxacBjpA7l2P2as6G+CFkLp8GQW2gBt4d5NrINk1nXglo15jGkugnxw5W+pOJYBc5jpDqByIsrhhkDu0sYxHKQgPoRwdBJsTN6JeU0brf1RlY/0QpexPwhmuMfIyQ9BWDqng4GNTTSGHLDl7oYctCTr4PkBTXcm70+C9frmUrhB1u6t+x/c+7Rf1rnTEthDhRh1KGmyujjFtVtpXg8RJ1xoKQo3rAvV9F1V8ETreUTRCrMnnTY0qhun3ByTlXj86puLT4bfxkuwkMyOhJdkJhFy1cs+2ymbDKuav8MPKsFN8jysCLxGDYGldt85d899KDiVqTCC50BndABpVYKH3Orw/hzO1j20qrBnRUDmlGh0mwoloW+AldF+VZq7q8zLqXBQ9pq1qA8iafiZo07of+1pA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08.07.24 11:46, Barry Song wrote: > On Mon, Jul 8, 2024 at 9:36 PM David Hildenbrand wrote: >> >> On 08.07.24 11:04, Zhiguo Jiang wrote: >>> The releasing process of the non-shared anonymous folio mapped solely by >>> an exiting process may go through two flows: 1) the anonymous folio is >>> firstly is swaped-out into swapspace and transformed into a swp_entry >>> in shrink_folio_list; 2) then the swp_entry is released in the process >>> exiting flow. This will increase the cpu load of releasing a non-shared >>> anonymous folio mapped solely by an exiting process, because the folio >>> go through swap-out and the releasing the swapspace and swp_entry. >>> >>> When system is low memory, it is more likely to occur, because more >>> backend applidatuions will be killed. >>> >>> The modification is that shrink skips the non-shared anonymous folio >>> solely mapped by an exting process and the folio is only released >>> directly in the process exiting flow, which will save swap-out time >>> and alleviate the load of the process exiting. >>> >>> Signed-off-by: Zhiguo Jiang >>> --- >>> >>> Change log: >>> v4->v5: >>> 1.Modify to skip non-shared anonymous folio only. >>> 2.Update comments for pra->referenced = -1. >>> v3->v4: >>> 1.Modify that the unshared folios mapped only in exiting task are skip. >>> v2->v3: >>> Nothing. >>> v1->v2: >>> 1.The VM_EXITING added in v1 patch is removed, because it will fail >>> to compile in 32-bit system. >>> >>> mm/rmap.c | 13 +++++++++++++ >>> mm/vmscan.c | 7 ++++++- >>> 2 files changed, 19 insertions(+), 1 deletion(-) >>> >>> diff --git a/mm/rmap.c b/mm/rmap.c >>> index 26806b49a86f..5b5281d71dbb >>> --- a/mm/rmap.c >>> +++ b/mm/rmap.c >>> @@ -843,6 +843,19 @@ static bool folio_referenced_one(struct folio *folio, >>> int referenced = 0; >>> unsigned long start = address, ptes = 0; >>> >>> + /* >>> + * Skip the non-shared anonymous folio mapped solely by >>> + * the single exiting process, and release it directly >>> + * in the process exiting. >>> + */ >>> + if ((!atomic_read(&vma->vm_mm->mm_users) || >>> + test_bit(MMF_OOM_SKIP, &vma->vm_mm->flags)) && >>> + folio_test_anon(folio) && folio_test_swapbacked(folio) && >>> + !folio_likely_mapped_shared(folio)) { >> >> I'm currently working on moving all folio_likely_mapped_shared() under >> the PTL, where we are then sure that the folio is actually mapped by >> this process (e.g., no concurrent unmapping poisslbe). >> >> Can we do the same here directly? > > Implementing this is challenging because page_vma_mapped_walk() is > responsible for > traversing the page table to acquire and release the PTL. This becomes > particularly > complex with mTHP, as we may need to interrupt the page_vma_mapped_walk > loop at the first PTE. Why can't we perform the check under the PTL and bail out? I'm missing something important. -- Cheers, David / dhildenb