From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB41FEB64DD for ; Fri, 21 Jul 2023 11:59:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D221C2801C7; Fri, 21 Jul 2023 07:59:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CD2022801C2; Fri, 21 Jul 2023 07:59:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B72F42801C7; Fri, 21 Jul 2023 07:59:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A7B3C2801C2 for ; Fri, 21 Jul 2023 07:59:48 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2DE5A8024C for ; Fri, 21 Jul 2023 11:59:48 +0000 (UTC) X-FDA: 81035474856.02.F0B0BD4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id CC81980005 for ; Fri, 21 Jul 2023 11:59:45 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YHXM7KcA; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689940786; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4Y7rbnaDJbn/YejSF4mQVA8Z4grlfMZHjKPnDFxLZ8A=; b=4NEsrj0Ef4ckLLv5WzDCRPb7RfNbdYEnRznxuxbvhB1P2Bfyp1VxYaOLKhnUwPqtmNQrLf JQbaLE2tv3ep3z1CAM/lRuL0nVhIV3pwIacjPsAbrQmr8IMrJ/1Axz69vbqbG6cw8tPJZ6 wH/Xy0+s0+TXSjUtw1k3HM29XZMPyzs= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YHXM7KcA; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689940786; a=rsa-sha256; cv=none; b=iNN4zrcTvPd6VeItz4cfKQr0Jn3RkuB7vqX/Gqx/bLlCq1WPXN6jawxKXJdqDoRBkgjj0S OLMORqcMFBucfH6lqbtsJQQogvkYBTfTO1HxTiAKSAc7vGclI5jUqhWiT4ANSAuvQWCj7d cuJmL636AED6dYSAJ4eUEeyu5BUYgGI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689940784; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4Y7rbnaDJbn/YejSF4mQVA8Z4grlfMZHjKPnDFxLZ8A=; b=YHXM7KcASdfLkCmk6CoRB72/QDK4OrdLrBvJOV0dmj6dvtr5W4iyzaQ8zq5ogSIW2K8sd2 AyrJDQhEqno3eUs4XUImLLHNqJ+5X7vtpDt+XkEJiEODpN8WBJJ3vyZr7sWNMiH0QK1Cq8 BFx00o/DhAWw79gVMgpmqqsHqxndlNQ= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-248-4m31K4mANrWGX0Rfwz0RHA-1; Fri, 21 Jul 2023 07:59:41 -0400 X-MC-Unique: 4m31K4mANrWGX0Rfwz0RHA-1 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-94a34e35f57so118178666b.3 for ; Fri, 21 Jul 2023 04:59:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689940780; x=1690545580; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4Y7rbnaDJbn/YejSF4mQVA8Z4grlfMZHjKPnDFxLZ8A=; b=P1wEk5SeEUKiuVJjp9ZLX9vKPt970QnYQHXYi+oLC751aOOviWRWB3iukEqDAiCPpl TADlDIlP4TzOfEDf4TZTjNoU2SDYZrpSQPyDTfr65Ahe747Jepr1tvdU7+2KKgXDc8Sf ynCZlmYHd6D/PAcSDKQtYy487Pn/sniK4zvCud6FCDuS9uxLn8u7fd1Mg1SNqlc19jnC 8qtmCCKc78A4WoNDq+BDZ1CvH2pw87rcEaWx0WCw955WqL1CB8zFigtLAoNzzatMF0k+ g0QJhYPIyvtu+zdeCDXO7OhgSAyhhPmMzUQURoaJE1pWi1YdxHimYf7L72JX7FbmI7/h 0k/A== X-Gm-Message-State: ABy/qLYMdW+wMzpo8QIUHmcvJ77GUymer2TfLowLMbDsD6HwNfW1W7sX K+huEDt/FPT5UMY8UFX184EJ8BYrLN3ZWgSrJeXtQ9B9jL5WYe2nUS27WQ05bxs0LSHzEfzhMSC DrteExU8RgRU= X-Received: by 2002:a17:906:2da:b0:994:54af:e282 with SMTP id 26-20020a17090602da00b0099454afe282mr1360630ejk.10.1689940780003; Fri, 21 Jul 2023 04:59:40 -0700 (PDT) X-Google-Smtp-Source: APBJJlEk/l1rT7vVGyK6B+M0/vN6OF6CipTv2G0AE0UWGqg9sgFPNWcoUSGmc+Sw2v1G9OPem3PIcQ== X-Received: by 2002:a17:906:2da:b0:994:54af:e282 with SMTP id 26-20020a17090602da00b0099454afe282mr1360600ejk.10.1689940779630; Fri, 21 Jul 2023 04:59:39 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:9af8:e5f5:7516:fa89? ([2001:b07:6468:f312:9af8:e5f5:7516:fa89]) by smtp.googlemail.com with ESMTPSA id um15-20020a170906cf8f00b00992b3ea1ee3sm2078970ejb.159.2023.07.21.04.59.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Jul 2023 04:59:38 -0700 (PDT) Message-ID: <6118063e-5c91-acc4-129f-3bacc19f25ce@redhat.com> Date: Fri, 21 Jul 2023 13:59:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [RFC PATCH v11 09/29] KVM: x86: Disallow hugepages when memory attributes are mixed To: Sean Christopherson , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Peng , Fuad Tabba , Jarkko Sakkinen , Yu Zhang , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , Vlastimil Babka , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" References: <20230718234512.1690985-1-seanjc@google.com> <20230718234512.1690985-10-seanjc@google.com> From: Paolo Bonzini In-Reply-To: <20230718234512.1690985-10-seanjc@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: CC81980005 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: pkazqcgw4up1g4gn7k6cukpqxwcuebid X-HE-Tag: 1689940785-6767 X-HE-Meta: U2FsdGVkX1+CE/P843qrEiM+u9GrCICn/d0G7FjyZae8OJ9x4DcxHoBfs2sCgbzfOLRfWD0G5YLEwTjMuri79gFc7pWok2Qbeq94KTju7DucLxZRBPc1ZbUmn6G64fHWAnEloX/LvTqv/hhsoZlMkxoDmFEsVePW2SY4j2J8Z2ybQT02Ed6cD2+Qai8upeE7A0zzfSIyEYBw+CDth1GMXUFNcASWwOLcxN/UXDDMLeKVSYFBCowfg/QqnZDTpxVXkMm6sHtpw0+kMgQEGkfBISTOTQw6Rvqr7SuUu4YuHWVjea7Dh8AETJB1qiGssYU1YuxBo+8vGT9xvKC3uXRyaHMEE8CatrvQuCxCv04zFJzZo/zR8R+41m2vRoYMtk+uK7tzTWK90iQg3XNpklYMZlN4ZTSJRsWXbXSX7myYrbtssv1WRD3GEcO0mfNbzmumwS4/HKFXInjW7xPM+UXo+J47inZq+zZc+Y1i7IpxmZbcj4rAHEjt7lMlEJS65GEz0bPiL/ER9x7fBOV2thnCHXAA7EEdxiPDbDXadU9wQLJPYrkQNV+oY0YnE9F5/i2z2+kDCyzuMSbunJYJvQQjlTeuNhXsnF4giKE2oqe1jgWqCDkwzWvC070+gCbIc8ydMdpoTjUd5Eqq1QhGLyMyIQUlyW/cKB6/PNXAkCGmugwLTNNN7K0eLaHJb8ZGI1osPZlZ6pDZ5u4zweekUqyHfYGo5EhCf3TQ80mpIjgyZyep/Y4eeoSBH+OTLOmeIRR+UCpVKyvcODPQHa22Q4loluoA/I/iuoW8W0ktvn5igi2e+vAZ5gi+DuuZeo2/kVG7zNBzTqfeMoVdS4tfMcxjHgKaM9QCIwiQ3F65/iDZ7/YD/Ecx4PkSNuSujjJG7h4CBxY9IF0mmuHytgekgPHHuzXvF6lXuWfYgoM0gWS0hT/DG426ivezNre6L2ba8L/IZoHLlno6C5JjJF8S28+ 4GxugoBw +RUu4kDFdXSffaOfbAlc/qFBhBwxXtESKo7HnIidwVtamOrRUf68ZsCVMFJLuELtVbgn5cuxRrf/0G7dAqFleXbK+4EvFkzqsH7mHf3hMr0WPXuOCLs4fyCHCa9KfiQV0zMNidjk0koc1NmqiuNNB8WD4jwWWNBz4uqJm9xx5dSRVSoentmakBBUi1xjnaWrc/kPzFBV94VZWWkuTCAhIbaXCMmvseESu0YdP+CCYxFj6Mvit0DUkjjphhnipt/aMtJBh1WO/287pN27Sa4cSl8nsMlQPC73FQHyS8z6C109PjC48+Pjo8RbkWcIJVrOVLjs7B3ZDTca8C9M3rqTF5mPRV/q1wTtI49a4rNBa8fSrwf+n6wB37goYlBejHGbdYzHYdqbijgtgMj0GsE8Acfny6XA9LHk2ki5T X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/19/23 01:44, Sean Christopherson wrote: > +static bool range_has_attrs(struct kvm *kvm, gfn_t start, gfn_t end, > + unsigned long attrs) > +{ > + XA_STATE(xas, &kvm->mem_attr_array, start); > + unsigned long index; > + bool has_attrs; > + void *entry; > + > + rcu_read_lock(); > + > + if (!attrs) { > + has_attrs = !xas_find(&xas, end); > + goto out; > + } > + > + has_attrs = true; > + for (index = start; index < end; index++) { > + do { > + entry = xas_next(&xas); > + } while (xas_retry(&xas, entry)); > + > + if (xas.xa_index != index || xa_to_value(entry) != attrs) { > + has_attrs = false; > + break; > + } > + } > + > +out: > + rcu_read_unlock(); > + return has_attrs; > +} > + Can you move this function to virt/kvm/kvm_main.c? Thanks, Paolo