From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62965C3600B for ; Thu, 27 Mar 2025 16:59:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C130280108; Thu, 27 Mar 2025 12:59:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 74AD62800FF; Thu, 27 Mar 2025 12:59:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C396280108; Thu, 27 Mar 2025 12:59:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 332892800FF for ; Thu, 27 Mar 2025 12:59:16 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A1E3181344 for ; Thu, 27 Mar 2025 16:59:17 +0000 (UTC) X-FDA: 83267941554.17.8922439 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf16.hostedemail.com (Postfix) with ESMTP id 43AEE180019 for ; Thu, 27 Mar 2025 16:59:14 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf16.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743094755; a=rsa-sha256; cv=none; b=YuhA6OUC+TJK0M1RVm/75z9R/0XJHw7Ndn2Chw92WZtB0/tz98K812TdmUsobhZfBwRkc+ 7qxZzT6ahKt1t9KjJoBlHfqBpSHmmYlIKwazTmQgIbj6IiLjJLdmgZhH356PcB32ZMHSXs F4W1UfE5e5/nzRN0LvYEP3Ykups1Szs= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf16.hostedemail.com: domain of shiju.jose@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=shiju.jose@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743094755; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l0WVSc09GqZ8vwYdUAE156r3UdQOSqy9rOO4KbV5kRM=; b=EC8l8UlkIuX/4UW95FEiWkWfcVZvzn67u3ZRAtsCNG1fNCVNZJlzT024y+pivGQYMcbMW2 +ogYa8jpyecty08plPPgdUCqUVbaibVrkCGTd4rl43vQjg8C9/9eF0p5PHYYfBm6odVj4g TjHbJj0BeZwumIu3MhHD+YP+nD/h54k= Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4ZNqXr6JTqz6M4Ql; Fri, 28 Mar 2025 00:55:40 +0800 (CST) Received: from frapeml100006.china.huawei.com (unknown [7.182.85.201]) by mail.maildlp.com (Postfix) with ESMTPS id 26E2A14051A; Fri, 28 Mar 2025 00:59:11 +0800 (CST) Received: from frapeml500007.china.huawei.com (7.182.85.172) by frapeml100006.china.huawei.com (7.182.85.201) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 27 Mar 2025 17:59:10 +0100 Received: from frapeml500007.china.huawei.com ([7.182.85.172]) by frapeml500007.china.huawei.com ([7.182.85.172]) with mapi id 15.01.2507.039; Thu, 27 Mar 2025 17:59:10 +0100 From: Shiju Jose To: Dan Williams , "linux-cxl@vger.kernel.org" , "dave@stgolabs.net" , Jonathan Cameron , "dave.jiang@intel.com" , "alison.schofield@intel.com" , "vishal.l.verma@intel.com" , "ira.weiny@intel.com" , "david@redhat.com" , "Vilas.Sridharan@amd.com" CC: "linux-edac@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "bp@alien8.de" , "tony.luck@intel.com" , "rafael@kernel.org" , "lenb@kernel.org" , "mchehab@kernel.org" , "leo.duran@amd.com" , "Yazen.Ghannam@amd.com" , "rientjes@google.com" , "jiaqiyan@google.com" , "Jon.Grimm@amd.com" , "dave.hansen@linux.intel.com" , "naoya.horiguchi@nec.com" , "james.morse@arm.com" , "jthoughton@google.com" , "somasundaram.a@hpe.com" , "erdemaktas@google.com" , "pgonda@google.com" , "duenwen@google.com" , "gthelen@google.com" , "wschwartz@amperecomputing.com" , "dferguson@amperecomputing.com" , "wbs@os.amperecomputing.com" , "nifan.cxl@gmail.com" , tanxiaofei , "Zengtao (B)" , Roberto Sassu , "kangkang.shen@futurewei.com" , wanghuiqiang , Linuxarm Subject: RE: [PATCH v2 1/8] cxl: Add helper function to retrieve a feature entry Thread-Topic: [PATCH v2 1/8] cxl: Add helper function to retrieve a feature entry Thread-Index: AQHbmcKr5anTvL2xzU6u4SEaFigSYLOF6PqAgAFGedA= Date: Thu, 27 Mar 2025 16:59:10 +0000 Message-ID: <610691bb7c6949b5a2137c568bc66fe2@huawei.com> References: <20250320180450.539-1-shiju.jose@huawei.com> <20250320180450.539-2-shiju.jose@huawei.com> <67e47285c1974_152c29442@dwillia2-mobl3.amr.corp.intel.com.notmuch> In-Reply-To: <67e47285c1974_152c29442@dwillia2-mobl3.amr.corp.intel.com.notmuch> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.126.170.230] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 43AEE180019 X-Stat-Signature: 6k58m7y8wqnnwfk8qaa4qxq15phmwbf7 X-Rspam-User: X-HE-Tag: 1743094754-33353 X-HE-Meta: U2FsdGVkX18qZMQJY29mQoyh7MaNmkKlruFyow2QlBr5p/a7GrEHr3GfDP2xEW9em+NlfJkBzqiyZsGo4l/lv5ZV0LuUcGelg1CAF9Q2ATkHzDycsdxBqnSy/o4+ewwOJh3eUWWPlGAbJBzRRTQ0YVjJ4CV99xTjbbgv1Y6LMJLpI9O0qdhIZZd2IkifnFN6UmRy5qG2fDVPqS77Z9da4n2YwQj6k8lAGtPPUpw+LmWSoQ1Gzkagv21APFjD9toU76VatdR4Dv6zSsLnAQm9Mbqf4VUn9u0ZfE04bvwWLtKeFbl7+6gqg40EFnS0VthwQMfonQWf5XnHSL3ifNYoZQLAP78aE+b1Sf1pwkzEKYkWzFw5unH3MAC69JFjVmyA0M5FdpXL/xZZJv09rceXzGhukNIaUr/G4NQLVSGDHyCot6ms/Ui0968usaojgUQ05EZWrBZ66+e6ZCwDWJ9EV/NE0fCefkIflYbtp9ZHJtt8JKfxvb3LKSUUkgAO8o4PyRueQVe3L1k+PxjqEYc+OrpwqkYCTqNLbqGjLSddQNlzsBOmfwb5Msap8QFDhAvl1+lm3p6p8mX4zbODY+UU1FusixyOGuWAZxi6/ktW6erF0XlfEjYm44wLjSTE0kD0OeTXSHnogTEzgydNH35OyRIMVSw5OO11n9aAvR9/ZyNB9dZ+0TVN4adAM8hJ0KpKrBlQ4mrws6vIhQgeke6DSKjB2WhyvBVzKmYw2Ej9cRDikknFu8LKI5o04SyJse/sX+1MtShUv5PVzucMBfu5OmOlyhlqg1idUCRdndTVsp3Sp3Qw0jluOrlDPGH7dv/el1EBLJdWTl4gjtJEI2X0+EnFhVgPDBpUfU8JqEB1ar/XzvB4ieYQgNEc+zdWz4iu8f0T/uYAls6kwaJml4lnWecivDsMjtOH2LyQ6KpLHtDb8Bd2iaorblKaPzuIPLM2qWUp7wEilalOU6U1Yh0 YvtgoSms 5bzFA7V8Vb4Iw0mgCpZVFy0D/8ZrEGsG7RV3sl29e0Ivl2HajNaKvn8r3bAcOMvuQALNVWqnttvDG7LbEKRI1zmDMVUxPHU2nuO8VQsB8TVQ1KvtjTiIx55dm1YWw1ciDVdRbfTsnNHA7fvBOuNYHYQeZ66ssZk44AuQbyiywO5dePLB202HQLrw3Ng884+hf/nGE3gmJY32XGTikkmg2fCRo0ShPmuqPDhYcSWfqYS/IbT5imPBnKMVF0kXbuIeKW/8OyLPA+YzWk9DchO6ANDeaWfINLFNmt5AcHBRhbYkqMhckoi8/U0qrZYAOGCwE+/IPSOVJSUiCaVQRU/Lc9zfGvVSGx1+lU6wlag7SDjaECs084+HC8xUGH1nwnDyBenWx29pIFuqZeHKg9jLJLkOymTvkwXJW74Hl51mZXmkPxp00kZCPBpkqx3xJbwCKqZItPpspmf9BDHITptBJjhG2D3GS93S17NXg4BrIF+KsAeiS5thaFgTpSjm/qMT4hzJ7mPKPUSy8MBroNtGJteK8jOz7TQSyBNY4MnrOnZgydXf5f0OtUrHaE554RYjC8aLO0bbuunNkZ8GJ7EPRR3rfdRWzeeQav7ARQsi7O3l6mQFCaBSGPdW4mN0F3z1YlpUqU8/EMM4+FyUDNJC0k4+zcf1RBC67QWJrnyzF209mzSBvFyQptBSpu6XvpW2kgaBR3JKa0DRzqHP+Nt+OSsP4M73NuQPuuJjt9tm9KiyvzWzTUt6AW+0pOGxnb9E6NuoWCpvaILvXGg0CNxYCmTULZvD8QWPcD4zJPCanDmP++qD6r9IDKHNEh8Knybko7sIeFzLmfe69LPuGXjCPV2r1tNoLAy02QiprV1WqSjRumzs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >-----Original Message----- >From: Dan Williams >Sent: 26 March 2025 21:33 >To: Shiju Jose ; linux-cxl@vger.kernel.org; >dan.j.williams@intel.com; dave@stgolabs.net; Jonathan Cameron >; dave.jiang@intel.com; >alison.schofield@intel.com; vishal.l.verma@intel.com; ira.weiny@intel.com; >david@redhat.com; Vilas.Sridharan@amd.com >Cc: linux-edac@vger.kernel.org; linux-acpi@vger.kernel.org; linux- >mm@kvack.org; linux-kernel@vger.kernel.org; bp@alien8.de; >tony.luck@intel.com; rafael@kernel.org; lenb@kernel.org; >mchehab@kernel.org; leo.duran@amd.com; Yazen.Ghannam@amd.com; >rientjes@google.com; jiaqiyan@google.com; Jon.Grimm@amd.com; >dave.hansen@linux.intel.com; naoya.horiguchi@nec.com; >james.morse@arm.com; jthoughton@google.com; somasundaram.a@hpe.com; >erdemaktas@google.com; pgonda@google.com; duenwen@google.com; >gthelen@google.com; wschwartz@amperecomputing.com; >dferguson@amperecomputing.com; wbs@os.amperecomputing.com; >nifan.cxl@gmail.com; tanxiaofei ; Zengtao (B) >; Roberto Sassu ; >kangkang.shen@futurewei.com; wanghuiqiang ; >Linuxarm ; Shiju Jose >Subject: Re: [PATCH v2 1/8] cxl: Add helper function to retrieve a feature= entry > >shiju.jose@ wrote: >> From: Shiju Jose >> >> Add helper function to retrieve a feature entry from the supported >> features list, if supported. >> >> Reviewed-by: Jonathan Cameron >> Reviewed-by: Fan Ni >> Signed-off-by: Shiju Jose >> --- >> drivers/cxl/core/core.h | 2 ++ >> drivers/cxl/core/features.c | 23 +++++++++++++++++++++++ >> 2 files changed, 25 insertions(+) >> >> diff --git a/drivers/cxl/core/core.h b/drivers/cxl/core/core.h index >> 1803aedb25ca..16bc717376fc 100644 >> --- a/drivers/cxl/core/core.h >> +++ b/drivers/cxl/core/core.h >> @@ -123,6 +123,8 @@ int cxl_ras_init(void); void cxl_ras_exit(void); >> >> #ifdef CONFIG_CXL_FEATURES >> +struct cxl_feat_entry *cxl_get_feature_entry(struct cxl_dev_state *cxld= s, >> + const uuid_t *feat_uuid); > >It is unfortunate that this naming choice is too similar to cxl_get_featur= e(). >However, as I go to suggest a new name I find that this is a duplicate of >get_support_feature_info() in Dave's fwctl series. Just drop this patch in= favor of >that. Hi Dan, I am fine to use get_support_feature_info() for the EDAC features.=20 However this function is defined as static in the fwctl series and=20 takes struct fwctl_rpc_cxl * as input for RPC instead of uuid_t * as in cxl_get_feature_entry(). static struct cxl_feat_entry * get_support_feature_info(struct cxl_features_state *cxlfs, const struct fwctl_rpc_cxl *rpc_in) Can you suggest how to use get_support_feature_info() from within the CXL d= river=20 to retrieve a supported feature entry (for e.g an EDAC feature)? > Thanks, Shiju