From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0F19EB64D9 for ; Wed, 14 Jun 2023 08:50:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 367278E0003; Wed, 14 Jun 2023 04:50:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 316FF8E0002; Wed, 14 Jun 2023 04:50:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B7E08E0003; Wed, 14 Jun 2023 04:50:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0F04A8E0002 for ; Wed, 14 Jun 2023 04:50:43 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D9FCCA0852 for ; Wed, 14 Jun 2023 08:50:42 +0000 (UTC) X-FDA: 80900732724.10.325A49A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id ADF4AA001C for ; Wed, 14 Jun 2023 08:50:40 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QHbxbCck; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686732640; a=rsa-sha256; cv=none; b=QQfyt4zqCx3Tdc0B8vQt5r4ttav6/KbG3oW1aGTh+fuYIE1PKcGgT98xnKG2y6Hs4xEi0V soWaGR6JqyhbKuldxCye3P7vY1A6vAFHN1YJKrvROEuqWBgaFvxQTcU7KW+2pEqBtV4dwg P+l0O3HYiQ21+/0W7h1UG5/Aug89zPM= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QHbxbCck; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686732640; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HJaR5Vd/9JW0NW0jYiNZu8AUcFpeksRgJUrDG804Cew=; b=gZw1Ba90yFmeKRIe4V63fEwh/mB4/PkkDaFt+iUP6mt4vXj7BPWUYWE319FTr06K6zTPZX e22CMnMOMeWAok4Nh2NBqIi1vsWtcUbrIszy9txCf7FEtuLYpZRD/KRLf8szj0AClV0G49 wi7kvh/w3FOI+yp8HGL5URPClcq7D4M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686732640; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HJaR5Vd/9JW0NW0jYiNZu8AUcFpeksRgJUrDG804Cew=; b=QHbxbCckLGsed+JFNt5XIxkkujV1THNxwIu+9syBs0cueYrbdFuBHqincK4iZvuB5DtQCn fUHVcwHIl88nsd4CE4jlG7Swp3sd3BH78O2vKB3cPk0CnIdqp4ypFsS6fStJ0Gcf26EGGO MagZi67ZLUPNX30DT3/HQ2xnYjBz2lc= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-404-HfaBTbgMPrCvgSfbXWSWqQ-1; Wed, 14 Jun 2023 04:50:38 -0400 X-MC-Unique: HfaBTbgMPrCvgSfbXWSWqQ-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3f7f77ac6b6so3561215e9.1 for ; Wed, 14 Jun 2023 01:50:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686732637; x=1689324637; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HJaR5Vd/9JW0NW0jYiNZu8AUcFpeksRgJUrDG804Cew=; b=T1kunDtBlfNOJ/eqEDy91EOjYrr4na+t0y8Yso3evlrwJAMtmHqVyPXhAtc0jgjZkK V22CwM7rzLUAZfVHFziFX1A/ieSXvocjtmHZUOnJv2gFu9M6Mt1Yk0PoT0SYFBCpXiIJ Gdk5rAfdY0OxGSrRLHoDEnr511HHIPMQpI8W6iFRA24htXwVoAU4KmZ6lrnSTEpWP03a Mhx8OElVmxzXpkkMJQt0QidhdwoxU1AzAU5Segpf9pAeoI6fyYxNhtbVydAfByqT14yj cib+GKYw9K8SeYLzM4wDOOSmWISm8loYCIdkbzQxX70Yi/QOkEUczCw7Fw8ZdpK79h8h IpCQ== X-Gm-Message-State: AC+VfDxDZ4rlr3Wz+DYEY7cIFwx4jzaWi9FNhmr7nHrRhM6tgb0lFMO7 AsIeKBRoet62Nn+g1j4jnj4tC7dRJe4OlDT4PRlI+6ln3B4GCGtcZv+S23c0gYFnpe/Sd0N5ppR Yga1gof0345nfu580FKk= X-Received: by 2002:a7b:ca55:0:b0:3f8:1b4b:bd13 with SMTP id m21-20020a7bca55000000b003f81b4bbd13mr6322802wml.20.1686732637286; Wed, 14 Jun 2023 01:50:37 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6GW/YLOQGF4QzFEcbvIwVImxYPULU1Owp7RiYxkgnp7L2Y4w+g6T2tmVS8Psfxf8hHira/QQ== X-Received: by 2002:a7b:ca55:0:b0:3f8:1b4b:bd13 with SMTP id m21-20020a7bca55000000b003f81b4bbd13mr6322791wml.20.1686732637000; Wed, 14 Jun 2023 01:50:37 -0700 (PDT) Received: from ?IPV6:2003:cb:c704:b200:7d03:23db:ad5:2d21? (p200300cbc704b2007d0323db0ad52d21.dip0.t-ipconnect.de. [2003:cb:c704:b200:7d03:23db:ad5:2d21]) by smtp.gmail.com with ESMTPSA id k1-20020a5d6e81000000b0030e5ccaec84sm17746027wrz.32.2023.06.14.01.50.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Jun 2023 01:50:36 -0700 (PDT) Message-ID: <61027367-695b-65ae-3f39-7b59c1e05bc5@redhat.com> Date: Wed, 14 Jun 2023 10:50:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v9 14/42] mm: Introduce VM_SHADOW_STACK for shadow stack memory To: Rick Edgecombe , x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , Weijiang Yang , "Kirill A . Shutemov" , John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, akpm@linux-foundation.org, Andrew.Cooper3@citrix.com, christina.schimpe@intel.com, debug@rivosinc.com, szabolcs.nagy@arm.com, torvalds@linux-foundation.org, broonie@kernel.org Cc: Yu-cheng Yu , Pengfei Xu References: <20230613001108.3040476-1-rick.p.edgecombe@intel.com> <20230613001108.3040476-15-rick.p.edgecombe@intel.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230613001108.3040476-15-rick.p.edgecombe@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: ADF4AA001C X-Stat-Signature: x8p3n6rmup99sijmjpr6dgjpbazop4xu X-Rspam-User: X-HE-Tag: 1686732640-674976 X-HE-Meta: U2FsdGVkX18jxobbQYVYkutaqg5w4gazbJcNN7sz0xb57fOZ45Ui5FeqO36XnA4XDy7cB6IjM+/pwLEOvRDLwTWqQN7OfFSeYd64B7O6iwYZZY7N4SFS5XAOTRHJMu6mn3SN6QeHbYsenJrcBXvqjthCb9dgmmGmooq3edf97U4vOaq44tGxH4pmc2NlilGBWQ3RvVOS3C67wLRTr0D9v5eZiNqpi2F45d5JNEtUytVN/Rs7s6gcl2xT9ksr8QQ0+XMYOLbYJj64ZjplouvweNv2J5XrzBj3H3EvevglrEmZT5I+MetN9UUO1W4W+dDoSCT53eeaIbm2aL1mF+Yfc0M2lVQIelrviRaGx4aFJperzZHOTGsVyyxN0apllupqem6FI27Dhcx8+KB/STEd0VBjgMHvjBWmM0DKTHWL2pYS2ncMexJShyGvdOeZg3vx0n3Fl4sHCX2NAO16xjal2Lf5sYkO8aMsj5WyzwYBCP3mdR/vhQkb43yHDApGxHOmY9DjVzNFC9tM6YryPQAkDxP0BQY6Qhuz8J3hCVHVcwT/k4zp4BvT/MNBE3BeMsO2tRJqEfrqOER77LbvA0/01Hi9goE1t7bigK+n1T8WElNu/G/0K2zBIbsjyK8udu9Iyz8rIlaO1GRt0dKFnQklo5JqVMoOqfYBGi3xzWOHCSmy6XhJduK10lvJ5XExSE8KKqDUpXEcGhFSaj9WcvguhfQ6VrqYjF5U7sv6n8ftLOJXW2QvL0RKewTgwWgwOIml/1RTYjfPAuzp385nZhe3Z6xr7LO5QRU4wfSNxRyzphnCrzrw4TEBQNd91+wB8qjoP9cafci7DDuws04j+RXHaBdZuzJ3HwxO3aWoHKyaxXce3t4Qz42NAeOoPlJrNBJyMvsl6IRje2K7gr4elIjE3+mRlxvV4G4gsWvqhgpFJOWanGGibV8K07vR+oKuDF51gFrJpA8EKq3GVnwN9a5 pnkCN4z1 WMdeTtxEyv2FVVYGI7YReHLbqS9/dZp5T3a/L1p1TTyeotdkA9LLEXIGqgGAD97DhgUTmnnEmHdpGYVDkhe5pML2vm1D9m4HeFZP4Zl85lj1kc8lM/suIKLiIPrF8MS6r2/yWUqKCjHJ1Jz4ko3oifPzKpDxk46+85DDCitELEQUmvq0K1WA+YGyCwX+tWk6Wsv6ScwSYCZSA4sS/wJk6jQ77HMFsbGAC53J846VcEQr+aL1K8J8qGGCWKKWWizDKPw/L2HtMury8CT36zaT2ajQmXXUtEy2waN41zE8ss1fozO07r9ipPAektxL3lMyefQkGVeBBOHQnJxMwr49sDT9HdRiuHjH3VbggQSsmz5J+cTH5hUPq90I3Qly2xLPN08IkevTzTSx/ntX+8TEHmWAN0ea5T1689CWXjJ+bOxylomWKBts5SyVS8ulYS/cDsI968MmqNPZUh1YxG+EeOD2GnO73i8SwexUb6i10FW9niaQXMRmINJdFUyJAV58HZByX1I2kz8NWnnaMqe81duOIoQ6W7VH1W3F8HWhBJWrlbHpad70GKy4laj9cirtlZDQ1yx+DwdVNvCRT8aJEtSL0LJLSYVhPuiXX2D+7EvhOUV+QgUl2Z6NnDXzwIQGfoF474/9cCod/sARhuoShrYIc9Gn6YvczANUk8etrS24mI1vN7sWxNCYfZg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 13.06.23 02:10, Rick Edgecombe wrote: > From: Yu-cheng Yu > > New hardware extensions implement support for shadow stack memory, such > as x86 Control-flow Enforcement Technology (CET). Add a new VM flag to > identify these areas, for example, to be used to properly indicate shadow > stack PTEs to the hardware. > > Shadow stack VMA creation will be tightly controlled and limited to > anonymous memory to make the implementation simpler and since that is all > that is required. The solution will rely on pte_mkwrite() to create the > shadow stack PTEs, so it will not be required for vm_get_page_prot() to > learn how to create shadow stack memory. For this reason document that > VM_SHADOW_STACK should not be mixed with VM_SHARED. > > Signed-off-by: Yu-cheng Yu > Co-developed-by: Rick Edgecombe > Signed-off-by: Rick Edgecombe > Reviewed-by: Borislav Petkov (AMD) > Reviewed-by: Kees Cook > Reviewed-by: Kirill A. Shutemov > Acked-by: Mike Rapoport (IBM) > Tested-by: Pengfei Xu > Tested-by: John Allen > Tested-by: Kees Cook > --- > Documentation/filesystems/proc.rst | 1 + > fs/proc/task_mmu.c | 3 +++ > include/linux/mm.h | 8 ++++++++ > 3 files changed, 12 insertions(+) > > diff --git a/Documentation/filesystems/proc.rst b/Documentation/filesystems/proc.rst > index 7897a7dafcbc..6ccb57089a06 100644 > --- a/Documentation/filesystems/proc.rst > +++ b/Documentation/filesystems/proc.rst > @@ -566,6 +566,7 @@ encoded manner. The codes are the following: > mt arm64 MTE allocation tags are enabled > um userfaultfd missing tracking > uw userfaultfd wr-protect tracking > + ss shadow stack page > == ======================================= > > Note that there is no guarantee that every flag and associated mnemonic will > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > index 420510f6a545..38b19a757281 100644 > --- a/fs/proc/task_mmu.c > +++ b/fs/proc/task_mmu.c > @@ -711,6 +711,9 @@ static void show_smap_vma_flags(struct seq_file *m, struct vm_area_struct *vma) > #ifdef CONFIG_HAVE_ARCH_USERFAULTFD_MINOR > [ilog2(VM_UFFD_MINOR)] = "ui", > #endif /* CONFIG_HAVE_ARCH_USERFAULTFD_MINOR */ > +#ifdef CONFIG_X86_USER_SHADOW_STACK > + [ilog2(VM_SHADOW_STACK)] = "ss", > +#endif > }; > size_t i; > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 6f52c1e7c640..fb17cbd531ac 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -319,11 +319,13 @@ extern unsigned int kobjsize(const void *objp); > #define VM_HIGH_ARCH_BIT_2 34 /* bit only usable on 64-bit architectures */ > #define VM_HIGH_ARCH_BIT_3 35 /* bit only usable on 64-bit architectures */ > #define VM_HIGH_ARCH_BIT_4 36 /* bit only usable on 64-bit architectures */ > +#define VM_HIGH_ARCH_BIT_5 37 /* bit only usable on 64-bit architectures */ > #define VM_HIGH_ARCH_0 BIT(VM_HIGH_ARCH_BIT_0) > #define VM_HIGH_ARCH_1 BIT(VM_HIGH_ARCH_BIT_1) > #define VM_HIGH_ARCH_2 BIT(VM_HIGH_ARCH_BIT_2) > #define VM_HIGH_ARCH_3 BIT(VM_HIGH_ARCH_BIT_3) > #define VM_HIGH_ARCH_4 BIT(VM_HIGH_ARCH_BIT_4) > +#define VM_HIGH_ARCH_5 BIT(VM_HIGH_ARCH_BIT_5) > #endif /* CONFIG_ARCH_USES_HIGH_VMA_FLAGS */ > > #ifdef CONFIG_ARCH_HAS_PKEYS > @@ -339,6 +341,12 @@ extern unsigned int kobjsize(const void *objp); > #endif > #endif /* CONFIG_ARCH_HAS_PKEYS */ > > +#ifdef CONFIG_X86_USER_SHADOW_STACK > +# define VM_SHADOW_STACK VM_HIGH_ARCH_5 /* Should not be set with VM_SHARED */ > +#else > +# define VM_SHADOW_STACK VM_NONE > +#endif > + > #if defined(CONFIG_X86) > # define VM_PAT VM_ARCH_1 /* PAT reserves whole VMA at once (x86) */ > #elif defined(CONFIG_PPC) Acked-by: David Hildenbrand -- Cheers, David / dhildenb