From: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To: Snaipe <me@snai.pe>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [RFC PATCH 1/1] fs,ns: allow copying of shm_mnt mount trees
Date: Fri, 30 Jan 2026 08:38:57 +0000 [thread overview]
Message-ID: <60f683fa-bd25-4656-ae53-fc247962bac7@wdc.com> (raw)
In-Reply-To: <20260129173515.1649305-2-me@snai.pe>
On 1/29/26 6:39 PM, Snaipe wrote:
> diff --git a/fs/namespace.c b/fs/namespace.c
> index d82910f33dc4..f51ad2013662 100644
> --- a/fs/namespace.c
> +++ b/fs/namespace.c
> @@ -38,6 +38,9 @@
> #include "pnode.h"
> #include "internal.h"
>
> +/* For checking memfd bind-mounts via shm_mnt */
> +#include "../mm/internal.h"
> +
Hi,
I don't want to comment on the rest of the change as I don't know enough
of the subject but this screams layering violation to me.
Thanks,
Johannes
next prev parent reply other threads:[~2026-01-30 8:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 17:35 [RFC PATCH 0/1] Bind-mounting memfds Snaipe
2026-01-29 17:35 ` [RFC PATCH 1/1] fs,ns: allow copying of shm_mnt mount trees Snaipe
2026-01-30 8:38 ` Johannes Thumshirn [this message]
2026-01-30 14:17 ` Snaipe
2026-02-04 16:51 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60f683fa-bd25-4656-ae53-fc247962bac7@wdc.com \
--to=johannes.thumshirn@wdc.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=me@snai.pe \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox