From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70FF8EB64DD for ; Wed, 12 Jul 2023 19:10:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F8468D000B; Wed, 12 Jul 2023 15:10:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A8C68D0002; Wed, 12 Jul 2023 15:10:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E8B888D000B; Wed, 12 Jul 2023 15:10:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D8E238D0002 for ; Wed, 12 Jul 2023 15:10:54 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 97499A035E for ; Wed, 12 Jul 2023 19:10:54 +0000 (UTC) X-FDA: 81003902028.30.5E9B264 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 5CB17A001A for ; Wed, 12 Jul 2023 19:10:52 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="FvtSAKP/"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689189052; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=q45SoRMuLgunlP8L7mZ4yYklFc9J8ZjnlV0HAlFrluA=; b=4EU93ClYJjy0V69yJHkw8HXsJhv9GTA8nid0xxJHm6OUzW/03iDwi48Cmnqp4YelyzruNc vRmoPg4YgJYZRdfwZHCTYrX2BBYE/7wy3Oxg8J14FN3d3232suWSyWwYqQfDq6jsnS9RDI knuURav30tPzl5AJuyHE2l6IuHDvjVQ= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="FvtSAKP/"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689189052; a=rsa-sha256; cv=none; b=v7uoIJGPlOkAtJJwK6xBCLUzUhfZayNgcef1j7M1894JRvJBRyH0wKthjo+e5nf7wRS7Gr twfcaGPGPCMTbpjD72tVjZ7ApQAHbYvWqMOjW6t/Q+AvSZNMlR129Y7dN7mnElFf6DSlE9 HguDgev5qX3yQx1Gun13Z4zhZQpjXBA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689189051; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q45SoRMuLgunlP8L7mZ4yYklFc9J8ZjnlV0HAlFrluA=; b=FvtSAKP/W0rluk3vy56TimDf2Qni7XOh5q48UldEydX5Cf/BmsggFGMCY94SDKEUgy7A9+ CGZPlRXNPT2KZhG5Euz9vPA7VWt9c2uq/A+V+nvmyfw2pZGUEPok7CsHfAvPFm7ZXhgsFQ It1bsnMe8emNIf1fKPi3N26ENukUBPg= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-437-JYGKujMLMAyhC62Mt_6ENQ-1; Wed, 12 Jul 2023 15:10:50 -0400 X-MC-Unique: JYGKujMLMAyhC62Mt_6ENQ-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3fa979d0c32so45579525e9.2 for ; Wed, 12 Jul 2023 12:10:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689189049; x=1691781049; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=q45SoRMuLgunlP8L7mZ4yYklFc9J8ZjnlV0HAlFrluA=; b=NjASYSzsgih1P6Hlv7hwGSKRhXYRNS2XeqKOaq4MRiCY2Orum0eQ+WuyiLAhk1FpF6 +O13kWHgqUkzD15Uz1W9yqjTpYkocFK74/Q54noPqHu14qgIC1DflL9CNS7zsljPfzXr k+3BV/spLFzfRf+Lhas5C54QTzNoA86QpOgeImox0Y1basBVjFkcjeIkXASf6YWxH9J2 6E/DC+nUEd+IHguqAFMZaGT74pfE3OyPt6lQ3ySHXeGNg2wu6jKHDPRGrxHb2vvs1c5Z MMMjiMEAC0ybHU3V91+m3WPxc2wznovqSn96/h1ZcTqm9StrsLc6FflddI5rlv9ljmJx GMxA== X-Gm-Message-State: ABy/qLahyESdVOOwB9HGq7eyBLcjqRl2ioy9Rbfa9DyDLFvTo/g288xQ uqcY5fxcIwE89wJ/U1fmsqDQ61t2KpD9LVyfxQw4ca6R6WndYPAoXYhGih2Dji7+UuhAh7Vsttd tTfp7O9WPs8U= X-Received: by 2002:a7b:c019:0:b0:3fb:a62d:1992 with SMTP id c25-20020a7bc019000000b003fba62d1992mr16262193wmb.0.1689189049322; Wed, 12 Jul 2023 12:10:49 -0700 (PDT) X-Google-Smtp-Source: APBJJlG7+RfJW8rL+kAwaM2CugjDDuPQVV8Tbi86e3qb2YFzqDwqbvHOu/X6/+h7PYfnyGjOw9KBjA== X-Received: by 2002:a7b:c019:0:b0:3fb:a62d:1992 with SMTP id c25-20020a7bc019000000b003fba62d1992mr16262181wmb.0.1689189048992; Wed, 12 Jul 2023 12:10:48 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:3700:3eea:ace6:5bde:4478? (p200300cbc70737003eeaace65bde4478.dip0.t-ipconnect.de. [2003:cb:c707:3700:3eea:ace6:5bde:4478]) by smtp.gmail.com with ESMTPSA id o29-20020a05600c511d00b003fa9a00d74csm409177wms.3.2023.07.12.12.10.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Jul 2023 12:10:48 -0700 (PDT) Message-ID: <60f2ef09-53b2-6bf8-9cd0-3b639ac7b765@redhat.com> Date: Wed, 12 Jul 2023 21:10:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH][next] selftests/mm: mkdirty: Fix incorrect position of #endif To: Colin Ian King , Andrew Morton , Shuah Khan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230712134648.456349-1-colin.i.king@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230712134648.456349-1-colin.i.king@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 5CB17A001A X-Stat-Signature: ojxt6pq6esbmgxdwz6mkebwnpfkt5of6 X-HE-Tag: 1689189052-11556 X-HE-Meta: U2FsdGVkX18FGTJdJHjifXbteVh3jiBrRerAYYbee+gpWupGP9EvR/hDsVn/0nIJ5YLn4i9rjKFShySfWFaRDaXzlKBA0ygw14N9Ya6ABE7MFx/k7nJBjdRRFJOusW8hQ+SvByEXgBQYDCGak+LMOTHZFOMHqWe057XIPBX2cEN15NDDztXpaAEvSoapd3FiyYYl9dQIkTLm/G5BG2u4LArAFjswBtjRSm3i3uHHUyR0A0v/pamQ9DiiGZjPzWFfSHtwQGOxxmkUaa4Q+Ak9ZBHVEkHPs7yuilSwlG5DC4lb4uLTbg+4ZHfaHyT440l3QA97wHQ9YbmDJYuJdE64vmAOSqHdgHYk4wvdUnP9MXeRwdOKRvFDGMfNZrx0iBWqMTwnNE6ZaoYZmjzRwN5onP96mv00H0c16aKfua4f/t7D++7Q+680N2DxxTYbUKi3X1ZRXnnshqnUEj0BOxYyB7akDEfv9SDpWLkbNsei2fJ43ntXNWzXAaPZlgrs6d1kVjeM1AvR7a5HxGkzSAVHIXoyBF41bMO016W7aoAXxkat/m+r4HmhreDWu1dav3JFVa+WDpV/TIdFVakvHj8NfJ6sE1GwDwcCkOsfA8v0s2d8cKaq07W89+rTNfjZt7PmbKSrpDD6/x68cweVgA9tyXadMQsvDwj7WOuADEIQ1VZ6DMudL5rcW+alNrBkGPZ6KYqu0lxZhBk/80LqQU02uLecnKiGAhxx5JGJRFTxyvEFvEnH5HjKLuFwUDimM/OqcRu/ZEB1gUa/6sUsNeaL+pBhlv1kMbCPocoM0kyAcwLh26ydyZPDAHappPsKl6GpjBjwwDBIqcK16bYx08l4SM7T6cZ9e35ZHlknoqbNvxzpW23U3PRlR4gotUpbH2+tgkUH6YOtT58uDDT53Zvsr2GFW6otsYJbpe+sdr19RuFkFkgWLvht8ajrg8BaYlslq/m79tzTPgbxVStIwAp FKWc/Euw 7dZ1TFXIQsScZ35+Fw5QKV+d44Hy+feuuPuhLNLW5xBycjOo4emam0vy3Du6s2Xs1MRn0WKaBOOtpZSLxAwjgRQvGbk0gZUx8KPswRISdLa4WRtes/7RHEYIfcijHAjD0yqiQEwrkK5vcfDaKC2p6kb/HLJsF2XBpDd6+gabGd0PFxqP54YEJXJZsiXyc/1+CpLSfug2QsuNoHq2xxj2OOHNycSqY34H8Yr1p4ETZWky8ZisYUJ5RlCTKwkPsxEVwCGrNvKi3eravGIZa9t92of7dNFrzKLeo1mxzegdt2KjjqNpomN0+aUOwVNPfA80HvpqhxgIYd1qaSnDpcfDJQWZvLaxv7TGrsQDInjFkOzT8uEhsNv5MOFa8RTQnO/juL/KkS6rCrpOpgoHeQANpkuThDbjWzFUa0HNuNG1tgG9kkR7mdqIyh9F5Q1XDVX22ojeDQzCbKk/HIIhterTF1XUqP41flF/SOdIgPLZDWoggbFc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12.07.23 15:46, Colin Ian King wrote: > The #endif is the wrong side of a } causing a build failure when > __NR_userfaultfd is not defined. Fix this by moving the #end to > enclose the } > > Fixes: 9eac40fc0cc7 ("selftests/mm: mkdirty: test behavior of (pte|pmd)_mkdirty on VMAs without write permissions") > Signed-off-by: Colin Ian King > --- > tools/testing/selftests/mm/mkdirty.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/mkdirty.c b/tools/testing/selftests/mm/mkdirty.c > index 6d71d972997b..301abb99e027 100644 > --- a/tools/testing/selftests/mm/mkdirty.c > +++ b/tools/testing/selftests/mm/mkdirty.c > @@ -321,8 +321,8 @@ static void test_uffdio_copy(void) > munmap: > munmap(dst, pagesize); > free(src); > -#endif /* __NR_userfaultfd */ > } > +#endif /* __NR_userfaultfd */ > > int main(void) > { Ouch, thanks! Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb