From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37A45C04FE0 for ; Wed, 16 Aug 2023 18:26:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8BAD928000B; Wed, 16 Aug 2023 14:26:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 844938D0001; Wed, 16 Aug 2023 14:26:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E3C428000B; Wed, 16 Aug 2023 14:26:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5A2F68D0001 for ; Wed, 16 Aug 2023 14:26:25 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 17D41120948 for ; Wed, 16 Aug 2023 18:26:25 +0000 (UTC) X-FDA: 81130797930.09.3F6BE58 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id 421701C0028 for ; Wed, 16 Aug 2023 18:26:23 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=QK3Ss4gY; spf=pass (imf18.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692210383; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qsxPjlfGZKQ7eOTanL7aXGS0H8ar2BnKFEV+v/cCuAo=; b=SKdRhwPn3UQcvGdUol7hoNLuNqK6N7TEzi89WAHub2DLaJNX5PmELX4N34Dz7BBVylr99+ hVjBM1UUvxVIpkiUCalu8U8Iuy45bqAfE/KxUKWAkPn4cKMruMk5eOcOP5AKYdhSXVSapw 3MPJRiqTvRUPskz8VZFJsGnGWeTZyM0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692210383; a=rsa-sha256; cv=none; b=HlvHZ4TqAPehhmtpFlZHbsTzX6i19Fkh3VO1/3TNlf834bLr2l7urxc5b9LqYd4V3U253C hYX87EW4tUl9gs82HEdOGwGRBGiIPt2GZN89k4/jWhAL+vgp9y2ZhJWifDR0/kG+/3wrLc 8JbaPr/eqcoaiMKgENwGewW1dr91KEo= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=QK3Ss4gY; spf=pass (imf18.hostedemail.com: domain of broonie@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2D6DA62A20; Wed, 16 Aug 2023 18:26:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3A3AC433C9; Wed, 16 Aug 2023 18:26:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692210381; bh=3lwZH0aCkN4fuwrTeQAhsYruTaew5rtoMeyWR8imUko=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QK3Ss4gYQANpF0kfjVDMhwPaCBnN7jcXmU+ud+rNTZoFKIrBrSXEwPGVGIBxSuBVa WPNXG6eJZ3FhK9KAyp3GfSYJ/zb+pE+4rCQknlaNheucXLhnJ67mh3RWIhFfKZTGL8 uXPBJpIcABURnESDC2XbooGsuC9LHy75ijzMgREdvGtpEQg9D9hhP7mVnrfKs6wg5o GOpKTl8nyoHQ5Shobze8RiECk2mqQteHONzc9PyVM6x2gHC7QohvJDw2aydMjS7K0r di+cOUZk4aPspJCVQsxXx0I5aMt2LWQ+6+xgwfkyKddkNk49YFt7sLHwaNqVbtpCJJ jeHDFcRu2mgxQ== Date: Wed, 16 Aug 2023 19:26:12 +0100 From: Mark Brown To: Catalin Marinas Cc: Will Deacon , Jonathan Corbet , Andrew Morton , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Arnd Bergmann , Oleg Nesterov , Eric Biederman , Kees Cook , Shuah Khan , "Rick P. Edgecombe" , Deepak Gupta , Ard Biesheuvel , Szabolcs Nagy , "H.J. Lu" , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v4 07/36] arm64/gcs: Provide copy_to_user_gcs() Message-ID: <60eeefc9-96db-4d4a-b0e4-751cba540471@sirena.org.uk> References: <20230807-arm64-gcs-v4-0-68cfa37f9069@kernel.org> <20230807-arm64-gcs-v4-7-68cfa37f9069@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tm7DmRva30JRxCzT" Content-Disposition: inline In-Reply-To: X-Cookie: Old soldiers never die. Young ones do. X-Rspamd-Queue-Id: 421701C0028 X-Rspam-User: X-Stat-Signature: fjye9waggpxc78roae6eiobq8epxi9c5 X-Rspamd-Server: rspam03 X-HE-Tag: 1692210383-376785 X-HE-Meta: U2FsdGVkX19TNgizq4q1/KdQSZQ5PPxbcPa+V+SF5VBFcqBC9tf6xmMeHxLS2p36xglmwHinuwR9ClWeKSDXC3+YAHQ8lnFJbV+eg3d3P9hHfJrL4QQBraB+2rKj5ZJQckw0DtlYIR84fwIPyTfNL99vvAf/NRYOFKRiBfBZkXxxIFV0xwjYFMQCY983Nh0s2ET5kQXl5MgFN6fy8TC3qL/k5VN/YXjI108SFAgcyeBdBxSaAiWj7tSnykozfIXHiNZV+6moJSGXaUecZm5AkqKNlLRwmZoEtDhF/LofnzbNnVylnKequq0mDMdtlHVsGuLYbU7MGkXhdwiNSb7jOjxJkJbaDH2AUso5SgoSBd4opQbaBJKCd2/WIpmwnZbfbP6JSvq9AoKdjDcTFmEGf/IPlkvAHzOFQY5yWNM0UEfWuWcx2J7AQTG0ss65WSFwoH/qHxqzkJYz1KpHwOJ2LSjQkuhihjUkXpX1ACDwhbbVwhn8JjsCCBbn1sMMhSh/xf1iWqjRkN6we0CxhPckv+6s7oXHYeXXY4ihJOgti2EbdvCJKSD3+C2BqgXmBGdBRg8LfeZewu5YicgHum5HdamLJvZ30y1nzqCFelnBm8nInVu9PM6kPvq7FVk3DfhI5qwftgj33MCmnywrZk2XuFTgkpgGfwFyMTZgsy0ehvujeV4oT+vN7g//dGZdqzG73csaN8lEVxO/tThwRt23+d719arHjTZ71AWPXu2sEtVFvjLBDUjToQJgSlBh7xLmAaNdSAkNOQE4jHQd7XMaMTvoZmEBYc6JTzL6jYj3Q/+XHFh73PxXj3P+YZcL4Az7V2Fi0yRVYajNbOwqlTNecnHgkHlJJY7NGnICuN893I+KtFFEYOp5AbymeINYhCDkkg74FdJmsgO4Ka+6gKXNOmYwsO+1+pbh/BPgZDcmVNpH/ezH9oPtI9M3X6K2EYSg8RhTpWaGuOXQeGmIkfM aIsKV1mb iEKXpBDwP46bMR7zfCuIqoA6L/509tUZh9CUheG0uHN1HsZy5l2JvzSU360wWvb5EFs3P/4dwPW/X6mkJzslJIT2UKBjebFGkQCxlLV6phq2Evl+Q4ILE0O74mY3xwMKpj6t+XOV1n/tHliLXEoQcQ4OIp9qyBYHlfj3vkjIYJzMV3JSEWj/2Sp/4vp8pSHtt6BdCIEr0RYqRSaEAbv261MzjHkGXSppD7Co2b8hkUjx5k74rb6tAXLT55h1iZfJwZu/aqHd3MlCa2CWach3b8S8LylUyOAT0deOXNVVEwK5Ns7z2+fuSJH5gvzIsEcWM2fZI5Vwky99baB3IUxAQdoCJTc6L7u/dVCbkZ6y+YkjMZuSybeC7JwrYfKm4aQRYb4bBB38xjZGOuN9GSLiu+KAFX6MvC6dWcLGXvglZ4oHBvq15eCGvn4yikW39nWU7HxJE7Bl3VlfI71ZkDoYKLGlqeQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --tm7DmRva30JRxCzT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Aug 11, 2023 at 05:36:05PM +0100, Catalin Marinas wrote: > On Mon, Aug 07, 2023 at 11:00:12PM +0100, Mark Brown wrote: > > +static inline int copy_to_user_gcs(unsigned long __user *addr, > > + unsigned long *val, > > + int count) > I think it makes more sense to have a put_user_gcs() of a single > element. I've only seen it used with 2 elements in the signal code but > we could as well do two put_user_gcs() calls (as we do for other stuff > that we push to the signal frame). Right, it's just the two element array in the signals code and the one element for the context token in map_shadow_stack(). I can refactor to a single read/write operation, I'd originally written it that way but I wasn't thrilled with either writing a load of fun macros to mirror the way vanilla put_user() is written or having code that looked very different to the other similarly named functions were done. --tm7DmRva30JRxCzT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmTdFMMACgkQJNaLcl1U h9DYQQf+Nxve6dTX12KVeA30x+OuPZrZ9604olhrpuQpYtFjAW9Y1s1V/zuJQfpi m2RUZwNwL8KLj0HHROEn6zCjxEWEgWDmYL0jocaZPRXfaXYATOaeKq/4ZNuZPTz0 T8WOwgOm1V+Oojr0s9tTF3eeU+TbqH2Pjn54/5nAm3/ZO3A3K/NA3aG1qVRgUg30 KC4cwnyO6b+WqMiy4HglvqDJiCFZXFEw8yTpaLuznzdX/t6qZ+XIkuiqDKn/ek2M Gzey1zWBfgdiqCsZDxAb+7rOoEnnyLh8qxMRQWzZCCEb2y/qihOUuFcyPsimZ8mU avhuox/i9muYxS6uDyrWVVaaN2t4bg== =OnPi -----END PGP SIGNATURE----- --tm7DmRva30JRxCzT--