From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAEBED6ACC3 for ; Wed, 27 Nov 2024 12:21:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6EE636B0092; Wed, 27 Nov 2024 07:21:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 69DD86B0093; Wed, 27 Nov 2024 07:21:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 517466B0095; Wed, 27 Nov 2024 07:21:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2EB206B0092 for ; Wed, 27 Nov 2024 07:21:40 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E4535AE54A for ; Wed, 27 Nov 2024 12:21:39 +0000 (UTC) X-FDA: 82831785540.20.D6B4F11 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf23.hostedemail.com (Postfix) with ESMTP id C88BB140017 for ; Wed, 27 Nov 2024 12:21:32 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=TjRCbQ+i; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=eynUz9j7; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf23.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1732710091; a=rsa-sha256; cv=pass; b=IIhbp6AMj2E39EgYGDAZ4R1wIXSfTvM4L16W3Ru7zQr5k0IkScpZzgohiSfbluL5YqcE0r MpMcbYqkYkaW+mphWHAGj4lAdtSO3f/zctrMVeXeW8whk7RAGS/XjyKn7Bj6hLy8IrVZjp WkYCDWanNywL05JpSr2yuUGXJ97r6tY= ARC-Authentication-Results: i=2; imf23.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=TjRCbQ+i; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=eynUz9j7; dmarc=pass (policy=reject) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf23.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732710091; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+x/tWu2qA+8nFa99lfcTFmDFktLhJhrZjQkV/NDsZyU=; b=s+AFkWFfP4mA1CZPFVe8CPXhObQCB8qgRGFj0f7zOJt9Zjc401HLDEM9subQhFVaKyPv2k s4e988PACYjTR4m5ueyUcp+ryW45LUqWJZzAN7pONWhhGT+APDd7kffWncXM32g7/vgzI6 IEOxZ8NRbnWVbXI45qA4BnMOUB3pXpE= Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4AR7MZwh000776; Wed, 27 Nov 2024 12:21:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=+x/tWu2qA+8nFa99lf cTFmDFktLhJhrZjQkV/NDsZyU=; b=TjRCbQ+iozW8HruOaZuSEpLEALbZLs9eNF u7VDuUKs/QYqhaQ1ItmukxdP94zH7/O4R7aXnoQeZHqiFI4vPMz77ClEjlcD8cEb QtWMSihef+N1Tsh8zNdCa2ZFo0jwWZf77MjKsfQZIzgJ6TqYB9Q0EQpQeR+XpPLk HbzJqCFGY/mzqtX6h1HLUF+1qVMxOY60HuFFO0DFatKuq5xG3GenE5aP2EerFl0y c8P9ugy98aiRPI5VnECD4wy05J8UCyWXPJwWfeX3J/G02tY6AVJVWQhJ3Cr4WM9F Sg1Ilf8gqyqPeZQKtRW7fcop8ufagzVF6CkawLDBGIQzPXudqdjQ== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 43382kfumj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 27 Nov 2024 12:21:33 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 4ARAKlU9023572; Wed, 27 Nov 2024 12:21:32 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2047.outbound.protection.outlook.com [104.47.58.47]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 4335gagc3p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 27 Nov 2024 12:21:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WgAWJtZ2p3uNiqznvcfXLSfn2HxfNvdu1OumcVPvJAGex+T42Yvv2+2ORE+vF5JyoOwLnCGT+JgjCDjkKvUwPiW3dhsqBIb5LgsLeFmBpf2ZgF2yxeERMXP4lMsazcZji6n58j8BIxe/2n9Ga4WLxG3D10Zs1sYk1Z/ouJFDOPrSF8ZGPxc4Q+cwxtekI18pSScP0olpOTZ1EYlbJ/LOZGYco7Y5iHXIcBLR2eMhN6Fi1K517mwWQJyo7rTsfKuSG/N1T3S01gioElLcxOYTEv5euCtq/r3lBaluCJ+88hyajDaL0CgaiAJbkfokV63kTNKYuaU3VZigt0ttuhaOSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+x/tWu2qA+8nFa99lfcTFmDFktLhJhrZjQkV/NDsZyU=; b=iW65dsJUpCUCaaixnXkC0+/sOcMjNz189srAKTr19VbipaecjJINluX37p0WYw6WdhnO/3YaXwP/e0FRN3u385BG7MlbSM5tNnY+tB/FQIT0tdEpoNfUgTQpiQrrpPlOarXkgC7P5R6YboNVi6nxjOcPzIc6Z2bBq3XpRFKReJLUHHFLtbMMXXjKSqieVZHfxB188VigWj4oCgU2gNadHIu9qyUNwnz/L+7aiDEQrB5CIGxLIK4ARLf3eXsbZ3vaBoiqEk9REOnmKT+4hvB8g5MpXQSUIZrU/gmJbw+6XdEKRgo+J52VrMZ2Wm7afRlspyyGqkuis6qda67e+/Ky+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+x/tWu2qA+8nFa99lfcTFmDFktLhJhrZjQkV/NDsZyU=; b=eynUz9j7svlEXWGLxj7F9L0aJVEE1VxXeUoWOwRdaolehvciOk/P3ahRsPnArNqV73bKzkHW2JQf2VADu1VRUCbeuxT5M1jvG9EZgHRB0HfbcnYyGaS564HS1OPhrHM1DGoRGwpsWX8QStzWPhQvcT+gowUBbgS57WuKAB9ZcTg= Received: from BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) by IA0PR10MB7255.namprd10.prod.outlook.com (2603:10b6:208:40c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8182.20; Wed, 27 Nov 2024 12:21:30 +0000 Received: from BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9]) by BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9%7]) with mapi id 15.20.8182.019; Wed, 27 Nov 2024 12:21:30 +0000 Date: Wed, 27 Nov 2024 12:21:24 +0000 From: Lorenzo Stoakes To: Wei Yang Cc: akpm@linux-foundation.org, Liam.Howlett@oracle.com, vbabka@suse.cz, jannh@google.com, linux-mm@kvack.org Subject: Re: [PATCH] mm/vma: next is already retrieved Message-ID: <60e4372d-a1ab-4ffc-a778-8de29f53b3d5@lucifer.local> References: <20241127114302.9650-1-richard.weiyang@gmail.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241127114302.9650-1-richard.weiyang@gmail.com> X-ClientProxiedBy: LO4P265CA0230.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:315::6) To BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB3366:EE_|IA0PR10MB7255:EE_ X-MS-Office365-Filtering-Correlation-Id: c679c331-994f-4321-6f8e-08dd0ede05f6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?AXVrVtQGRTjo6LEZRsVfrQJ2//EKXr0YeBHkbEupVkkZob78K7Ht9/X4lFZP?= =?us-ascii?Q?41BaffR0RzyKlEQWocWgdQI2Rr/9RQl06/v6sjWVbVzPI0c86oSMUcYrnE24?= =?us-ascii?Q?WsZm3DPfbYhP434fiOcJTvKFjsZ4lO/GNfJq+kbK3Us1H1mCCXT1ak69r57N?= =?us-ascii?Q?crl5lH5dAchL3W+vejPVHoreHiHOKNKJLzxJsB5EIq6uh298c2VYd1w3iAsV?= =?us-ascii?Q?G8d+BsG26SfEQ/uSuynRCxJl8uklH7cB+/pXApTf0gaDX43GosZBBXSN0/of?= =?us-ascii?Q?BWlpsBXdH6MluTtO3Q5jHry8yJ7CyV6prCBrtJrk6/GAM5BzxOKGYpT/aM39?= =?us-ascii?Q?XVjIVSlN1lUtQl2BkdH7AhZ4WXlGt4Jqtz3XdzT24k9nvjcqzzl90+DYiSG/?= =?us-ascii?Q?PT9t2ttwzYUp/qpU4qcVva6GlcsdMutvEgb7url2+uaK1BIfb3APi0N8JgBa?= =?us-ascii?Q?BOQCjcAI7wCY+gOcEFM0ar3Amf9AtTJXARVJ77YC1E0qi4auAU0we1U3BWWb?= =?us-ascii?Q?yEGkQniuTprBa/HSrisfAkyhrkh8zu/8F++QNtWIvLyESkfMtyGx4zYqis8z?= =?us-ascii?Q?ksYSTa3VFSdoEKUfqZnWR7er4KWAjDvS6QCnmPzNCWH0SgPJa4dJ2Wv9mepb?= =?us-ascii?Q?KYdyniad0cIzb9aut9GtZN4N9gsU/dI1/GHAw8I7Jo16+nuA5JubMXc1eUT6?= =?us-ascii?Q?OU2WX0QWg7j9zyQt9TXhawRRQU2BrfhXTKEIVQVuCeXH4hnUnd/zZ+9WXzTK?= =?us-ascii?Q?Fp8h7unCcIQUMiYJ0dfPcKJyVsGChs9HwNGrYnrmJV2KzcWmRKa5pazsTs1R?= =?us-ascii?Q?1MDKPxk7bmMkh9zcJvYSdRn4SG7rRcK9JftsOV0Tku4bTJ73zEMiBQEGends?= =?us-ascii?Q?m21+uztZtz1NZvL1RcFwUwqNjTFhBe7r3wLt5c2U9ut/GZILfU44832dU0w3?= =?us-ascii?Q?jr0usjHr6wFzVGcz/4Tc+dgHD0LnjHwZoyRbf1QoCQ1KX6OlIy8Z8HHlMSQL?= =?us-ascii?Q?h9R+uVXNNPck/5qIKM42e0+zChOciX1IyRjsEQsHedckrWyI91Ikc5wlzhAu?= =?us-ascii?Q?4n/RiaGK8xXg6DjY/NwXPmryWB2wkGfc8vXUN44Cov0cdE6Rzj61ViQJnvQa?= =?us-ascii?Q?93CXr2Efl8YaAqLEcpLoSWkElRjiRG9sfl4WKJTsvnd690PMQaNGIjHy5xMK?= =?us-ascii?Q?D4IPYT8YQKFffvxsK44/TeJP4RM7dQCKXBWqOaxT+rn5AdS+2WWXpecPAIun?= =?us-ascii?Q?rSkvEijGfU5Rt9qQTvM/svpZGOtAv2Y9lE75Qxwg1xKdc5v1Totz58rJJBE2?= =?us-ascii?Q?OMG1Z3heUlglpESgWYZ3QMIZyJNl5S1tbd4PvVXqVk7TQg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3366.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?82mk6+yegCuzLoq1RASnhIo+soZyZ1F5JFOq4X4Ws9WwWEfx18e78I51rJl7?= =?us-ascii?Q?2XMFAFuv8SdYOWKu06/fv+jIbgBmF8Ur4Y7GCeiTSRJIB8w5ZS4MUvbS1MCA?= =?us-ascii?Q?eyVDNXcnzhctYmB3tzHrs6ubw/CQ4sBgU1jrRCWyrFY+O7httx9X0JrRAvDO?= =?us-ascii?Q?P8e48f3I4ULzJpbj3QqBsCQC+XgvnrPGs0SV7Tojw7aURA150kVaAd71ANF1?= =?us-ascii?Q?GZm1UmriE9uzwQ5OfJBygDGeRI9VR38lBuTHVD8WWqNz6qRcI0Pf9Hcz5ntJ?= =?us-ascii?Q?pXgyCnUoUk/BB+FElpQSCBz+PcB38sVhCHQZkgkx5D6zkqJ38R+CW6nmxIme?= =?us-ascii?Q?0RM3X40/nCtEmWAR2OB/7iILK+wENm+zdLwgXomOX02/tNE3+fnLZNAtUUwt?= =?us-ascii?Q?i66RQgJvhWQu4FEMK6nQj3+CxCu5dWlFt5S/kyiDTLs4Fe0wmjbP1oeOPCU+?= =?us-ascii?Q?u6rzdb6mmMD5mQo7F5+o1AezqJq/P4sRVh+aYGJ8tIpW+enwlbZ5yFdxNF9b?= =?us-ascii?Q?tFZxsweUUMrRmUYL0j68u47qB08dF5N6yFUyteotHatj+ELsRVCPsIno28k4?= =?us-ascii?Q?vet4baR5Z5o3s7cgIQ4wD4NJynRyGZTPq5pRfL0Fpr0Z5C0Q8SDTLQ60Ux7i?= =?us-ascii?Q?977i7n7DMBdFUZD6TjDBE0aEI6wr1IkdSrz+YTH8Wc1fsOHyzPNxKB+VWAAR?= =?us-ascii?Q?6PmzcbwfcKdKSvgstvfPzgw+XQ0qe+l41tE72ShyowVQBxnoAUmSqnaYr1PX?= =?us-ascii?Q?1UWH7pxppF50/iAURx0GQSGgR5FPPqpssv9UPn/HULIs5chRPNuDc31mfXxA?= =?us-ascii?Q?CYpcXG4IMvocDwWcxuyqnVG+jRFxFi2GmF6wbAZ2n0Zr3sVM94dvCJX+/Hsa?= =?us-ascii?Q?QrC/uBKNhHAPWRY+I+Ir+cIvHHtcS1ZTtj6HHxwLyIgcPGvSg3biTDmSDhx+?= =?us-ascii?Q?wz/G8FLEM30XANCkJdG7bKGx+kD0p67F8KxSJUWav4+qFybPefXo7zrevSW+?= =?us-ascii?Q?vrldURREzb6qdFn/KWVb1QBPpdtd44ZtbzRQO/OvRymKy9Jd8BCafcH8BTOE?= =?us-ascii?Q?pJ42xuIRO3ZPQ5//5Db8zEQaJPsftPDZwFpBooLh3uZjb2jeb6KcVWNCjOJK?= =?us-ascii?Q?xB9USSu6gYqVsgmxEtjfLW9iMjJW31C+8kZYEaRXrMObI9zR2cpJQiMsD2jo?= =?us-ascii?Q?2lwsIIM1v0kY/KbVOlEqlD3qkDpCzTRsqXIP6dwzBzCPnmVRyki8mojrLUge?= =?us-ascii?Q?stfH9vBFgYw1baj2OOv9rufTCZJKN/97BD5fiCoHpBFOu2mkDQAnzIc4B6aN?= =?us-ascii?Q?M48xZLls6AgbFK2PWmtbpe1WZgz6FWO1JHbWNdmD3Qc0sln5DUwvBU5Q9K15?= =?us-ascii?Q?jpULbidVFxHgVdUrzEoFUfO8KcupJqjTGN7NNHUempUJeM8iNIAUdYzUXCxw?= =?us-ascii?Q?aj+tFsOQxIaM7ftR7yWHQx1u4LdCr7zRFl/F1Zsi/Fz48uv4ehiy9rFV/fAO?= =?us-ascii?Q?EshXYEsjxXuRNjhOMdhFzl3nkESAcYodwKrcnAI6JsK/75+MOcAddwRea/YC?= =?us-ascii?Q?2NXf39POo6cmQrS9kxoBEfEMMBg6VNTl7/pXRhezx6A0sWMDHPxKchv1doYa?= =?us-ascii?Q?JA=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: WDi2sDX9pZ9ar8Bbd8HxjQKbiW5mNPAmKAW24vs5rrmgkMefaSa2J9MY7CZsUUDLk8llKz1pcDPw9hA+XGcBGUloyH4J+ACizonLo9+yHpylGXzwe57FWRVaT4+jtaprIboEsXlKsBVfuEghs2yeyA/LoaR7kKl+o/bGS1Hcrny05YRSz9W/goYTQy9WxD9e2OxD31fPRsqVpGvA2rctEwuzXKRPj/VmnN/zXtPsZxxG5FEH0HCKEsDflInOV+cuXGtejI5T7QHebUNwKYKiw9YK9lvKpwlot/JrCBiWHxQOAmtWFYMeLOkBoknJDkhaPebB0ESIiixo8+GjgZ/kW5Zj/5TFOOB4UD/OUgMPd/LEomNdsy6VJ2WlLYFI0S9CGa6cauVKpTvHL9dy4tRKUPSvFeUWq9uJg61zDliogLF8p7mKxA3H7XMjmSrXk6UKzviv5PMxk/Zh4zJZnXHaKqj/kQwzm8v7i6p2DoUrzb9JmPOqz3KnaxOrZa4PIq8V9idHUzjSdxEMQQ0TiTKzgG6Gl9UnuauBfLIyi6QUsn+tFEDgw1iAWLvKNyYgK+hOQX0QT41o9mCjUvBF/nxPuNqgjJuJumbkJSn8xw6EO60= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: c679c331-994f-4321-6f8e-08dd0ede05f6 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3366.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2024 12:21:30.3310 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4NdqhqZJFN0HoLjTX+bdtMxRbEIM0zgUPIIpJIorebY8K7/gHyL7eRjG/tJY0cdbIvNJnNtfM4AwCc7rZ3gxrNt2HvmyRMnN1WxLaynIyvQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR10MB7255 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2024-11-27_04,2024-11-27_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 suspectscore=0 mlxlogscore=999 phishscore=0 adultscore=0 malwarescore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2411270100 X-Proofpoint-ORIG-GUID: vtxHXdh7IARsgwSoKt7EHefkAeLliGEO X-Proofpoint-GUID: vtxHXdh7IARsgwSoKt7EHefkAeLliGEO X-Stat-Signature: kx6gorttssy19xwodsejb6rgidngqb6f X-Rspam-User: X-Rspamd-Queue-Id: C88BB140017 X-Rspamd-Server: rspam08 X-HE-Tag: 1732710092-970258 X-HE-Meta: U2FsdGVkX18Y3fr9hStE5g1M47srYNk8fPhaarm/7q/fJSYIUNoi9FYddoQ7ukwLcjRaRWq/x22mP5D73aO8X8IwD8IRsfmG5q84akgIINI+5EGQ8WXfdRMdUdYCmIV/miGFL4CtsgMVfzDSH9gb+E4NOsuS6RNZnS9PkbMLJe0pCRZazldWHgUF1Q2d6/Sa5wNAH7rcRw3cfNn3fVhp1tRdayIhBOlLINjCak3/n+sPSwIMWACML/qHJ/0icbxA9ILCf2mWkMx4f564d7R5MiR4dvtQS3WX404H2Y8devURQzlV4rhQgR3yOZdpkBNDYyFsEWFxWZTrqjDpoiWXn/SEi8rFqFWT+KijHGMAN+GKMRMCzh6R4Ct+4ySG+B6VhWOOF9x3gpgaerIT67Duw9r7wtVwpgv6InhPx9R1IN8ljResqaCxPzDzbynjwRBUmWX3gP2E3LRhjLrT0mIvguFnnUa0jobrF0pkAcmn4n1/FYm3i+MOr9lF9dtiW20JPk0gNrYYhLpI+FzG1/a2FXOrVP3Q26Q1SHeT/I0jpfRx5GqXd5Qf8KZL8xqtjdmz83L3YXsmmbz7wUFWjvDmEtzNIu6icO8EeCaPwHh9owZbPoCO7v6/vaSvfP/+J3nBXhZh6PNZTKen6eO2kewN7L3ifuXwJFtSLq2uJhX7+TGrdvXtisZ80VAiCnTzDPNbceMJOzhvvsIztOd9oTwWEOaQN+R3D3ipd/Ygdj9fOCCZtYw5BxzlwYbPy9AXfFrVdmzyHzY2tUELNrWdkahzqPs3TOB0/AC5VvlCKPLNT2VVLxMcbBSA0xkUqnS+u0qfx4XZ2vr9L/l+PWzTDjB4OTiTfWCrTCS8J9Ppse2sNDFJriH/fLaQuS2UAUmzYAPsiepQHgGvl+0QQGpKoOXHVTK1lLDquP/VNFExg7s8v9PmdYqCUaTDuRB9rcuYsqBYy+wK7w/Xqzc2sbcJa4J DPoPHAav 4QWmreQbR+467MENK3QD2auA5THCbkN6AcqYCK4pv/EskSa32sONKHNxp98hQoNUwWB28QeAeF5YFsLP9B9tJaswgin10qqcxdbXcylQ5xSeMJhpPAqODpakPFFh+iG+jS7UIaD8lh5Ab1U3umIJWfP9V7vutS27anhY67jebXW+Eh9VZL6YDO0Df2yulFYtVFjDq1so8eB0OUhxjAoB5gvPk/vBcrR/VhzOY9zMEfoclpVJRqQqFOvlS6Z9fPVEA5i+9jGX78JYI477MWzoYUvI3N3trYdlaaDtp/jJ7IjkKRpSo1mdFiXBb5O9MkojR6uoHXO2BF1X724WQuBh2UoKDTEp/8jMLzmaysYfcCluiWrs3aWSYLUEvzJxGAopTw5C6LCQAeXNSk+W/haTt175+Qrs/uLCVbWvb9aPNbvx5YPYAZlV3xkNXZ8Wk8jUpfcwaTHcvbWOY80RqpbxwZ1gLhRBpd/EUUgbRKpZYPRVfVLsdUmikhLZT/7X/6+LvI/G4i3e8519Ulw/WrjHrtyTrcbP1nAvZo9GWQ+nQdx3hdzu97woSBRvR+izcomTeeNa2cFotDRgHf3UzDVxkru4K5b/5udo2H3tlERl6LUkpwO++jxEEYkQUHv9pF1RqjCyRFyHfMqdJ7AKwGo/ANd52kor/htvVrvWpXWQqN3yB2LkXPi7OvV9tcQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Wei, Thanks for the patch, though I would again ask if you could please stop fiddling around with the VMA stuff until things are a _little_ more settled, perhaps best to leave until the new year? I'm talking about small refactorings and optimisations here - for bugs or major issues - please do, of course, submit immediately. On Wed, Nov 27, 2024 at 11:43:02AM +0000, Wei Yang wrote: > vma_iter_next_rewind() here gets next vma and rewind iterator. > > Actually the next vma is already been retrieved to new_vma. Since the > iterator is initialized to addr, we don't need to adjust it. > > Signed-off-by: Wei Yang > CC: Liam R. Howlett > CC: Lorenzo Stoakes > CC: Vlastimil Babka > CC: Jann Horn > --- > mm/vma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vma.c b/mm/vma.c > index 8a454a7bbc80..d419e3700fa7 100644 > --- a/mm/vma.c > +++ b/mm/vma.c > @@ -1727,7 +1727,7 @@ struct vm_area_struct *copy_vma(struct vm_area_struct **vmap, > > vmg.vma = NULL; /* New VMA range. */ > vmg.pgoff = pgoff; > - vmg.next = vma_iter_next_rewind(&vmi, NULL); > + vmg.next = new_vma; HOWEVER, this is a good spot and you're right (I mean we explicitly _check_ that the found VMA is after the point at which we intend to insert the new one). But while we're here, can we fix this HORRIBLE variable naming? We reuse 'new_vma' to refer to the _next_ VMA and newly merged one/one we have to create. So could you update your code to do something like: vmg.next = find_vma_prev(mm, addr, &vmg.prev); if (vmg.next && ... This self-documents your fix, avoids the need for the vma_iter_next_rewind(), fixes the inefficiency you've found, and avoids stupidly overloading what new_vma refers to. Also update the commit message to refer to this. And can you update the test_copy_vma() test in tools/testing/vma/vma.c to explicitly test for VMAs that come afterwards both merge and non-merge cases? It's time to really start taking advantage of this huge power we have to userland test things! :) > new_vma = vma_merge_new_range(&vmg); > > if (new_vma) { > -- > 2.34.1 > > Thanks, Lorenzo