From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0D8EEB64DD for ; Wed, 2 Aug 2023 02:59:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 65C3628011E; Tue, 1 Aug 2023 22:59:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 60C86280112; Tue, 1 Aug 2023 22:59:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FADA28011E; Tue, 1 Aug 2023 22:59:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3F891280112 for ; Tue, 1 Aug 2023 22:59:40 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0FB06140D01 for ; Wed, 2 Aug 2023 02:59:40 +0000 (UTC) X-FDA: 81077659320.28.F3AD48E Received: from out30-100.freemail.mail.aliyun.com (out30-100.freemail.mail.aliyun.com [115.124.30.100]) by imf28.hostedemail.com (Postfix) with ESMTP id B4F5DC0008 for ; Wed, 2 Aug 2023 02:59:37 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf28.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.100 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690945178; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=00Kr7A3Y/z3EXiCSo6LqRvW7dvznByRWDrPNCbm9gcM=; b=0sBy62nmvPHrMISPhDTMIF+mwHYStBe3HWoX6VMfryiwrP+/kNqW2KntakGMCnYcPpMNij xnLUBfo6M6qCTBuL0uag2asZ4nCAoIz01iOnpzBO3d7I9wt+tJ91w4LSjr49ubo5vG8NOY Yndpk0FAWIV8dsZhRZXFFFGBFJVxqgQ= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf28.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.100 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690945178; a=rsa-sha256; cv=none; b=pN3BG4YfPkOaezeYyHH9uS/UdEkFFb2B6PwTGTD5Jol7mDTLuiQOOc8H1HwUKo0DQhHhQJ 7nR4NI8/Rq+Y/8nLhA5vIr7qVRgNK58sYdMouTmh+KKjYaX8qHC4w0EjZ55azlnXmk43Vm N36oaxa5f3u5n5OMNM6pj+hSZVgK5lI= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R661e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0Vot7iDF_1690945172; Received: from 30.97.48.77(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0Vot7iDF_1690945172) by smtp.aliyun-inc.com; Wed, 02 Aug 2023 10:59:33 +0800 Message-ID: <60c83ca0-de10-1c69-b03f-e3b73c2d01dc@linux.alibaba.com> Date: Wed, 2 Aug 2023 11:00:00 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 5/5] mm/compaction: remove unnecessary "else continue" at end of loop in isolate_freepages_block To: Kemeng Shi , linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org Cc: mgorman@techsingularity.net, willy@infradead.org, david@redhat.com References: <20230729174354.2239980-1-shikemeng@huaweicloud.com> <20230729174354.2239980-6-shikemeng@huaweicloud.com> From: Baolin Wang In-Reply-To: <20230729174354.2239980-6-shikemeng@huaweicloud.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B4F5DC0008 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: upkoxm9zcu7ywchozyazj91bipryjees X-HE-Tag: 1690945177-238964 X-HE-Meta: U2FsdGVkX18HTj3C5gPyUcfCpPG34vQywXTvQNJLwNov9Ap1rI0TF30NfLCqdJVI4BjAeg1j/xqktAYwe0N1p75MYJVMGE9awy9C3ONUEyHNtxtF4W0KDfhFDjcCDGF4/W+IqpGHgYik6/J2JJwNdXjkGtppyVjKJWr8oijtVlj9pCwq/qqT/afYWmX4XjgUeNK/7aSd33OWVFcgcjf62vWcwpVa8Hk40T3V5vEJ9e8ZP/+lK5a/bICJVLiw6ct5gjli8ya4Mq0lGh0boaTVqz66ehnsfhvUXtRbA7H1cJfv/qNjr5waWrX0Rj+zILDTPxsM+0K3bvzB4uRkmU0wqaueCvpub6QjaEooL83v/ThWvouHQM/ZkJmg66Z2fVXOuh211eaHN1PJKttRFs4TipHj0jJf2OrUuOSIG5I5+svcslmvFQBgo60uoAZsCja0jH0BE/BAypNVcm3uYuaYrjT8E3hA8Es36ojG5N+e/ddCV94gnn1N4a/m3LX+M7kUDHJDQ0x15DbtJ+oCZNoSPuSBExG3ZOGaRJ7w0/qm7rpF9Q8YlYhIDKCAmEXjUoglx5cFXb01zK+rrwM22UjJ540H6cEigZ215MQyTevWKZYvQn66m2uxuT/Ab3QfqUMaz4h4+V+z/+Nf+XOW85SFX9GkUMTOBE2g7+0u755RTv9T3cnkYP2dT0tu0m90cxEpP3+Xt0Q6Pk5g0xGRzEx/+K5R/molTMnj4rYvem7SOZIZlPIL8jYt86AmlqG28tMWf1xPW/cbfE8JYS1Od/QgODD20cDPqlrZJHsXi4R7GlIKhLt72N5HvtWcCK8J1Ef1kLK7sv8Oz3itZQNX8VBnfBCYrwvDQnE7MbxjpdlmkyOtdzzPssNdabowylRHsqJWoTx/g8sQpOfnA3j/xoXM0PSsFvVSdEKFwn6ucxiqAJJjq3JCjViGXh0UKJgN609Jha346y25//8wdixidHJ jm6/9eeJ k1TZfr4yNk8hIEblMKn0U69q2x6Vu0y+pidsnFYrCYoLOFNbodKuh7hujI7fK9+J47FrlNtReDDlUHbnxV59VYQNKk5rwB2SyOtaL6FgCvDwCsoEAhmFC9DhyNSPcbP3o9MJqmvd+eQUxYw3GkL+Q37EW9Hn/nF00WVeLiwfHCuf0Z2GB2Wc0PCL6AgnV9IUhmbldtQTkHqtZAy9AM9UTZYQ7Xbov3mT611Vg0x5Lo6Ty5Hs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/30/2023 1:43 AM, Kemeng Shi wrote: > There is no behavior change to remove "else continue" code at end of scan loop. > Just remove it to make code cleaner. > > Signed-off-by: Kemeng Shi Reviewed-by: Baolin Wang > --- > mm/compaction.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index cfb661f4ce23..d38297018077 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -670,9 +670,6 @@ static unsigned long isolate_freepages_block(struct compact_control *cc, > isolate_fail: > if (strict) > break; > - else > - continue; > - > } > > compact_unlock_irqrestore(&locked, flags);