From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: Kemeng Shi <shikemeng@huaweicloud.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org
Cc: mgorman@techsingularity.net, willy@infradead.org, david@redhat.com
Subject: Re: [PATCH 5/5] mm/compaction: remove unnecessary "else continue" at end of loop in isolate_freepages_block
Date: Wed, 2 Aug 2023 11:00:00 +0800 [thread overview]
Message-ID: <60c83ca0-de10-1c69-b03f-e3b73c2d01dc@linux.alibaba.com> (raw)
In-Reply-To: <20230729174354.2239980-6-shikemeng@huaweicloud.com>
On 7/30/2023 1:43 AM, Kemeng Shi wrote:
> There is no behavior change to remove "else continue" code at end of scan loop.
> Just remove it to make code cleaner.
>
> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> ---
> mm/compaction.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/mm/compaction.c b/mm/compaction.c
> index cfb661f4ce23..d38297018077 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -670,9 +670,6 @@ static unsigned long isolate_freepages_block(struct compact_control *cc,
> isolate_fail:
> if (strict)
> break;
> - else
> - continue;
> -
> }
>
> compact_unlock_irqrestore(&locked, flags);
prev parent reply other threads:[~2023-08-02 2:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-29 17:43 [PATCH 0/5] Fixes and cleanups to compaction Kemeng Shi
2023-07-29 17:43 ` [PATCH 1/5] mm/compaction: allow blockpfn outside of pageblock for high order buddy page Kemeng Shi
2023-08-01 19:12 ` Andrew Morton
2023-08-02 1:57 ` Baolin Wang
2023-08-02 6:01 ` Kemeng Shi
2023-07-29 17:43 ` [PATCH 4/5] mm/compaction: remove unnecessary cursor page in isolate_freepages_block Kemeng Shi
2023-08-02 2:59 ` Baolin Wang
[not found] ` <20230729174354.2239980-3-shikemeng@huaweicloud.com>
2023-08-02 2:32 ` [PATCH 2/5] mm/compaction: set compact_cached_free_pfn correctly in update_pageblock_skip Baolin Wang
[not found] ` <20230729174354.2239980-4-shikemeng@huaweicloud.com>
2023-08-02 2:56 ` [PATCH 3/5] mm/compaction: merge end_pfn boundary check in isolate_freepages_range Baolin Wang
[not found] ` <20230729174354.2239980-6-shikemeng@huaweicloud.com>
2023-08-02 3:00 ` Baolin Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60c83ca0-de10-1c69-b03f-e3b73c2d01dc@linux.alibaba.com \
--to=baolin.wang@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=shikemeng@huaweicloud.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox