From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BF6EE7E636 for ; Tue, 26 Sep 2023 13:50:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 680876B015B; Tue, 26 Sep 2023 09:50:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6310D6B015C; Tue, 26 Sep 2023 09:50:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F91E6B015D; Tue, 26 Sep 2023 09:50:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 40F126B015B for ; Tue, 26 Sep 2023 09:50:06 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0F0D8B375B for ; Tue, 26 Sep 2023 13:50:06 +0000 (UTC) X-FDA: 81278882412.14.3A2309A Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by imf10.hostedemail.com (Postfix) with ESMTP id BCBBDC001C for ; Tue, 26 Sep 2023 13:50:02 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=xfj7LYPX; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf10.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.51 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695736202; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:dkim-signature; bh=cRs3HHfGHaH5W3/uj1x1VaVTGyeeNQR7KwXCiLuCrmM=; b=bdfyWrUNOeWElOv7hnuNI+oJVaP1VoSYkalXL54RHmwH/CUR4OKbuvKW+KOv9rma45PRZa 8nhfwr/XZuf9ZbePXAUEwCqCv2kffYiFRs4kwSzxnmH+w8Wsy5msUWg1espCyesxM9hCM1 4BkNJwD7g17AK6kp5wZZduXymttaB9Q= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=xfj7LYPX; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf10.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.128.51 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695736202; a=rsa-sha256; cv=none; b=SLpa6y/UsvckRUZ45lYUbynVta1O9F0JUTPgc44+BssVzHKbyKYQJqGlIMhMwFyhnkIL7z GZ5Rb49jgbZaDVFBZclR7Nij3Mb2Tk6CnvXY7/eN4DposBTrePlNu5bYoq9dKs4swbZm6j pYfECzhUZWYZSkYOtjulDq8rxUKJ+8A= Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4053cb57f02so77179825e9.1 for ; Tue, 26 Sep 2023 06:50:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1695736201; x=1696341001; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cRs3HHfGHaH5W3/uj1x1VaVTGyeeNQR7KwXCiLuCrmM=; b=xfj7LYPXxbRlwSbd4v52HGgboN8C/oNLxb0cq3ymJRLx/lq8MO4guLbQBnob2J1lhD 4UqbKk/uXE/poAU+Ch56/G8lqtXK92lr+D0eNisVXMVmNPWPdPtmRXrn2hJJ6Ez+dtM1 xvgtsKXF1Dq1Zn0rgJNeuQsUasbJF5wE+vfA5J4WPHyeJQL4WpTceQhQy/5IkKG+Wsiq 2WFSzHMdP4X7alwF/lSQp4xYmt9stHnXxgF37At6S1jnsdgjT5+F6HjBGsaDOX6I398L dLDk16hZM4t1IRzsB7ubWyRjF3lyfDh2WzkdvJEVsYH+fPzTxO1TnYwz3b1+zmzEZGjw oMew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695736201; x=1696341001; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cRs3HHfGHaH5W3/uj1x1VaVTGyeeNQR7KwXCiLuCrmM=; b=L5fLZ9Qfb0/boxmMnoJClgqQwAy0NtWA0IsMrq99OcYE/0wf3uITVuwm797IIDvG1W fm0JGc3VJIlEkXA/Vq0Q7vD78qMvh3gWXncQi2zo6Sv1WynomIvl3VcBa81VJx+kqrQu lHKsTWTp7MQMmoX2eXroc3rSLuD6clL7FFAzSbnad1ejUTDu+eDAm1Q+lc+51iBT7Xq9 AvVnm0nPKNlUd+wKSm+gdMdSci/1wwJN8MOH8I7wTLV1DA2Jdg7IvAm0VVy7uFwcIdIo GUfMmwwZsZGwFz3XH7CKMLe5TpZZ5SJg4CklmPqfruoZYkKB8mrLEfM08a63iNs2CeJO Bs+g== X-Gm-Message-State: AOJu0YzFP9/53Y9iN66eL5vPb9omK8HHrJ2S4UqRPucXHwjKtJOtb5jb vtYFb37+TtyrQ8IAHU3lKNjaPg== X-Google-Smtp-Source: AGHT+IF91hGN1iRDS8YgIh/vPtUJ+zpofgOyE21tn2k4Y0dzzbVuW2uJnDRcsiLSCzeUbXQdNsr/9Q== X-Received: by 2002:a5d:4fc9:0:b0:31a:dc2e:2db2 with SMTP id h9-20020a5d4fc9000000b0031adc2e2db2mr9310520wrw.49.1695736200924; Tue, 26 Sep 2023 06:50:00 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id o11-20020a056000010b00b0031c52e81490sm14821340wrx.72.2023.09.26.06.49.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 06:50:00 -0700 (PDT) Date: Tue, 26 Sep 2023 16:49:57 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, "Eric W. Biederman" , Sebastian Ott Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, Thomas =?iso-8859-1?Q?Wei=DFschuh?= , Alexander Viro , Christian Brauner , Kees Cook , Mark Brown , Willy Tarreau , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] binfmt_elf: Support segments with 0 filesz and misaligned starts Message-ID: <60c7fdeb-da32-4d21-9e34-368050224d6c@kadam.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87jzsemmsd.fsf_-_@email.froward.int.ebiederm.org> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: BCBBDC001C X-Stat-Signature: 83nt6maeum7d1yg13rmojgpnf8tysiih X-Rspam-User: X-HE-Tag: 1695736202-324122 X-HE-Meta: U2FsdGVkX1/1wGf8cs28Z9bpLnyQ54RTc3okXmuWutxJdqkLMRrc4/iJugS17aPyNsjH+ktFkceIBwo7O0v2j8WIEayOBi3hR38/Wxs2ewMH3gPsEbe62KnHnpxRzT3FBI+RuDHlSf6v9PycpHn7uzxfvRdDhTmZj28kl+4kdSyVL9zpo9ZEi2yzo32QFrBO/Tuv8F61j512DTIeCReTDEyahAep1KJg/cBT58QpHUd0FuCCtjk1OZMH4I27wjaMGB++6jaC8y+VjtfPvmYtPEq8d5liTPNUMha7OyeaBg4lYZaKvuagRDaKviDRM3TIvi9EJ78QffRfPneVZFX+PUl4ziSzxTweh8qqN2UsDFJlMPAcUbrS2RtAfxpxsxtHPDZ1GlKIakHJP1bN87VqrW8VbOCccDDJU7umI4JFifFsEm5+qmwMeGx6JVhs+iQjk4CAplUAtG571bhx7dFVZcdtnJNVZcbFSdLvyQVmD+bSQSdysrY+Ae7HJk/S7Xx28E95kFyH4RnjJTcXES0NZABT9uC1orQFkiluCCxjYoOgYlKC4c/Ad6CEZmsjPWXBYb9hmlZsEn77iPvBV+fc623sDmSUhpizxQONlyY3jI7CHbMLN2gIi0Jgj1eADgojJPYDZZZh259V8cZesyxLLHj7LQ+1p9x/HnY1o7dqti5Ij2VDQDObDxvYMKxMKbPZYsM5EMuPkqWFqY1FOogyz4ymxXAnJVz+FTujRg0dWTPMW0twtd0Sf5YCBzGrs8bZ1+usBGlRZpgCQ2L/++YWPuWKOIw+QEpewiNsuZUDltoNU9RHPo2VINZOGUJ59eMqv8cBKK6/l1FJ9fVRxpiktBqAcwfga/ph1wlT9LjJyTa3TnPPXSf4R8P8u6QIV4ht8WvoVgQirLvvGNTiQblOuMS0ZXhqCKw5iEhbDMBI8A2TOXXJTURZ/cwqXgXiOFfDfzoChdOayWWF8wdbafC UU87Ij61 Ag3r/hXz5ma1OGxsvjctzcmHfSm7sZIpnkR5FWwoDNXIi9BNV+Yz+So6qEz3wM0hjdc+WT9oBTZljhW37xGIX1g+Wh90pSec91wkSPj3y8ifMgMAVrIL3Iptu6ndKet3agcPeOfc5YYVvCX1eoRp/gBfj57swaSDwUWDC2qtRR75zbaLeJSp7qsXjENcjSyP33TQu4dZM/78n+7E5OwxwbO06poL0lpLvEmA4jvSpKwCzmyKX9DNF4LPGzRy5ERNK953cdsr4X9D07Z2IqMV132ScXlIljzcxX/2dm5fZIOuBhC6rIIjMdx1UQRkfF/MWD9X3o9W9pukT9eFDXje6aiByZAg2rvp/wP2OXyT4rmQK6ZMOjG15JtFaQbIBoMH9AneXEQ4XqoEuwFlTZq+dQIBAFZ/t5iIcrQPUNED4wtLSSA/w+sInBd6b4S5Vh7UpwIefnIY36oXnRKk/Wde6ZUu4dB/NMEQ6x9Nria0WtSzekkXnIqecwdmMzNrRHupwr0pb4rEvMu5G8OPAFTs23eKeM4AWb/F0CL0+4gCTkkNZt6cj5EGnIzLslQwKk+OGEB0kxtE5rtEF9bVGeE86siET/N0E4EdSRmvF9dT5M3kDDRUxmzRlsTCtS6zmvH8HD2TN5BDDik8JlnEI0r59MtzoajkAH3ecX+1pTeXDm2fB1xA5/6Nco1r524/0wWWoTT6U X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Eric, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Eric-W-Biederman/binfmt_elf-Support-segments-with-0-filesz-and-misaligned-starts/20230925-210022 base: https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/execve patch link: https://lore.kernel.org/r/87jzsemmsd.fsf_-_%40email.froward.int.ebiederm.org patch subject: [PATCH] binfmt_elf: Support segments with 0 filesz and misaligned starts config: i386-randconfig-141-20230926 (https://download.01.org/0day-ci/archive/20230926/202309261925.QvgPAYL7-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce: (https://download.01.org/0day-ci/archive/20230926/202309261925.QvgPAYL7-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202309261925.QvgPAYL7-lkp@intel.com/ smatch warnings: fs/binfmt_elf.c:431 elf_load() error: uninitialized symbol 'map_addr'. vim +/map_addr +431 fs/binfmt_elf.c a6409120b31666 Eric W. Biederman 2023-09-25 390 static unsigned long elf_load(struct file *filep, unsigned long addr, a6409120b31666 Eric W. Biederman 2023-09-25 391 const struct elf_phdr *eppnt, int prot, int type, a6409120b31666 Eric W. Biederman 2023-09-25 392 unsigned long total_size) a6409120b31666 Eric W. Biederman 2023-09-25 393 { a6409120b31666 Eric W. Biederman 2023-09-25 394 unsigned long zero_start, zero_end; a6409120b31666 Eric W. Biederman 2023-09-25 395 unsigned long map_addr; a6409120b31666 Eric W. Biederman 2023-09-25 396 a6409120b31666 Eric W. Biederman 2023-09-25 397 if (eppnt->p_filesz) { a6409120b31666 Eric W. Biederman 2023-09-25 398 map_addr = elf_map(filep, addr, eppnt, prot, type, total_size); a6409120b31666 Eric W. Biederman 2023-09-25 399 if (BAD_ADDR(map_addr)) a6409120b31666 Eric W. Biederman 2023-09-25 400 return map_addr; a6409120b31666 Eric W. Biederman 2023-09-25 401 if (eppnt->p_memsz > eppnt->p_filesz) { a6409120b31666 Eric W. Biederman 2023-09-25 402 zero_start = map_addr + ELF_PAGEOFFSET(eppnt->p_vaddr) + a6409120b31666 Eric W. Biederman 2023-09-25 403 eppnt->p_filesz; a6409120b31666 Eric W. Biederman 2023-09-25 404 zero_end = map_addr + ELF_PAGEOFFSET(eppnt->p_vaddr) + a6409120b31666 Eric W. Biederman 2023-09-25 405 eppnt->p_memsz; a6409120b31666 Eric W. Biederman 2023-09-25 406 a6409120b31666 Eric W. Biederman 2023-09-25 407 /* Zero the end of the last mapped page */ a6409120b31666 Eric W. Biederman 2023-09-25 408 padzero(zero_start); a6409120b31666 Eric W. Biederman 2023-09-25 409 } a6409120b31666 Eric W. Biederman 2023-09-25 410 } else { a6409120b31666 Eric W. Biederman 2023-09-25 411 zero_start = ELF_PAGESTART(addr); a6409120b31666 Eric W. Biederman 2023-09-25 412 zero_end = zero_start + ELF_PAGEOFFSET(eppnt->p_vaddr) + a6409120b31666 Eric W. Biederman 2023-09-25 413 eppnt->p_memsz; For this else path, map_addr is only set if there is an error. a6409120b31666 Eric W. Biederman 2023-09-25 414 } a6409120b31666 Eric W. Biederman 2023-09-25 415 if (eppnt->p_memsz > eppnt->p_filesz) { a6409120b31666 Eric W. Biederman 2023-09-25 416 /* a6409120b31666 Eric W. Biederman 2023-09-25 417 * Map the last of the segment. a6409120b31666 Eric W. Biederman 2023-09-25 418 * If the header is requesting these pages to be a6409120b31666 Eric W. Biederman 2023-09-25 419 * executable, honour that (ppc32 needs this). a6409120b31666 Eric W. Biederman 2023-09-25 420 */ a6409120b31666 Eric W. Biederman 2023-09-25 421 int error; a6409120b31666 Eric W. Biederman 2023-09-25 422 a6409120b31666 Eric W. Biederman 2023-09-25 423 zero_start = ELF_PAGEALIGN(zero_start); a6409120b31666 Eric W. Biederman 2023-09-25 424 zero_end = ELF_PAGEALIGN(zero_end); a6409120b31666 Eric W. Biederman 2023-09-25 425 a6409120b31666 Eric W. Biederman 2023-09-25 426 error = vm_brk_flags(zero_start, zero_end - zero_start, a6409120b31666 Eric W. Biederman 2023-09-25 427 prot & PROT_EXEC ? VM_EXEC : 0); a6409120b31666 Eric W. Biederman 2023-09-25 428 if (error) a6409120b31666 Eric W. Biederman 2023-09-25 429 map_addr = error; a6409120b31666 Eric W. Biederman 2023-09-25 430 } a6409120b31666 Eric W. Biederman 2023-09-25 @431 return map_addr; a6409120b31666 Eric W. Biederman 2023-09-25 432 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki