From: Mike Kravetz <mike.kravetz@oracle.com>
To: Muchun Song <songmuchun@bytedance.com>,
akpm@linux-foundation.org, osalvador@suse.de, mhocko@suse.com,
david@redhat.com, willy@infradead.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
duanxiongchun@bytedance.com, zhengqi.arch@bytedance.com,
fam.zheng@bytedance.com,
Anshuman Khandual <anshuman.khandual@arm.com>
Subject: Re: [PATCH] mm: migrate: fix missing update page_private to hugetlb_page_subpool
Date: Wed, 19 May 2021 20:34:01 -0700 [thread overview]
Message-ID: <60ba549e-3337-6415-cbd4-1311069756d0@oracle.com> (raw)
In-Reply-To: <20210520025949.1866-1-songmuchun@bytedance.com>
On 5/19/21 7:59 PM, Muchun Song wrote:
> Since commit d6995da31122 ("hugetlb: use page.private for hugetlb specific
> page flags") converts page.private for hugetlb specific page flags. We
> should use hugetlb_page_subpool() to get the subpool pointer instead of
> page_private(). The commit forgot to update it in the page migration
> routine. So fix it.
>
> Fixes: d6995da31122 ("hugetlb: use page.private for hugetlb specific page flags")
> Reported-by: Anshuman Khandual <anshuman.khandual@arm.com>
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> ---
> mm/migrate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thank you Muchun!
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
--
Mike Kravetz
next prev parent reply other threads:[~2021-05-20 3:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 2:59 Muchun Song
2021-05-20 3:34 ` Mike Kravetz [this message]
2021-05-20 4:24 ` Andrew Morton
2021-05-20 5:13 ` [External] " Muchun Song
2021-05-20 18:16 ` Mike Kravetz
2021-05-21 2:17 ` Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60ba549e-3337-6415-cbd4-1311069756d0@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=david@redhat.com \
--cc=duanxiongchun@bytedance.com \
--cc=fam.zheng@bytedance.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=songmuchun@bytedance.com \
--cc=willy@infradead.org \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox