From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C63CEC433DB for ; Tue, 5 Jan 2021 16:55:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4A07722CB9 for ; Tue, 5 Jan 2021 16:55:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A07722CB9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D48B08D0087; Tue, 5 Jan 2021 11:55:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CF83A8D006E; Tue, 5 Jan 2021 11:55:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C0EEB8D0087; Tue, 5 Jan 2021 11:55:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0243.hostedemail.com [216.40.44.243]) by kanga.kvack.org (Postfix) with ESMTP id A9FD28D006E for ; Tue, 5 Jan 2021 11:55:53 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 734081DFA for ; Tue, 5 Jan 2021 16:55:53 +0000 (UTC) X-FDA: 77672323386.12.word71_4705268274da Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id 5E9F71800FEB0 for ; Tue, 5 Jan 2021 16:55:53 +0000 (UTC) X-HE-Tag: word71_4705268274da X-Filterd-Recvd-Size: 4491 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Tue, 5 Jan 2021 16:55:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1609865752; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=98+pCbtUqbWy+Z4JNrWpa2FBDJ8j13rrHnVYcmJcyK4=; b=WD/8JDX5bf8RSTCI6SoLeLlUfYNb7jM8allQnyMYd74ZXAGX3fmDwZrfCm5tG4UwSUtA2v aRlfqQf6A0hGPv7gXBHMhSJ9X9wIOmxNOKP4+meCawjhPzf6KFUd8GPkX8qa7+9QvSGKT5 d9GyicdynMpvLLQbE5wzEh+rZITULsY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-78-wc2OnmZUOqyhWzCWqLqpqw-1; Tue, 05 Jan 2021 11:55:50 -0500 X-MC-Unique: wc2OnmZUOqyhWzCWqLqpqw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1AB3A1088D70; Tue, 5 Jan 2021 16:55:00 +0000 (UTC) Received: from [10.36.114.117] (ovpn-114-117.ams2.redhat.com [10.36.114.117]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0BC1957; Tue, 5 Jan 2021 16:54:58 +0000 (UTC) Subject: Re: [PATCH v3 3/4] mm: simplify parameter of setup_usemap() To: Baoquan He , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, akpm@linux-foundation.org, rppt@kernel.org References: <20210105074708.18483-1-bhe@redhat.com> <20210105074708.18483-4-bhe@redhat.com> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <60b2a544-ee72-99f8-b584-2cf5851ae83a@redhat.com> Date: Tue, 5 Jan 2021 17:54:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20210105074708.18483-4-bhe@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 05.01.21 08:47, Baoquan He wrote: > Parameter 'zone' has got needed information, let's remove other > unnecessary parameters. > > Signed-off-by: Baoquan He > Reviewed-by: Mike Rapoport > --- > mm/page_alloc.c | 17 +++++++---------- > 1 file changed, 7 insertions(+), 10 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index b2a46ffdaf0b..e0ce6fb6373b 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -6824,25 +6824,22 @@ static unsigned long __init usemap_size(unsigned long zone_start_pfn, unsigned l > return usemapsize / 8; > } > > -static void __ref setup_usemap(struct pglist_data *pgdat, > - struct zone *zone, > - unsigned long zone_start_pfn, > - unsigned long zonesize) > +static void __ref setup_usemap(struct zone *zone) > { > - unsigned long usemapsize = usemap_size(zone_start_pfn, zonesize); > + unsigned long usemapsize = usemap_size(zone->zone_start_pfn, > + zone->spanned_pages); > zone->pageblock_flags = NULL; > if (usemapsize) { > zone->pageblock_flags = > memblock_alloc_node(usemapsize, SMP_CACHE_BYTES, > - pgdat->node_id); > + zone_to_nid(zone)); > if (!zone->pageblock_flags) > panic("Failed to allocate %ld bytes for zone %s pageblock flags on node %d\n", > - usemapsize, zone->name, pgdat->node_id); > + usemapsize, zone->name, zone_to_nid(zone)); > } > } > #else > -static inline void setup_usemap(struct pglist_data *pgdat, struct zone *zone, > - unsigned long zone_start_pfn, unsigned long zonesize) {} > +static inline void setup_usemap(struct zone *zone) {} > #endif /* CONFIG_SPARSEMEM */ > > #ifdef CONFIG_HUGETLB_PAGE_SIZE_VARIABLE > @@ -7037,7 +7034,7 @@ static void __init free_area_init_core(struct pglist_data *pgdat) > continue; > > set_pageblock_order(); > - setup_usemap(pgdat, zone, zone_start_pfn, size); > + setup_usemap(zone); > init_currently_empty_zone(zone, zone_start_pfn, size); > memmap_init_zone(zone); > } > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb