From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22189C433EF for ; Thu, 20 Jan 2022 12:27:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 99B046B00A0; Thu, 20 Jan 2022 07:27:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 94BB76B00A1; Thu, 20 Jan 2022 07:27:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 813356B00A2; Thu, 20 Jan 2022 07:27:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay038.a.hostedemail.com [64.99.140.38]) by kanga.kvack.org (Postfix) with ESMTP id 730576B00A0 for ; Thu, 20 Jan 2022 07:27:45 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4659220B90 for ; Thu, 20 Jan 2022 12:27:45 +0000 (UTC) X-FDA: 79050591690.02.787D001 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf20.hostedemail.com (Postfix) with ESMTP id 7DE041C0007 for ; Thu, 20 Jan 2022 12:27:44 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 36B0A1F3AA; Thu, 20 Jan 2022 12:27:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1642681663; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NymTDre5i6YMhXOHXf85vTj6gDABODo1HKBgVHkUdOk=; b=ajovI1EnlRa84W/90koDqKORZNc8O/cduxa3xdES8kiiAHnS6SS+atUBbEjs/fwsQ7S5hV 6Xcpj6R2Nak73l4VDC/R88ULyTpRllitT97cMGqSYa7R9JK4Iv6Jc750/qX2DS49EsQlbR NamtxQcksSPuhORsoE51noKfycXka0c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1642681663; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NymTDre5i6YMhXOHXf85vTj6gDABODo1HKBgVHkUdOk=; b=Vkti1i+Pe0vqpsTrtNOb708/kkCDTmVkbqsX5/oxi2BGh79/bHI4yxKzRJuocVnlmc+8qU yiml9ZRLdryFPMBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E462F13B51; Thu, 20 Jan 2022 12:27:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id g+ENNz5V6WHrXgAAMHmgww (envelope-from ); Thu, 20 Jan 2022 12:27:42 +0000 Message-ID: <60a15c8b-c70b-0fd5-287e-d37d2107bf04@suse.cz> Date: Thu, 20 Jan 2022 13:27:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v4 58/66] mm/mremap: Use vma_find() instead of vma linked list Content-Language: en-US To: Liam Howlett , "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton Cc: Song Liu , Davidlohr Bueso , "Paul E . McKenney" , Matthew Wilcox , Laurent Dufour , David Rientjes , Axel Rasmussen , Suren Baghdasaryan , Rik van Riel , Peter Zijlstra , Michel Lespinasse , Jerome Glisse , Minchan Kim , Joel Fernandes , Rom Lemarchand References: <20211201142918.921493-1-Liam.Howlett@oracle.com> <20211201142918.921493-59-Liam.Howlett@oracle.com> From: Vlastimil Babka In-Reply-To: <20211201142918.921493-59-Liam.Howlett@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 7DE041C0007 X-Stat-Signature: 78d6f3sy7n1ctgbenmr44jssqhaingze Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ajovI1En; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Vkti1i+P; dmarc=none; spf=pass (imf20.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-Rspamd-Server: rspam02 X-HE-Tag: 1642681664-633068 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/1/21 15:30, Liam Howlett wrote: > From: "Liam R. Howlett" > > Signed-off-by: Liam R. Howlett Acked-by: Vlastimil Babka > --- > mm/mremap.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/mm/mremap.c b/mm/mremap.c > index b09e107cd18b..4ad39c985d04 100644 > --- a/mm/mremap.c > +++ b/mm/mremap.c > @@ -713,7 +713,7 @@ static unsigned long move_vma(struct vm_area_struct *vma, > if (excess) { > vma->vm_flags |= VM_ACCOUNT; > if (split) > - vma->vm_next->vm_flags |= VM_ACCOUNT; > + find_vma(mm, vma->vm_end)->vm_flags |= VM_ACCOUNT; > } > > return new_addr; > @@ -869,9 +869,11 @@ static unsigned long mremap_to(unsigned long addr, unsigned long old_len, > static int vma_expandable(struct vm_area_struct *vma, unsigned long delta) > { > unsigned long end = vma->vm_end + delta; > + struct vm_area_struct *next; > if (end < vma->vm_end) /* overflow */ > return 0; > - if (vma->vm_next && vma->vm_next->vm_start < end) /* intersection */ > + next = find_vma(vma->vm_mm, vma->vm_end); > + if (next && next->vm_start < end) /* intersection */ Could just use find_vma_intersection()? > return 0; > if (get_unmapped_area(NULL, vma->vm_start, end - vma->vm_start, > 0, MAP_FIXED) & ~PAGE_MASK)