From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9036CC433F5 for ; Thu, 21 Oct 2021 08:50:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2CA7A610C8 for ; Thu, 21 Oct 2021 08:50:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2CA7A610C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id BEF8E900002; Thu, 21 Oct 2021 04:50:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B9F7C6B0072; Thu, 21 Oct 2021 04:50:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB5D6900002; Thu, 21 Oct 2021 04:50:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0230.hostedemail.com [216.40.44.230]) by kanga.kvack.org (Postfix) with ESMTP id 9EFBC6B0071 for ; Thu, 21 Oct 2021 04:50:57 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 67135180CE6B4 for ; Thu, 21 Oct 2021 08:50:57 +0000 (UTC) X-FDA: 78719824554.29.0202010 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 275961043019 for ; Thu, 21 Oct 2021 08:50:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634806256; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TMKCQhzyCZoKip7jkhipm5coeXVlUYjq8hHmo56D0kM=; b=MVjrjySRWbvnyHImFAmxP1i/zXp1Zq69odDVz333BSGjV8vn66TpOVThAjQYcErocTDTzo 3YtXugSsuNhuMpxWZVQST49DCWYVYKnkdQS/ulDckey3prGKe6D8tcXzgKUDhwru7wLMhJ 7wctT3NJBj1ULVkcr7eTeVtoInbHM7k= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-81-g6NlD_IxOkCvGTkym-JunA-1; Thu, 21 Oct 2021 04:50:55 -0400 X-MC-Unique: g6NlD_IxOkCvGTkym-JunA-1 Received: by mail-wr1-f69.google.com with SMTP id s18-20020adfbc12000000b00160b2d4d5ebso11158805wrg.7 for ; Thu, 21 Oct 2021 01:50:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=TMKCQhzyCZoKip7jkhipm5coeXVlUYjq8hHmo56D0kM=; b=4uhQx83zKQm1m9SL2s/IzQzQpg9vxZoeNMcaYaykxGEHYAoO/JYr/eLCaOSFqHPz+s GOXcQD15BuUUKmjZWM8H431x3o/b/r2qj75FbunNdgExWNTuQ1Umscijwx8gGwHmpiya M80KVdu64SwLFRtYz2ITtuD7msPrL+8kg0W8/xC/MlWeMU/6nm0q+tl2jWZGG1b6bniB O61Yeu2dRAXdLP3eRmUsKTe07QbRbe40sbnqL3OAh27i5iGoqWqCI+oXX6dtOlPsDA9y iTtqX/wkBQ013lhBWc8gnjVEUjKZWjN5KPsVltjKyI6SqEAP0oTkgq/1ia1UmZLswafj fWMg== X-Gm-Message-State: AOAM532vwf2Dkk1hqHEfIBjMhOvFal8ICLFon3YKBpd+O8IDcVjq6wnU 9S4dLo3AN9h1geo/MI65l2lQtEdYXdepId23XimXO3CCIpFVEaVDmmGSX/kUudG6CoZA3IvuJJ0 Osm+zHrbIcIY= X-Received: by 2002:a7b:c4c8:: with SMTP id g8mr5037466wmk.101.1634806253952; Thu, 21 Oct 2021 01:50:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwEHGgkVyg0q1OaErEei7VkUfa1cHgmw1g0ZMcPOr7mjHHlR0oZ31aOenII21AbbYuKXfXn3w== X-Received: by 2002:a7b:c4c8:: with SMTP id g8mr5037448wmk.101.1634806253781; Thu, 21 Oct 2021 01:50:53 -0700 (PDT) Received: from [192.168.3.132] (p4ff23aba.dip0.t-ipconnect.de. [79.242.58.186]) by smtp.gmail.com with ESMTPSA id s8sm4281769wrr.15.2021.10.21.01.50.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Oct 2021 01:50:53 -0700 (PDT) Message-ID: <60939c5c-2b1f-a7d7-61b3-f8f501a4893f@redhat.com> Date: Thu, 21 Oct 2021 10:50:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH] mm/page_alloc: use clamp() to simplify code To: Wang ShaoBo , akpm@linux-foundation.org Cc: weiyongjun1@huawei.com, huawei.libin@huawei.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20211021034830.1049150-1-bobo.shaobowang@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20211021034830.1049150-1-bobo.shaobowang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: srhqbu4ifstg6uhezm5cabrw6ybg8z7b Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MVjrjySR; spf=none (imf13.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 275961043019 X-HE-Tag: 1634806253-64257 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 21.10.21 05:48, Wang ShaoBo wrote: > This patch uses clamp() to simplify code in init_per_zone_wmark_min(). > > Signed-off-by: Wang ShaoBo > --- > mm/page_alloc.c | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index b37435c274cf..d0449212a824 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -8460,16 +8460,12 @@ int __meminit init_per_zone_wmark_min(void) > lowmem_kbytes = nr_free_buffer_pages() * (PAGE_SIZE >> 10); > new_min_free_kbytes = int_sqrt(lowmem_kbytes * 16); > > - if (new_min_free_kbytes > user_min_free_kbytes) { > - min_free_kbytes = new_min_free_kbytes; > - if (min_free_kbytes < 128) > - min_free_kbytes = 128; > - if (min_free_kbytes > 262144) > - min_free_kbytes = 262144; > - } else { > + if (new_min_free_kbytes > user_min_free_kbytes) > + min_free_kbytes = clamp(new_min_free_kbytes, 128, 262144); > + else > pr_warn("min_free_kbytes is not updated to %d because user defined value %d is preferred\n", > new_min_free_kbytes, user_min_free_kbytes); > - } > + > setup_per_zone_wmarks(); > refresh_zone_stat_thresholds(); > setup_per_zone_lowmem_reserve(); > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb