From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA391C2BBCA for ; Tue, 25 Jun 2024 07:05:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A6636B0085; Tue, 25 Jun 2024 03:05:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 356826B02CD; Tue, 25 Jun 2024 03:05:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F6DB6B02D2; Tue, 25 Jun 2024 03:05:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0259F6B0085 for ; Tue, 25 Jun 2024 03:05:56 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A1F7C1A1845 for ; Tue, 25 Jun 2024 07:05:56 +0000 (UTC) X-FDA: 82268526312.26.80A87E2 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf02.hostedemail.com (Postfix) with ESMTP id F084780019 for ; Tue, 25 Jun 2024 07:05:53 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719299146; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5IxQoYJux0O3UTaquRuqlU7mPeohdXbHYSeVJXkTm9g=; b=SoWZoJbx0U5540PRC4Pyfjel6BeGVZXcpAlomtJ4tlv0Db6iWnwaKna69AqzIj2P5Rg5O+ 92JEXr8lTBXjyNSMiT2kPvf364YSs4Uv/gBoklIKK+ERH4b6BZ0gjeXc12zclMkfSDOaFc du7H4PFbGYy5rkarD5wDM4I8i4omXLs= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719299146; a=rsa-sha256; cv=none; b=yaSTulRcs0ahAf07uGQTxtNIpWKB3pPksYOw2Rjvc5slCl/ZRDMmAIVZZG1Wl4QEvb/7Pi 0jYCs3xMQo+w11tCnAKvKWXsTHr1ufQuHTFbluTqCAmYoyxOUmSAIkx5jcjcFXBs6UpJR+ Vh63mlC79qR4Y66MYI3/xJQqQcXtTQM= Received: from mail.maildlp.com (unknown [172.19.88.194]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4W7bT60ChMznXYr; Tue, 25 Jun 2024 15:05:46 +0800 (CST) Received: from kwepemd200019.china.huawei.com (unknown [7.221.188.193]) by mail.maildlp.com (Postfix) with ESMTPS id 73B731402DE; Tue, 25 Jun 2024 15:05:50 +0800 (CST) Received: from [10.173.127.72] (10.173.127.72) by kwepemd200019.china.huawei.com (7.221.188.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 25 Jun 2024 15:05:49 +0800 Subject: Re: [PATCH v5 3/4] selftest/mm: test enable_soft_offline behaviors To: Jiaqi Yan CC: , , , , , , , , , , , , , References: <20240624163348.1751454-1-jiaqiyan@google.com> <20240624163348.1751454-4-jiaqiyan@google.com> From: Miaohe Lin Message-ID: <609062d2-977c-4229-8c66-d15bb8e47eb8@huawei.com> Date: Tue, 25 Jun 2024 15:05:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20240624163348.1751454-4-jiaqiyan@google.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.127.72] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemd200019.china.huawei.com (7.221.188.193) X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: F084780019 X-Stat-Signature: pxwdzgkhckh4pky4ma77nch548376nrx X-Rspam-User: X-HE-Tag: 1719299153-734711 X-HE-Meta: U2FsdGVkX1/4Hpbzkp6XXnzNjc9Ap808OAY6ukT4LomiOCAqGTs5hk3zZUp/r1esICFMoJKE1f8xNO18Lc8cNXg6Z8UMO+OfHmndIjyl8LZPidBQTsXuy1b/JmbwBv9RFYuLyF5TJBN9nYrqF9sw1J0L6yZA60oUOKGEcfr7OdJrCwI+aXwBFrIGDMgdatgCTt+Btj8NxsW44euHIu4N2jtpa7rNg6JMjeqqPp4CYu/cBPhvXRTGCkIRySfV2liqZRCZPkjLdqZBVLSMs/svmgp/H3nR85sXSC8RtzGCfqqY8kCG62yDgLulJlMHunU5Y2OPXxN9zfiz+9DE2Nh+fLkkNresxHy6x+JHULanQQvSuDpM2g/I+RVDBoHjDBmOftFW64MDDQ2NjsNX6SKA64F9wjJSTKZMOAkiEjJIPVkZ35JVzQTjCqV2w4G4jt5sWXXLn1JuSmrSoL5WQkZRdHkKi90/zIWx9WJe+PAc/LjAFhlNtSTA9MoeFmsQlHpx6MrX7UWC7l4/IzAKpzA3mjojZ79+SAX9ckR9PJLxA1GfaNvg4xZeJQ3Qk8VW3e5849UTsKHRlq0yb3baTZAH+f7FChW7bXVTTADg0XghCWN2GYvkA/xR0/Z5eQlz3JcU2xPU/KqZnek5+3V11OU/GMQ1liCauDhtgqV1qgWwfKcJwGvnxv6UnZwZL3YAc/h/OiOkBOLtj7lNvJblachGy5afHPM1CvGWRtJTdgmzeJO/s0eqYCYjge/Dg0KOPH36+SZB/mubMZpTxKKWa/TelKF4k+lFuES5VDHYYLczaymULhBt9ab48PwzxMM2nqwMKuA3j2o0TgBeSqz6BRm4SXZCCb4EEfyByvDJvozMGXo/K28lzD0Wg77WsAS2nyy0T0/UbP3VdOvT1NLQWT4X36YsGxEE4sqSmncCgy3cwTLV37jfvLdfklQ8qgm095dOy5HDf+c2a5+uaUSD8Zj mvl2hOg8 19VOXWb+WnggKt97CjH+gv83xlYb32+1ENunGetXlg+C0v5eKSAqOpGIqBXTYpZxcyn+PhR4iVKVRBCS4Yk1RL16OAqYDEfubea0NlYPRVSxkeyg0XlKLcHeeh5tFkinRX4dz3CCHJ3EVXNPwRpaSMmfj4d0ePW3KWbZEoZeMxvv9/Bb1QQKudjnZZVGV0Bun4C/Cvj/Q+sjtkEiDZa4Gg1xYzZ5suh//FiujaXPkmgn8GohFZ9ok9UzKVF0GQZLIROfs X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/6/25 0:33, Jiaqi Yan wrote: > Add regression and new tests when hugepage has correctable memory ... > diff --git a/tools/testing/selftests/mm/hugetlb-soft-offline.c b/tools/testing/selftests/mm/hugetlb-soft-offline.c > new file mode 100644 > index 000000000000..16fe52f972e2 > --- /dev/null > +++ b/tools/testing/selftests/mm/hugetlb-soft-offline.c > @@ -0,0 +1,227 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Test soft offline behavior for HugeTLB pages: > + * - if enable_soft_offline = 0, hugepages should stay intact and soft > + * offlining failed with EINVAL. s/failed with EINVAL/failed with EOPNOTSUPP/g > + * - if enable_soft_offline = 1, a hugepage should be dissolved and > + * nr_hugepages/free_hugepages should be reduced by 1. > + * > + * Before running, make sure more than 2 hugepages of default_hugepagesz > + * are allocated. For example, if /proc/meminfo/Hugepagesize is 2048kB: > + * echo 8 > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages > + */ > + ... > +static void test_soft_offline_common(int enable_soft_offline) > +{ > + int fd; > + int expect_errno = enable_soft_offline ? 0 : EOPNOTSUPP; > + struct statfs file_stat; > + unsigned long hugepagesize_kb = 0; > + unsigned long nr_hugepages_before = 0; > + unsigned long nr_hugepages_after = 0; > + int ret; > + > + ksft_print_msg("Test soft-offline when enabled_soft_offline=%d\n", > + enable_soft_offline); > + > + fd = create_hugetlbfs_file(&file_stat); > + if (fd < 0) { > + ksft_exit_fail_msg("Failed to create hugetlbfs file\n"); > + return; > + } > + > + hugepagesize_kb = file_stat.f_bsize / 1024; > + ksft_print_msg("Hugepagesize is %ldkB\n", hugepagesize_kb); > + > + if (set_enable_soft_offline(enable_soft_offline)) { > + ksft_exit_fail_msg("Failed to set enable_soft_offline\n"); Call destroy_hugetlbfs_file() in error path? > + return; > + } > + > + if (read_nr_hugepages(hugepagesize_kb, &nr_hugepages_before) != 0) { > + ksft_exit_fail_msg("Failed to read nr_hugepages\n"); > + return; > + } > + > + ksft_print_msg("Before MADV_SOFT_OFFLINE nr_hugepages=%ld\n", > + nr_hugepages_before); > + > + ret = do_soft_offline(fd, 2 * file_stat.f_bsize, expect_errno); > + > + if (read_nr_hugepages(hugepagesize_kb, &nr_hugepages_after) != 0) { > + ksft_exit_fail_msg("Failed to read nr_hugepages\n"); > + return; > + } > + > + ksft_print_msg("After MADV_SOFT_OFFLINE nr_hugepages=%ld\n", > + nr_hugepages_after); > + > + if (enable_soft_offline) { > + if (nr_hugepages_before != nr_hugepages_after + 1) { > + ksft_test_result_fail("MADV_SOFT_OFFLINE should reduced 1 hugepage\n"); > + return; > + } > + } else { > + if (nr_hugepages_before != nr_hugepages_after) { > + ksft_test_result_fail("MADV_SOFT_OFFLINE reduced %lu hugepages\n", > + nr_hugepages_before - nr_hugepages_after); > + return; > + } > + } > + > + ksft_test_result(ret == 0, > + "Test soft-offline when enabled_soft_offline=%d\n", > + enable_soft_offline); Call destroy_hugetlbfs_file() when test finished ? Thanks. .