From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4E8EC433E6 for ; Tue, 1 Sep 2020 06:23:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 86E7D2071B for ; Tue, 1 Sep 2020 06:23:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="VR8oUlLx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 86E7D2071B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0A60F8E0001; Tue, 1 Sep 2020 02:23:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 057086B005A; Tue, 1 Sep 2020 02:23:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E86C38E0001; Tue, 1 Sep 2020 02:23:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0200.hostedemail.com [216.40.44.200]) by kanga.kvack.org (Postfix) with ESMTP id CF8626B0055 for ; Tue, 1 Sep 2020 02:23:23 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 8FF673633 for ; Tue, 1 Sep 2020 06:23:23 +0000 (UTC) X-FDA: 77213500686.29.grain30_38143a527096 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin29.hostedemail.com (Postfix) with ESMTP id 63D77180868D6 for ; Tue, 1 Sep 2020 06:23:23 +0000 (UTC) X-HE-Tag: grain30_38143a527096 X-Filterd-Recvd-Size: 6492 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Tue, 1 Sep 2020 06:23:22 +0000 (UTC) Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0816ESPV092614; Tue, 1 Sep 2020 02:23:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=yoyRoKGbWHQ33j2r6pSr82DlMFsFpDBXh6XA8dUNRIk=; b=VR8oUlLxF1O0hJSqODn4dTKbwJQ2yNFGsI2UtoesnXKWPBz6PUqjCe5W3iPH4b96czHs TCwNjgI0z2asJXkw7g0d4YlF2uPlYf+rZXALMovuk11kfwryh4FC33JgwaiQg1EKKuda M0kwxNMetcdM6xPs9BQJa08U1/qikmCzAqrZBh4WD8etQ3K2hro/hy0NLvGqXqLc7mOr c8e0+DOf319tkS5iDCwgDqbDORTTNMi3lNSrBHPOEWrYzVE3M/1eqYrRNuGXcKWyPpEM YUK7bk6YONspTDjE5ZIDRVkkuG/cs26oJBtVdxE9CfgfJoWImRtPs86BugdpVMU5gAmt 0Q== Received: from ppma02fra.de.ibm.com (47.49.7a9f.ip4.static.sl-reverse.com [159.122.73.71]) by mx0a-001b2d01.pphosted.com with ESMTP id 339gup86nr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 01 Sep 2020 02:23:11 -0400 Received: from pps.filterd (ppma02fra.de.ibm.com [127.0.0.1]) by ppma02fra.de.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 0816CGor024734; Tue, 1 Sep 2020 06:23:09 GMT Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by ppma02fra.de.ibm.com with ESMTP id 337en7hvbh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 01 Sep 2020 06:23:09 +0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0816N6LW24576424 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 1 Sep 2020 06:23:07 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DB52FAE04D; Tue, 1 Sep 2020 06:23:06 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B8C42AE053; Tue, 1 Sep 2020 06:23:03 +0000 (GMT) Received: from [9.85.87.76] (unknown [9.85.87.76]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 1 Sep 2020 06:23:03 +0000 (GMT) Subject: Re: [PATCH v3 06/13] mm/debug_vm_pgtable/THP: Mark the pte entry huge before using set_pmd/pud_at To: Anshuman Khandual , linux-mm@kvack.org, akpm@linux-foundation.org Cc: mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-snps-arc@lists.infradead.org, x86@kernel.org, linux-arch@vger.kernel.org, Gerald Schaefer , Christophe Leroy , Vineet Gupta , Mike Rapoport , Qian Cai References: <20200827080438.315345-1-aneesh.kumar@linux.ibm.com> <20200827080438.315345-7-aneesh.kumar@linux.ibm.com> <37558832-9cb6-9a11-0009-e268ad51c1f3@arm.com> From: "Aneesh Kumar K.V" Message-ID: <60857a9f-0df2-ff19-d857-8e8582e85099@linux.ibm.com> Date: Tue, 1 Sep 2020 11:53:02 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <37558832-9cb6-9a11-0009-e268ad51c1f3@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-09-01_04:2020-09-01,2020-09-01 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 mlxlogscore=999 lowpriorityscore=0 priorityscore=1501 bulkscore=0 spamscore=0 mlxscore=0 malwarescore=0 phishscore=0 impostorscore=0 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009010054 X-Rspamd-Queue-Id: 63D77180868D6 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/1/20 8:51 AM, Anshuman Khandual wrote: > > > On 08/27/2020 01:34 PM, Aneesh Kumar K.V wrote: >> kernel expects entries to be marked huge before we use set_pmd_at()/set_pud_at(). >> >> Signed-off-by: Aneesh Kumar K.V >> --- >> mm/debug_vm_pgtable.c | 21 ++++++++++++--------- >> 1 file changed, 12 insertions(+), 9 deletions(-) >> >> diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c >> index 5c0680836fe9..de83a20c1b30 100644 >> --- a/mm/debug_vm_pgtable.c >> +++ b/mm/debug_vm_pgtable.c >> @@ -155,7 +155,7 @@ static void __init pmd_advanced_tests(struct mm_struct *mm, >> unsigned long pfn, unsigned long vaddr, >> pgprot_t prot) >> { >> - pmd_t pmd = pfn_pmd(pfn, prot); >> + pmd_t pmd; >> >> if (!has_transparent_hugepage()) >> return; >> @@ -164,19 +164,19 @@ static void __init pmd_advanced_tests(struct mm_struct *mm, >> /* Align the address wrt HPAGE_PMD_SIZE */ >> vaddr = (vaddr & HPAGE_PMD_MASK) + HPAGE_PMD_SIZE; >> >> - pmd = pfn_pmd(pfn, prot); >> + pmd = pmd_mkhuge(pfn_pmd(pfn, prot)); >> set_pmd_at(mm, vaddr, pmdp, pmd); >> pmdp_set_wrprotect(mm, vaddr, pmdp); >> pmd = READ_ONCE(*pmdp); >> WARN_ON(pmd_write(pmd)); >> >> - pmd = pfn_pmd(pfn, prot); >> + pmd = pmd_mkhuge(pfn_pmd(pfn, prot)); >> set_pmd_at(mm, vaddr, pmdp, pmd); >> pmdp_huge_get_and_clear(mm, vaddr, pmdp); >> pmd = READ_ONCE(*pmdp); >> WARN_ON(!pmd_none(pmd)); >> >> - pmd = pfn_pmd(pfn, prot); >> + pmd = pmd_mkhuge(pfn_pmd(pfn, prot)); >> pmd = pmd_wrprotect(pmd); >> pmd = pmd_mkclean(pmd); >> set_pmd_at(mm, vaddr, pmdp, pmd); >> @@ -237,7 +237,7 @@ static void __init pmd_huge_tests(pmd_t *pmdp, unsigned long pfn, pgprot_t prot) >> >> static void __init pmd_savedwrite_tests(unsigned long pfn, pgprot_t prot) >> { >> - pmd_t pmd = pfn_pmd(pfn, prot); >> + pmd_t pmd = pmd_mkhuge(pfn_pmd(pfn, prot)); > > There is no set_pmd_at() in this particular test, why change ? because if you are building a hugepage you should use pmd_mkhuge(). That is what is setting _PAGE_PTE with this series. We don't make pfn_pmd set _PAGE_PTE -aneesh