From: Miaohe Lin <linmiaohe@huawei.com>
To: Uros Bizjak <ubizjak@gmail.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Cc: Vitaly Wool <vitaly.wool@konsulko.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mm/z3fold: Add __percpu annotation to *unbuddied pointer in struct z3fold_pool
Date: Mon, 5 Aug 2024 15:09:58 +0800 [thread overview]
Message-ID: <607b6854-081d-7d07-b2a8-fbfb004d5723@huawei.com> (raw)
In-Reply-To: <20240730123445.5875-1-ubizjak@gmail.com>
On 2024/7/30 20:34, Uros Bizjak wrote:
> Compiling z3fold.c results in several sparse warnings:
>
> z3fold.c:797:21: warning: incorrect type in initializer (different address spaces)
> z3fold.c:797:21: expected void const [noderef] __percpu *__vpp_verify
> z3fold.c:797:21: got struct list_head *
> z3fold.c:852:37: warning: incorrect type in initializer (different address spaces)
> z3fold.c:852:37: expected void const [noderef] __percpu *__vpp_verify
> z3fold.c:852:37: got struct list_head *
> z3fold.c:924:25: warning: incorrect type in assignment (different address spaces)
> z3fold.c:924:25: expected struct list_head *unbuddied
> z3fold.c:924:25: got void [noderef] __percpu *_res
> z3fold.c:930:33: warning: incorrect type in initializer (different address spaces)
> z3fold.c:930:33: expected void const [noderef] __percpu *__vpp_verify
> z3fold.c:930:33: got struct list_head *
> z3fold.c:949:25: warning: incorrect type in argument 1 (different address spaces)
> z3fold.c:949:25: expected void [noderef] __percpu *__pdata
> z3fold.c:949:25: got struct list_head *unbuddied
> z3fold.c:979:25: warning: incorrect type in argument 1 (different address spaces)
> z3fold.c:979:25: expected void [noderef] __percpu *__pdata
> z3fold.c:979:25: got struct list_head *unbuddied
>
> Add __percpu annotation to *unbuddied pointer to fix these warnings.
>
> Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
> Cc: Vitaly Wool <vitaly.wool@konsulko.com>
> Cc: Miaohe Lin <linmiaohe@huawei.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
Thanks.
.
prev parent reply other threads:[~2024-08-05 7:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 12:34 Uros Bizjak
2024-08-05 7:09 ` Miaohe Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=607b6854-081d-7d07-b2a8-fbfb004d5723@huawei.com \
--to=linmiaohe@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ubizjak@gmail.com \
--cc=vitaly.wool@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox