From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7440C433F5 for ; Fri, 14 Jan 2022 13:44:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 371496B0072; Fri, 14 Jan 2022 08:44:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F9BC6B0073; Fri, 14 Jan 2022 08:44:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 14C3C6B0074; Fri, 14 Jan 2022 08:44:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 05DCF6B0072 for ; Fri, 14 Jan 2022 08:44:39 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id B6FD096F33 for ; Fri, 14 Jan 2022 13:44:38 +0000 (UTC) X-FDA: 79029012636.05.6453B35 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id F112B140016 for ; Fri, 14 Jan 2022 13:44:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1642167876; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nfjFLSHiBQKga3FwXwxrCNc9DhWW0rRljO+uSdIGNDI=; b=EoNGWjaU2GFwo1XS2eOlMsTulLpubFLWni/ldxfyuZtnP/7YK8aG9QOo2+bbK7RGxDH5HM WxyE6sKLZ0tfiZ1G8VXJu54mveDa0j0AwbUIL1JyPjONCS/viwwgEPVGwKDGs+m7wemLam ++rKVt2FPuRuRfgGD733DuLjo286Q0k= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-100-J3T9qFOpOSu5PdPrl0wuwA-1; Fri, 14 Jan 2022 08:44:35 -0500 X-MC-Unique: J3T9qFOpOSu5PdPrl0wuwA-1 Received: by mail-ed1-f71.google.com with SMTP id j10-20020a05640211ca00b003ff0e234fdfso8453941edw.0 for ; Fri, 14 Jan 2022 05:44:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=nfjFLSHiBQKga3FwXwxrCNc9DhWW0rRljO+uSdIGNDI=; b=lIRJey19CeuGGjKL3i7nvIzOI1VwEnOeoPvAPlogLemyqMxu1/hodPR4hNR/jrYOyN FjnR8Gm9VnS4WM3iMZlGmh4j9BtbDu5V/5S20lsxAdjGQrTxdQkYKMuk+xeZcth5COKk xvUHnTrwPLVVktzW8Tl5cZaeA8rc9bm1qYYCgxLOerDHly375zlMjqsXnviy1Y4hBZ71 lXv4vCk++mZPhC89cGAHs2TNhASLKkv8flxHsK9rmlxQzVXLKGqkLmxcFsuHPBHoD+FH WGLKGbJSLnSu0QyKGAcOOc8EUvJ4rbE91NMP6XYJ0ecRViEUh95ZX55b0bvB6iTumg2y IQNw== X-Gm-Message-State: AOAM53132OZwhqrc8Qjp1QJqaYlra75Jj6isqKw3hCEy5n96+tZtAVTt kObDzTdRbRJXAzoSciI7cuDsioD3/ySSqVNK/+UCMCPcQgb4+4j2FNKyVWbgq0Hct66TkI5zGjf fY5Lfnd0D2AQ= X-Received: by 2002:a05:6402:1008:: with SMTP id c8mr9115184edu.114.1642167874595; Fri, 14 Jan 2022 05:44:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJx5OFak9AC/l+A6gU6QqTI2K9zWFX8t7yOZXV50BOSN3qj9pr1cdJHhBXdsT7LCgDNpLjpiDw== X-Received: by 2002:a05:6402:1008:: with SMTP id c8mr9115163edu.114.1642167874354; Fri, 14 Jan 2022 05:44:34 -0800 (PST) Received: from ?IPV6:2003:cb:c701:9d00:ff87:1c9b:108a:9702? (p200300cbc7019d00ff871c9b108a9702.dip0.t-ipconnect.de. [2003:cb:c701:9d00:ff87:1c9b:108a:9702]) by smtp.gmail.com with ESMTPSA id 10sm1861145ejy.174.2022.01.14.05.44.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Jan 2022 05:44:33 -0800 (PST) Message-ID: <60778775-b5f5-0837-092f-9911cec84854@redhat.com> Date: Fri, 14 Jan 2022 14:44:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [RFC PATCH v3 7/8] drivers: virtio_mem: use pageblock size as the minimum virtio_mem size. To: Zi Yan , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Michael Ellerman , Christoph Hellwig , Marek Szyprowski , Robin Murphy , linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux-foundation.org, iommu@lists.linux-foundation.org, Vlastimil Babka , Mel Gorman , Eric Ren References: <20220105214756.91065-1-zi.yan@sent.com> <20220105214756.91065-8-zi.yan@sent.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220105214756.91065-8-zi.yan@sent.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: F112B140016 X-Stat-Signature: ez5osy6naw1nj837h5xu49s7ktei91tx Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EoNGWjaU; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf26.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam03 X-HE-Tag: 1642167877-842804 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 05.01.22 22:47, Zi Yan wrote: > From: Zi Yan > > alloc_contig_range() now only needs to be aligned to pageblock_order, > drop virtio_mem size requirement that it needs to be the max of > pageblock_order and MAX_ORDER. > > Signed-off-by: Zi Yan > --- > drivers/virtio/virtio_mem.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c > index a6a78685cfbe..2664dc16d0f9 100644 > --- a/drivers/virtio/virtio_mem.c > +++ b/drivers/virtio/virtio_mem.c > @@ -2481,8 +2481,7 @@ static int virtio_mem_init_hotplug(struct virtio_mem *vm) > * - Is required for now for alloc_contig_range() to work reliably - > * it doesn't properly handle smaller granularity on ZONE_NORMAL. > */ Please also update this comment. -- Thanks, David / dhildenb