From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE592C4332F for ; Mon, 13 Nov 2023 10:53:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D2926B0193; Mon, 13 Nov 2023 05:53:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 682936B0195; Mon, 13 Nov 2023 05:53:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 522C96B0196; Mon, 13 Nov 2023 05:53:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3D5996B0193 for ; Mon, 13 Nov 2023 05:53:20 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0AE21C07D7 for ; Mon, 13 Nov 2023 10:53:20 +0000 (UTC) X-FDA: 81452619360.22.8F146A1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf12.hostedemail.com (Postfix) with ESMTP id ACBF44000A for ; Mon, 13 Nov 2023 10:53:17 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="O3Ytn32/"; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699872797; a=rsa-sha256; cv=none; b=nH1PUBrwEHeNQxw1SX4SEqZZxAVgY/TAxgkNrNfhydATX8xwfljhuKRrl5up/Qi4T+Vr1t LtJeY35u8IXgxukzesrU+uTeAi4owrCV5PPHbI9CPBzKv9g1vEsg/7qULdIhqxt/uI5GMO jE1YwlAsVXr2MSMv/gg/MDH6y719hpc= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="O3Ytn32/"; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699872797; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CDib0WPgnyHNwdlVluzu/3B03IrEFVPMkButsVaAPJg=; b=NQDzM3tQu/KjwIBjXD+1N89EmQGVMM+IZYseeG57q+yH24NDEYXggRGiovBwbneQEr9L8Z gpHLlQQKgrATUKuMmgUuXshmPezk3lINIdkXc/WiueVV8sfVuMPeiRtKwTW6mhfsXEtJcN 17Tpfos7JTmbqQcnz2fwUiiGxYlwfH8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699872796; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=CDib0WPgnyHNwdlVluzu/3B03IrEFVPMkButsVaAPJg=; b=O3Ytn32/iBECe5AX5vI6traL36T4mFkecYkaul/gBVCh9YolL1GNNR4h/t252ogpbb5gRw Tk/eA0eHf4osTwdWjU64poub6CS/cCwQiY/JN/u26/uJX4vBo6GOvPJ6D/ZUsDsXfvAIxu 6y8LcUmaO/eKpR3SNB6/+JgjNh5T62s= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-286-889JoFNTMQWznijCZ22H8A-1; Mon, 13 Nov 2023 05:53:15 -0500 X-MC-Unique: 889JoFNTMQWznijCZ22H8A-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4084001846eso28944605e9.1 for ; Mon, 13 Nov 2023 02:53:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699872794; x=1700477594; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CDib0WPgnyHNwdlVluzu/3B03IrEFVPMkButsVaAPJg=; b=OP5p8pXjbt104PGMWfJ+Eq9Vx+WFOeWXbluG7mxu8QCrSmjmNakdozVORqjsF6HpCd ZfZMssrMr5WmrFCKPwqTWG0+0NPsxESGkr4ZELwEW0X+DEqBq9BjuPeUMX+jruKK9qRQ M3o4ApzJqA+cPpG+0PJ3r8XB5Jw0TaTch3k2R3VmuPKzjZRAt1q65KlMFLWwhCPaBdxp WVoAVH3gE3hrtLcd6EaamA+0u7dkmQ4umLiJMl1wvLpvYUE07bdD4otyNWHxZvTLjx8A QXpWZPtC05C8L0rAdjsVINYCS7hEX7/h+AX8pCKTBEgX/8AQsuboI6bg5HWySiTHWGmC RYsA== X-Gm-Message-State: AOJu0YwPMntVuACCMLqHobqZs3d4f76ws84N3JLzF22eA4WqsTi4ztrK dCMDZC31mmRdpBoCpdUrF2v/+co4mp71bMSLOfVmyMtWvG0I464ANcg6HQhjausaX566TEq43HX KVq6Dn6Iu3v4= X-Received: by 2002:a05:600c:1c82:b0:40a:4a5c:3af0 with SMTP id k2-20020a05600c1c8200b0040a4a5c3af0mr5160757wms.24.1699872794297; Mon, 13 Nov 2023 02:53:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IHxiI684fpuq4P07TCiagexfGIP9643qXf3t2ZLoCkfmTAvfJ8NyUDNmWCuyN48aiJ7jzYIyw== X-Received: by 2002:a05:600c:1c82:b0:40a:4a5c:3af0 with SMTP id k2-20020a05600c1c8200b0040a4a5c3af0mr5160735wms.24.1699872793822; Mon, 13 Nov 2023 02:53:13 -0800 (PST) Received: from ?IPV6:2003:d8:2f09:f500:a38f:d086:59d4:9df? (p200300d82f09f500a38fd08659d409df.dip0.t-ipconnect.de. [2003:d8:2f09:f500:a38f:d086:59d4:9df]) by smtp.gmail.com with ESMTPSA id q15-20020a05600c46cf00b004060f0a0fd5sm7640488wmo.13.2023.11.13.02.53.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Nov 2023 02:53:13 -0800 (PST) Message-ID: <606d2d7a-d937-4ffe-a6f2-dfe3ae5a0c91@redhat.com> Date: Mon, 13 Nov 2023 11:53:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] mm: support large folio numa balancing To: Baolin Wang , akpm@linux-foundation.org Cc: ying.huang@intel.com, wangkefeng.wang@huawei.com, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, John Hubbard References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: ACBF44000A X-Stat-Signature: fgq3e789813goptwm7ocy6u1ym7pkk8z X-Rspam-User: X-HE-Tag: 1699872797-440589 X-HE-Meta: U2FsdGVkX19u/Q7DzMRLJH3NA4ElIAnattU3Qo5wWe5nwGBm5MaZKou1iAvq0njKyFXp7CjPjvzAZ9ZBg2SqPoL0pNp3udraRFl3Ts+KGBSi8kVSN+QJBc8cymGhgzAZxf2rTdvrDXzhCEtUxfTV5LYWyyby09Jqz9KqgTjuDOV/LIGelEf/Hf+AZN2/EqrSxEaBKjihn/BRUtSrNqFaU8vepdFF03Z9O/pO+4xkk0B2yTrsmIa5RrJq1Cph7rpHtBNZQMChPLbOLlNweS+CM+wCMG8Y/J8JdVmJ4XOTy0D5Pl4mQ0kw0MfTNnD5OeibR1TuZIMWrbFrcx7VBhphz6AQxo47ziLoGrmwrvV4M2AJjO3LrKLVRIDQUHJDdYVcIALjFpJJDHVClqg+YCEM3xqB08DaFAm4n3EiZ0RK6ZrM64GNpyC5jz8wnXrPbrMtpYEqLZs6628+VR7/hVk0y2wEq1Kb23hRhnRGtA6ZOssOEUmpN//5WmVjfAQkCdBZtDoIes3Hh+LNyVNp2YqTnoiY7772veF51VLXcVyAI+03a/mgeeEMGAhFPK910mZiYoZS5JvyWwXLHMdCegApLb9Sesx5P8h8Sux1gj/g3t4c+ewiVI/NjywPrlvtrMbx3ebP4QQGLtxOuOKUKoVsUOmhnZ/3DNuI3WKahQQGxvav/19JM16liskMPO4IEKDdGjSRqEgOSRiCgHVsNOs07s+hZeTWaCu9jbxiLmktCX4PvJ+33Q2usvHwuW4P9Ohqj0irSQzIGS/rLNM52BPm6FfQZsi2fqQMP3nh6OKSB5sfGfh4jidf4EQjCAaAqTXCHBDZe49XouuU8Q/6cjW7foFUqmz33jPILeD75CEFyiC68ygRuHexFXRshwqxU0MUr2OgW9ejrn/H97ieEgx17GpCC156mMEijBmEkHhf6UVDwYu5YGFmF/nz4gAeG47RJcNDKUjJ8eGj+FQxCgQ jKgk+QLh 9XwVHfxk12K+bUeG0BlgIJ4bs+Xs6Fog+c9zp62BpoNMaeOVK8spQQFou94ijExMVOWLTNS2nu8lKFuoq4VKg+ZXcQEskhDnUcMAzlJsXA/JUkurzGfkkiJzotiR0eo6N3laV+guuMA3L9abXiNcH01X00jTIsqf8719I4ZQoSCJt085gopHv6YIdy+CXltwaa41NemblsUEQvolVhsN3Qe1PPcr5fMKJN+1DFKNwDm9NyYFfG8ClShU6nS2Aeg6CyiJZwJJqIbaFop82qtknCtLf6ZVblGeZLWN4HcuE/jxiqUr4dHz139W4jW5eorwnVUVYGR4/VBXwO8vGTZnuFdBmw454cxdeBcbt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 13.11.23 11:45, Baolin Wang wrote: > Currently, the file pages already support large folio, and supporting for > anonymous pages is also under discussion[1]. Moreover, the numa balancing > code are converted to use a folio by previous thread[2], and the migrate_pages > function also already supports the large folio migration. > > So now I did not see any reason to continue restricting NUMA balancing for > large folio. I recall John wanted to look into that. CCing him. I'll note that the "head page mapcount" heuristic to detect sharers will now strike on the PTE path and make us believe that a large folios is exclusive, although it isn't. As spelled out in the commit you are referencing: commit 6695cf68b15c215d33b8add64c33e01e3cbe236c Author: Kefeng Wang Date: Thu Sep 21 15:44:14 2023 +0800 mm: memory: use a folio in do_numa_page() Numa balancing only try to migrate non-compound page in do_numa_page(), use a folio in it to save several compound_head calls, note we use folio_estimated_sharers(), it is enough to check the folio sharers since only normal page is handled, if large folio numa balancing is supported, a precise folio sharers check would be used, no functional change intended. I'll send WIP patches for one approach that can improve the situation soonish. -- Cheers, David / dhildenb